From 8ced105bdf70ca566df60b7894de44d28271e09e Mon Sep 17 00:00:00 2001 From: Peter Sollich Date: Sat, 12 Mar 2022 18:11:44 +0100 Subject: [PATCH] The problem was that the assert didn't take into account the fact that some regions may be on the decommit list already due to aging of regions. (#66495) --- src/coreclr/gc/gc.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/coreclr/gc/gc.cpp b/src/coreclr/gc/gc.cpp index 8c8ca438075..720b6153495 100644 --- a/src/coreclr/gc/gc.cpp +++ b/src/coreclr/gc/gc.cpp @@ -12414,6 +12414,9 @@ void gc_heap::distribute_free_regions() if (num_regions_to_decommit[kind] > 0) { + // remember how many regions we had on the decommit list already due to aging + size_t num_regions_to_decommit_before = global_regions_to_decommit[kind].get_num_free_regions(); + // put the highest regions on the decommit list global_region_allocator.move_highest_free_regions (num_regions_to_decommit[kind]*region_factor[kind], kind == basic_free_region, @@ -12424,7 +12427,9 @@ void gc_heap::distribute_free_regions() if (kind == basic_free_region) { - assert (global_regions_to_decommit[kind].get_num_free_regions() == (size_t)num_regions_to_decommit[kind]); + // we should now have num_regions_to_decommit[kind] regions more on the decommit list + assert (global_regions_to_decommit[kind].get_num_free_regions() == + num_regions_to_decommit_before + (size_t)num_regions_to_decommit[kind]); } else {