Commit Graph
2309 Commits
Author SHA1 Message Date
Andy Gocke 4f7d9e7561 Add table of testing configurations (#66347)
* Add table of testing configurations

* Remove "cross" from specification
2022-03-10 15:48:39 -08:00
Elinor Fung 78083e7dd0 Add test for comhost with managed host (#66360) 2022-03-09 20:52:18 -08:00
Elinor Fung c2ec86b1c5 Rename GeneratedDllImportAttribute -> LibraryImportAttribute (#66307) 2022-03-09 18:07:52 -08:00
Radek Zikmund 00ed84ae9b Mark EncryptionPolicy.NoEncryption and EncryptionPolicy.AllowNoEncryption as obsolete (#66292)
Fixes #65545
2022-03-08 18:44:17 +01:00
Elinor Fung 627851323f Add tests for ijwhost (#66308) 2022-03-08 09:14:43 -08:00
Jan Kotas 17662fc30c Replace TargetFrameworks with TargetFramework where possible (#66198) 2022-03-04 22:21:59 -08:00
Elinor Fung 94480f128c Rename classes in p/invoke generator to be LibraryImport (#66217) 2022-03-04 19:42:33 -08:00
Aaron Robinson 6fe1a80959 Use CMakeProjectReference instead of ProjectReference (#66202)
* Use CMakeProjectReference instead of ProjectReference

Changing this permits usage of "\runtime\dotnet.cmd build" as opposed
  to forcing users to use "\runtime\dotnet.cmd msbuild".
2022-03-04 19:40:27 -08:00
Sam PatelandAleksey Kliger 611d45f73e Update files to remove imhameed (#66160)
* Update Codeowners to remove imhameed

* Update area-owners.md to remove imhameed

* Update fabricbot.json file to remove imhameed

* update codeowners file to remove alexrp

* update codeowners to remove Egor from Mono files

* remove merp related entries from CODEOWNERS

Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>

Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
2022-03-04 12:15:58 -05:00
Elinor Fung a0635832f1 Rename DllImportGenerator project to LibraryImportGenerator (#66029) 2022-03-03 22:17:23 -08:00
Radek Zikmund b8f1a06951 Mark SslProtocols.Tls and SslProtocols.Tls11 as obsolete (#65773)
Fixes #65546
2022-03-03 15:04:42 +01:00
Jeremy Koritzinsky 922777acf3 Disable default marshalling for bool (#65749) 2022-03-02 20:57:54 -08:00
Elinor Fung a7a4ed9593 Update p/invoke source generator errors to use SYSLIB prefix (#65983) 2022-03-01 14:24:04 -08:00
Elinor Fung d9eafd0c55 Move diagnostics for invalid GeneratedDllImportAttribute usage to generator instead of analyzer (#65915) 2022-02-28 16:57:47 -08:00
Viktor Hofer 9ebe0efa48 sfx+oob split, shim project refactoring, P2Ps
Split the build of shared framework and out-of-band projects so that
it's possible to just build the shard framework projects, which was
requested by the CLR teams. In the next infrastructure rollout, the
current "libs.ref+libs.src" subsets should be removed. Generate the
targeting pack with an incomplete (without shims) frameworklist as part
of the "libs.sfx" subset.

Build the shim projects after the shared framework and oob projects and
re-generate the targeting pack's frameworklist to include the shims.

Refactor the shims so that they aren't grouped anymore by generated &
manual. Instead group them by "ref" and "src" same as other libraries
in the tree which allows to reference the source project shims and read
from the ReferenceAssembly metadata.

Use ProjectReferences in traversal projects and shim projects instead
of named references that point to binplace directories (see graph below)
This allows to build parts of the product dynamically, i.e. the shim
projects, apicompat.proj, sfx.proj and oob.proj.
2022-02-24 12:32:04 +01:00
Jeff Handley 075a24d791 Update area-owners and fabricbot to reflect libraries area pod changes (#65830)
* Update area-owners to use area team names for the libraries area pods

* Update fabricbot for libraries pod changes; remove configs for old project boards

* Remove intra-team consultants from libraries areas
2022-02-24 09:41:08 +00:00
Elinor Fung 7984b32774 Update GeneratedDllImportAttribute CharSet -> StringMarshalling (#65544) 2022-02-23 18:36:10 -08:00
Jeremy Koritzinsky fdb949d9c6 Add proposed plan for the COM source generator (#60143) 2022-02-23 14:26:24 -08:00
Aleksey Kliger (λgeek) f0c7520818 [docs] Create mono-thread-state-machine.md (#65720)
* Create mono-thread-state-machine.md

  Add the thread state machine design document

* Add some sequence diagrams

* Add hybrid suspend race sequence diagram

* More details on self-transitions

* fix coop GC suspend discussion

* undo accidental deletion
2022-02-22 19:50:33 -05:00
Andy Ayers 537d6077d7 JIT: revise approach for x64 OSR epilogs (#65609)
Rework x64 OSR so OSR methods have standard epilogs.

Details in attached doc.
2022-02-21 11:08:33 -08:00
Jeremy KoritzinskyandElinor Fung ca6f4206f5 Remove ExactSpelling from GeneratedDllImport (#65343)
* Update conversion code fix to offer multiple fixes for appending each previously probed entry-point suffix when ExactSpelling is false.

* Remove ExactSpelling property and move properties that were relying on ExactSpelling = false to use explicit entrypoint names.

* Emit ExactSpelling = true for all of our emitted target DllImports.

* Fix a few entry points

* Add a comment around CharSet.Auto

* Update compatibility doc.

* Update docs/design/libraries/DllImportGenerator/Compatibility.md

Co-authored-by: Elinor Fung <[email protected]>

Co-authored-by: Elinor Fung <[email protected]>
2022-02-18 22:51:27 -08:00
Qiao Pengchengandqiaopengcheng 90b7be39c4 [LoongArch64] JIT/EE interface for getting ABI-info (#62893)
* [LoongArch64] add ToolBox directory about jitinterace for getting ABI-info. (#59561)

Co-authored-by: Loongson's .NET-teams

* [LoongArch64] add new interace for getting ABI-info. (#59561)

* [LoongArch64] add the linking page for LoongArch64 ABI-info. (#59561)

* [LoongArch64] moved ThunkInput.txt to #62885.

* [LoongArch64] moved vm/jitinterface.cpp to #62885.

* remove the JIT/EE interface back from #62885..

* [LoongArch64] Fix the compiling error after merge.

* [LoongArch64] add comments for the returned value of `getFieldTypeByHnd`.

* [LoongArch64] rename getFieldTypeByHnd to getFieldSizeClassificationByHnd.
Also add macro define for returned value of `getFieldSizeClassificationByHnd`.

* [LoongArch64] Delete the interface `getArgType2`.
And refactor the returned values of `getFieldSizeClassificationByHnd`.

* [LoongArch64] delete `GetArgType` within `ToolBox/superpmi`.

* [LoongArch64] rename `getFieldSizeClassificationByHnd` to
`getLoongArch64PassStructInRegisterFlags`.

* [LoongArch64] amend the floating-ABI for native-struct.

* [LoongArch64] update all related `GetFieldSizeClassificationByHnd`
by `GetLoongArch64PassStructInRegisterFlags` and amend some comments.

* [LoongArch64] replace `LookupApproxFieldTypeHandle()`
by `GetFieldTypeHandleThrowing()`.

* [LoongArch64] implements the crossgen2 for LoongArch64.

* Revert "[LoongArch64] implements the crossgen2 for LoongArch64."

This reverts commit b05a2b90e8d8a2f6d1cf7f101ddfc9d4ed8d984e.

The crossgen2 for LoongArch64 will be submitted by a new PR.

* [LoongArch64] update the `GUID JITEEVersionIdentifier`.
Also delete some unused comments.

Co-authored-by: qiaopengcheng <[email protected]>
2022-02-18 00:07:48 -08:00
Immo Landwerth 255c3ab9fa Add line break to please Firefox 2022-02-17 16:37:39 -08:00
Immo Landwerth ea5376adf7 Replace picture of API review process with diagram (#65527) 2022-02-17 12:36:25 -08:00
Eirik Tsarpalis 973b7640ae Add @teo-tsirpanis to community triagers (#65503) 2022-02-17 08:06:33 -05:00
David WrightonandAaron Robinson 135a9608c4 Proposed changes to ECMA 335 for ref field support (#63659)
* Initial proposed changes for ref fields

* Fix end of line issue

* Update docs/design/specs/Ecma-335-Augments.md

Co-authored-by: Aaron Robinson <[email protected]>

* Update local signature wording

Co-authored-by: Aaron Robinson <[email protected]>
2022-02-16 12:16:04 -08:00
Viktor Hofer 20e8f905d0 Don't use Targets* helper properties in libs (#64500)
* Don't use Targets* helper properties in libs projs

This change makes it possible to migrate 200+ (ref+src) projects to use
TargetFramework instead of TargetFrameworks which avoids the additional
outer build evaluation and invocation which ultimately makes the overall
build faster.

Targets* properties (i.e. TargetsWindows, TargetsAnyOS, TargetsUnix,
etc.) rely on the TargetFramework property which usually are set
inside a project. The TargetFramework property is only
available before a project specifies it if it's explicitly set in a props
file or if the project is cross-targeting and the outer-build dispatches
into the inner-build. During the dispatch, the TargetFramework property
is passed in as a global property.

Until now that behavior wasn't a problem because every libraries project
cross-targeted (by setting the TargetFrameworks property) even though
many only include a single TargetFramework (i.e. NetCoreAppCurrent).

To allow projects to use the TargetFramework property instead of
TargetFrameworks, the Targets* helper properties can't be calculated
anymore early in a props file as the TargetFramework property isn't set
at that time.

In general, the guidance by the SDK/msbuild team is to not read from the
TargetFramework property before the project sets it
(in a property group). That effectively means that the TargetFramework
property shouldn't be used in props files at all.

Therefore these helper properties can't be used anymore for property
conditions and I'm replacing their usage with TargetPlatformIdentifier
comparisons for both properties and items.
In nearly all cases, the Targets* helper properties can be replaced with
TargetPlatformIdentifier checks on items and in the few cases where
TargetsUnix or TargetsLinux marks multiple tfms as compatible, the exact
tfms must be used instead for the TargetPlatformIdentifier comparison.

Whenever a project needs to condition properties on the platform, I'm
first setting the TargetPlatformIdentifier the same way the SDK sets it
so that the SDK later doesn't need to set it again to avoid the
additional expensive msbuild function call.

* Use TargetFramework singular to avoid outer builds

Use TargetFramework instead of TargetFrameworks property whenever a
projects only targets a single target framework. This avoid unnecessary
outer builds and evaluations and makes the build faster.
2022-02-12 13:07:16 +01:00
Andrew WangandJuan Hoyos acbd20e673 Update linux-instructions.md for .NET 6/7 (#65160)
* Update linux build instructions for .NET 6/7
* Add linux musl arm to the list

Co-authored-by: Juan Hoyos <[email protected]>
2022-02-10 14:56:09 -08:00
David Wrighton 9e45de46c9 Add default method support to virtual statics (#64717)
- The preview feature version of virtual statics implemented for .NET 6 does not allow for the interface methods to have a default implementation.
- With this change, we add support for the interface method having an actual implementation to CoreCLR. From what I can tell the Mono runtime already had such support
- There are some small ECMA spec updates to allow this change that are also included

In addition, I've taken the liberty to enable running the coreclr test suite on Mono on Windows. It needed a small amount of fixup.
2022-02-09 10:44:15 -08:00
Marek Fišera 1ac45f5161 [wasm] Fix WebSocket tests on NodeJS (#64330)
- Move all SetScriptCommands to a target, so they are placed after scenario in the generated script.
- Add WasmXHarnessArgsCli as an alternative variable that can be used from cli.
- Fix NodeJS symbolic links on Helix.
- Copy TestEchoMiddleware and RemoteLoopMiddleware even for Scenario=NodeJS.
- Enable System.Net.WebSockets.Client.Tests on NodeJS.
2022-02-09 10:27:24 +01:00
Michal Strehovský 87777b624b Change the way we build CoreCLR tests for NativeAOT (#64738)
* Remove NativeAOT testing added in dotnet/runtime#62704 to make room for the different strategy.
* Build NativeAOT as part of test build, not test run
2022-02-09 07:23:13 +09:00
Jakob Botsch NielsenandMichal Strehovský 3fc8b09944 Add JIT support for control-flow guard on x64 and arm64 (#63763)
Add support for generating control-flow guard checks. The support is enabled by a JIT flag or by setting COMPlus_JitForceControlFlowGuard=1.

Co-authored-by: Michal Strehovský <[email protected]>
2022-02-08 18:20:12 +01:00
Michal Strehovský b11469f658 NativeAOT ARM64 libraries testing (#64373)
Enable ARM64 libraries testing for NativeAOT.

* Copy the crosstargeting build approach from crossgen2. We'll now build two ILC compilers when targeting ARM64 from x64: an arm64-hosted one that is useless on the build machine, and a x64-hosted one, that will work on the build machine. The `ILCompiler.csproj/props/_crossarch.csproj` projects mirror crossgen's approach.
* Limit the number of libraries tests to one. Hopefully it avoids the build races that we'd see until we can update the repo build to .NET 7 Preview 1.
* Create an ARM64 NativeAOT CI leg that sends the libraries tests to Helix to run.
2022-02-08 13:33:47 +09:00
Austin Wise db1bbf4068 Fix link in readytorun-format.md (#64878)
The link was not rendering correctly, as the link text and target were on separate lines.
2022-02-06 10:39:55 -08:00
Michał Zegan e836ce548a Fix test build command in docs/workflow/building/coreclr/nativeaot.md (#64690)
The command `src/tests/build[.cmd|.sh] nativeaot [Debug|Release] tree nativeaot` seems not to work as expected.
Namely it seems to build not only the nativeaot smoke tests.
Fixed to be `src\tests\build[.cmd|.sh] -nativeaot [Debug|Release] -tree:nativeaot`
2022-02-03 20:35:43 +09:00
Andy Ayers 04bcc055e9 Writeup on OSR Details and Debugging (#64428)
Information about how to think about OSR and to debug jit and runtime
when OSR is enabled.
2022-02-01 18:17:26 -08:00
Viktor Hofer ef5803de62 Delete NS2x runtime specific impls (#64610)
* Remove .NETStandard runtime implementations

Remove the remaining ten .NETStandard runtime specific implementations.
For reasoning please see https://github.com/dotnet/runtime/issues/64536.

* Remove infra support for NS platform specific tfms

Also cleaning-up some logic and stop disabling AppendTargetFramework.
2022-02-01 22:51:32 +01:00
Fan Yang bccc18bb6c [Mono] Add incremental build instructions when ... (#64396)
... you need to need to run library tests or run HelloWorld sample with your change to mono.
2022-02-01 16:01:19 -05:00
Jeff HandleyandEirik Tsarpalis da7f377219 Update area-owners verbiage about FabricBot configuration for notifications (#64595)
* Update area-owners verbiage about FabricBot configuration for notifications

* Add link to the automation.md doc

Co-authored-by: Eirik Tsarpalis <[email protected]>

Co-authored-by: Eirik Tsarpalis <[email protected]>
2022-02-01 09:37:27 -08:00
Michal Strehovský e824d399a6 Fix NativeAOT official build (#64432)
Official builds are currently not building NativeAOT CoreLib.

For unknown reasons the official build splits native build and managed build of the CoreCLR partition.

We had a convenient clr.nativeaotlibs subset that built both the native part and managed part. Managed part can't be built without the native part, so it makes sense.

To satisfy official build's weirdness, we need to split this into two subsets so that we can tell the official build to build the managed part. (Official builds already build everything in the native part, so we're good there.)
2022-01-28 21:26:43 +09:00
Michal Strehovský b4147e66c9 Remove Native AOT pointer to runtimelab (#64429) 2022-01-28 04:09:14 -08:00
fe0d9200f4 [docs] Collecting stack traces with native symbols on WebAssembly (#64383)
* [docs] Collecting stack traces with native symbols on WebAssembly

* Apply suggestions from code review

Co-authored-by: Larry Ewing <[email protected]>
Co-authored-by: Ankit Jain <[email protected]>

Co-authored-by: Larry Ewing <[email protected]>
Co-authored-by: Ankit Jain <[email protected]>
2022-01-27 14:16:21 -05:00
Jan Kotas b571499765 Clarify purpose of PDB Document hashing (#64306)
Fixes #63505
2022-01-25 17:31:27 -08:00
Mitchell Hwang 1c50993492 [Android][libs] Enable Internal.Console.Write in System.Private.CoreLib (#63949)
* [Android][libs] Enable Internal.Console.Write in System.Private.CoreLib

* [docs] Add debugging System.Private.CoreLib Internal.Console.Write

* Elaborate on debugging corelib log

* Address feedback
2022-01-24 15:06:56 -05:00
Eric Erhardt d99fa6789a Respond to feedback in GenerateMultiTargetRoslynComponentTargetsFile (#63943)
* Respond to feedback in GenerateMultiTargetRoslynComponentTargetsFile

Two small follow up changes from #58446

- Fix a type-o that breaks incremental build. Forgot to use MSBuild property syntax
- Instead of having the infrastructure hard-code removing 'Abstractions', packages can set their own Disable source gen property name.

* PR feedback
2022-01-24 10:42:15 -06:00
David Wrighton 9d360c9aa2 Update NativeAOT codegen and Crossgen2 for CreateSpan (#63977)
- Make sure FieldRVA pointers remain aligned as required by the code generator
  - Use the same Packing Size approach as the IL Linker will use (See jbevain/cecil#817 for details)
  - Compilers that generate CreateSpan will need to follow that trick to be compatible with rewriters.
- Provide ECMA spec augment describing packing size detail
2022-01-23 14:23:32 -08:00
Andy Gocke 83f8df4e78 Revert "Enable System.Text.Json tests on netfx (#63803)" (#64108)
This reverts commit 34794bc5f2.
2022-01-21 13:32:37 -08:00
Kevin Jones 22e2db1228 Update the macOS CoreCLR building documentation. (#63932)
This updates the documentation to refer to the up-to-date location of
requirements and prerequisites.
2022-01-20 23:26:05 -08:00
Maxim Lipnin 4e48641996 Polish the PR build doc (#64036) 2022-01-20 07:29:18 -05:00
Jeremy KoritzinskyandElinor Fung 94b699cc6f Update StructMarshalling design now that DisableRuntimeMarshallingAttribute is approved (#63765)
Co-authored-by: Elinor Fung <[email protected]>
2022-01-19 16:46:00 -08:00