Commit Graph
105 Commits
Author SHA1 Message Date
Radek Zikmund 00ed84ae9b Mark EncryptionPolicy.NoEncryption and EncryptionPolicy.AllowNoEncryption as obsolete (#66292)
Fixes #65545
2022-03-08 18:44:17 +01:00
Radek Zikmund b8f1a06951 Mark SslProtocols.Tls and SslProtocols.Tls11 as obsolete (#65773)
Fixes #65546
2022-03-03 15:04:42 +01:00
Elinor Fung a7a4ed9593 Update p/invoke source generator errors to use SYSLIB prefix (#65983) 2022-03-01 14:24:04 -08:00
Immo Landwerth 255c3ab9fa Add line break to please Firefox 2022-02-17 16:37:39 -08:00
Immo Landwerth ea5376adf7 Replace picture of API review process with diagram (#65527) 2022-02-17 12:36:25 -08:00
Michal Strehovský b4147e66c9 Remove Native AOT pointer to runtimelab (#64429) 2022-01-28 04:09:14 -08:00
Michal Strehovský 207590a7b8 Fold coreclr/ToolBox into coreclr/tools (#63917)
This separation only existed because of Razzle build sequencing of desktop CLR. It doesn't make sense for CoreCLR. The only thing the extra directory is doing now is that it breaks tab completion when navigating the CoreCLR source tree because ToolBox comes before tools alphabetically and most things live in tools.
2022-01-18 10:10:36 -05:00
Layomi Akinrinade 7a2fac8c13 Update list of analyzer diagnostics with JSON entries (#61809) 2021-11-22 14:30:09 -08:00
e10532af7e Obsolete thumbtacked AssemblyName properties (#59522)
* Obsolete thumbtacked AssemblyName properties

Fix #59061

* Ignore obsoletion

* Fix pragma

* Merge the AssemblyName member obsoletions into a single diagnostic id

* Fix pragma to use updated diagnostic id

* Suppress SYSLIB0037 in reflection tests

* Suppress SYSLIB0037 warnings

Co-authored-by: Jeff Handley <[email protected]>
Co-authored-by: Jeff Handley <[email protected]>
2021-11-15 17:06:46 -08:00
Daniel Cazzulino 3af0a68df9 Add direct SDK installer links (#53061)
These are most of the time more useful than just the runtime ones.

I could not find the equivalent `.sha512` links for the checksums for the SDK installers, though :(
2021-10-21 15:45:20 -07:00
Jeff Handley ed4f087a59 SYSLIB0036 - Regex.CompileToAssembly is obsolete (#59837) 2021-09-30 19:03:52 -04:00
Stephen Toub 00aa6518a6 Add initial regex source generator (#59186)
* Add RegexGeneratorAttribute

Adds the new RegexGenerator attribute that's a signal to the regex
generator to generate code for the specified regex.

* Implement RegexGenerator

Add a source generator for generating C# code for Regex.  This is
primarily a port of RegexCompiler.cs, generating C# code instead of
MSIL.

* Add generator test project

Adds tests dedicated to the mechanics of the source generator, e.g. that
appropriate diagnostics are issued for improper use of RegexGenerator.

* Integrate source generator into many regex tests

Start integrating the source generator into the regex test suite, so
that many existing tests also validate the generated code.

* Address PR feedback

* Improve cachability of source generator

Changing the generator to not collect all regexes together means we don't need to reprocess/regenerate all regexes every time any one of them is changed.

* Use closest matching ctor from GetRegexAsync

To better test the appropriate ctor usage.

* Improve a few of the polyfills

* Address PR feedback

* Fully qualify types and remove unnecessary $s

Also fixed one place where the IL we were generating wasn't as good as the reflection emit code.

* Suppress a couple more warnings

* Fix stray !

* Fix TODO about unrolling multi comparisons

Also clean up generated code in a few places to make it more readable / concise.

* Update resources per PR feedback

* Add more tests, clean up parser code, and allow instance/interface methods

* Fix test suppression on mobile
2021-09-22 13:52:02 -04:00
Eirik Tsarpalis e500c800ef Fix broken API proposal template link (#59083) 2021-09-14 07:40:21 -07:00
Jimmy Cushnie e3741896f4 Fix small typo in api-review-process.md (#57625) 2021-08-18 09:39:04 +02:00
Kevin Jones 35cf750ea5 Obsolete some System.Security.Cryptography.Pkcs APIs
These members have never worked in .NET/.NET Core
2021-08-12 15:13:48 -07:00
Anirudh AgnihotryandViktor Hofer 4684a1dbab Automatic calculate the assembly and package version in servicing (#57158)
* automatically update the assembly version

* address feedback

* move IsAspNetCoreApp to packaging.targets

* make assemblyintef pack private, update header and instructions on building the package in servicing

* fixes the allconfig leg

* update the docs

* Update docs/project/library-servicing.md

Co-authored-by: Viktor Hofer <[email protected]>

Co-authored-by: Viktor Hofer <[email protected]>
2021-08-12 10:29:20 -07:00
Kevin JonesandJeff Handley c5faf00fd5 Obsolete Rfc2898DeriveBytes.CryptDeriveKey (#57002)
* Obsolete Rfc2898DeriveBytes.CryptDeriveKey

* Apply suggestions from code review

Co-authored-by: Jeff Handley <[email protected]>

Co-authored-by: Jeff Handley <[email protected]>
2021-08-11 21:35:05 -06:00
Viktor Hofer 22cee85aa0 Clean-up pkgproj leftovers in libs and apply fixes (#56899)
* Clean-up pkgproj leftovers in libs and apply fixes

Remove any pkgproj infrastructure that was only used by src/libraries
(which is the majority). Delete the packageindex *YAY*.
Update the documentation that covered the packageindex and the pkgprojs.

Avoid any incremental builds during packaging by removing
libraries-packages.proj and use src.proj for packaging instead. Make use
of the `GeneratePackageOnBuild` property to build package during the
allconfigurations without requiring a different entry target.

Fix the addition of the DocumentationFile during packaging when
`GeneratePackageOnBuid` is used by hooking onto the
`DocumentationProjectOutputGroup` that NuGet uses and replacing the
generated documentation file with the one that comes via the
intellisense package.
Also introduce a property to choose the generated documentation file
over the one from the intellisense package:
<UseIntellisenseDocumentationFile>false</UseIntellisenseDocumentationFile>

Removing a few leftover PackageDescription properties from the projects'
Directory.Build.props file.

Cleaning up properties in Directory.Build.props & Directory.Build.targets
files.

* Actually run packaging during the allconfigurations build

* Update docs

* make runtime specific pkgs non packable

* io.ports native pkg fixes
2021-08-06 12:01:36 +02:00
Jeff Handley 895c99cc50 Remove old fwlink from Obsolete messages and make message improvements (#56690)
* Remove old fwlink from Obsolete messages and make message improvements

* Thorough review and update of Obsolete messages

* Cleanup

* Make messages about unsupported APIs more consistent

* Update RequiresUnreferencedCodeAttribute messages to be consistent between ref and src

* Cleanup

* Cleanup

* Use 'not supported' instead of 'no longer supported'

* Omit unnecessary error:false from Obsolete attributes. Fix message typo.

* Remove old comment

* PR feedback
2021-08-04 14:58:10 -04:00
Jeff Handley 4fa710e22f Mark HandleProcessCorruptedStateExceptionsAttribute as obsolete (#56664) 2021-08-03 19:28:42 -04:00
Kevin Jones 87e98f36c7 Obsolete CryptoConfig.EncodeOID (#55592) 2021-07-13 20:16:54 -04:00
Kevin Jones b9020ea1ee Obsolete useManagedSha1 and ProduceLegacyHmacValues 2021-07-07 12:00:02 -07:00
Kevin Jones af18e93a2b Obsolete X509Certificate2.PrivateKey and PublicKey.Key. (#54562)
The two properties got different diagnostic IDs so that the messages could better reflect the caller recovery action.
2021-06-28 09:59:06 -07:00
Kevin Jones 066894e0b7 SYSLIB0026: Obsolete mutable X509 certificate APIs 2021-06-21 16:36:51 -07:00
Levi Broderick 84b88e7a6a Obsolete SuppressIldasmAttribute and remove ildasm.exe support for it (#50951) 2021-05-19 09:08:44 -07:00
Alexander Köplinger d8afd37cc0 Fix link to servicing PR template (#52961)
The old URL didn't show the template anymore, just a generic GitHub page. Linking to the raw URL so `<!-- -->` comments are visible.
2021-05-19 13:24:49 +02:00
da42d13516 Add obsoletions for System.Runtime (#52014)
* Add obsoletions for System.Runtime

* Fix tests

* Fix

* Update AppDomain obsoletion to SYSLIB0024 and augment message

* Add missing period to the SYSLIB0024 obsoletion message

* Update obsoletion message per feedback

Co-authored-by: Genevieve Warren <[email protected]>

Co-authored-by: Jeff Handley <[email protected]>
Co-authored-by: Jeff Handley <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
2021-05-12 14:41:17 -07:00
ebcd10205b Unnecessary cryptographic derived types obsoletions (#52303)
* add new obsoletion ID

* nowarn for new obsoletion

* add obsoletions to csproj

* AesCryptoServiceProvider obsoletion

* DESCryptoServiceProvider obsoletion

* MD5CryptoServiceProvider obsoletion

* RC2CryptoServiceProvider obsoletion

* SHA1CryptoServiceProvider obsoletion

* SHA256CryptoServiceProvider obsoletion

* SHA384CryptoServiceProvider obsoletion

* SHA512CryptoServiceProvider obsoletion

* TripleDESCryptoServiceProvider obsoletion

* add obsoletions to csproj

* *Managed obsoletions

* add pragma suppress for types usages

* add nowarn in tests csproj

* add documentation

* add nowarn to new identified tests csproj

* add pragma suppress for types usages #2

* update documentation

* fix md5 usage

* Fix indentation

* fix obsoletions inclusion in csproj

* remove extra obsoletions inclusion in csproj

* De-dupe project items that were in both the browser and non-browser configs. Ensure Obsoletions.cs is included in all configs.

* Remove duplicate RandomNumberGeneratorImplementation.cs reference

* Update documentation

* Remove duplicate Obsoletions.cs from project file (introduced in merge)

Co-authored-by: Jeff Handley <[email protected]>
Co-authored-by: Jeff Handley <[email protected]>
2021-05-11 17:04:54 +00:00
e39196ffc9 Fixed Broken Links in Documentation (#50653)
Co-authored-by: Youssef Victor <[email protected]>
Co-authored-by: Marek Safar <[email protected]>
2021-05-10 10:09:08 +02:00
Jeff HandleyandJeremy Barton ebd695fee1 Mark RNGCryptoServiceProvider as Obsolete (#52373)
* Mark RNGCryptoServiceProvider as Obsolete

* Use the static methods on RandomNumberGenerator instead of Create()

* Use RandomNumberGenerator.GetBytes() instead of RandomNumberGenerator.Create().GetBytes()

* Revert "Use RandomNumberGenerator.GetBytes() instead of RandomNumberGenerator.Create().GetBytes()"

This reverts commit 447f8485a08f831f34d00597a30800ac36f034ef.

* Update src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.CurrentUserOnly.Windows.cs

Co-authored-by: Jeremy Barton <[email protected]>
2021-05-07 18:33:52 -07:00
Jeff Handley 7ea26e68f9 Obsolete the Rijndael and RijndaelManaged classes 2021-05-06 09:28:41 -07:00
Hadrian Tang 94e4e3f023 Add entries to the glossary (#52291) 2021-05-05 16:26:35 +02:00
Layomi Akinrinade fb931c6fa6 Address feedback from STJ source-gen PR #51300 (#52147)
* Address feedback from STJ source-gen PR #51300

* Address review feedback
2021-05-04 08:48:13 -07:00
Pavel SavaraandJan Kotas fced2bd519 [doc] Glossary +SEH +TFM (#51878)
* 2 abreviations I noticed in BOTR and missing here.

Co-authored-by: Jan Kotas <[email protected]>
2021-04-26 12:12:27 -07:00
Buyaa Namnan 207b03a073 Annotate unsupported APIs in .Net core as Obsolete - Reflection area (#50941)
* Annotate unsupported APIs in .Net core as Obsolete - Reflection area
2021-04-25 13:09:54 -07:00
Jeff Handley ac98c81720 Improve some of our recent obsoletions (#51721)
* Replace usage of NET50_OBSOLETIONS with NET5_0_OR_GREATER

* Correct GitHub handle

* Use a diagnostic id for the RuntimeEnvironment obsoletions from #50666

* Use fully-qualified attribute name in ref source updates from #49411

* Use a diagnostic id for the JsonSerializerOptions.IgnoreNullValues obsoletion from #41141
2021-04-23 07:01:37 -04:00
Jeff Handley 39246d1f0e WebRequest/ServicePoint/WebClient Obsoletion Follow-Up (#51550)
* WebRequest/ServicePoint/WebClient Obsoletion Follow-Up

* Suppress SYSLIB0014 at the project level for System.Net.Requests
2021-04-22 15:41:40 -07:00
Jeff Handley 21dcc7385e Improve documentation for obsoletion/analyzer diagnostics (#51595)
* Improve documentation for obsoletion/analyzer diagnostics

* Clarity for SYSLIB0### and SYSLIB1### sequences

* Add info about the SYSLIB documentation pages

* Add pointer to the docs within Obsoletions.cs
2021-04-22 13:57:52 -07:00
erhanatesoglu 907fc3e13a Update branching-guide.md (#50795)
updated repository name from corefx to runtime
2021-04-16 14:56:57 -04:00
33033b22ec Implement new GetContextInfo API overloads (#49186)
* Add basic GetContextInfo regression tests.

* Implement new GetContextInfo API overloads

Implements #47880, adding new, more performant overloads for GetContextInfo.

- Add helper for only creating a region if it isn't infinite
- Start an internal extensions class for easier mapping of System.Drawing concepts to System.Numerics types
- Simplify GraphicsContext

* Update WindowsGraphics to use new overloads.

* Skip tests when GDI+ isn't available.

* Add `[SupportedOSPlatform("windows")]`

* Use new Obsolete attribute pattern.

* Use Obsoletions.cs and conditionalize in ref.

* Address feedback

* Conditionalize the obsoletion in the src

* Update suppression in tests

* Apply obsoletions downlevel using an internal ObsoleteAttribute

Co-authored-by: Jeff Handley <[email protected]>
Co-authored-by: Santiago Fernandez Madero <[email protected]>
2021-04-16 11:07:04 -07:00
Maryam Ariyan 95f06ff500 Add LoggingGenerator (#51064) 2021-04-16 10:36:13 -07:00
Michelle McDaniel 6f12c00fbd Update aka.ms links (#48924)
* Update aka.ms links

* Temporarily remove the symbols, nethost and badge links
2021-03-18 15:22:06 +01:00
Annchous 0b7bcf0f9c Add obsolete attribute to DisablePrivateReflectionAttribute (#49550)
* Add obsolete attribute to DisablePrivateReflectionAttribute

* Attribute added to ref file

* fix ref file and attribute

* Add new diagnostic ID

* Fix obsolete attribute

* Fix obsolete attribute in ref file

* Add new obsoletion ID to documentation

* Removed all references of DisablePrivateReflection in src/coreclr

* Fixed error message of obsoletion

* Fixed documentation

* Removed reference of DisablePrivateReflection

* Add NoWarn for new obsoletion ID

* Add pragma to tests

* Fix error message of new obsoletion

* Fix new obsoletion description in documentation
2021-03-17 09:42:19 -04:00
Viktor Hofer e52568de3d Address remaning master mentions that should be main (#48904)
Did a second search of master in the repo since all the M2M changes went
in and found some remaining places that weren't included in the
previous change.
2021-03-01 13:08:32 +01:00
Viktor Hofer 3553284bea Rename mention to master branch to main (#48824) 2021-03-01 10:09:31 +01:00
Dan Moseley a088dd291f Fix build break in markdown lint (#48041) 2021-02-08 22:11:22 -08:00
Youssef VictorandDan Moseley 5d5c3e7a58 Enable markdownlint rule (MD009) (#40887)
* Create markdownlint.yml

* Create markdownlint-problem-matcher.json

* Create .markdownlint.json

* Update .markdownlint.json

* fix violations

* fixes

* Remove "push" section

As advised by @viktorhofer so it's quite clear it only runs in CI.

Co-authored-by: Dan Moseley <[email protected]>
2021-02-08 10:43:40 -08:00
Anirudh Agnihotry a66b4e3bf5 Single Transport Package for aspnetcore (#47684)
* Adding non ectensions library to transport package and moving transport package to all config leg

* update servicing policy doc

* change name from Microsoft.Extensions.Internal.Transport -> Microsoft.AspNetCore.Internal.Transport

* make isAspnetCore property explicit

* csproj to proj change

* remove non used extensions assemblies from transport package

* Update Directory.Build.props
2021-02-08 00:03:31 -08:00
David Mason 6a58b9c159 update profiling API status (#47217) 2021-01-20 02:22:28 -08:00
Jan Kotas 10381a2cdc Find&Replace coreclr/src -> coreclr (#45761) 2020-12-08 10:40:17 -08:00