Tanner Gooding
e73aa17e23
Adding SkipInit to Internal.Runtime.CompilerServices.Unsafe ( #27377 )
...
* Adding SkipInit to Internal.Runtime.CompilerServices.Unsafe
* Updating the runtime to handle Unsafe.SkipInit
* Updating Decimal.DecCalc to use Unsafe.SkipInit
* Removing 'workaround for CS0165' comments
Signed-off-by: dotnet-bot <[email protected] >
2019-10-23 09:26:09 -04:00
Ben Adams
d5b182c6d8
Improve Dictionary TryGetValue size/perfomance ( dotnet/coreclr#27195 )
...
* Dictionary avoid second bounds check in Get methods
* Add NullRef methods to Unsafe
Signed-off-by: dotnet-bot <[email protected] >
2019-10-22 09:46:29 -04:00
Stephen Toub
c4aa67cbd9
Change several internal/private instance methods to be static ( #26835 )
...
* Replace ToLower(CultureInfo.InvariantCulture) with ToLowerInvariant()
* Mark several members static
Signed-off-by: dotnet-bot <[email protected] >
2019-09-24 20:06:06 +02:00
Michal Strehovský
d81ec88406
Mark unsafe intrinsics as reflection blocked
...
Keeping these reflection enabled pulls in quite a bit of junk (generic dictionaries, standalone method bodies, bookkeeping) that adds up to 1.5% of the size of Hello World...
Signed-off-by: dotnet-bot <[email protected] >
2019-09-09 09:24:01 +02:00
Stephen Toub and Adam Sitnik
ff7dd88cfa
Use expression-bodied members in more places ( dotnet/coreclr#26500 )
...
* Fix IDE0027 (use expression body for accessors)
* Fix IDE0023 / IDE0024 (use expression body for operators)
* Apply suggestions from code review
Co-Authored-By: Adam Sitnik <[email protected] >
Signed-off-by: dotnet-bot <[email protected] >
2019-09-05 10:46:55 +02:00
Stephen Toub
5f38497e19
Remove unused usings from Corlib ( dotnet/coreclr#26250 )
...
* Fix IDE0065 (misplaced using)
* Fix IDE0005 (remove unnecessary usings)
Signed-off-by: dotnet-bot <[email protected] >
2019-08-20 19:45:30 +02:00
Stephen Toub
2e9134f1a6
Fix IDE0056 (use index operator)
...
Signed-off-by: dotnet-bot <[email protected] >
2019-08-18 07:01:54 +02:00
Stephen Toub
c8eb6972b5
Fix IDE0060 (unused parameter)
...
Signed-off-by: dotnet-bot <[email protected] >
2019-08-18 07:01:54 +02:00
Stephen Toub
e19d95b6de
Contribute to IDE0044 (make field readonly)
...
I used the auto-fix and then undid changes in areas where the fields were potentially mutated in native, e.g. I undid many of the changes in reflection. We can revisit those individually later.
Signed-off-by: dotnet-bot <[email protected] >
2019-08-13 21:35:04 +02:00
Stephen Toub
01fa50943f
Fix StyleCop warning SA1121 (use built-in types)
...
Signed-off-by: dotnet-bot <[email protected] >
2019-08-09 16:23:42 +02:00
Stephen Toub
da2c1cde97
Re-enable StyleCop warnings SA1028 and SA1518 (trailing whitespace and blank lines) ( #40113 )
...
Mechanical/automated change. The only manual changes were a) removing the two rules from the CodeAnalysis.ruleset file, b) removing spaces from one line of a .targets file that is used to generate a .cs file, and c) reverting the changes in a few test files where the naive replacement happened in the middle of a verbatim string where the whitespace actually mattered.
Signed-off-by: dotnet-bot <[email protected] >
2019-08-08 23:44:46 +02:00
Andrii Siriak
0abee2baf5
Switch from IndexOf(string) to Contains(string) for better readability and performance ( #38757 )
...
* Fix performance IndexOf(string) -> Contains(string)
* Make comparison ordinal
Signed-off-by: dotnet-bot <[email protected] >
2019-06-24 21:12:12 +02:00
Stephen Toub
4a29e94abb
Update Corelib to adapt to compiler nullability updates
...
Signed-off-by: dotnet-bot <[email protected] >
2019-06-17 22:36:59 +00:00
Stephen Toub
001844340a
Remove defunct !s and update some TODO-NULLABLE comments
...
Signed-off-by: dotnet-bot <[email protected] >
2019-06-13 09:44:12 +02:00
Stephen Toub
b4aa38f0c2
Adjust several where T : class? constraints ( dotnet/coreclr#24894 )
...
* Adjust several `where T : class?` constraints
* Address PR feedback
Signed-off-by: dotnet-bot <[email protected] >
2019-06-05 10:31:21 +02:00
Stephen Toub
a67c6a2b52
Add and apply nullable attributes ( dotnet/coreclr#24679 )
...
* Add and apply nullable attributes
* Adapt to API review decisions
* Address PR feedback
Signed-off-by: dotnet-bot <[email protected] >
2019-05-28 18:14:19 +02:00
Stephen Toub
b31b703b89
Turn on nullability for all of Corelib ( dotnet/coreclr#24497 )
...
* Enable nullable at the project level
* Remove `#nullable enable` from individual files
Removes `#nullable enable` from almost all .cs files in System.Private.CoreLib. I left it only in the ~30 files (out of ~1480 that had it) that are mirrored to corefx, that are built into projects by corefx that don't yet set NullableContextOptions at the project level, and that use nullable annotations; otherwise, they'd break the corefx build.
Signed-off-by: dotnet-bot <[email protected] >
2019-05-10 10:51:17 +02:00
Stephen Toub
f1901501e8
Nullable: Runtime serialization, COM, Vector, remaining IO, and other ( #23895 )
...
Signed-off-by: dotnet-bot <[email protected] >
2019-04-22 16:42:05 +00:00
Anirudh Agnihotry
1e64bf5c1c
Nullable Internal.Win32.RegistryKey ( dotnet/coreclr#23856 )
...
* anootated registrykey
* Fixing the build for windows
* Adding bang after the resize argument
Signed-off-by: dotnet-bot <[email protected] >
2019-04-22 16:28:33 +00:00
Stephen Toub
074f8a9e6c
Nullable: Attributes, SafeHandles, and misc ( dotnet/coreclr#23810 )
...
* Nullable: Attributes, SafeHandles, and misc
* Address PR feedback
Signed-off-by: dotnet-bot <[email protected] >
2019-04-22 16:28:28 +00:00
Anirudh Agnihotry
a9193f4dc3
adding null annotations ( dotnet/coreclr#23744 )
...
Signed-off-by: dotnet-bot <[email protected] >
2019-04-22 16:24:08 +00:00
Santiago Fernandez Madero
1675c9e7d4
Nullable: All remaining exceptions ( dotnet/coreclr#23676 )
...
* Nullable: All remaining exceptions
* Fix build break and PR Feedback
Signed-off-by: dotnet-bot <[email protected] >
2019-04-09 13:23:21 -07:00
Jan Kotas
9d354a7332
Delete RuntimeThread.cs ( dotnet/coreclr#23532 )
...
No longer needed
Signed-off-by: dotnet-bot <[email protected] >
2019-03-29 08:04:23 +01:00
Filip Navara
d14b15f502
Move Thread to shared CoreLib ( dotnet/coreclr#22744 )
...
* Move Thread to shared CoreLib
* Remove all local variables from Thread in shared code
* Remove duplicate checks
* Port back CoreRT changes needed for shared code
* Fix missing culture initialization in ThreadStart()
* Adjust for shared WaitHandle
Signed-off-by: dotnet-bot <[email protected] >
2019-02-28 22:41:40 +01:00
Filip Navara
21fca52b3d
Move ResourceManager to shared CoreLib. ( dotnet/coreclr#22249 )
...
* Move ResourceManager to shared CoreLib.
* Split UAP code out of ResourceManager.cs into separate files.
* Remove ResourceManager.NonUap.cs.
* Do not access internal field (CoreRT build fix).
* Fix non-Windows builds (CoreRT).
* Remove obsolete Debug code.
Signed-off-by: dotnet-bot <[email protected] >
2019-02-02 00:20:35 +01:00
Jan Kotas
3505ee705e
Fix build for ProjectN/WinRTInterop Delete superfluous AsyncCausalityTracer arguments
...
Signed-off-by: dotnet-bot <[email protected] >
2019-01-19 20:39:48 +01:00
Marek Safar
091f7c3fc8
Fix build
...
Signed-off-by: dotnet-bot <[email protected] >
2019-01-19 20:39:48 +01:00
Marek Safar
2963d731c3
Move AsyncCausality to shared partition ( dotnet/coreclr#22062 )
...
* Move AsyncCausality to shared partition
* Set FeatureAsyncCausalityTracer property
Signed-off-by: dotnet-bot <[email protected] >
2019-01-18 18:20:29 +00:00
dotnet bot
ccd7b52ca8
Add System.Private.CoreLib shared sources ( #12162 )
...
Taken from corefx commit 5956ad35864352b38c53aa8c2d1ce012c96b168d. Subsequent updates will happen via a mirroring bot.
2018-12-20 18:51:17 +01:00