Users have been complaining about strange errors arising when using the OracleClient classes.
I have tracked it down to the OciDefineHandle and OciDefineByPos calls, and OracleParameter
handling of amanged objects by unmanaged code. Currently two of the parameters passed to the
above OCI call are short variables. They are passed as "ref" fields as Oracle uses their
address to put size and indicator data once the data is fetched. However, being defined as
short means that they are eligible for being moved during garbage collection. Thus if that
field is moved between the OciDefineByPos call and the fetch of the data then what Oracle is
pointing to may no longer be variable. I'm thinking it may be better to define these fields as
IntPtr and allocate them and retrieve their values via Marshal.ReadInt16. As for OracleParameter,
it uses a managed object "indicator" that is also used in a similar way. This reference is replaced
by a IntPtr and a get/set method to access the contents.
* System.Data.OracleClient/OracleParameter.cs: add
parameter support for LONG RAW and RAW data types
* System.Data.OracleClient.Oci/OciDefineHandle.cs: flush
extra assigning of types
svn path=/trunk/mcs/; revision=146885
** Fixes#321718
* OciCalls.cs: Add stub for OCILobCharSetForm to get the charset
form associated with a CLOB/NCLOB.
* OciLobLocator.cs: Add Environment handle property that is
required to call OCILobCharSetForm and pass the output value to
OCILobRead.
* OciDefineHandler.cs: Update Environment property of
OCILobLocator.
svn path=/trunk/mcs/; revision=144980
* System.Data.OracleClient/OracleConnection.cs: add stubs
for method GetSchema which is part of NET_2_0, and clean up warnings
* System.Data.OracleClient/OracleCommand.cs
* ystem.Data.OracleClient/OracleParameter.cs
* System.Data.OracleClient/OracleBFile.cs
* System.Data.OracleClient.Oci/OciHandle.cs: clean up warnings
* System.Data.OracleClient.Oci/OciDescriptorHandle.cs
* System.Data.OracleClient.Oci/OciDefineHandle.cs: make methods internal
svn path=/trunk/mcs/; revision=112925
* Test/TestOracleClient.cs: fix typo,
enable more test,
Tests pass for parameters for Character, Number, and Date
for Input, Output, InputOutput, and ReturnValue and
situations when any of these could be DBNull.Value
* System.Data.OracleClient/OracleParameter.cs: fix
handling of parameters for character, number, and date
types. Need to redo all the other types based on the above.
* System.Data.OracleClient.Oci/OciDefineHandle.cs: rename private
method DefineLong to DefineLongVarChar
svn path=/trunk/mcs/; revision=112641
* Test/TestOracleClient.cs: get oracle connected tests
going again
* System.Data.OracleClient.Oci/OciDefineHandle.cs
* System.Data.OracleClient/OracleDataReader.cs
* System.Data.OracleClient/OracleCommand.cs: fix character
field value for a reader that was retrieved from a REF CURSOR.
It was failing due to OCI_INVALID_HANDLE - resolve the error
by passing a connection object which has a valid environment
handle.
* System.Data.OracleClient.Oci/OciCalls.cs: correct
call to OCIDefineByPos
* System.Data.OracleClient/OracleParameter.cs: better way to
determine if the input value Is Null instead of using reflection.
Flush - Re-arraning how variables are being bound.
* System.Data.OracleClient/OciGlue.cs: add function
to convert OCI Return / Error Status Code to a String Description
* System.Data.OracleClient.Oci/OciErrorHandle.cs: better
error handling
svn path=/trunk/mcs/; revision=112419
* System.Data.OracleClient/OracleParameter.cs
* System.Data.OracleClient.Oci/OciStatementHandle.cs
* System.Data.OracleClient.Oci/OciDefineHandle.cs: fix bug
for GetOracleLob in OracleDataReader that was created
via a REF CURSOR. Bug occurred because the cursor when created
did not have a ServiceContext - this was solved by passing
the connection in which did. Fixes bug#350408. In OracleParameter, also
show the data type that is not implemented.
* Test/testblob.cs
* Test/TestOracleClient.cs: updated tests
* Test/refcursortest.cs: added ref cursor test with blob
svn path=/trunk/mcs/; revision=111595
* System.Data.OracleClient/OracleParameter.cs: free
unmanaged resources after update of values
2005-12-13 Daniel Morgan <[email protected]>
* System.Data.OracleClient.Oci/OciErrorHandle.cs patch
from "Hubert FONGARNAND" <[email protected]>
- fix error handling for non-English locales. Bug# 76623.
2005-12-13 Daniel Morgan <[email protected]>
* System.Data.OracleClient/OracleParameter.cs: patch
from "Hubert FONGARNAND" <[email protected]>
- fix Timestamp when filling a DataSet. Bug# 76437.
2005-12-13 Daniel Morgan <[email protected]>
* System.Data.OracleClient/OracleParameter.cs: patch
from "Hubert FONGARNAND" <[email protected]>
- problems with OracleClob as input parameters
(when the input parameter is an OracleString,
mono crashes with a invalidcastexception)
- problems with OracleDateTime.Null, OracleString.Null
as input parameters (it works with DBNull.Value,
but it fails with those parameters)
svn path=/trunk/mcs/; revision=54271
* System.Data.OracleClient/OracleCommandBuilder.cs: update
based on changes Suresh did to OdbcCommandBuilder, SqlCommandBuilder,
and DbDataAdapter
* System.Data.OracleClient/OracleParameter.cs
* System.Data.OracleClient.Oci/OciHandle.cs
* System.Data.OracleClient.Oci/OciCalls.cs
* System.Data.OracleClient.Oci/OciDataType.cs
* System.Data.OracleClient.Oci/OciParameterDescriptor.cs
* System.Data.OracleClient.Oci/OciStatementHandle.cs
* System.Data.OracleClient.Oci/OciDefineHandle.cs: with help
from Hubert FONGARNAND <[email protected]>
implement TIMESTAMP support via OciDateTime descriptor
* System.Data.OracleClient.dll.sources: add
OciDateTimeDescriptor.cs to build
* System.Data.OracleClient.Oci/OciDateTimeDescriptor.cs: add new
file to support Oracle TIMESTAMP using OciDateTime descriptor
svn path=/trunk/mcs/; revision=48254
* System.Data.OracleClient/OracleParameter.cs
* System.Data.OracleClient/OracleCommand.cs
* System.Data.OracleClient/OracleDataReader.cs: support
Output parameters. Return and InputOutput are TODO. Input
already supported. TODO for handling NULL indicator on Output params.
* System.Data.OracleClient/OracleConnection.cs: remove
compile warning
* Test/TestOracleClient.cs: add tests for out parameters
svn path=/trunk/mcs/; revision=47076
* System.Data.OracleClient/OracleDataReader.cs: add LONG
to GetOracleValue to return an OracleString
* System.Data.OracleClient.Oci/OciDefineHandle.cs: add
LONG VARCHAR support. See DefineLong ()
for LAMESPEC about OCI
* Test/TestOracleClient.cs: add LONG to Oracle tests
svn path=/trunk/mcs/; revision=40229
* Assembly/AssemblyInfo.cs: updated copyright
* System.Data.OracleClient/OracleCommand.cs: add
connection string parameter "Server" and
removed "Database" to match .NET
* System.Data.OracleClient/OracleLob.cs: handle
BLOBs and CLOBs that are not null, but are empty
* System.Data.OracleClient/OracleCommand.cs: started
implementing Clone and ExecuteOracleScalar
* System.Data.OracleClient/OracleDataReader.cs: modified
- ms.net has GetDataTypeName return data types upper case
- implement GetFieldType
- implement GetOracleValues, GetOracleValue,
GetOracleDateTime, GetOracleNumber, GetOracleString
- modified GetOracleLob based on internal change
- fix GetSchemaTable to return the correct "DataType"
instead of always being System.String
- GetValue should return Blobs as a byte array and Clobs
as a string
- Test/TestOracleClient.cs: updated Mono Oracle Tests
- System.Data.OracleClient.Oci/OciCalls.cs: update
DllImports for data type, actual data size, and iters
* System.Data.OracleClient.Oci/OciDefineHandle.cs: modified
- added properties for precision and field type
- if ROWID is specified in a SELECT statement, handle
the data type of OciDataType.RowIdDescriptor by just
treating it as 10 byte string
- do not free a HGlobal handle for a LOB since they do
not get a HGlobal created for them
- GetValue should return an OracleLob for BLOBs and CLOBs
* System.Data.OracleClient.Oci/OciDataType.cs: make enum
OciDataType to be uint
* System.Data.OracleClient.Oci/OciParameterDescriptor.cs:
- add function to convert Oracle's data type name
to .net data type name
* System.Data.OracleClient.Oci/OciRowIdDescriptor.cs: flush
svn path=/trunk/mcs/; revision=38419
* System.Data.OracleClient/OracleCommandBuilder.cs:
Fixed namespace.
* System.Data.OracleClient.dll.sources:
Added OracleCommandBuilder.cs.
2004-05-26 Joerg Rosenkranz <[email protected]>
* System.Data.OracleClient.Oci/OciDefineHandle.cs:
Merged in a fix send by Rogerio Pereira Araujo
<[email protected]>: Fixed a bug with NUMBER data type
when no parameter is passed to OracleCommand.
svn path=/trunk/mcs/; revision=28333
2004-03-31 Joerg Rosenkranz <[email protected]>
* System.Data.OracleClient.Oci/OciDefineHandle.cs:
Changed DefineChar to allow retrieval of
multibyte characters (i.e. german umlauts).
* System.Data.OracleClient.Oci/OciStatementHandle.cs:
OciDefineHandles are now disposed in the
Dispose function.
svn path=/trunk/mcs/; revision=24996
2004-01-26 Joerg Rosenkranz <[email protected]>
* System.Data.OracleClient.Oci/OciCalls.cs:
Changed binding of OciStmtPrepare from string
to byte [].
* System.Data.OracleClient.Oci/OciDefineHandle.cs:
Character types are converted using UTF8 encoding.
* System.Data.OracleClient.Oci/OciStatementHandle.cs:
SQL statement to be prepared is converted to byte
array using UTF8 encoding.
svn path=/trunk/mcs/; revision=22579
2004-01-09 Joerg Rosenkranz <[email protected]>
* System.Data.OracleClient.Oci/OciCalls.cs:
Added. It contains all external OCI calls which are
removed from all other files.
* System.Data.OracleClient/OciGlue.cs:
Fix for #52699 (OCI not thread safe).
* System.Data.OracleClient.Oci/OciHandle.cs:
Introduced special handling for Bind, Define and
Environment handles in FreeHandle. Revised the handling for
other types. Minor change in Dispose.
Replaced OCI calls.
* System.Data.OracleClient.Oci/OciDescriptorHandle.cs:
Special handling for Parameter handles in FreeHandle.
Replaced OCI calls.
* System.Data.OracleClient.Oci/OciDefineHandle.cs:
Character types are converted using the DefaultEncoding.
Replaced OCI calls.
* System.Data.OracleClient/OracleCommand.cs:
Dispose created OciStatementHandles.
* System.Data.OracleClient/OracleDataReader.cs:
Dispose used OciStatementHandle.
* System.Data.OracleClient/OracleTransaction.cs:
Dispose transaction handle.
* System.Data.OracleClient.Oci/OciStatementHandle.cs:
OCI_INVALID_HANDLE results in exception "Invalid handle."
Replaced OCI calls.
* System.Data.OracleClient.Oci/OciTransactionHandle.cs:
Introduced DetachFromServiceContext which is called in Commit
and Rollback (Fix for #52702).
* System.Data.OracleClient/OracleParameter.cs:
* System.Data.OracleClient.Oci/OciEnvironmentHandle.cs:
* System.Data.OracleClient.Oci/OciErrorHandle.cs:
* System.Data.OracleClient.Oci/OciLobLocator.cs:
* System.Data.OracleClient.Oci/OciServerHandle.cs:
* System.Data.OracleClient.Oci/OciServiceHandle.cs:
* System.Data.OracleClient.Oci/OciSessionHandle.cs:
Replaced OCI calls.
svn path=/trunk/mcs/; revision=21877
* System.Data.OracleClient.Oci/IOciDescriptorHandle.cs:
* System.Data.OracleClient.Oci/IOciHandle.cs:
* System.Data.OracleClient.Oci/OciDescriptorType.cs:
Removed. These are no longer used.
* System.Data.OracleClient.Oci/OciParameterDescriptor.cs:
Add new class
* list:
Add System.Data.OracleClient.Oci/OciParameterDescriptor.cs
Rem System.Data.OracleClient.Oci/IOciDescriptorHandle.cs
Rem System.Data.OracleClient.Oci/IOciHandle.cs
Rem System.Data.OracleClient.Oci/OciDescriptorType.cs
* System.Data.OracleClient/OciGlue.cs:
Move the OCIAttrGet* methods into OciHandle
* System.Data.OracleClient/OracleDataReader.cs:
* System.Data.OracleClient/OracleParameter.cs:
Change the way that columns are bound and described
* System.Data.OracleClient.Oci/OciBindHandle.cs:
* System.Data.OracleClient.Oci/OciDefineHandle.cs:
* System.Data.OracleClient.Oci/OciDescriptorHandle.cs:
* System.Data.OracleClient.Oci/OciEnvironmentHandle.cs:
* System.Data.OracleClient.Oci/OciErrorHandle.cs:
* System.Data.OracleClient.Oci/OciHandle.cs:
* System.Data.OracleClient.Oci/OciLobLocator.cs:
* System.Data.OracleClient.Oci/OciServerHandle.cs:
* System.Data.OracleClient.Oci/OciServiceHandle.cs:
* System.Data.OracleClient.Oci/OciSessionHandle.cs:
* System.Data.OracleClient.Oci/OciStatementHandle.cs:
* System.Data.OracleClient.Oci/OciTransactionHandle.cs:
All handles now derive from OciHandle, and these classes
have been rewritten as such. Also attempted to implement
the Dispose () methods for these classes.
* System.Data.OracleClient.Oci/OciHandleType.cs:
Add descriptor types into here because handles and
descriptors are used in many of the same OCI functions.
svn path=/trunk/mcs/; revision=12176
* System.Data.OracleClient/OracleConnection.cs:
Rollback transactions when connection closes if they
are open.
* System.Data.OracleClient/OracleDataReader.cs:
Implement GetOracleLob ()
* System.Data.OracleClient/OracleLob.cs:
Implement some of the details, like Read/Write/Seek
* System.Data.OracleClient.Oci/OciBindHandle.cs:
Remove debug message.
* System.Data.OracleClient.Oci/OciDefineHandle.cs:
Add LOB support.
* System.Data.OracleClient.Oci/OciEnvironmentHandle.cs:
Minor formatting changes
* System.Data.OracleClient.Oci/OciLobLocator.cs:
Huge amounts of code to make it work. Lots of ugly
OCI P/Invoke code.
* Test/TestOracleClient.cs:
Improve the LOBTest.
svn path=/trunk/mcs/; revision=12021
* System.Data.OracleClient/OracleDateTime.cs:
* System.Data.OracleClient/OracleInfoMessageEventArgs.cs:
* System.Data.OracleClient/OracleInfoMessageEventHandler.cs:
* System.Data.OracleClient/OracleMonthSpan.cs:
* System.Data.OracleClient/OraclePermission.cs:
* System.Data.OracleClient/OraclePermissionAttribute.cs:
* System.Data.OracleClient/OracleTimeSpan.cs:
* System.Data.OracleClient.Oci/IOciDescriptorHandle.cs:
* System.Data.OracleClient.Oci/OciDescriptorHandle.cs:
* System.Data.OracleClient.Oci/OciLobLocator.cs:
New classes added. Some based on .NET docs,
others (internal) based on getting some LOB
support (doesn't actually work yet).
* list:
Add new files
* System.Data.OracleClient/OracleBFile.cs:
* System.Data.OracleClient/OracleBinary.cs:
* System.Data.OracleClient/OracleLob.cs:
* System.Data.OracleClient/OracleNumber.cs:
* System.Data.OracleClient/OracleString.cs:
Change handling of NULL object based on new
discovery.
* System.Data.OracleClient/OracleCommand.cs:
* System.Data.OracleClient/OracleDataReader.cs:
Typo fix.
* System.Data.OracleClient.Oci/OciDefineHandle.cs:
* System.Data.OracleClient.Oci/OciEnvironmentHandle.cs:
Add some code to handle LOBs. Still more to
come.
* Test/TestOracleClient.cs:
New test for LOB added.
svn path=/trunk/mcs/; revision=11828
* System.Data.OracleClient/OciBindHandle.cs:
* list:
Add new class
* System.Data.OracleClient/OracleCommand.cs:
Add transaction logic for rollback/commit,
attaching to oracle service context, and a
couple of test cases.
Add Parameter handling
* System.Data.OracleClient/OracleDataReader.cs:
Change GetValue call
* System.Data.OracleClient/OracleParameter.cs:
Make this work
* System.Data.OracleClient/OracleType.cs:
Add values to enum
* System.Data.OracleClient.Oci/OciDefineHandle.cs:
Add GetValue call which is used by data reader
* System.Data.OracleClient.Oci/OciStatementHandle.cs:
Add parameter logic
* Test/TestOracleClient.cs:
Add some new test cases.
svn path=/trunk/mcs/; revision=11709
* System.Data.OracleClient.Oci/OciColumnInfo.cs:
* System.Data.OracleClient.Oci/OciDataType.cs:
* System.Data.OracleClient.Oci/OciDefineHandle.cs:
* list:
New classes added
* System.Data.OracleClient/OciGlue.cs:
Changes to AttrGet functions
* System.Data.OracleClient/OracleCommand.cs:
* System.Data.OracleClient/OracleDataReader.cs:
Start some work on getting data reader going
* System.Data.OracleClient.Oci/OciAttributeType.cs:
Add DisplayName
* System.Data.OracleClient.Oci/OciStatementHandle.cs:
Add code to get schema for query, as well as
define output values.
svn path=/trunk/mcs/; revision=11571