Leaves it up to deriving classes to override Dispose (bool) and
perform a rollback if necessary. Fixes bug #325397. Code formatting.
* ExceptionHelper.cs: Added TransactionNotUsable method that constructs
an InvalidOperationException to be thrown by IDbTransaction
implementations when the transaction is no longer open.
* OdbcTransaction.cs: Keep state of the transaction, and update it
when performing commit or rollback. In Dispose (bool), only perform
a rollback if transaction was not committed or rollback before.
In Commit and Rollback, throw an InvalidOperationException if
transaction is no longer open.
* SqlTransaction.cs: Avoid unnecessary initialization. Remove
isRolledBack since its essentially the same as isOpen. Use
ExceptionHelper.TransactionNotUsable instead of duplicating code.
On 2.0 profile, ignore call to Rollback when transaction was already
disposed.
* OleDbTransaction.cs: Keep track of whether transaction is open and
whether it's disposed. In Commit an Rollback, throw an IOE if the
transaction is no longer open. In Dispose (bool), perform a rollback
if the transaction is still open.
svn path=/trunk/mcs/; revision=87835
for assigning zero-length string, and use String.Length to check for
zero-length string. Added support for IsolationLevel.Snapshot.
Added StructuredTypeMembers schema collection and restrictions. Fixed
table name for MetaDataCollections collection. Implemented
DataSourceInformation collection. Added missing data types (probably
introduced in 2.0 SP1). In GetSchema, throw InvalidOperationException
if connection is closed and throw NotImplementedException for
StructuredTypeMembers collection.
svn path=/trunk/mcs/; revision=87751
not valid. On 2.0 profile, when IsolationLevel.Unspecified is passed
make sure to also set SqlTransaction.IsolationLevel to
ReadCommitted. Modified exceptions to match MS.
svn path=/trunk/mcs/; revision=87735
IsolationLevel.Unspecified, so the default is set as ReadCommited.
Thanks to Jerome Haltom <[email protected]> for this patch.
Fixes bug # 333082.
* SqlTransaction.cs: If transaction count is greater then 0 then roll
back. Thanks to Jerome Haltom <[email protected]> for this
patch. Fixes bug # 331953.
svn path=/trunk/mcs/; revision=87659
* SqlCommand.cs, SqlDataReader.cs, SqlConnection.cs: When the
server resets the connection, now the client code also disconnects
the session and remove the instance from pool. Fixes bug # 81933.
svn path=/trunk/mcs/; revision=83522
* SqlCommand.cs (Transaction, Connection): IDbCommand Transaction
and Connection can be set to null. Fixes bug 82189.
svn path=/trunk/mcs/; revision=83059
* SqlClientFactory.cs: Use SqlDataSourceEnumerator from S.D.Sql and
marked method todo. Avoid unnessary casts. Code formatting.
* SqlCommand.cs: Explicit interface implementation of IDbCommand not
necessary on 2.0 profile. Fixes API mismatches. Avoid unnecessary
casts. Code formatting.
* SqlConnection.cs: Also use RecommendAsConfigurable instead of
SettingBindableAttribute on 2.0. Use StateChange event from base class
on 2.0. Only explicitly implement IDbConnection methods on 1.0, since
these are implemented by base class on 2.0 profile. Removed extra
explicit implementation of IDisposable since the base class implements
this. Code formatting.
* SqlDataAdapter.cs: Dispose (bool) override not necessary on 2.0
profile. Stubbed ICloneable.Clone. Fixes API mismatches.
* SqlDataReader.cs: On 2.0, IDisposable.Dispose is implemented by
DbDataReader. Only 1.0 profile, explicitly implemented IEnumerable
GetEnumerator. Code formatting.
* SqlDataSourceEnumerator.cs: Removed.
* SQLDebugging.cs: Marked sealed on 2.0. Code formatting.
* SqlNotificationAuthType.cs: Removed.
* SqlNotificationInfo.cs: Added missing fields. Code formatting.
* SqlNotificationSource.cs: Added missing fields. Code formatting.
* SqlNotificationTransports.cs: Removed.
* SqlNotificationType.cs: Added missing Unknown field. Code formatting.
* SqlParameter.cs: Removed Browsable and EditorBrowsable attributes
from Precision and Scale. Fixes API mismatches. Code formatting fixes.
* SqlTransaction.cs: On 2.0 profile, Dispose method is exposed by
base class. Fixes API mismatches. Code formatting fixes.
* System.Data.dll.sources: Removed ISqlNotificationReceiver.cs,
SqlDataSourceEnumerator.cs, SqlNotificationAuthType.cs,
SqlNotificationTransports.cs.
svn path=/trunk/mcs/; revision=81134
* SqlCommand.cs, SqlConnectionStringBuilder.cs, SqlConnection.cs:
Fixed 1.0 and 2.0 extras, errors as stated in class status page.
* SqlDataAdapter.cs, SqlParameter.cs:Fixed 1.0 and 2.0 extras,
errors as stated in class status page.
* SqlBulkCopyColumnMappingCollection.cs: Fixed 1.0 and 2.0 extras,
errors as stated in class status page.
svn path=/trunk/mcs/; revision=78717
* SqlParameter.cs (SqlParameter): Updated constructor to use the
new TDS RPC implementation.
Fixed missing attributes.
(SetDbType): Added new case for sql_variant type.
(ConvertToFrameworkType): Implemented new private method to
convert the data type to framework type.
* SqlParameterCollection.cs: Fixed missing attributes and
implemented missing methods.
* SqlConnection.cs: Fixed missing attributes.
* SqlConnectionStringBuilder.cs: Certain attributes are missing or
its value or they are not appropriate. Fixed them.
* SqlDataReader.cs (GetData): Method is available only under 1.0
profile.
* SqlCommandBuilder.cs: Certain attributes are available only
under 2.0 profile, so moved them inside ifdef.
* SqlCommand.cs: Certain attributes are available only under 2.0
profile, so moved them inside ifdef.
svn path=/trunk/mcs/; revision=78186
* SqlClientFactory.cs: Added two using directives.
(CreateConnectionStringBuilder): Implemented the method.
(CreatePermission): Implemented the property.
* SqlCommand.cs: Added one using directive.
(Clone): Implemented the method.
(Dispose): Implemented the method.
(BeginExecuteXmlReader): Implemented the method.
* SqlCommandBuilder.cs (QuoteIdentifier): Implemented the method.
(UnquoteIdentifier): Implemented the method.
* SqlConnection.cs (ChangePassword): Implemented the method.
2007-03-19 Nidhi Rawal <[email protected]>
* SqlClientFactory.cs (CanCreateDataSourceEnumerator): Implemented
the property.
* SqlCommand.cs (Notification): Implemented the property.
(NotificationAutoEnlist): Implemented the property.
* SqlDataReader.cs (VisibleFieldCount): Implemented the property.
* SqlConnectionStringBuilder.cs (TrustServerCertificate): Implemented
the property.
(TypeSystemVersion): Implemented the property.
(UserInstance): Implemented the property.
(ContextConnection): Implemented the property.
* SqlConnection.cs (FireInfoMessageEventOnUserErrors): Implemented
the property.
(StatisticsEnabled): Implemented the property.
* SqlDataAdapter.cs (UpdateBatchSize): Implemented the property.
* SqlParameter.cs: Implemented one attribute.
svn path=/trunk/mcs/; revision=75189
* SqlParameter.cs: Move isVariableSizeType flag to TdsMetaParameter
so that the TdsMetaParameter can validate itself for valid size / values.
* SqlCommand.cs (Execute): Call Validate on TdsMetaParameter.
* TdsMetaParameter.cs: Add Validate() method. For now, validate
size/value. Add isVariableSizeType.
* SqlCommandTest.cs: Add OutputParamSizeTest1-4 to test size/value
validation exception.
svn path=/trunk/mcs/; revision=74500
* SqlCommand.cs (CommandType): Exception type thrown in 2.0
profile is different than 1.0, ArgumentOutOfRangeException.
(Connection): Exception type thrown in 2.0 profile is different
than 1.0, ArgumentOutOfRangeException.
(Execute): If Size property is 0 for String and Binary type, then
throw InvalidOperationException.
(ValidateCommand): Exception type thrown in 2.0 profile is
different than 1.0, NullReferenceException.
svn path=/trunk/mcs/; revision=74232
* SqlCommand.cs (ExecuteScalar): Fix returned value for
stored procedure calls to return the first column of the
first row produced by the proc.
* SqlCommandTest.cs: Add parameterized stored procedure call tests
to ExecuteScalar and ExecuteNonQuery.
svn path=/trunk/mcs/; revision=73982
implement support for return of output values in the parameter
collection.
2007-03-07 Andreia Gaita <[email protected]>
svn path=/trunk/mcs/; revision=73914
* SqlParameter.cs (CompareInfo): Implemented the property
CompareInfo.
2007-02-15 Nidhi Rawal <[email protected]>
* SqlCommand.cs: Added some attributes which were not implemented
for .NET 2.0 and removed extra attribute which are not there in
.NET 2.0.
* SqlCommandBuilder.cs: Added some attributes that were not
implemented for .NET 2.0.
* SqlParameterCollection.cs: Added some attributes that were
not implemented for .NET 2.0.
* SqlConnectionStringBuilder.cs: Added some attributes that
were not implemented for .NET 2.0.
* SqlConnection.cs: Added attribute that was not implemented
for .NET 2.0.
* SqlParameter.cs: Added some attributes which were not
implemented for .NET 2.0 and removed some extra attributes which
are not there in .NET 2.0
svn path=/trunk/mcs/; revision=73144
* SqlTransaction.cs (Dispose): Fixed compliation warning.
* SqlDataReader.cs (GetValues): Length of elements to be copied was
decided based on the argument array passed, which caused a bug, if
the length of given array is more than actual column values.
* SqlCommandBuilder.cs (CatalogSeparator, SchemaSeparator)
(CatalogLocation): Implemented missing properties.
(CreateDeleteCommand, CreateInsertCommand, CreateUpdateCommand):
Modified private methods to take bool flag. If true, add actual
parameter name instead of p1, p2 etc.
(CreateParameter): Added overloaded private method to create
parameter with the actual column name.
(GetUpdateCommand, GetDeleteCommand, GetInsertCommand):
Implemented missing overloaded methods.
(SetRowUpdatingHandler): Implemented missing protected method.
* SqlCommand.cs: Fixed compilation warning. Removed bogus
MonoTODO's.
svn path=/trunk/mcs/; revision=70619
* SqlCommand.cs (Execute): If sql2 length is greater than 0, then
add ';' and the respective sql2 string and then execute the
string. Fixes bug # 79880.
svn path=/trunk/mcs/; revision=69019
System.ComponentModel.Component already calls Dispose.
* SqlParameter.cs: Removed explicit interface implementation of
IDataParameter.ParameterName.
* OdbcErrorCollection.cs: Removed explicit interface implementation
of IEnumerable.GetEnumerator ().
* OdbcCommand.cs: Removed destructor as the destructor in
System.ComponentModel.Component already calls the Dispose method.
Removed explicit interface implemenation of members that are
implement by public members.
* OdbcDataReader.cs: Removed explicit interface implemenation of
IDataRecord.GetData.
* OleDbErrorCollection.cs: Removed explicit interface implementation
of IEnumerable.GetEnumerator ().
* OleDbParameterCollection.cs: Removed explicit interface
implementation members that are already implementation by public
members.
* DataTable.cs: Renamed initInProgress to fInitInProgress. BeginInit
and EndInit must only be virtual in 2.0 profile. Set eol-style to CRLF.
svn path=/trunk/mcs/; revision=61328
* Test/ProviderTests/System.Data.SqlClient/SqlParameterTest.cs :
Test if Parameter Type is inferred correctly
when Value is null or DBNull. Also, if Type is not explicitly set,
test if it is inferred from the value of the parameter evertime the
value is set.
* System.Data.SqlClient/SqlParameter.cs :
- InferSqlType : if value is null or DBNull.Value, retain the
current parameter type.
svn path=/trunk/mcs/; revision=61156
* Test/ProviderTests/System.Data.SqlClient/SqlConnectionTest.cs :
- OpenTest_1 : test InvalidOperationException is raised if
ConnectionString is empty
- DisposeTest : test nullreference exception is not raised
* System.Data.SqlClient/SqlConnection.cs :
- SetConnectionString : set the pareameter to default values
if connection string is empty or null
- Open : Raise InvalidOperationException if Connection String
is empty or null
- Dispose : Test exception not raised if dispose called on a
connection with empty connection string
slight modification of the patch by Jonel Rienton
svn path=/trunk/mcs/; revision=59582
* Test/ProviderTests/System.Data.SqlClient/SqlCommandBuilderTest.cs :
- Corrected the testcase to check for queries corresponding to
ms.net 2.0
- verify that columns that do not allow nulls are not included
in the null-checks.
- Added testcase to check for DBConcurrencyException for
Delete Command.
- Check the DataType of the null-check parameters
* System.Data.Common/DbDataAdapter.cs :
* Update () : If the Update/Delete Query has a null check,
then populate the parameter value correctly.
* System.Data.SqlClient/SqlCommandBuilder.cs :
* CreateDeleteCommand ()
* CreateUpdateCommand ()
* CreateInsertCommand ()
- Changed the signature. Do not need DataRow parameter
as the Query generated is parametric.
- Correct the null-check term in the WhereClause, set the
correct properties for null-check parameter
fixes#78027
- Modified the generated query to match the query as
generated by 2.0. We now ignore null-check in the
whereclause if the Column does not allow nulls.
* ctor () : Set QuotePrefix and QuoteSuffix for 2.0 profile
* GetUpdateCommand ()
* GetInsertCommand ()
* GetDeleteCommand ()
- Do not create new command everytime. Create only if
not already created.
* RefreshSchema : Reset the commands.
svn path=/trunk/mcs/; revision=59175
* Mono.Data.Tds/Mono.Data.Tds.Protocol/Tds70.cs :
- ProcessColumnInfo () : Set IsAutoIncrement Value for the column.
* System.Data/Test/ProviderTests/System.Data.SqlClient/SqlCommandBuilderTest.cs :
- Added testcase to verify UpdateCommand created with AutoIncrement
columns.
* System.Data/Test/ProviderTests/ProviderIndependant/DataReaderTest : Added a test to verify if AutoIncrement
value is set in the SchemaTable.
svn path=/trunk/mcs/; revision=57689