2087 Commits
Author SHA1 Message Date
Nikolay Sivov f9052ed78e [System.Drawing] Use CoreFX implementation of BufferedGraphics on Windows (#16163)
The issue was made visible with .NET Core WinForms. Some controls draw text with DrawTextEx to intermediate Graphics based on Bitmap, that later it's moved back to main Graphics with DrawImage. This results in a lost of transparency component along the way, making antialiased glyph bitmaps draw and B/W. Corruption is visible with gray antialiasing, but is more severe in subpixel modes.

I verified that same happens with gdiplus on Windows, code from CoreFX works correctly.
2019-08-12 12:42:07 +02:00
Filip Navara 98cb4aed20 [System.Drawing] Fix comparison in MeasureString_Wrapping_Dots test (#15958) 2019-08-01 17:09:38 +02:00
Alexander Köplinger 77cf4cc4f8 [tests] Remove MONOMAC ifdef from BCL tests (#13694)
It was set by xamarin-macios when they were still taking the raw .cs source files
but since we switched to prebuilt binaries we need to replace it with
some define we're actually setting in Mono.

Most cases can be replaced by just XAMMAC_4_5 since MOBILE is defined on the xammac profile.
2019-03-27 20:21:48 +01:00
Alexander Köplinger 92b435d6fe Move drawing types for XI/XM/wasm/orbis/unreal to System.Drawing.Common (#13414)
* Move drawing types for XI/XM/wasm/orbis/unreal to System.Drawing.Common

For XI/XM they were in Xamarin.iOS.dll/OpenTK-1.0.dll before.

For wasm/orbis/unreal we remove System.Drawing.dll from the profiles and
add the types to System.Drawing.Common.dll instead to align with the other
mobile profiles (only "net_4_x" and "build" still have System.Drawing.dll).

* Bump API snapshot submodule

* [csproj] Update project files
2019-03-12 18:07:19 +01:00
Egor Bogatov d0013e438c Add System.Drawing converters to netstandard facade (#13326)
This PR adds missing System.Drawing converters thus it completes NS2.1 support (as of today) for all profiles except macOS\IOS specific ones: monotouch, tv, watch, xammac, xammac_net_4_5.
2019-03-11 13:23:31 +01:00
Alexander Köplinger b31a445e85 [gitattributes] Do CRLF normalization on sln/proj files
They can be used with native line endings.

We now have a shared folder with the dotnet repos and they have CRLF normalization enabled.
This difference leads to conflicts while applying changes from the dotnet repos to mono.
2019-03-06 08:34:01 +01:00
monojenkins caf22d5f0b [csproj] Update project files 2019-01-02 13:54:08 +01:00
guthubuser e77d5bafef Update Graphics to find err
ystem.Exception: Generic Error [GDI+ status: GenericError]
  at System.Drawing.GDIPlus.CheckStatus (System.Drawing.Status status) [0x00079] in <bb99ab19679c4cf79f4136bd0faf8b5e>:0 
  at System.Drawing.Graphics.FillRectangle (System.Drawing.Brush brush, System.Int32 x, System.Int32 y, System.Int32 width, System.Int32 height) [0x00025] in <bb99ab19679c4cf79f4136bd0faf8b5e>:0 
  at System.Drawing.Graphics.FillRectangle (System.Drawing.Brush brush, System.Drawing.Rectangle rect) [0x0002c] in <bb99ab19679c4cf79f4136bd0faf8b5e>:0 
  at (wrapper remoting-invoke-with-check) System.Drawing.Graphics.FillRectangle(System.Drawing.Brush,System.Drawing.Rectangle)
  at System.Windows.Forms.Control.PaintControlBackground (System.Windows.Forms.PaintEventArgs pevent) [0x002ff] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.Control.OnPaintBackground (System.Windows.Forms.PaintEventArgs pevent) [0x00000] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.Control.WmPaint (System.Windows.Forms.Message& m) [0x0005f] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.Control.WndProc (System.Windows.Forms.Message& m) [0x001a4] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.ScrollBar.WndProc (System.Windows.Forms.Message& m) [0x00000] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.Control+ControlWindowTarget.OnMessage (System.Windows.Forms.Message& m) [0x00000] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.Control+ControlNativeWindow.WndProc (System.Windows.Forms.Message& m) [0x0000b] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.NativeWindow.WndProc (System.IntPtr hWnd, System.Windows.Forms.Msg msg, System.IntPtr wParam, System.IntPtr lParam) [0x00085] in <69ecb40f27a1431a99620933ba9a8b39>:0
2018-12-19 10:33:31 -05:00
Egor Bogatov 787f1bc69c [NS2.1] Import some primitive System.Drawing types from CoreFX (#11658)
* Import Color and friends from CoreFX

* Fix some tests

* SystemColors.cs from CoreFX

* bump corefx

* ignore reflection tests

* fix System.Web tests

* bump corefx

* remove files

* fix mobile platforms

* fix mobile build

* fix mobile build

* fix mobile build

* fix mobile build

* Bump API snapshot submodule

* [csproj] Update project files
2018-11-29 09:12:32 +01:00
Alexander Köplinger fab1f8e19b Update csproj 2018-11-29 02:30:49 +01:00
Alexander Kyte fb42448b70 [runtime] Integrate BenchmarkDotNet for in-tree microbenchmarks (reapply of #9833) (#11813) 2018-11-28 17:13:07 +01:00
Alexander Köplinger 1f6c9272fe Revert "[runtime] Integrate BenchmarkDotNet for in-tree microbenchmarks (#9833)"
This reverts commit e15b8c53ff.

It broke other builds.

Revert "[bench] Revert hardcoding of microbenchmarks to run-jenkins (#11787)"

This reverts commit 7a81ac67a2.
2018-11-27 13:46:23 +01:00
Alexander Kyte e15b8c53ff [runtime] Integrate BenchmarkDotNet for in-tree microbenchmarks (#9833)
Don't merge, using my fork of the BenchmarkDotNet repo so I can use a not-yet-merged hack to fix the build.
2018-11-26 12:34:26 -08:00
HebaruSan e743a7fd74 [WinForms] Really fix ToolStrip background (#11287)
## Problem

Even after #10942, menus and toolstrips still look awful with a dark theme:

![toolstrip](https://user-images.githubusercontent.com/1559108/46361551-8e6dea80-c633-11e8-97d1-242612b4b5cf.png)

## Previous attempt

#10942 was a first stab in the dark at what was going on here, before I managed to get mono to compile for testing. I was hopeful that it would address this, but the problem was different.

## Another red herring

Later I thought the problem might be that `SystemColors.ButtonFace.IsSystemColor` was `false`. It looked like this might have caused the runtime to interpret `ButtonFace`'s special 168 value as an RGB code instead of a system color marker.

This fix had no effect (see below for true cause), but I'll include it anyway; the lower bound of the upper system colors block needs to decrease from 170 to 168 to allow `ButtonFace` and `ButtonHighlight` to be considered system colors:

https://github.com/mono/mono/blob/44db64c620c2c957a49b3f5a69cb09c19c1c8c1a/mcs/class/System.Drawing/System.Drawing/KnownColor.cs#L200-L203

## Actual cause

The toolstrip color comes from `ProfessionalColorTable.ToolStripGradientBegin` and `ProfessionalColorTable.ToolStripGradientEnd`. The latter color is hard coded to a light shade, but the former defaults to `SystemColors.ButtonFace`.

These are the colors that are loaded from the GTK system theme:

https://github.com/mono/mono/blob/b104565ccfde477fc7b6308f2d3e4efff0af5848/mcs/class/System.Windows.Forms/System.Windows.Forms/X11DesktopColors.cs#L111-L116

Note that `ButtonFace` is not among them. This means that it uses a compile time default, and is not a good choice for the background of a control. `ToolStrip` is using it anyway, but other controls use `SystemColors.Control` instead.

## Changes

There are two obvious ways to fix this:

1. Use `SystemColors.Control` instead of `SystemColors.ButtonFace` in `ProfessionalColorTable`
2. Load `SystemColors.ButtonFace` from the system theme

This pull request does both. In addition, it also sets the other end of the toolstrip gradients to `SystemColors.ControlLight` instead of a hard coded value. The choice of `ControlLight` was made because in those cases where alternate hard coded values were available for both sides of the gradient, the "other" side was consistently lighter. Now it looks better:

![image](https://user-images.githubusercontent.com/1559108/47258840-efd0ee80-d466-11e8-842f-2fed8b3b9d82.png)
2018-11-16 20:09:20 +01:00
Alexander Köplinger 2fd171c4f9 Fix tarball build
1) We try to include every source in .sources but that doesn't work
for generic _test.sources since we'd need to prepend the Test/ path.

2) MonoNativeConfig.cs.in was removed in 273f120c52
2018-11-04 13:15:46 +01:00
Alexander Köplinger 75f3c0cc0c [System.Drawing] Fix test build for wasm profile
It was recently switched to only contain the netstandard20 subset of types.
2018-11-01 02:04:40 +01:00
monojenkins 6ef9162b78 [csproj] Update project files 2018-10-31 14:08:04 +01:00
Marek Safar 103999d3cd [corlib] Tweak more wasm defines 2018-10-31 14:08:04 +01:00
Ludovic Henry a282040c96 [bcl] Build all XUnit and NUnit tests for monodroid, monotouch, monotouch_tv, monotouch_watch and wasm BCL profiles (#11201) 2018-10-17 14:44:45 -04:00
Ludovic Henry 2a4cfddd9a [sdks] Build tests for BCL targets (#11141)
* [sdks] Build BCL profiles without configure flags

* [sdks] Add BclTemplate to build BCL profiles

This is to avoid building all the profiles in a single `sdks/out/bcl` directory which will be shared between android, ios and wasm.

* [sdks] Simplify call to BclTemplate

* [mcs] Make directory dependency as order-only

We would otherwise always rebuild the target since the directory is updated whenever something is added to the directory. This is a common Makefile technique.

* [sdks] Build tests for BCL targets
2018-10-16 14:00:12 -04:00
Alexander Köplinger 3b40965d0a [System.Drawing] Switch tests to use embedded test resources 2018-09-27 22:46:56 +02:00
Katelyn Gadd 84af5b235e Move the PreBuild dependency property later in the file so targets can't override it (#10429)
* Move the PreBuild dependency property later in the file so targets can't override it

* [csproj] Update project files
2018-09-02 17:54:01 +02:00
Katelyn Gadd a6a8abde09 Kill sln dependencies (#10406)
* Remove use of sln dependencies and use csproj project references instead

* Rewrite jay.vcxproj so it builds correctly even without help from the sln file

* Force pre-build event to run after references are resolved. Change how culevel.exe path is computed to be more resilient.

* [csproj] Update project files
2018-08-31 17:44:27 +02:00
Katelyn Gadd 14d20074ff Move to generating msbuild choose elements to get if-else selection behavior for sources in projects so that we don't get erroneous duplicate files in cases where there are both profile and host platform criteria (#9952)
A recent commit revealed that in cases where we select based on a mix of host platform and profile, genproj csproj files can end up with duplicate sources because the existing <ItemGroup Condition= approach could make multiple groups match for a given compile when we really just want one.

This PR changes to generating a cascade of msbuild <Choose> elements, which give if-else selection to ensure that we only ever build a single set of files.
2018-08-09 02:52:37 +02:00
Katelyn Gadd feaf8ee391 Use msbuild project reference to establish dependency on genconsts instead of solution dependencies (#9670)
Using solution dependencies in ```bcl.sln``` seems flaky and seems like it might not establish the full ordering we need to ensure that ```Consts.cs``` exists before we build things that require it. Let's try using project references (where ```corlib.dll``` 'depends' on ```genconsts.exe```) instead. This should also insert the dependency for any project that includes Consts.cs instead of just corlib.

This PR also makes update-solution-files actually fail if ```genconsts.exe``` fails to build because it was driving me mad.

Part of #6886
2018-08-02 00:30:54 +02:00
Filip Navara 60b95ba08d Fix System.Drawing on 64-bit macOS. (#9824)
Carbon implementation now throws exception instead of crashing in the mismatched p/invoke calls.
Cocoa implementation now support 64-bit mode and uses the handle of `NSView` that is passed in instead of relying on `NSGraphicsContext.CurrentContext`. It also fixes handling of flipped views.

Requires up to date libgdiplus.
2018-08-01 12:47:47 +02:00
Katelyn Gadd e271c293ee Rework genproj to use gensources to build sources list for each profile and host platform (#8985)
* Update genproj makefile to include gensources
Update genproj argument parser to be more generous about displaying help

* Checkpoint

* Checkpoint

* Checkpoint

* Checkpoint

* Checkpoint

* Checkpoint

* Checkpoint

* Checkpoint

* Fix rebase issue

* Checkpoint

* Checkpoint

* Fix built sources only being added to one profile

* Fix typo

* Checkpoint

* Fix indentation

* Use csc instead of mcs

* Checkpoint

* Fix BUILT_SOURCES only being handled for the first profile processed

* Checkpoint

* Checkpoint

* Strip double slashes from paths to fix spurious csproj change

* Checkpoint

* Checkpoint

* Checkpoint

* Checkpoint: Fix genproj compilation

* Checkpoint

* Checkpoint

* Checkpoint

* Fix crash when no targets were loaded (due to an error)

* Checkpoint

* Checkpoint

* Checkpoint

* Fix TryParseTargetInto bug

* Checkpoint

* Shuffle exclude logic around so that it works correctly during genproj diffing

* Remove gensources tracing

* Checkpoint

* Fix handling of oddball sources paths from executable.make

* Fix jay not being set to build

* Fix wrong slashes being used for embedded resource paths

* [csproj] Update project files
2018-06-29 08:01:31 +02:00
Egor Bogatov 51935465ae Delete unused files in BCL (#9288)
The following files in `mcs/class/*.cs` are not used anywhere (*.csproj/*.source).
2018-06-25 11:15:20 +02:00
monojenkins ab4d81e794 [csproj] Update project files 2018-05-31 23:34:33 +02:00
Egor Bogatov 09de0b9e1b [System] ComponentModel and System.Net from corefx (#7948)
* ComponentModel from corefx

* System.Net.Mail from corefx

* update SR.cs

* fix build error

* fix tests

* undo run-test-default.sh change

* update corefx

* fix failing tests

* hide DesignerAttribute on mobile profiles

* Bump API snapshot submodule
2018-04-20 22:04:39 -07:00
Hugh Bellamy 4bd60ea895 Fix Gdi+ WrongState exception type and remove incorrect test for GdiPlus status code (#8276)
* Fix Status.WrongState exception

* Remove invalid test for GdipLockBits

* Fix LinearGradientBrush behaviour to match netfx/netcore
2018-04-18 17:43:14 -04:00
Katelyn Gadd 7eff6686fd Default platform to net_4_x if none is specified, to fix tools that build without setting a platform (#8223)
* Default platform to net_4_x if none is specified, to fix tools that build without setting a platform

* [csproj] Update project files
2018-04-16 09:54:53 -04:00
monojenkins 093df52396 [csproj] Update project files 2018-04-12 11:39:27 +02:00
Marek Safar b3881a418f CoreFX update 2018-04-12 11:39:27 +02:00
monojenkins 585954cbb9 [msvc] Update csproj files (#8067) 2018-04-06 02:17:12 +02:00
Filip Navara a810739246 Include CoreFX GraphicsPath and Region tests. 2018-04-02 15:22:26 +02:00
Hugh Bellamy fcd52894d9 [System.Drawing] Remove failing jpeg flags tests (#7931) 2018-04-01 00:41:17 +02:00
Alexander Köplinger 2cbd1706dc [System.Drawing] Enable corefx xunit tests (#7924) 2018-03-31 01:13:03 +02:00
monojenkins 2f66873ab2 [msvc] Update csproj files (#7811)
* [msvc] Update csproj files

* [msvc] Delete old net_4_x.csproj and xbuild_12.csproj files
2018-03-28 19:29:28 +02:00
monojenkins 3e8f4f7db8 [msvc] Update csproj files (#7497) 2018-03-08 17:14:32 +01:00
monojenkins 12cbe9a7bd [msvc] Update csproj files (#7238) 2018-02-23 17:00:46 +01:00
Alexis Christoforides dcda4c77bc Disable some PngCodecTest that have trouble on CI right now 2018-02-09 15:36:18 -05:00
EgorBo 90d11817f8 fix leak in FontFamily 2018-01-30 23:03:43 -05:00
monojenkins e51565c7e5 [msvc] Update csproj files (#6100) 2017-11-25 23:34:52 +01:00
Hugh Bellamy 8a82b292fb Update GdipGetImageDimensions tests to pass against Windows GDI+ (#6008)
Make the image height dimension check more relaxed.
These fail against windows and cause errors when fixed in mono/libgdiplus#121
2017-11-16 18:57:11 +01:00
monojenkins d2e60f48b6 [msvc] Update csproj files (#5745) 2017-10-09 21:40:39 +02:00
Marek Safar 411a37af27 Bump corefx 2017-10-05 22:43:54 +02:00
Hugh Bellamy 177fca4917 Fix LinearGradientMode parameter validation to match corefx (#5672) 2017-10-02 16:15:28 +02:00
Hugh Bellamy 5825342717 Remove invalid tests for image palettes in GdiPlusTest (#5671)
C.r. https://github.com/mono/libgdiplus/pull/112
2017-10-02 02:28:25 +02:00
Alexander Köplinger a243301ee4 [WinForms/Drawing] Remove some leftover test scripts (#5518)
They're no longer used.
2017-09-06 22:24:07 +02:00