36 Commits
Author SHA1 Message Date
Egor Bogatov dc56ae2acb Fix 9332 2018-07-09 18:52:23 +02:00
Marek Safar a6d12ab738 [System.Runtime.Serialization] Makes more APIs work for mobile 2018-06-03 08:44:06 +02:00
Alexander Köplinger 6e246cf613 [Facades] Move types from Facades into class libraries (#7574)
We implemented them in the facades until now but in .NET 4.7.1
they were promoted into the regular class libraries.

Use PLATFORM_DEBUG_FLAGS for IL-less assemblies

Also replace some files with corefx that were identical.
2018-03-13 12:28:43 +01:00
Marek Safar 07adebd8bf Updates referencesource to .NET 4.7 2017-04-11 12:25:37 +02:00
Marek Safar 47a6f56439 [bcl] Clean up some warnings 2016-11-29 19:16:02 +01:00
Alexander Köplinger 112631f5c6 [bcl] Add missing APIs for netstandard parity and expose a few APIs on mobile
This ensures we're compliant with the upcoming netstandard2.0 API surface area.
2016-09-23 17:50:06 +02:00
Marek Safar b6a30059db [bcl] Update Reference Source to .NET Framework 4.6.2 2016-08-09 18:07:14 +02:00
Marek Safar ff24de4596 [bcl] Don't build not installed mobile assemblies 2016-08-02 10:23:04 +02:00
Marek Safar 680321339d [System.Runtime.Serialization.dll] Update referencesource strings 2016-04-04 16:41:35 +02:00
Marcos Henrich 8a1e9242f6 [System.Runtime.Serialization] Static writer fix.
While serializing any type into a contract member of type object an
exception would be thrown.

To avoid this XmlObjectSerializerWriteContext.InternalSerialize should
in this case be called using the object type instead of the member type,
similar how reference sources does in  type instead of the member type,
 referencesources seems to be doing omething similar [1].

Fixes #37116.

[1]
http://referencesource.microsoft.com/#System.Runtime.Serialization/System/Runtime/Serialization/XmlObjectSerializerWriteContext.cs,619
2016-03-29 10:09:38 +01:00
Aaron Bockover f76b8b4df1 XmlObjectSerialier: fix ISerializable (bxc#37171)
The shim/bridge between Mono and the RS implementation of
XmlObjectSerializer, DataContractSerializer, etc. did not properly
invoke the constructor required by ISerializable, as it completely
omitted passing the populated SerializationInfo object.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=37171
2015-12-21 11:00:46 -05:00
Miguel de Icaza ae8d66d6a9 [System.Runtime.Serialization] Static serializer calls directly into internal APIs to fix C6 regression
With C6 we introduced a regression
https://bugzilla.xamarin.com/show_bug.cgi?id=36100, which is caused by
the new static serialization code that we wrote to reuse Microsoft's
serializer.

The code uses Invoke on a series of MethodInfos, and this obscures the
actual code that will be invoked at runtime to serialize certain
objects, causing the following exception:

Attempting to JIT compile method '(wrapper runtime-invoke) <Module>:runtime_invoke_bool_Nullable`1<Decimal> (object,intptr,intptr,intptr)' while running with --aot-only.

This patch makes the simple code work, but a more thorough review of
the code would allow us to remove many of the slow dynamic codepaths
in the serializer.

We opted for that approach to keep the code as similar as possible to the
original.

But the code basically does this:

* Use the XmlFormatGeneratorStatics property InternalSerializeMethod,
  whose sole purpose is to delay computing the MethodInfo for the
  XmlFormatWriterGenerator's InternalSerialize.

* Use the resulting method in a few places to call the MethodInfo.

The MethodInfo was used because the original code uses Reflection.Emit
to create fast serializers and it needs handles to internal methods,
but our static rewriter does not need it.

We should replace all of those uses, but for now, this patch at least
deals with the 36100 bug.
2015-12-04 13:54:48 -05:00
Atsushi Eno cc9ddec7c4 [S.R.Serialization] fix default value comparison.
The fixed code used to invoke null.Equals(other).

The new test (by @alien0ada) shows the failing case.
2015-06-22 20:12:38 +09:00
Marek Safar 7050ee1ee7 [System.Runtime.Serialization] Update public api 2015-06-01 15:46:38 +02:00
Atsushi Eno ad06a4d80a [S.R.Serialization] fill message strings. 2015-04-24 14:37:00 +09:00
Atsushi Eno 5bc665e8c4 [S.R.Serialization] for some use cases we don't expect reflection exception.
We do throw TargetInvocationException because we can only use reflection.
So unwrap those exceptions. It is kind of silly though...
2015-04-24 14:36:57 +09:00
Atsushi Eno 1ca18d222c [S.R.Serialization] fix Json reader member duplicate check index. 2015-04-24 14:36:56 +09:00
Atsushi Eno bad2fdb5e8 [S.R.Serialization] fix condition on simple dictionary output. 2015-04-24 14:36:56 +09:00
Atsushi Eno cda40030b2 [S.R.Serialization] add Json reader/writer interpreters.
They don't pass all the tests in System.ServiceModel.Web yet.
2015-04-24 14:36:55 +09:00
Atsushi Eno 05dc210442 [S.R.Serialization] remove debugging code. 2015-04-24 14:36:55 +09:00
Atsushi Eno fc05116b03 [S.R.Serialization] implement XmlDataContract's interpreter method. 2015-04-24 14:36:54 +09:00
Atsushi Eno 2481129c45 [S.R.Serialization] additional type check for collection serialization is also needed. 2015-04-24 14:36:54 +09:00
Atsushi Eno a7051c6365 [S.R.Serialization] additional type check for array serialization is needed. 2015-04-24 14:36:54 +09:00
Atsushi Eno 98c812ee24 [S.R.Serialization] do not update memberType when not expected.
The removed code caused unexpected omission of xsi:type by giving "false"
Type information that is from the actual value (when the expected type is
different, xsi:type should be written).
2015-04-24 14:36:54 +09:00
Atsushi Eno 99a7c698f0 [S.R.Serialization] fix nullable serialization to match referencesource codegen.
The original code is complicated enough that I misinterpreted the logic...

The reulting code should look like this:

	DateTime? expr_94 = timeSubmitted;
	DateTime dateTime;
	bool arg_B5_0;
	if (XmlObjectSerializerWriteContext.GetHasValue<DateTime> (expr_94)) {
		dateTime = XmlObjectSerializerWriteContext.GetNullableValue<DateTime> (expr_94);
		arg_B5_0 = false;
	}
	else {
		dateTime = XmlObjectSerializerWriteContext.GetDefaultValue<DateTime> ();
		arg_B5_0 = true;
	}

The fixed code should be like this now.
2015-04-24 14:36:53 +09:00
Atsushi Eno f6d778c148 [S.R.Serialization] fix deserialization of primitive arrays in reader interpreter.
Basically the primary cause of the problem was that invoked primitive array
reader methods via reflection had 'out' parameter, which needed special care.
2015-04-24 14:36:53 +09:00
Atsushi Eno 1a8b8015a7 [S.R.Serialization] fix member indexing on reading deserialized members. 2015-04-24 14:36:53 +09:00
Atsushi Eno 828b7fb7a0 [S.R.Serialization] fix array element deserialization.
Array elements were not deserialized correctly and causing null (default)
items put into the array.
2015-04-24 14:36:53 +09:00
Atsushi Eno c5d45b2857 [S.R.Serialization] fix writer interpreter on enumerating non-dictionary.
Collection serialization was mostly failing, when it was non-dictionary.

Now it should be closer to referencesource dynamic code behavior.
2015-04-24 14:36:52 +09:00
Atsushi Eno affe15ccff [S.R.Serialization] fix reader interpreter: "required" check was broken.
Now it should match referencesource behavior.
2015-04-24 14:36:52 +09:00
Atsushi Eno d1152054a2 [S.R.Serialization] Fix TryWritePrimitive() parameter assignment.
It was inconsistent with what referencesource codegen does.
2015-04-24 14:36:52 +09:00
Atsushi Eno 51c1b640e7 [S.R.Serialization] add missing ConvertValue on xml reader interpreter. 2015-04-24 14:36:52 +09:00
Atsushi Eno 9f0d571781 [S.R.Serialization] implement XmlFormatReaderGenerator interpreter.
Though it's still buggy and shows several nunit test failures yet.
2015-04-24 14:36:51 +09:00
Atsushi Eno 02915b9d61 [S.R.Serialization] implemented interpreter-based XmlFormatWriterGenerator. 2015-04-24 14:36:51 +09:00
Atsushi Eno 569890717a [S.R.Serialization] switch to (non-emit) reflection-based implementation stubs.
The new code is to implement reflection (non-emit) based serialization
so that it works on iOS.

Actually I _totally_ switched to this new implementation because dynamic
method based implementation also doesn't work fine, even on desktop
(due to invocation failure on internal methods, it seems that our dynamic
method needs some bugfixes).

The new methods with NotImplementedException in new classes need to be
implemented.
2015-04-24 14:36:51 +09:00
Atsushi Eno b3a7d0aa00 [S.R.Serialization] switch to referencesources.
It builds on net_4_5 and monodroid so far.

We still need to eliminate dynamic code generation to make it work on iOS.
2015-04-24 14:36:50 +09:00