13 Commits
Author SHA1 Message Date
Marcos Henrich 8a1e9242f6 [System.Runtime.Serialization] Static writer fix.
While serializing any type into a contract member of type object an
exception would be thrown.

To avoid this XmlObjectSerializerWriteContext.InternalSerialize should
in this case be called using the object type instead of the member type,
similar how reference sources does in  type instead of the member type,
 referencesources seems to be doing omething similar [1].

Fixes #37116.

[1]
http://referencesource.microsoft.com/#System.Runtime.Serialization/System/Runtime/Serialization/XmlObjectSerializerWriteContext.cs,619
2016-03-29 10:09:38 +01:00
Miguel de Icaza ae8d66d6a9 [System.Runtime.Serialization] Static serializer calls directly into internal APIs to fix C6 regression
With C6 we introduced a regression
https://bugzilla.xamarin.com/show_bug.cgi?id=36100, which is caused by
the new static serialization code that we wrote to reuse Microsoft's
serializer.

The code uses Invoke on a series of MethodInfos, and this obscures the
actual code that will be invoked at runtime to serialize certain
objects, causing the following exception:

Attempting to JIT compile method '(wrapper runtime-invoke) <Module>:runtime_invoke_bool_Nullable`1<Decimal> (object,intptr,intptr,intptr)' while running with --aot-only.

This patch makes the simple code work, but a more thorough review of
the code would allow us to remove many of the slow dynamic codepaths
in the serializer.

We opted for that approach to keep the code as similar as possible to the
original.

But the code basically does this:

* Use the XmlFormatGeneratorStatics property InternalSerializeMethod,
  whose sole purpose is to delay computing the MethodInfo for the
  XmlFormatWriterGenerator's InternalSerialize.

* Use the resulting method in a few places to call the MethodInfo.

The MethodInfo was used because the original code uses Reflection.Emit
to create fast serializers and it needs handles to internal methods,
but our static rewriter does not need it.

We should replace all of those uses, but for now, this patch at least
deals with the 36100 bug.
2015-12-04 13:54:48 -05:00
Atsushi Eno cc9ddec7c4 [S.R.Serialization] fix default value comparison.
The fixed code used to invoke null.Equals(other).

The new test (by @alien0ada) shows the failing case.
2015-06-22 20:12:38 +09:00
Atsushi Eno 05dc210442 [S.R.Serialization] remove debugging code. 2015-04-24 14:36:55 +09:00
Atsushi Eno 2481129c45 [S.R.Serialization] additional type check for collection serialization is also needed. 2015-04-24 14:36:54 +09:00
Atsushi Eno a7051c6365 [S.R.Serialization] additional type check for array serialization is needed. 2015-04-24 14:36:54 +09:00
Atsushi Eno 98c812ee24 [S.R.Serialization] do not update memberType when not expected.
The removed code caused unexpected omission of xsi:type by giving "false"
Type information that is from the actual value (when the expected type is
different, xsi:type should be written).
2015-04-24 14:36:54 +09:00
Atsushi Eno 99a7c698f0 [S.R.Serialization] fix nullable serialization to match referencesource codegen.
The original code is complicated enough that I misinterpreted the logic...

The reulting code should look like this:

	DateTime? expr_94 = timeSubmitted;
	DateTime dateTime;
	bool arg_B5_0;
	if (XmlObjectSerializerWriteContext.GetHasValue<DateTime> (expr_94)) {
		dateTime = XmlObjectSerializerWriteContext.GetNullableValue<DateTime> (expr_94);
		arg_B5_0 = false;
	}
	else {
		dateTime = XmlObjectSerializerWriteContext.GetDefaultValue<DateTime> ();
		arg_B5_0 = true;
	}

The fixed code should be like this now.
2015-04-24 14:36:53 +09:00
Atsushi Eno c5d45b2857 [S.R.Serialization] fix writer interpreter on enumerating non-dictionary.
Collection serialization was mostly failing, when it was non-dictionary.

Now it should be closer to referencesource dynamic code behavior.
2015-04-24 14:36:52 +09:00
Atsushi Eno d1152054a2 [S.R.Serialization] Fix TryWritePrimitive() parameter assignment.
It was inconsistent with what referencesource codegen does.
2015-04-24 14:36:52 +09:00
Atsushi Eno 9f0d571781 [S.R.Serialization] implement XmlFormatReaderGenerator interpreter.
Though it's still buggy and shows several nunit test failures yet.
2015-04-24 14:36:51 +09:00
Atsushi Eno 02915b9d61 [S.R.Serialization] implemented interpreter-based XmlFormatWriterGenerator. 2015-04-24 14:36:51 +09:00
Atsushi Eno 569890717a [S.R.Serialization] switch to (non-emit) reflection-based implementation stubs.
The new code is to implement reflection (non-emit) based serialization
so that it works on iOS.

Actually I _totally_ switched to this new implementation because dynamic
method based implementation also doesn't work fine, even on desktop
(due to invocation failure on internal methods, it seems that our dynamic
method needs some bugfixes).

The new methods with NotImplementedException in new classes need to be
implemented.
2015-04-24 14:36:51 +09:00