41 Commits
Author SHA1 Message Date
Alexander Köplinger 6caf00b09c [bcl] Remove AssertExtensions helper classes (#5828)
* [bcl] Remove AssertExtensions helper classes

Since we're on nunitlite now we can use the proper `Assert.Throws<>()`
instead and remove the helper class (which we actually duplicated!)
2017-10-19 12:38:33 +02:00
Alexander Köplinger b03e606287 Remove ChangeLog files from the repo
They weren't updated in the last 6 years and aren't helpful anymore (e.g. by causing unrelated matches during git grep searches).
2016-01-29 19:17:06 +01:00
Alexander Köplinger 0950f55eaf [System.Web] Add test for 9c25439320
Test case from https://bugzilla.xamarin.com/show_bug.cgi?id=13909
2016-01-08 20:54:54 +01:00
Alexander Köplinger 98cf04084a [bcl] Remove NET_4_0 defines from class libs
NET_4_0 is always defined now, so the ifdefs are redundant.
I verified the libs are exactly the same after this change, so this is effectively a no-op.
2015-07-26 15:01:49 +02:00
Daniel Lo Nigro 627e902c8d Fix routing of CatchAll tokens 2014-02-24 10:11:47 -08:00
Pablo Ruiz Garcia 6128710873 Fixed xamarin bug #13708: routing constraints should be trated as 'convertible to string' in order to be compat with MS.NET 2013-08-05 15:20:31 +02:00
Pablo Ruiz Garcia 6c70b38e17 Refactor of Route's GetVirtualPath implementation based on System.Web.Http.Routing code in order to fix a few incompatibilities between our implementation and the one at ms.net 2013-05-06 00:31:44 +02:00
Daniel Lo Nigro eb76e79bd9 Fix Xamarin bug #9133 - Routes should be case insensitive. 2012-12-26 13:24:26 +11:00
Daniel Lo Nigro b52f3f5468 Fix bug 9116 (https://bugzilla.xamarin.com/show_bug.cgi?id=9116)
Need to use .Equals() for comparison instead of the "!=" operator, as != will do a reference comparison in the case of boxed value types.
2012-12-23 16:20:40 +11:00
Pablo Ruiz Garcia 3ab03bc826 Fix style to adhere to mono's coding guidelines. 2012-11-29 17:00:21 +01:00
Pablo Ruiz Garcia 3ce598d0a1 Fixed routes with CatchAll argument, in order to make them succesfully
match requests with empty (or null) catch-all portion.

Included a couple of unit-tests which pass both here, and on ms.net land.

License: This patch is under MIT/X11 license.
2012-11-29 15:46:49 +01:00
Pablo Ruiz Garcia 4c066fa286 Fixes xamarin-bug #8646: Inconsistencies with MS.NET on Sys.Web.Routing logic.
This patch fixes some inconsistencies on Sys.Web.Routing between our implementation
and the one found on MS.NET.. Both relating to URL Generation code inside of
Route.GetVirtualPath().

1) When defining a route with a parameter with both a default value and some
constraint, Route.GetVirtualPath() fails to match if no parameter values is specified.

2) HttpMethodConstraint, does not take into account RouteDirection.UrlGeneration.

See: https://bugzilla.xamarin.com/show_bug.cgi?id=8646
License: This patch is under MIT/X11 license.
2012-11-29 01:33:55 +01:00
Marek Safar 2ba6a8925b Fixed few unit tests build issues 2011-03-08 14:10:16 +00:00
Marek Habersack 62b047ae5b [asp.net] Fix for bug #671753. Route.GetVirtualPath must take ambient values into account. 2011-02-25 13:06:51 +01:00
Marek Habersack d66b7f5543 [asp.net,routing] Fix for bug #651966. Regular expression constraints must be treated as absolute regexps. 2011-01-22 12:43:14 +01:00
Marek Habersack d3a5fe689a [asp.net] Make StopRoutingHandler actually stop the routing instead of throwing an exception
Patch from Damir Simunic <[email protected]>, thanks!
2011-01-14 21:30:11 +01:00
Marek Habersack 69461167e7 [asp.net,routing] Fix for bug #651593. Don't match all-literal routes for URLs with excessive segments. 2010-11-05 11:36:49 +01:00
Marek Habersack 967d70e50b [asp.net,routing] Fix for bug #648901. Matching engine must ignore trailing slash in the URLs. 2010-10-26 02:00:21 +02:00
Marek Habersack cb4836ed8f 2010-05-05 Marek Habersack <[email protected]>
* RouteValueDictionary.cs: do not process type fields in
	RouteValueDictionary (object)

	* RouteCollection.cs: GetRouteData throws an exception if Request
	is null in the passed context.
	Added Ignore* and MapPageRoute* 4.0 APIs

	* RequestContext.cs: 4.0 API update

	* PatternParser.cs: match parser rewrite to encompass 4.0 bug
	fixes. We don't emulate some of the pre-4.0 routing bugs anymore.

svn path=/trunk/mcs/; revision=156695
2010-05-05 00:43:57 +00:00
Marek Habersack aa7314ad76 2009-09-09 Marek Habersack <[email protected]>
* RouteTest.cs: added two tests for empty and null route URLs (bug
	#537751)

2009-09-09  Marek Habersack  <[email protected]>

	* Route.cs: when Url is set to null, create a parser for empty
	string. Fixes bug #537751

	* PatternParser.cs: Parse allows for null/empty URLs. Fixes bug
	#537751

svn path=/trunk/mcs/; revision=141630
2009-09-09 19:49:50 +00:00
Marek Habersack a8cfd91279 2009-08-19 Marek Habersack <[email protected]>
* Route.cs: GetRouteData adds contents of its DataTokens
	dictionary to the returned RouteData.DataTokens dictionary. Fixes
	bug #523330. Patch from [email protected], thanks!

svn path=/trunk/mcs/; revision=140273
2009-08-19 18:37:10 +00:00
Marek Habersack adba453b57 2009-06-25 Marek Habersack <[email protected]>
* RouteCollectionTest.cs, RouteTest.cs: added new tests for
	GetVirtualPath

2009-06-25  Marek Habersack  <[email protected]>

	* PatternParser.cs: parameter name lookups must be
	case-insensitive.
	Null and empty (string) parameters are skipped when building query
	part of the action path.

2009-06-25  Marek Habersack  <[email protected]>

	* LinqDataSource.cs: make ContextType not throw an exception when
	ContextTypeName is not set, but rather return a null in that
	case.

2009-06-25  Marek Habersack  <[email protected]>

	* MetaTableTest.cs: new GetVirtualPath tests.

	* DynamicDataRouteTest.cs: added tests for route.Defaults
	modifications on class init.

	* DynamicDataRouteHandlerTest.cs: added

2009-06-25  Marek Habersack  <[email protected]>

	* MetaTable.cs: Fixes to make tests succeed.

	* MetaModel.cs: added the GetDataFieldAttributes method for
	retrieving attributes associated with data type/field.
	Fixes to make tests succeed.

	* MetaColumn.cs: refactoring - use
	MetaModel.GetDataFieldAttributes instead of the local version.

	* DynamicDataRouteHandler.cs: implemented GetRequestContext,
	GetRequestMetaTable.

	* DynamicDataRoute.cs: when the Action and Table properties are
	set before one of GetVirtualPath or GetRouteData methods are
	called for the first time, a check is made whether the Defaults
	collection exists and whether it contains entries for Action and
	Table. Initialization code makes sure those entries are inserted
	into the dictionary in those cases.

svn path=/trunk/mcs/; revision=136875
2009-06-25 19:35:20 +00:00
Marek Habersack fed07c12c0 2009-06-04 Marek Habersack <[email protected]>
* RouteValueDictionaryExtensions.cs: if both values are strings in
	Has (string, value), compare them case-insensitively. Fixes bug
	#502555

2009-06-04  Marek Habersack  <[email protected]>

	* RouteCollectionTest.cs: added two more test cases to the bug
	#502555 test. They check whether url generation matches defaults
	case-insensitively.

svn path=/trunk/mcs/; revision=135438
2009-06-04 15:31:02 +00:00
Marek Habersack 9de8e1df99 2009-05-27 Marek Habersack <[email protected]>
* Makefile (LIB_MCS_FLAGS): added support for defining the DEBUG
	symbol on compiler command line.

2009-05-27  Marek Habersack  <[email protected]>

	* PatternParser.cs: if Match is passed an empty path, do not
	attempt to match the Url segments, skip to defaults matching right
	away.

2009-05-27  Marek Habersack  <[email protected]>

	* RouteCollectionTest.cs: added a test for routes from
	NerdDinner.

svn path=/trunk/mcs/; revision=134877
2009-05-27 20:53:58 +00:00
Marek Habersack e0f0a9dd5c 2009-05-25 Marek Habersack <[email protected]>
* UrlPattern.cs: removed - replaced by PatternParser below.

	* RouteValueDictionaryExtensions.cs: added - some shortcuts for
	using RouteValueDictionary in PatternParser

	* Route.cs: use the new PatternParser.
	Factored out ProcessConstraint into ProcessConstraintInternal so
	that the latter can be used by the PatternParser class.
	Added parameter checks in ProcessConstraint.

	* PatternTokenType.cs: added

	* PatternToken.cs: added a helper class for the pattern parser.

	* PatternParser.cs: added. New implementation of url
	parser/matcher/generator which fixes all URL isues known so
	far. Fixes bug #504378

2009-05-25  Marek Habersack  <[email protected]>

	* System.Web.Routing_test.dll.sources: added
	System.Web.Routing/AssertExtensions.cs

	* System.Web.Routing.dll.sources: added
	System.Web.Routing/PatternParser.cs
	System.Web.Routing/PatternToken.cs
	System.Web.Routing/PatternTokenType.cs
	System.Web.Routing/RouteValueDictionaryExtensions.cs

	removed
	System.Web.Routing/UrlPattern.cs

2009-05-25  Marek Habersack  <[email protected]>

	* RouteTest.cs: added several tests for GetVirtualPath,
	GetRouteData, ProcessConstraint and refactored some tests.

	* RouteCollectionTest.cs: added several tests for GetVirtualPath

	* AssertExtensions.cs: added some methods to make code testing for
	exception throws look nicer.

svn path=/trunk/mcs/; revision=134682
2009-05-25 12:38:37 +00:00
Gonzalo Paniagua Javier 3ca2cb0516 fix test
svn path=/trunk/mcs/; revision=134029
2009-05-13 00:43:10 +00:00
Marek Habersack d219fb0b28 2009-05-12 Marek Habersack <[email protected]>
* UrlPattern.cs: The
	value comparison is done case-insensitively when the dictionary
	values are strings. Fixes bug #502555

svn path=/trunk/mcs/; revision=133997
2009-05-12 21:51:01 +00:00
Marek Habersack 93e9f216e1 2009-05-11 Marek Habersack <[email protected]>
* UrlPattern.cs: TrySubstitute treats defaults differently
	now. They are not consulted when checking if the passed values
	match the pattern, but only when substituting the values. Fixes
	bug #502555

2009-05-11  Marek Habersack  <[email protected]>

	* RouteCollectionTest.cs: added test for bug #502555

svn path=/trunk/mcs/; revision=133904
2009-05-11 17:12:11 +00:00
Marek Habersack c9c7252804 2009-05-05 Marek Habersack <[email protected]>
* UrlPattern.cs: Match adds defaults values should some keys be
	missing from the url. Fixes bug #500739

	* Route.cs: a small GetRouteData loop optimization

2009-05-05  Marek Habersack  <[email protected]>

	* RouteTest.cs: added test for bug #500739

svn path=/trunk/mcs/; revision=133577
2009-05-05 13:17:30 +00:00
Marek Habersack e2d52d7929 2009-02-14 Marek Habersack <[email protected]>
* UrlPattern.cs: use the defaults collection when matching a path
	and segments are missing.

	* RouteCollection.cs: GetRouteData must use VirtualPathProvider
	to check for virtual path existence.

svn path=/trunk/mcs/; revision=126891
2009-02-13 23:21:33 +00:00
Atsushi Eno b0ebd6f5bb 2008-10-23 Atsushi Enomoto <[email protected]>
* UrlPattern.cs : fixed possible out-of-range case ("tableName/" in
	  DynamicData).

	* RouteTest.cs :
	  add one more case that used to cause out-of-range error.


svn path=/trunk/mcs/; revision=116843
2008-10-23 11:03:04 +00:00
Atsushi Eno ac7f00d699 2008-10-17 Atsushi Enomoto <[email protected]>
* RouteValueDictionary.cs : its string comparison is case
	  insensitive.

	* RouteValueDictionaryTest.cs : test for case-insensitive comparison.


svn path=/trunk/mcs/; revision=116277
2008-10-17 18:21:36 +00:00
Atsushi Eno fac89a5692 2008-10-17 Atsushi Enomoto <[email protected]>
* UrlPattern.cs : fixed pattern match for such string that has
	  suffix. (DynamicData uses it.)

	* RouteTest.cs : added test for DynamicData default pattern.


svn path=/trunk/mcs/; revision=116234
2008-10-17 14:59:28 +00:00
Atsushi Eno 95398f45bf 2008-10-16 Atsushi Enomoto <[email protected]>
* System.Web.Routing_test.dll.sources:
	  added RouteValueDictionaryTest.cs.

	* RouteValueDictionary.cs : object argument is actually for
	  anonymous type instance.

	* RouteValueDictionaryTest.cs : new test.


svn path=/trunk/mcs/; revision=116002
2008-10-16 14:20:23 +00:00
Atsushi Eno 8cb21562bb 2008-10-10 Atsushi Enomoto <[email protected]>
* UrlRoutingModule.cs : implement PostMapRequestHandler() and 
	  PostResolveRequestCache() to work correctly in order.
	  Now it should practically work.

	* UrlRoutingModuleTest.cs , TestStubTypes.cs : added test for
	  pipeline processing of requests.


svn path=/trunk/mcs/; revision=115424
2008-10-10 11:34:01 +00:00
Atsushi Eno acfe2986ae RouteCollection.RouteExistingFiles support.
svn path=/trunk/mcs/; revision=113452
2008-09-18 18:35:32 +00:00
Atsushi Eno 38321ee8e6 check invalid constraint and implement ProcessRequest().
svn path=/trunk/mcs/; revision=113386
2008-09-18 04:29:23 +00:00
Atsushi Eno 64a00cfead ongoing UrlRoutingModule implementation and tests.
svn path=/trunk/mcs/; revision=113265
2008-09-17 09:37:25 +00:00
Atsushi Eno 8acac8067d Route.GetRouteData() and HttpMethodConstraint.Match() with tests.
svn path=/trunk/mcs/; revision=112896
2008-09-12 18:02:55 +00:00
Atsushi Eno 1c1ab5802c Url parser implementation and some tests.
svn path=/trunk/mcs/; revision=112830
2008-09-12 09:37:37 +00:00
Atsushi Eno 17db992fad some implementations and tests.
svn path=/trunk/mcs/; revision=112761
2008-09-11 14:38:17 +00:00