45 Commits
Author SHA1 Message Date
Sebastian Mayr 9780d577e9 Fix NullReferenceException when reader fails
If the reader execution in the try block fails, reader will stay null, but we later try to access reader.RecordsAffected. This raises a null reference exception which hides the original exception, making this particularly hard to detect.
2015-11-20 01:53:02 +01:00
Zoltan Varga 0985d4aa4b [bcl] Remove NET_2_0 defines from the class libs. This has been done using: unifdef -t -DNET_2_0 -o <filename> <filename>. 2015-01-13 15:29:38 -05:00
Marek Habersack 55baf957fd 2010-07-19 Marek Habersack <[email protected]>
* SqlDataSourceView.cs: added the RaiseUnsupportedCapabilityError
	method (2.0+)

	* RoleGroupCollection.cs: added OnValidate (undocumented) overload

	* ParameterCollection.cs: added missing Add method overload (2.0+)

	* LiteralControlBuilder.cs: added the AppendLiteralString method
	override (2.0+)

svn path=/trunk/mcs/; revision=160569
2010-07-19 13:05:30 +00:00
Marek Habersack ef9c9e51ce Do not abuse the 'private' keyword
svn path=/trunk/mcs/; revision=116539
2008-10-20 17:37:54 +00:00
Konstantin Triger f3b0d789b8 make the behavior for SqlDataSourceView.FilterExpression comply with the behavior of ObjectDataSourceView.FilterExpression
svn path=/trunk/mcs/; revision=92450
2008-01-08 13:44:02 +00:00
Igor Zelmanovich 86644d0e33 2007-05-29 Igor Zelmanovich <[email protected]>
* ObjectDataSourceView.cs:
	* SiteMapDataSource.cs:
	* SqlDataSource.cs:
	* SqlDataSourceView.cs:
	DataSourceChanged and DataSourceViewChanged are raised in right case, when
	different properties changed their value.				


svn path=/trunk/mcs/; revision=78131
2007-05-29 14:59:47 +00:00
Igor Zelmanovich ce6459ba68 2007-05-27 Igor Zelmanovich <[email protected]>
* ObjectDataSourceView.cs: fixed SelectMethod and SelectCountMethod properties:
	when changed, DataSourceViewChanged event is raised.
	
	* SqlDataSourceView: fixed SelectCommand property:
	when changed, DataSourceViewChanged event is raised.


svn path=/trunk/mcs/; revision=78009
2007-05-27 13:23:17 +00:00
Igor Zelmanovich 107e1f2983 2007-05-02 Igor Zelmanovich <[email protected]>
* SqlDataSourceView.cs:
	make CancelSelectOnNullParameter property works.


svn path=/trunk/mcs/; revision=76559
2007-05-02 09:46:07 +00:00
Igor Zelmanovich 7320e371e3 2007-04-12 Igor Zelmanovich <[email protected]>
* SqlDataSourceView.cs: fixed: InitializeParameters:
	restored flow, broken in r75137.

svn path=/trunk/mcs/; revision=75729
2007-04-15 14:03:40 +00:00
Konstantin Triger c6a17bec7f use Invariant culture for string manipulations
svn path=/trunk/mcs/; revision=75426
2007-04-05 11:28:59 +00:00
Adar Wesley 535dc2897a 2007-03-29 Adar Wesley <[email protected]>
* ObjectDataSourceView.cs: fixed events so they are raized at the
        right times.  Added many tests to verify the correct time.
        * SqlDataSourceView.cs: fixed events so they are raized at the right
        times.  Added many tests to verify the correct time.


svn path=/trunk/mcs/; revision=75137
2007-03-29 13:37:36 +00:00
Igor Zelmanovich c92920880e 2007-03-22 Igor Zelmanovich <[email protected]>
* ObjectDataSource.cs:
	* ObjectDataSourceView.cs:
	* SqlDataSource.cs:
	* SqlDataSourceView.cs:
	fixed flow: changes in Insert/Update/DeleteParameters does not 
	cause DataSourceViewChanged event.				


svn path=/trunk/mcs/; revision=74807
2007-03-22 14:13:49 +00:00
Adar Wesley f4956944c3 2007-02-20 Adar Wesley <[email protected]>
* SqlDataSource.cs: fixed ViewState behavior to conform to MS.  Added relevant tests.
        * SqlDataSourceView.cs: fixed ViewState behavior to conform to MS. Added relevant tests.


svn path=/trunk/mcs/; revision=73193
2007-02-20 17:01:51 +00:00
Adar Wesley 4b78f66714 2007-02-20 Adar Wesley <[email protected]>
* SqlDataSourceView.cs: Fixed parameter merging logic and some bug fixing.
        Added more tests.


svn path=/trunk/mcs/; revision=73146
2007-02-20 08:29:30 +00:00
Konstantin Triger 4821cb5e64 typo: ParameterPrefix is prepended inside CreateDbParameter
svn path=/trunk/mcs/; revision=70971
2007-01-14 09:39:39 +00:00
Vladimir Krasnov 93259d3707 * SqlDataSourceView.cs: fixed OnUpdating, OnInserting call with SqlDataSourceCommandEventArgs
svn path=/trunk/mcs/; revision=70845
2007-01-11 09:57:25 +00:00
Vladimir Krasnov f3f5ba3cc0 * SqlDataSourceView.cs: fixed parameters init for ExecuteUpdate
svn path=/trunk/mcs/; revision=70709
2007-01-09 12:25:58 +00:00
Vladimir Krasnov 0d481e93eb * DetailsView.cs: fixed DeleteItem, excluded keys for new values
* SqlDataSourceView.cs: fixed ExecuteDelete, check cancel in OnDeleting event

svn path=/trunk/mcs/; revision=70696
2007-01-09 09:56:10 +00:00
Igor Zelmanovich 9bdf8e23cf 2007-01-08 Igor Zelmanovich <[email protected]>
* SqlDataSourceView.cs: fixed CreateDbParameter, used DBNull for value=null.


svn path=/trunk/mcs/; revision=70659
2007-01-08 16:14:23 +00:00
Vladimir Krasnov 130ad38566 * SqlDataSourceView.cs: fixed InitializeParameters, added ParameterPrefix when check that param is already in collection
svn path=/trunk/mcs/; revision=70647
2007-01-08 13:03:59 +00:00
Vladimir Krasnov 0a322eb54d * SqlDataSourceView.cs: fixed insert, delete, update methods, added calls to OnDataSourceViewChanged
svn path=/trunk/mcs/; revision=70593
2007-01-07 16:24:30 +00:00
Vladimir Krasnov 9a92397cff * SqlDataSourceView.cs,ObjectDataSourceView.cs: fixed parameter merge when values and old values are null
svn path=/trunk/mcs/; revision=70362
2007-01-02 13:57:57 +00:00
Vladimir Krasnov c3ff67b287 * Parameter.cs: fixed ConvertValue to coorect handle TypeCode.Empty
* ObjectDataSourceView.cs: fixed MergeParameterValues, call Parameter.ConvertValue, fixed ConvertParameter to hanlde TypeCode.Empty
* SqlDataSourceView.cs: fixed InitializeParameters, call Parameter.ConvertValue, fixed ParameterPrefix property, fixed CreateDbParameter, added usege of ParameterPrefix

svn path=/trunk/mcs/; revision=70115
2006-12-27 10:01:17 +00:00
Vladimir Krasnov f774dbfcdd * SqlDataSourceView.cs: fixed InitializeParameters, parameters order parameters case insensetive search
* ObjectDataSourceView.cs: fixed MergeParameterValues, parameters case insensetive search

svn path=/trunk/mcs/; revision=69864
2006-12-21 14:57:25 +00:00
Miguel de Icaza 8616a7e405 2006-11-28 Miguel de Icaza <[email protected]>
* Rationalize the user of MonoTODOs.  

		- Removed all the TODOs that were only overwritten methods
		and had no further information.

		- Methods that threw exceptions now have the message "Not
		implemnted".

		- Methods that return some constant are declared like
		that.

		- Removed a bunch of stale MonoTODOs that had not been
		removed. 


svn path=/trunk/mcs/; revision=68620
2006-11-28 22:15:23 +00:00
Vladimir Krasnov 72e3924240 * System.Web.dll.sources: added DataSourceCasheManager.cs
* System.Web20.vmwcsproj: added DataSourceCasheManager.cs
* ParameterCollection.cs: fixed SetDirtyObject method
* ObjectDataSource.cs, ObjectDataSourceView.cs: removed VievState utilization for control's properties, implemented caching
* SqlDataSource.cs, SqlDataSourceView.cs: implemented caching

svn path=/trunk/mcs/; revision=67593
2006-11-09 13:28:01 +00:00
Vladimir Krasnov 7990f125d4 * SqlDataSource.cs, SqlDataSourceView.cs: redesign and bug fixes
* added SqlDataSourceDerbyTest.cs
* run-mono-tests.bat: added Derby to tests class path

svn path=/trunk/mcs/; revision=66745
2006-10-17 13:20:40 +00:00
Andrew Skiba 33db549935 * SqlDataSourceView.cs: return DataView from ExecuteSelect when DataSourceMode is DataSet.
svn path=/trunk/mcs/; revision=65042
2006-09-07 08:58:02 +00:00
Chris Toshok 885cbe5bda 2006-02-22 Chris Toshok <[email protected]>
* ParameterCollection.cs: add an EditorAttribute to the class.

	* Parameter.cs: cleanup, fix the Value property, and implement the
	Size property.

	* SqlDataSourceView.cs: clean things up a bit, and add handling
	for parameters.


svn path=/trunk/mcs/; revision=57191
2006-02-23 02:47:50 +00:00
Chris Toshok 148d6798c3 2006-02-22 Chris Toshok <[email protected]>
* SqlDataSourceFilteringEventArgs.cs: formatting.

	* SqlDataSourceSelectingEventArgs.cs: remove ExecutingSelectCount,
	both the property and ctor arg.

	* AccessDataSourceView.cs (ExecuteSelect): use SelectingEventArgs,
	not CommandEventArgs.  Also, cast the return value of
	oleCommand.ExecuteReader.

	* AccessDataSource.cs (.ctor): fix the ctors and remove FIXME
	comments.
	(GetDbProviderFactory): implement naively, and leave a MonoTODO.
	(GetPhysicalDataFilePath): implement, again naively.  this is
	where the NRE is generated when we access ConnectionString in a
	testcase on .net.
	(ConnectionString): dynamically generate this based on our
	DataFile attribute.
	(DataFile): clear the ConnectionString in the setter so we'll
	regenerate it.
	(ProviderName): use base.ProviderName in the getter, not
	this.ProviderName, so we don't recurse infinitely.
	
	* SqlDataSourceView.cs: start reworking this class.

	* SqlDataSource.cs (GetDbProviderFactory): implement this,
	following the MS docs on the matter (if ProviderName is null/"",
	return SqlClientFactory.Instance.)
	(GetDbProviderFactoryInternal): add an internal method for use by
	SqlDataSourceView.
	(TrackViewState): don't invoke View.TrackViewState unless we have
	one.
	(Selecting): change event handler type to match MS.
	(Filtering): add missing event.
	(View): call CreateDataSourceView, don't just create an
	SqlDataSourceView.


svn path=/trunk/mcs/; revision=57169
2006-02-22 19:14:04 +00:00
Kornél Pál 83946b2158 Replaced assembly references with constants in Consts.cs.
svn path=/trunk/mcs/; revision=47823
2005-07-28 23:46:29 +00:00
Lluis Sanchez 3b4fdcc1c6 2005-05-26 Lluis Sanchez Gual <[email protected]>
* DataListItem.cs:
	* GridViewRow.cs:
	* DataGridItem.cs:
	* RepeaterItem.cs:
	* FormView.cs:
	* MenuItemTemplateContainer.cs:
	* DetailsView.cs: Track changes in the IDataItemContainer interface.
	
	* CommandField.cs: Added CausesValidation property. Set that
	property value to all buttons of the field.
	
	* SqlDataSourceView.cs:
	* CollectionDataSource.cs:
	* XmlDataSourceView.cs: Properly initialize the base class.
	
	* SiteMapDataSource.cs:
	* SiteMapHierarchicalDataSourceView.cs:
	* SiteMapNodeItem.cs:
	* SiteMapDataSourceView.cs:
	* SiteMapPath.cs: Mostly implemented.
	
	* HierarchicalDataBoundControl.cs: Always bind the control when the
	page is loaded for the first time.
	
	* TreeView.cs: Properly bind the control when loaded from a callback.


svn path=/trunk/mcs/; revision=45062
2005-05-26 16:17:00 +00:00
Lluis Sanchez 300c4162b7 2005-02-02 Lluis Sanchez Gual <[email protected]>
* Button.cs, MonthChangedEventArgs.cs, FontInfo.cs, Xml.cs, Style.cs,
	CookieParameter.cs, HyperLinkColumn.cs, Table.cs,
	RegularExpressionValidator.cs, WizardNavigationEventArgs.cs,
	ServerValidateEventArgs.cs, Menu.cs, DataControlField.cs,
	DataGridPagerStyle.cs, Label.cs, CheckBox.cs, ListItem.cs,
	RadioButton.cs, TableStyle.cs, ListControl.cs, Image.cs,
	BaseCompareValidator.cs, FontUnit.cs, DataListCommandEventArgs.cs,
	IButtonControl.cs, BaseDataList.cs, DataList.cs, BulletedList.cs,
	RangeValidator.cs, DataBoundControl.cs, ControlParameter.cs,
	RepeaterItemEventArgs.cs, SqlDataSource.cs, BaseValidator.cs,
	CustomValidator.cs, MenuItem.cs, SessionParameter.cs, TextBox.cs,
	QueryStringParameter.cs, Content.cs, ContentPlaceHolder.cs,
	CheckBoxList.cs, RepeaterCommandEventArgs.cs, RadioButtonList.cs,
	RequiredFieldValidator.cs, AdRotator.cs, DataListItemEventArgs.cs,
	DataGridSortCommandEventArgs.cs, Repeater.cs,
	MenuItemTemplateContainer.cs, HyperLink.cs, SqlDataSourceView.cs,
	XmlDataSource.cs, MultiView.cs, DataGridCommandEventArgs.cs,
	Panel.cs, CompositeControl.cs, DataGrid.cs, ButtonColumn.cs,
	CompareValidator.cs, HierarchicalDataBoundControl.cs,
	EditCommandColumn.cs, Calendar.cs, SiteMapDataSource.cs, 
	ListBox.cs, TableCell.cs, ObjectDataSourceSelectingEventArgs.cs,
	ObjectDataSourceMethodEventArgs.cs,DataGridPageChangedEventArgs.cs,
	WebControl.cs, BaseDataBoundControl.cs, FormParameter.cs,
	ValidationSummary.cs, View.cs, ImageButton.cs, TableRow.cs,
	LinkButton.cs, DataGridColumn.cs, Parameter.cs, TableItemStyle.cs,
	AdCreatedEventArgs.cs:
	
	General 2.0 API fixes: missing attributes, incorrect inheritance,
	missing sealed keywords, wrong signatures, etc.


svn path=/trunk/mcs/; revision=39994
2005-02-02 16:24:08 +00:00
Sanja Gupta c07af6cb8a ChangeLog: Updated.
BaseDataList.cs:
DataBountControl.cs:
Repeater.cs: Added SelectArguments property and updated.
SiteMapDataSourceView.cs:
SqlDataSourceView.cs:
XmlDataSourceView.cs: Removed extra method, which was there to keep 
                      things compiling.


svn path=/trunk/mcs/; revision=36515
2004-11-25 04:20:53 +00:00
Sanja Gupta 1bb213331a ChangeLog: Updated.
SqlDataSourceView.cs: Updated methods and added one property.

svn path=/trunk/mcs/; revision=36381
2004-11-22 10:06:07 +00:00
Sanja Gupta bc71e69a24 ChangeLog: Updated.
SqlDataSource.cs: Updated call to constructor of SqlDataSourceView.cs.
SqlDataSourceView.cs: Updated constructor.

svn path=/trunk/mcs/; revision=36304
2004-11-19 10:05:07 +00:00
Sanja Gupta 2f5248a22e ChangeLog: Updated.
SqlDataSourceView.cs: Corrected exception handling in ExecuteSelect method.

svn path=/trunk/mcs/; revision=36301
2004-11-19 08:38:26 +00:00
Sanja Gupta 45ec04ea92 ChangeLog: Updated.
SqlDataSourceView.cs: Updated ExecuteSelect method.

svn path=/trunk/mcs/; revision=36265
2004-11-18 12:42:22 +00:00
Lluis Sanchez 5e2f763a48 * SqlDataSourceView.cs: Removed implementation of Events (it is inherited
from DataSourceView.cs).

svn path=/trunk/mcs/; revision=36151
2004-11-15 22:20:49 +00:00
Raja R Harinath 79d58a83bb (Select): Add 'override' to make it compile.
svn path=/trunk/mcs/; revision=35954
2004-11-10 07:03:08 +00:00
Sanja Gupta 37c863887a ChangeLog: Updated.
SqlDataSource.cs: Corrected method calls.
SqlDataSourceView.cs: Partial implementation of few methods.

svn path=/trunk/mcs/; revision=35687
2004-11-05 10:49:16 +00:00
Sanja Gupta e9ada58532 ChangeLog: Updated.
SiteMapDataSourceView.cs:
SqlDataSourceView.cs:
XmlDataSourceView.cs: Cosmetic changes because of modifications in
        base class, DataSourceView. Changes are to keep things compiling.

svn path=/trunk/mcs/; revision=35167
2004-10-20 07:38:41 +00:00
Duncan Mak d1c09fcc67 Add licensing info
svn path=/trunk/mcs/; revision=30345
2004-06-24 20:59:43 +00:00
Martin Baulig dfedf08d98 2004-04-22 Martin Baulig <[email protected]>
Renamed the `NET_1_2' conditional to `NET_2_0' in all files.

svn path=/trunk/mcs/; revision=25877
2004-04-23 02:24:02 +00:00
Ben Maurer 069539d2b0 2003-11-22 Ben Maurer <[email protected]>
* SqlDataSource*: Implement almost everything. Data access is
	still missing.

svn path=/trunk/mcs/; revision=20349
2003-11-23 02:44:44 +00:00