* Style.cs: if CssClass is null, return String.Empty. Fixes bug
#473303
Added a range check to the BorderStyle property.
2009-02-06 Marek Habersack <[email protected]>
* StyleTest.cs: added tests for CssClass and BorderStyle.
Renamed the Style_CssClass method to Style_RegisteredCssClass.
svn path=/trunk/mcs/; revision=126051
* CodeBuilder.cs, RootBuilder.cs, CollectionBuilder.cs: updates
related to ControlBuilder cleanup.
* ControlBuilder.cs: code cleanup - no field should be visible
outside the class unless it's a constant or a read-only field.
2009-01-13 Marek Habersack <[email protected]>
* XmlBuilder.cs: updates related to ControlBuilder cleanup.
2009-01-13 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs, AspGenerator.cs, BaseCompiler.cs,
GlobalAsaxCompiler.cs, PageThemeCompiler.cs: updates related to
ControlBuilder cleanup.
svn path=/trunk/mcs/; revision=123229
* Style.cs: WriteStyleAttributes must not use the fontinfo field
directly, it has to be done via the Font property. Fixes bug
#449793
svn path=/trunk/mcs/; revision=120345
* ContentPlaceHolder.cs, Content.cs, FormViewPagerRow.cs,
ChangePassword.cs, DetailsViewPagerRow.cs: implements
INonBindingContainer interface.
* Wizard.cs: implement INonBindingContainer interface for several
private/internal classes.
2008-11-15 Marek Habersack <[email protected]>
* INonBindingContainer.cs: added
* Control.cs: BindingContainer now checks if a control implements
INonBindingContainer interface in addition to the
BINDING_CONTAINER mask check.
* UserControl.cs: implements INonBindingContainer
* ControlBuilder.cs: use the new INonBindingContainer interface to
determine the binding container type in the BindingContainerType
property. If TemplateBuilder's ContainerType implements that
interface, the NamingContainer is queried for the binding
container type. If ContainerType is null, we return our own
ControlType (if we're TemplateBuilder)
2008-11-15 Marek Habersack <[email protected]>
* System.Web.dll.sources: added System.Web.UI/INonBindingContainer.cs
svn path=/trunk/mcs/; revision=118917
* ImageMap.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in Render ().
* DropDownList.cs, ListBox.cs: validate the event in LoadPostData ().
* TextBox.cs: validate the event in LoadPostData ().
Register for event validation in AddAttributesToRender ().
* HiddenField.cs: validate the event in RaisePostDataChangedEvent.
Register for event validation in Render ().
* RadioButton.cs: validate the event in LoadPostData ().
Register for event validation in InternalAddAttributesToRender.
* CheckBox.cs, RadioButtonList.cs: validate the event in
RaisePostDataChangedEvent.
* Menu.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in GetClientEvent ().
* DetailsView.cs, GridView.cs: validate the event in
RaisePostBackEvent ().
Register for validation in GetCallbackScript () and in OnPreRender
* Button.cs, Table.cs, BulletedList.cs, Calendar.cs, LinkButton.cs,
ImageButton.cs, TreeView.cs: validate the event in RaisePostBackEvent ().
2008-10-17 Marek Habersack <[email protected]>
* Control.cs: added the ValidateEvent internal method, used by
classes descending from Control to automatically trigger event
validation.
* Page.cs: removed the CheckForValidationSupport method. It moved
to Control.cs
RaisePostBackEvent no longer validates the events, this
functionality has been moved to Control.ValidateEvent.
2008-10-17 Marek Habersack <[email protected]>
* HtmlInputHidden.cs: validate the event in LoadPostDataInternal.
* HtmlInputButton.cs: validate the event in
RaisePostBackEventInternal ().
Register for event validation in RenderAttributes ()
* HtmlTextArea.cs: validate the event in
RaisePostBackDataChangedEvent ().
* HtmlButton.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ()
* HtmlAnchor.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ().
* HtmlInputRadioButton.cs, HtmlSelect.cs: validate the event in
LoadPostData.
* HtmlInputText.cs, HtmlInputImage.cs, HtmlInputCheckBox.cs,
HtmlInputPassword.cs: validate the event in
RaisePostDataChangedEvent ().
2008-10-17 Marek Habersack <[email protected]>
* MenuAdapterTest.cs: work around event validation failure in the
test environment.
2008-10-17 Marek Habersack <[email protected]>
* PageTest.cs: use a custom version of HtmlInputHidden control to
work around the new event validation code which doesn't work in
this instance.
svn path=/trunk/mcs/; revision=116231
* Control.cs: SaveViewStateRecursive must return view state even
if EnableViewState is false. This is apparently what .NET does, as
some commercial ASP.NET controls take advantage of that via
reflection.
2008-10-14 Marek Habersack <[email protected]>
* CompositeDataBoundControl.cs: renamed the itemcount ViewState
item from "_ItemCount" to "_!ItemCount" for .NET
compatibility. This item is accessed and used by some commercial
ASP.NET controls.
* DataBoundControl.cs: OnPagePreLoad must force databinding also
when the request is not a postback.
svn path=/trunk/mcs/; revision=115766
* ControlParameter.cs: Evaluate calls DataBinder.Eval to do the
evaluation now. This makes it support complex expressions.
2008-10-08 Marek Habersack <[email protected]>
* DataBinder.cs: in Eval expression needs to be trimmed before
checking whether it's an empty string.
GetIndexedPropertyValue must explicitly look for the "Item"
property, the lack of the DefaultMember attribute on type must not
throw exceptions.
2008-10-08 Marek Habersack <[email protected]>
* ControlParameterTest.cs: added a test for ControlParameter
evaluating a complex property expression.
svn path=/trunk/mcs/; revision=115193
* XmlDataSource.cs: Make sure the result of the multiplication is a
long (not an integer casted into a long since it could overflow).
[Found using Gendarme's ReviewCastOnIntegerMultiplicationRule]
svn path=/trunk/mcs/; revision=114339
* System.Web.dll.sources: added System.Web.UI/IAutoFieldGenerator.cs
and System.Web.UI.WebControls/IPersistedSelector.cs.
* IPersistedSelector.cs : new in 3.5 SP1.
* IAutoFieldGenerator.cs : new in 3.5 SP1.
svn path=/trunk/mcs/; revision=112940
* DataBoundControl.cs: set RequiresDataBinding to true in
Initialize only if not in a postback, if not data bound and if the
view state is enabled. Fixes bug #398318
UpdateViewData removes the OnDataSourceViewChanged handler before
connecting to the datasource and restores it before returning to
the caller.
OnLoad gets the data source before initialization, to avoid
premature OnDataSourceViewChanged triggers. Fixes bug #398318
svn path=/trunk/mcs/; revision=111526
* TreeView.cs: when TreeView is displaying a site map and there is
no node selected by the user, select the node corresponding to the
current page, if any.
svn path=/trunk/mcs/; revision=109040
* DataGrid.cs: removed the private class TableID and moved its
code to ChildTable.cs (see below). 2.0 instantiates teh ChildTable
with the owner parameter now. Fixes bug #400377
* ChildTable.cs: refactoring - moved code from TableID previously
defined in DataGrid.cs to here and made the class available under
different names for both 1.x and 2.x profiles. Fixes bug #400377
svn path=/trunk/mcs/; revision=108638
* MailDefinition.cs: look for the mail body file in the correct
path. Patch from Jackson Harper <[email protected]>,
thanks! Fixes bug #408699
* PasswordRecovery.cs: do not ask password recovery question if
it's disabled. Patch from Jackson Harper <[email protected]>,
thanks! Fixes bug #408696
svn path=/trunk/mcs/; revision=108636
* GridView.cs: minor optimizations (removed a foreach loop,
replaced calls to Array.Length with a variable containing the
length).
svn path=/trunk/mcs/; revision=107043
* BaseDataBoundControl.cs, ChangePassword.cs, CustomValidator.cs,
DataControlFieldCollection.cs, DataControlField.cs,
PasswordRecovery.cs, PagerSettings.cs: do not use synthetized
event accessors (to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* AnonymousIdentificationModule.cs, FormsAuthenticationModule.cs,
DefaultAuthenticationModule.cs, MembershipProvider.cs,
WindowsAuthenticationModule.cs, PassportAuthenticationModule.cs,
RoleManagerModule.cs: do not use synthetized event accessors (to
avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* HttpApplication.cs, HttpCachePolicy.cs, SiteMapProvider.cs,
TraceContext.cs: do not use synthetized event accessors (to avoid
locks).
2008-05-30 Marek Habersack <[email protected]>
* SessionStateModule.cs: do not use synthetized event accessors
(to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* ProfileModule.cs: do not use synthetized event accessors (to
avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* SessionStateModule.cs: do not use synthetized event accessors
(to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* DataBindingCollection.cs, ExpressionBindingCollection.cs: do not
use synthetized event accessors (to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* ClientBuildManager.cs: do not use synthetized event accessors
(to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* CacheDependency.cs: do not use synthetized event accessors (to
avoid locks).
svn path=/trunk/mcs/; revision=104569
* HierarchicalDataBoundControl.cs: Modified GetData method to check if
DataSource implements IHierarchicalEnumerable and if so constructs and
returns a new instance of ReadOnlyDataSourceView. This provides functional
compatibility with the Microsoft.NET framework. Fixes bug
#395209. Patch contributed by James Fitzsimons
<[email protected]>, thanks!
2008-05-18 Marek Habersack <[email protected]>
* HierarchicalDataBoundControlTest.cs: Added
TestIHierarchicalEnumerableDataSource to test change made to
GetData method to make functionally compatibile with Microsoft.NET
framework. Patch contributed by James Fitzsimons
<[email protected]>, thanks!
2008-05-28 Marek Habersack <[email protected]>
* ReadOnlyDataSourceView.cs: added. Patch contributed by James
Fitzsimons <[email protected]>, thanks!
svn path=/trunk/mcs/; revision=104329
* Calendar.cs: do not create dateInfo in the constructor - culture
might be not set yet at this point. Fixes bug #323566
Added a private property, DateInfo, which creates the dateInfo
when requested.
2008-05-06 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: compatibility - added the
__stringResource static field to the generated class and a call to
SetStringResourcePointer to the FrameworkInitialize method.
* PageCompiler.cs: __fileDependencies should also be defined in
the 1.x profile.
Page properties assigned in the page directive should be set
inside BuildControlTree in the 2.0 profile.
svn path=/trunk/mcs/; revision=102573
* BulletedList.cs: Avoid calling ToString on a string.
* ButtonField.cs: Throw, not just create, the exceptions.
* HyperLinkField.cs: Throw, not just create, the exceptions.
* ImageField.cs: Throw, not just create, the exception. Avoid calling
ToString on a string.
* ListControl.cs: Avoid calling ToString on a string.
[All issues were found using Gendarme]
svn path=/trunk/mcs/; revision=102571
* SiteMapNode.cs: the implicitResourceKey parameter to one of the
constructors sets the value of the ResourceKey property.
GetImplicitResourceString uses the provider's ResourceKey as the
global resource object key and the node's ResourceKey to construct
the resource name. Fixes bug #323994
ResourceKey setter throws an InvalidOperationException now, when
the node is read-only.
2008-04-30 Marek Habersack <[email protected]>
* SiteMapDataSource.cs: when no starting node is found, return
null instead of Provider.RootNode. Fixes bug #323994
svn path=/trunk/mcs/; revision=102197
* SqlDataSource.cs: raise the DataSourceChangedEvent when setting
ConnectionString, ProviderName or DataSourceMode properties only
when the new value differs from the old one. Fixes bug #359392
svn path=/trunk/mcs/; revision=101679
* ObjectDataSourceView.cs: ExecuteSelect should return an empty
aray when no data has been retrieved from the specified source
type. Fixes bug #380106
svn path=/trunk/mcs/; revision=100819
* AssemblyResourceLoader.cs: dispose of streams the way it should
be done.
2008-04-15 Marek Habersack <[email protected]>
* MailDefinition.cs: dispose of streams the way it should
be done.
2008-04-15 Marek Habersack <[email protected]>
* HttpRequest.cs: dispose of streams the way it should
be done.
2008-04-15 Marek Habersack <[email protected]>
* CachingCompiler.cs: dispose of streams the way it should
be done.
svn path=/trunk/mcs/; revision=100690
* Control.cs: refactoring - IdSeparator property is internally
present also in 1.1.
2008-04-10 Marek Habersack <[email protected]>
* RadioButton.cs: adjust 'name' and 'value' attribute values to
match MS.NET. Fixes bug #378024
svn path=/trunk/mcs/; revision=100302
* CheckBoxList.cs: set the Selected property to the value in POST
data only if the item in question was enabled before postback
occurred. Fixes bug #377703
svn path=/trunk/mcs/; revision=100299
* ListControl.cs: make sure the owned items' Enabled property is
set to the same value what ListControl's. Fixes bug #377703
* ListItemCollection.cs: fixed SetDirty to store the index of the
last dirtied item properly. Fixes bug #377703
For the 2.0 profile, set the ListItem instances Enabled property
to the value of the owning ListControl (internal ItemsEnabled
property was added to make it possible). Fixes bug #377703
svn path=/trunk/mcs/; revision=100296
* NunitWebResources/adapters.browser,
NunitWebResources/TestCapability.browser: modified to work and
support tests of browser defs in
etc/mono/2.0/Browsers/Compat.browser.
++ class/System.Web/Test/System.Web/ChangeLog (working copy)
* AppBrowsersTest.cs: added tests to ensure browscap.ini
etc/mono/2.0/Browsers/Compat.browser are being used when there
are App_Browser/*.browser files.
++ class/System.Web/Test/System.Web.UI/ChangeLog (working copy)
* PageTest.cs: added tests to ensure that using a
ControlAdapter that is not of the type corresponding to the
control doesn't cause a cast error.
++ class/System.Web/Test/System.Web.UI.WebControls/ChangeLog (working copy)
* DataBoundControlTest.cs, HierarchicalDataBoundControlTest.cs,
WebControlTest.cs: added tests to ensure that using a
ControlAdapter that is not of the type corresponding to the
control doesn't cause a cast error.
++ class/System.Web/System.Web/ChangeLog (working copy)
* HttpApplicationFactory.cs (CapabilitiesProcessor): changed to
use etc/mono/2.0/Browser/*.browser files in addition to
~/App_Browsers/*.browser files.
++ class/System.Web/System.Web.UI/ChangeLog (working copy)
* Page.cs (PageAdapter): fixed cast error when a ControlAdapter that
wasn't a PageAdapter was used.
++ class/System.Web/System.Web.Configuration_2.0/ChangeLog (working copy)
* CapabilitiesBuild.cs (Process), ICapabilitiesProcess.cs (Process),
nBrowser/Build.cs (Process): Added initialCapabilities argument to
facilitate using browscap.ini capabilities.
* CapabilitiesResult.cs (ctor), nBrowserResult.cs (ctor): Change
items arg to IDictionary to facilitate using browscap.ini capabilities.
* nBrowser/Node.cs (Reset): Removed code which checked prohibited
non-alphanumerics in id attributes because .NET is not that strict.
* nBrowser/Node.cs (MergeFrom): Fixed NullReferenceExceptions that
occurred when the source or destination node did not have any
capabilities or adapters.
* nBrowser/Result.cs (AddAdapter): Fixed to allow types in other
assemblies.
++ class/System.Web/System.Web.UI.WebControls/ChangeLog (working copy)
* DataBoundControl.cs (InternalPerformDataBinding),
HierarchicalDataBoundControl.cs (InternalPerformDataBinding),
WebControl.cs (Render): fixed cast errors when a ControlAdapter
that wasn't of the type corresponding to the control was used.
++ class/System.Web/System.Web.Configuration/ChangeLog (working copy)
* HttpCapabilitiesBase.cs (GetConfigCapabilities): changed to use
browscap.ini for default capabilities when *.browser files are
present, so we don't need to maintain browser capabilities in two
places.
svn path=/trunk/mcs/; revision=100150