and use it to determine if viewstate needs to be saved instead of
the newly introduced ViewStateShouldBeSaved. Remove
ViewStateShouldBeSaved.
svn path=/trunk/mcs/; revision=126025
* Control.cs: if a control has been added to the controls
collection, removed and added again do not call OnInit (). At the
same time OnInit() should be called more than once if a control is
added to a container which, in turn, is then added to another
control. To achieve that a new state mask flag has been added -
REMOVED. Fixes bug #471305
svn path=/trunk/mcs/; revision=125798
* Control.cs: update of the fix for bug #470993 - view state of
the child controls isn't saved when any of their parents has it
disabled.
svn path=/trunk/mcs/; revision=125663
* HtmlTextWriter.cs: if OnTagRender returns false when called from
RenderBeginTag, push the tag to the stack regardless, and ignore
it in DoBeginTag and RenderEndTag. Fixes bug #463634
svn path=/trunk/mcs/; revision=124377
* CodeBuilder.cs, RootBuilder.cs, CollectionBuilder.cs: updates
related to ControlBuilder cleanup.
* ControlBuilder.cs: code cleanup - no field should be visible
outside the class unless it's a constant or a read-only field.
2009-01-13 Marek Habersack <[email protected]>
* XmlBuilder.cs: updates related to ControlBuilder cleanup.
2009-01-13 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs, AspGenerator.cs, BaseCompiler.cs,
GlobalAsaxCompiler.cs, PageThemeCompiler.cs: updates related to
ControlBuilder cleanup.
svn path=/trunk/mcs/; revision=123229
* LiteralStringControlBuilder.cs: added. Fixes bug #461214
* ControlBuilder.cs: added location tracking for literal string
children. Fixes bug #461214
* TemplateParser.cs: line pragmas are on by default. Fixes bug
#460479
2009-01-12 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: the LiteralStringControlBuilder
class is now used to track the location of the plain strings being
output to the generated code. Fixes bug #461214
* AspGenerator.cs: AppendLiteralString is called with the current
parser location as one of its parameters in FlushText (). Fixes
bug #461214
2009-01-12 Marek Habersack <[email protected]>
* System.Web.dll.sources: added
System.Web.UI/LiteralStringControlBuilder.cs
svn path=/trunk/mcs/; revision=123106
* ControlBuilder.cs: BindingContainerType returns typeof (Page)
only when the current object is a RootBuilder and it's been
created for a page parser. Otherwise it returns typeof
(Control). Fixes bug #45630
svn path=/trunk/mcs/; revision=121752
* TemplateParser.cs: in the 2.0 profile when a custom control is
registered, do not compile it right away but store the tag name in
a registry to be compiled at a later stage.
2008-12-11 Marek Habersack <[email protected]>
* BaseCompiler.cs: added a new method, InitializeType, to be
overriden in child classes when any class initialization needs to
be performed before methods, constructors and fields are created.
* TemplateControlCompiler.cs: if the parser has any custom
controls registered, compile them here - in the InitializeType
method.
svn path=/trunk/mcs/; revision=121262
* MasterPageParser.cs: do not compile anything while
parsing. MasterType virtual path is not compiled, but stored for
later. It is compiled when the MasterType property is requested
from within MasterPageCompiler.
* PageParser.cs: do not compile anything while
parsing. MasterPageFile, MasterType and PreviousPageType virtual
paths aren't compiled but checked for existence and stored for
later. Actual compilation happens when the MasterType and
PreviousPageType are requested from within PageCompiler.
* BaseParser.cs: added a new helper method, ThrowParseFileNotFound.
2008-12-10 Marek Habersack <[email protected]>
* ParseException.cs: made serializable.
* PageCompiler.cs: CreateStronglyTypedProperty calls
AddReferencedAssembly to add type's assembly to the unit's
references after the typed property has been created.
* BaseCompiler.cs: added a new helper method,
AddReferencedAssembly to be used whenever an assembly location
needs to be added to the compilation unit's list after the parsing
is done (e.g. when processing PreviousPageType or MasterPageType
properties in PageParser)
2008-12-10 Marek Habersack <[email protected]>
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWebResources/MissingMasterFile.aspx
* System.Web_test.dll.sources: added System.Web.UI/PageParserTest.cs
2008-12-10 Marek Habersack <[email protected]>
* NunitWebResources/MissingMasterFile.aspx: added
2008-12-10 Marek Habersack <[email protected]>
* PageParserTest.cs: added
svn path=/trunk/mcs/; revision=121181
* System.Web_test.dll.sources: added System.Web.UI/DataBinderTest.cs
2008-12-03 Marek Habersack <[email protected]>
* DataBinderTest.cs: added
2008-12-03 Marek Habersack <[email protected]>
* DataBinder.cs: clean up Eval for good this time.
GetIndexedPropertyValue should throw an exception when a string
indexer expression is used and the container is an IList.
svn path=/trunk/mcs/; revision=120590
* DataBinder.cs: when Eval attempts to find Items [] in the
container, catch and ignore all exceptions - the null returned
from GetPropertyValue may be a legitimate return value.
svn path=/trunk/mcs/; revision=120485
* StateManagedCollection.cs: adding an item to the collection does
not call SetDirty as an item is added, thus not affecting the
indexes of its predecessors. Fixes bug #443100
Insert doesn't call SetDirtyObject as all objects are made dirty
in SetDirty which is called from here. Same applies to this [int]
indexer.
svn path=/trunk/mcs/; revision=120436
* TemplateControlCompiler.cs: instead of adding ContentPlaceHolder
instances to the ContentPlaceHolders collection when the
placeholder is instantiated in the control build method, collect
the ids and store them in ContentPlaceHolders inside the
constructor. Fixes bug #449970
For each content placeholder generate a public virtual property
named "Template_PLACEHOLDERID", this is compatible with what .NET
does.
* BaseCompiler.cs: added new virtual method,
AddStatementsToConstructor, which is called just before
CreateConstructor returns.
2008-12-01 Marek Habersack <[email protected]>
* MasterPage.cs: use List <string> for ContentPlaceHolders instead
of ArrayList.
CreateMasterPage now directly accesses the ContentPlaceHolders as
it is now a list of strings
svn path=/trunk/mcs/; revision=120353
* DataBinder.cs: do the proper thing in Eval when a non-indexed
property is requested on an object and not found. In that case try
to use the Items property.
svn path=/trunk/mcs/; revision=120199
* System.Web.dll.sources: added
System.Web.Compilation/AspComponent.cs
2008-11-25 Marek Habersack <[email protected]>
* RootBuilder.cs: use new API in AspComponentFoundry to retrieve
registered control type.
* TemplateControlParser.cs: AddControlImports () removed. Its
functionality is now implemented in ControlBuilder.AddChild in a
more elegant, fine grained and correct way.
* TemplateParser.cs: replaced some "" with String.Empty
* ControlBuilder.cs: AddChild now adds an import for child's
namespace if the control being added has been registered in the
web.config file. Possible fix for #447896 and #447898
* PageParser.cs, MasterPageParser.cs: do not call
AddControlImports, it no longer exists.
2008-11-25 Marek Habersack <[email protected]>
* AspComponentFoundry.cs: GetComponentType methods replaced with
GetComponent returning an instance of AspComponent which fully
describes the registered item. Components are cached, indexed by
full tag name.
* AspComponent.cs: added
svn path=/trunk/mcs/; revision=119893
* TemplateControlCompiler.cs: make the Bind regex stricter.
When creating Eval expression from Bind, replace single quotes
with double quotes. Fixes bug #447597
When processing Bind expressions and the regex doesn't match,
throw an exception.
2008-11-21 Marek Habersack <[email protected]>
* ControlBuilder.cs: in BindingContainerType if builder is a
RootBuilder and no naming container is found, return typeof
(Page). In the TemplateBuilder case return cb.ControlType, not
this.ControlType.
svn path=/trunk/mcs/; revision=119661
* ControlBuilder.cs: make sure no control implementing the
INonBindingContainer can be returned from BindingContainerType.
svn path=/trunk/mcs/; revision=119233
* ContentPlaceHolder.cs, Content.cs, FormViewPagerRow.cs,
ChangePassword.cs, DetailsViewPagerRow.cs: implements
INonBindingContainer interface.
* Wizard.cs: implement INonBindingContainer interface for several
private/internal classes.
2008-11-15 Marek Habersack <[email protected]>
* INonBindingContainer.cs: added
* Control.cs: BindingContainer now checks if a control implements
INonBindingContainer interface in addition to the
BINDING_CONTAINER mask check.
* UserControl.cs: implements INonBindingContainer
* ControlBuilder.cs: use the new INonBindingContainer interface to
determine the binding container type in the BindingContainerType
property. If TemplateBuilder's ContainerType implements that
interface, the NamingContainer is queried for the binding
container type. If ContainerType is null, we return our own
ControlType (if we're TemplateBuilder)
2008-11-15 Marek Habersack <[email protected]>
* System.Web.dll.sources: added System.Web.UI/INonBindingContainer.cs
svn path=/trunk/mcs/; revision=118917
* TemplateControlCompiler.cs: treat Eval and Bind expressions as
verbatim code. The only difference between the two is that in the
latter case Bind is replaced with Eval in the output code. Fixes
bug #444725
2008-11-14 Marek Habersack <[email protected]>
* DataBinder.cs: if Eval doesn't find the indicated property, try
to find an indexer property on the object and use the expression
value as its parameter. Fixes#444725
svn path=/trunk/mcs/; revision=118799
* TemplateControl.cs: pass content hash to
UserControlParser.GetCompiledType when compiling a control in
ParseControl.
* UserControlParser.cs: when compiling a control using a text
reader, append a unique suffix to the "file path" - that way
controls compiled from different input streams won't conflict with
each other in the compilation cache.
svn path=/trunk/mcs/; revision=116979
* TemplateControlParser.cs: added internal method
AddControlImports which adds namespaces named in the
pages/controls section of web.config
* MasterPageParser.cs: unconditionally add namespaces named in the
pages/controls section of web.config.
* PageParser.cs: add namespaces named in the pages/controls
section of web.config to the page whenever it uses a master page.
svn path=/trunk/mcs/; revision=116858
* StateManagedCollection.cs: modified {Load,Save}ViewState to
properly store/recreate the collection of controls and to use a
more consistent structure for the state.
svn path=/trunk/mcs/; revision=116818
* ImageMap.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in Render ().
* DropDownList.cs, ListBox.cs: validate the event in LoadPostData ().
* TextBox.cs: validate the event in LoadPostData ().
Register for event validation in AddAttributesToRender ().
* HiddenField.cs: validate the event in RaisePostDataChangedEvent.
Register for event validation in Render ().
* RadioButton.cs: validate the event in LoadPostData ().
Register for event validation in InternalAddAttributesToRender.
* CheckBox.cs, RadioButtonList.cs: validate the event in
RaisePostDataChangedEvent.
* Menu.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in GetClientEvent ().
* DetailsView.cs, GridView.cs: validate the event in
RaisePostBackEvent ().
Register for validation in GetCallbackScript () and in OnPreRender
* Button.cs, Table.cs, BulletedList.cs, Calendar.cs, LinkButton.cs,
ImageButton.cs, TreeView.cs: validate the event in RaisePostBackEvent ().
2008-10-17 Marek Habersack <[email protected]>
* Control.cs: added the ValidateEvent internal method, used by
classes descending from Control to automatically trigger event
validation.
* Page.cs: removed the CheckForValidationSupport method. It moved
to Control.cs
RaisePostBackEvent no longer validates the events, this
functionality has been moved to Control.ValidateEvent.
2008-10-17 Marek Habersack <[email protected]>
* HtmlInputHidden.cs: validate the event in LoadPostDataInternal.
* HtmlInputButton.cs: validate the event in
RaisePostBackEventInternal ().
Register for event validation in RenderAttributes ()
* HtmlTextArea.cs: validate the event in
RaisePostBackDataChangedEvent ().
* HtmlButton.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ()
* HtmlAnchor.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ().
* HtmlInputRadioButton.cs, HtmlSelect.cs: validate the event in
LoadPostData.
* HtmlInputText.cs, HtmlInputImage.cs, HtmlInputCheckBox.cs,
HtmlInputPassword.cs: validate the event in
RaisePostDataChangedEvent ().
2008-10-17 Marek Habersack <[email protected]>
* MenuAdapterTest.cs: work around event validation failure in the
test environment.
2008-10-17 Marek Habersack <[email protected]>
* PageTest.cs: use a custom version of HtmlInputHidden control to
work around the new event validation code which doesn't work in
this instance.
svn path=/trunk/mcs/; revision=116231
* HttpResponse.cs: CacheabilityUpdatedEvent is no longer
used. cached_response is allocated only when the IsCached property
is assigned the 'true' value.
* HttpCachePolicy.cs: CacheabilityUpdatedEvent is no longer used,
removed all the traces of it. SetCacheability should not switch
output caching on.
2008-10-15 Marek Habersack <[email protected]>
* OutputCacheModule.cs: do not take any action if Response returns
null from GetCachedResponse.
2008-10-15 Marek Habersack <[email protected]>
* Page.cs: Response caching is switched on only when output
caching is configured for this page instance. Fixes bug #435549.
svn path=/trunk/mcs/; revision=115861
* Control.cs: SaveViewStateRecursive must return view state even
if EnableViewState is false. This is apparently what .NET does, as
some commercial ASP.NET controls take advantage of that via
reflection.
2008-10-14 Marek Habersack <[email protected]>
* CompositeDataBoundControl.cs: renamed the itemcount ViewState
item from "_ItemCount" to "_!ItemCount" for .NET
compatibility. This item is accessed and used by some commercial
ASP.NET controls.
* DataBoundControl.cs: OnPagePreLoad must force databinding also
when the request is not a postback.
svn path=/trunk/mcs/; revision=115766
* ControlParameter.cs: Evaluate calls DataBinder.Eval to do the
evaluation now. This makes it support complex expressions.
2008-10-08 Marek Habersack <[email protected]>
* DataBinder.cs: in Eval expression needs to be trimmed before
checking whether it's an empty string.
GetIndexedPropertyValue must explicitly look for the "Item"
property, the lack of the DefaultMember attribute on type must not
throw exceptions.
2008-10-08 Marek Habersack <[email protected]>
* ControlParameterTest.cs: added a test for ControlParameter
evaluating a complex property expression.
svn path=/trunk/mcs/; revision=115193
* TemplateParser.cs: make sure the generated class name is a valid
language independent identifier. Fixes bug #431622
2008-10-03 Marek Habersack <[email protected]>
* BuildManager.cs: if an assembly fails to build out of a batch of
files, extract the virtual path that was requested by the client
and attempt to compile it alone.
svn path=/trunk/mcs/; revision=114732
* Page.cs: Implemented the UniqueFilePathSuffix and MaxPageStateFieldLength
properties.
Some coding style changes.
svn path=/trunk/mcs/; revision=114432