15 Commits
Author SHA1 Message Date
Filip Navara c628f13279 System.Windows.Forms: Fix incorrect layout for table layout nested in flow layout
Fixes issue #8922. The flow layout code specifies `int.MaxValue` as width in `GetPreferredSize` call, which the table layout didn't handle properly and tried to use all the available space.

Relevant WinForms open source code that implements the same behavior:
https://github.com/dotnet/winforms/blob/master/src/System.Windows.Forms/src/System/Windows/Forms/Layout/FlowLayout.cs#L183-L188

https://github.com/dotnet/winforms/blob/master/src/System.Windows.Forms/src/System/Windows/Forms/Layout/TableLayout.cs#L700-L702
2018-12-21 11:58:52 +01:00
Filip Navara 1b5ebf2649 System.Windows.Forms: Fix regressions in layout code and TextBox Font handling (#10238)
* Fix layout of scrollbars in combobox.

* Fix TextBox height fixup to work properly inside TableLayout.

* Fix changing TextBox font before the Control handle has been created.

* Add test case.

* Reintroduce fix for TextBoxTest.Bug82749. We need to save the user requested control bounds outside of ExplicitBounds since ExplicitBounds are used by table layout engine.
2018-08-27 15:35:01 +02:00
Filip Navara 5d23a12446 [System.Windows.Forms] Unify layout engines for Controls and ToolStripItems (#7612)
* Update AnchorLayoutEvents to match Windows behavior, make Bug82762 test platform independent.

* Cache affected layout control and property across SuspendLayout/ResumeLayout.

* Extend AnchorLayoutEvents test.

* Update for little nuances in the layout code.

* Unify flow layout for ToolStrips and FlowLayoutPanel by using the IArrangedContainer and IArrangedElement abstractions.

* Implement basic table layout support for ToolStrips.

* Clean up handling of FlowLayoutSettings.

* Fixes for default values of LayoutSettings in tool strips.

* Remove more of the duct tape holding the ToolStrip layouts together and replace it with calls into the LayoutEngine. Fix other small bugs that prevented ToolStrip overflows from being displayed correctly. Tested with KeePass.

* Fix indentation.

* Address code style issues.

* Remove unnecessary override.

* Fix indentation.

* Bump API snapshot submodule
2018-03-16 12:42:43 +01:00
Filip NavaraandJiri Volejnik 376002afb4 Call LayoutEngine.InitLayout when appropriate and move the dist_right and dist_bottom calculation there.
Co-authored-by: Jiri Volejnik <[email protected]>
2018-03-05 19:10:08 +01:00
Filip Navara 016a5a8679 Fix propagating layout to parents and then back to children when PreferredSize changes. 2018-03-05 19:10:08 +01:00
Filip Navara 71931189fa Remove obsolete code for layout of AutoSize forms. 2018-03-05 19:10:07 +01:00
Filip Navara 622ad5480d Unify the code for layout of anchored controls to avoid setting the bounds twice for controls with AutoSize set to true. 2018-03-05 19:10:07 +01:00
Filip Navara 78ad684762 Fix the default layout engine and its quirks enough to pass all unit tests again. 2018-03-05 19:10:07 +01:00
Filip NavaraandJiri Volejnik cbb07605df Move GetPreferredSize implementations from container classes to respective LayoutEngine implementations.
Rework the layout engines to use AutoSizeInternal property since TextBoxBase has its own AutoSize that should not be respected by layout engines.
Rework automatic sizing behavior of TextBoxBase to return correct values.
Rework TableLayout completely to use same code for layout and calculation of preferred size.

Co-authored-by: Jiri Volejnik <[email protected]>
2018-03-05 19:10:07 +01:00
Jiri Volejnik 71989c037e Ignore invisible controls in FlowLayout. 2018-03-05 19:10:06 +01:00
Filip Navara ca957c45b4 Apply size constrains to control sizes when calculating flow layout. 2018-03-05 19:10:06 +01:00
Filip Navara 78f4b60e6c Reduce memory pressure by reusing the LayoutEngine objects. 2018-03-05 19:10:05 +01:00
Eberhard Beilharz 66b85dc9ad [SWF] Allow to compile without X11 installed (Xamarin-59496)
This change fixes a crash we get in resgen when building without
X11 installed. The bug got introduced when fixing Xamarin-395.

Change-Id: If81a4a3ca4db7a1b0156480ad49bd61610ecebf0
2017-09-15 10:33:22 +02:00
Alexander Köplinger b03e606287 Remove ChangeLog files from the repo
They weren't updated in the last 6 years and aren't helpful anymore (e.g. by causing unrelated matches during git grep searches).
2016-01-29 19:17:06 +01:00
Zoltan Varga ef380e3712 Rename Managed.Windows.Forms to System.Windows.Forms for consistency. 2015-03-03 15:59:16 -05:00