3644 Commits
Author SHA1 Message Date
Maxim Lipnin 9988ebc7f2 [System.Xml] Fix deserialization issue (#16965)
[This ](https://github.com/mono/mono/pull/11194/files#diff-ae54d9565e735005686191de0f19ed50R431-R435)change in `XmlTypeMapElementInfo.GetElement`  introduced the logic for handling the case of derived types deserialization. 
For some cases (like https://github.com/mono/mono/issues/16918) it breaks existing functionality because it returns wrong element for given element name after searching withing derived types collection.

![image](https://user-images.githubusercontent.com/3258267/65416085-bedc0500-ddff-11e9-941c-f24045c64121.png)

Unfortunately, what I can do here is just reverting the related changes.

Fixes https://github.com/mono/mono/issues/16918
2019-09-24 11:35:15 +02:00
Johan Lorensson dfb46dad7d Add Windows x64 Full AOT Interpreter support on CI. (#15127)
Add support to run full interpreter test suite on CI for Windows x64 Full AOT.
Since Windows x64 Full AOT uses a different full AOT profile WinAOT a separate
testing profile was setup for the interpreter testing. NOTE, this profile is
pure for testing, inline with the other testing profiles. It is also reusing
most of its sources from other sources files (mainly WinAOT) to reduce maintenance
of the profile.

Commit also includes some smaller adjustments needed in order to get full
pass rate for Windows x64 Full AOT + Interpreter on CI.
2019-06-20 09:23:39 +02:00
Alexander Köplinger 9606a8f180 [bcl] Remove usages of mono-project.com/go-mono.com/google.com in tests (#14586)
Use example.com and example.org instead.

Fixes https://github.com/mono/mono/issues/14585

Note that not all of the things I replaced make an actual network request but I thought it'd be nice to be consistent.
2019-05-23 14:12:14 +02:00
Martin Baulig 1eb9161ca6 Removing some remoting and multi-appdomain APIs on wasm and the AOT test profiles.
Build / profile changes:
------------------------

* `build/profiles/testing_aot_common.make`: define `DISABLE_REMOTING = yes` and
  `NO_MULTIPLE_APPDOMAINS = yes`.

* `mcs/class/corlib/Makefile`: check `DISABLE_REMOTING` when setting
  `REFERENCE_SOURCES_FLAGS` (and don't define `FEATURE_REMOTING`, `MONO_COM`
   and `FEATURE_COMINTEROP`).

* added new `testing_aot_common_corlib.dll.exclude.sources`.  Several types in
  the `System.Runtime.Remoting.Messaging` namespace are used by the runtime in
  non-remoting scenarios, so those need to be preserved.
  For all other remoting namespaces, we only need a few stripped down stub versions
  of the some of the types; those have been added to a new `legacy` directory, so
  we can wildcard-exclude all the files here.

* added new `testing_aot_common_corlib.dll.sources`; this currently only contains
  `legacy/*.cs` to list above mentioned stub versions.

* added new `testing_aot_common_corlib_test.dll.exclude.sources` as a common test
  excludes file.

API Changes (conditional to `DISABLE_REMOTING`):
------------------------------------------------

* `mcs/class/corlib/legacy/`: add stub-versions for some of the remoting-related
  classes that are used by the runtime (so we can't completely remove those types):

  - `System.MarshalByRefObject`.
  - `System.Runtime.Remoting.IRemotingTypeInfo`.
  - `System.Runtime.Remoting.ObjectHandle`.
  - `System.Runtime.Remoting.RemotingServices`.
  - `System.Runtime.Remoting.Activation.ActivationServices`.
  - `System.Runtime.Remoting.Contexts.Context`.
  - `System.Runtime.Remoting.Messaging.ILogicalThreadAffinative`.
  - `System.Runtime.Remoting.Messaging.LogicalCallContext`.
  - `System.Runtime.Remoting.Proxies.TransparentProxy`.
  - `System.Runtime.Remoting.Proxies.RealProxy`.

  some of these have fields that need to be preserved; these are marked with
  appropriate `#region` pragmas.

All changes below are conditional to `DISABLE_REMOTING`.

* `System.Runtime.Remoting.Messaging.AsyncResult`: this class is used by some of
  the async code, so we can't completely remove it.  However, we can remove the
  `MonoMethodMessage call_message` field when `DISABLE_REMOTING`.

* `System.Runtime.Remoting.Messaging.MonoMethodMessage`: this class is also used
  by some runtime code and thus needs to be preserved. However, when `DISABLE_REMOTING`
  is defined, then we make some changes to it:
  - remove all iterfaces (`IMethodCallMessage`, `IMethodReturnMessage`, and `IInternalMessage`).
  - `Properties` throws `PlatformNotSupportedException`.

* `System.Runtime.InteropServices.Marshal`: disable some COM-related code.

* `System.Threading.Thread`: remove `CurrentContext` property.

* `System.Threading.ExecutionContext`: adjust conditional logic; don't define
  `FEATURE_REMOTING` if `DISABLE_REMOTING`.

* `System.Activator`: add `DISABLE_REMOTING` to the existing
   `#if FEATURE_REMOTING || MOBILE_LEGACY` conditional in this class.

* `System.AppDomain`: since we only have one domain, `DefaultDomain` will always
   return the root domain; comment out the call to `RemotingServices.GetDomainProxy`
   as well as some internal methods.

* `System.__ComObject`: stub out on `DISABLE_REMOTING` as well as `!FULL_AOT_RUNTIME`.

* `System.Runtime.Serialization.Formatters.Binary.BinaryFormatter`: adjust `IFormatter`
  versus `IRemotingFormatter` interface logic to use the former when `DISABLE_REMOTING`.

* `System.Runtime.Serialization.Formatters.Binary.BinaryObjectReader`: adjust existing
  `#if FEATURE_REMOTING || MOBILE_LEGACY` conditional to add `DISABLE_REMOTING` to it.

* `System.Diagnostics.CorrelationManager`: comment out some `CallContext.LogicalGetData()`
  and `CallContext.LogicalSetData`.

* `System.Diagnostics.TraceEventCache`: likewise.

Test changes:
-------------

* `mono/tests/Makefile.am`: conditionally disable some remoting tests.

* `corlib/Test/System.Runtime.Serialization/SerializationTest.cs`: conditionally
   disable all tests requiring remoting.

* `corlib/Test/System/ActivatorTest.cs`: same; trying to preserve as much as possible
  in this test.

* added some `DISABLE_REMOTING` and `DISABLE_SECURITY` conditionals to some of the tests.
2019-05-21 12:33:55 +02:00
Martin Baulig 0e5e464cff Add a few DISABLE_SECURITY conditionals. (#14300)
* Add a few `DISABLE_SECURITY` conditionals.

* [csproj] Update project files

* Fix tests.
2019-05-10 10:17:00 +02:00
monojenkins 0da2ba771b [csproj] Update project files 2019-04-30 12:14:57 +02:00
Martin Baulig 06487590ff Define DISABLE_SECURITY and DISABLE_REMOTING on wasm and testing_aot. 2019-04-29 15:47:04 +02:00
monojenkins 3d7a63ba17 [csproj] Update project files 2019-04-25 09:17:13 +02:00
Alexander Köplinger 77cf4cc4f8 [tests] Remove MONOMAC ifdef from BCL tests (#13694)
It was set by xamarin-macios when they were still taking the raw .cs source files
but since we switched to prebuilt binaries we need to replace it with
some define we're actually setting in Mono.

Most cases can be replaced by just XAMMAC_4_5 since MOBILE is defined on the xammac profile.
2019-03-27 20:21:48 +01:00
Alexander Köplinger 1bc213fac1 [System.Xml] Don't hardcode nunit-lite-console in GeneratedCodeAttribute
Instead determine it at runtime.
2019-03-27 11:39:22 +01:00
Alexander Köplinger 92b435d6fe Move drawing types for XI/XM/wasm/orbis/unreal to System.Drawing.Common (#13414)
* Move drawing types for XI/XM/wasm/orbis/unreal to System.Drawing.Common

For XI/XM they were in Xamarin.iOS.dll/OpenTK-1.0.dll before.

For wasm/orbis/unreal we remove System.Drawing.dll from the profiles and
add the types to System.Drawing.Common.dll instead to align with the other
mobile profiles (only "net_4_x" and "build" still have System.Drawing.dll).

* Bump API snapshot submodule

* [csproj] Update project files
2019-03-12 18:07:19 +01:00
Egor Bogatov e42bf95d14 NS2.1 Sync new changes, mobile profiles (#13198)
* Add RuntimeHelpers.GetSubArray. Add missing types to NS's TypeForwarders.cs

* more NS2.1 changes

* ios changes

* Update Decimal (it's now readonly struct)

* fix mcs

* add ROMC.cs

* Fix tests, finish monodroid profile

* Make SRE-not-supported NS2.1 compatible

* Make monotouch_tv and watch NS2.1 compatible

* make some SRE types more NS21 compatible (non-abstract now)

* bump corefx

* More NS21 fixes

* bump coreclr acceptance tests

* Bump API snapshot submodule

* [csproj] Update project files
2019-03-06 08:55:16 +01:00
Alexander Köplinger b31a445e85 [gitattributes] Do CRLF normalization on sln/proj files
They can be used with native line endings.

We now have a shared folder with the dotnet repos and they have CRLF normalization enabled.
This difference leads to conflicts while applying changes from the dotnet repos to mono.
2019-03-06 08:34:01 +01:00
Ludovic Henry a43f1d2909 [sdks] Add mac-{mac32,mac64} targets (#12959)
* [sdks] Add mac-{mac32,mac64} targets

* [sdks] Add configure-* and build-* for CI
2019-02-12 18:57:56 -05:00
monojenkins caf22d5f0b [csproj] Update project files 2019-01-02 13:54:08 +01:00
Vlad Brezae 53672c5f4c [interp] Enable System.Xml tests (#11791)
* [tests] Change timezone so it doesn't fail on UTC+2 systems

Change to remote UTC-1

* [interp] Enable System.XML tests
2018-11-28 07:19:08 -08:00
Vlad Brezae 9cf13ee9e5 [interp] Enable System.Data tests on fullaotinterp (#11798)
* [interp] Enable System.Data tests on fullaotinterp

* [csproj] Update project files
2018-11-28 15:50:01 +02:00
Alexander Köplinger 041c2d0d66 [bcl] Remove unused DISABLE_CAS_USE and AGCLR define (#11695)
* [bcl] Disable unused DISABLE_CAS_USE and AGCLR define

* [csproj] Update project files
2018-11-15 17:26:33 +01:00
majellin24 92711632bf Modification to allow deserialization of derrived types (#11194)
* Modification to allow deserialization of derrived types

* white space correction

* second attempt

* third attempt

* fourth

* whitespace

* maybe fix null ref exception

* missed same condition in other method

* fixing condition

* hopefully correcting the test failure in AOT

* Modification to allow deserialization of derrived types

white space correction

second attempt

third attempt

fourth

whitespace

maybe fix null ref exception

missed same condition in other method

fixing condition

hopefully correcting the test failure in AOT

formatting

missed some formatting

* adding a test for PR #11194

* fixing a few exceptions

* adding ref
2018-10-31 10:43:46 +01:00
Vlad Brezae 5204ef1f5c [tests] Add new build profile for testing mixed mode (#11307)
We aot only the bcl (--aot=full,interp) while the tests code is interpreted.

<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2018-10-30 15:48:46 -04:00
Egor Bogatov 4693c9775c [corlib] DateTime, TimeSpan and TimeZone from CoreFX (#11232)
* DateTime from corefx

* TimeZone and TimeSpan from corefx

* bump corefx

* remove some reflection tests temporarily (due to corefx bump)

* ignore "Obsolete" warrning-error in System.XML (because of TimeZone)

* undo submodules

* remove TimeZone.cs

* Add tests

* clean up

* fix failing TZ tests

* Add HebrewCalendar as optional to "he" culture

* ignore failing tests

* Bump API snapshot submodule

* [csproj] Update project files
2018-10-23 17:25:30 +02:00
Ludovic Henry a282040c96 [bcl] Build all XUnit and NUnit tests for monodroid, monotouch, monotouch_tv, monotouch_watch and wasm BCL profiles (#11201) 2018-10-17 14:44:45 -04:00
Ludovic Henry 2a4cfddd9a [sdks] Build tests for BCL targets (#11141)
* [sdks] Build BCL profiles without configure flags

* [sdks] Add BclTemplate to build BCL profiles

This is to avoid building all the profiles in a single `sdks/out/bcl` directory which will be shared between android, ios and wasm.

* [sdks] Simplify call to BclTemplate

* [mcs] Make directory dependency as order-only

We would otherwise always rebuild the target since the directory is updated whenever something is added to the directory. This is a common Makefile technique.

* [sdks] Build tests for BCL targets
2018-10-16 14:00:12 -04:00
Alexander Köplinger 3d910b7477 [System.XML] Switch tests to use embedded test resources 2018-09-27 22:47:14 +02:00
Katelyn Gadd 84af5b235e Move the PreBuild dependency property later in the file so targets can't override it (#10429)
* Move the PreBuild dependency property later in the file so targets can't override it

* [csproj] Update project files
2018-09-02 17:54:01 +02:00
Katelyn Gadd a6a8abde09 Kill sln dependencies (#10406)
* Remove use of sln dependencies and use csproj project references instead

* Rewrite jay.vcxproj so it builds correctly even without help from the sln file

* Force pre-build event to run after references are resolved. Change how culevel.exe path is computed to be more resilient.

* [csproj] Update project files
2018-08-31 17:44:27 +02:00
Katelyn Gadd 14d20074ff Move to generating msbuild choose elements to get if-else selection behavior for sources in projects so that we don't get erroneous duplicate files in cases where there are both profile and host platform criteria (#9952)
A recent commit revealed that in cases where we select based on a mix of host platform and profile, genproj csproj files can end up with duplicate sources because the existing <ItemGroup Condition= approach could make multiple groups match for a given compile when we really just want one.

This PR changes to generating a cascade of msbuild <Choose> elements, which give if-else selection to ensure that we only ever build a single set of files.
2018-08-09 02:52:37 +02:00
Katelyn Gadd feaf8ee391 Use msbuild project reference to establish dependency on genconsts instead of solution dependencies (#9670)
Using solution dependencies in ```bcl.sln``` seems flaky and seems like it might not establish the full ordering we need to ensure that ```Consts.cs``` exists before we build things that require it. Let's try using project references (where ```corlib.dll``` 'depends' on ```genconsts.exe```) instead. This should also insert the dependency for any project that includes Consts.cs instead of just corlib.

This PR also makes update-solution-files actually fail if ```genconsts.exe``` fails to build because it was driving me mad.

Part of #6886
2018-08-02 00:30:54 +02:00
Alexander Köplinger 124febb1c1 [bcl] Include all .sources files in the tarball (#9803)
https://github.com/mono/mono/commit/0f0e31842f1f394c4e95d3726c20af547e706278 added a new pipes_pns.sources file
but we forgot to add it to EXTRA_DISTFILES so it gets included in the tarball.

Given that this happens almost all the time when we add a new .sources file
we should just always include all *.sources
2018-07-30 11:14:00 +02:00
Jo Shields 64f58747c1 [System.XML] Include common.sources in the tarball 2018-07-20 10:30:23 -04:00
Egor Bogatov 95ea74ebdb [System.XML] xunit tests and trivial types from CoreFX (#9351)
Adds 1192 xunit tests for System.XML from CoreFX
Also, moves common lines from `mobile_System.Xml.sources` and `System.Xml.sources` to `common.sources`

Part of #8132
2018-07-20 02:10:02 +02:00
Marek Safar 262c5f40cb [corlib] Default to fast Span<T> (#9204)
Part of #7249
2018-07-12 10:15:07 +02:00
Katelyn Gadd e271c293ee Rework genproj to use gensources to build sources list for each profile and host platform (#8985)
* Update genproj makefile to include gensources
Update genproj argument parser to be more generous about displaying help

* Checkpoint

* Checkpoint

* Checkpoint

* Checkpoint

* Checkpoint

* Checkpoint

* Checkpoint

* Checkpoint

* Fix rebase issue

* Checkpoint

* Checkpoint

* Fix built sources only being added to one profile

* Fix typo

* Checkpoint

* Fix indentation

* Use csc instead of mcs

* Checkpoint

* Fix BUILT_SOURCES only being handled for the first profile processed

* Checkpoint

* Checkpoint

* Strip double slashes from paths to fix spurious csproj change

* Checkpoint

* Checkpoint

* Checkpoint

* Checkpoint: Fix genproj compilation

* Checkpoint

* Checkpoint

* Checkpoint

* Fix crash when no targets were loaded (due to an error)

* Checkpoint

* Checkpoint

* Checkpoint

* Fix TryParseTargetInto bug

* Checkpoint

* Shuffle exclude logic around so that it works correctly during genproj diffing

* Remove gensources tracing

* Checkpoint

* Fix handling of oddball sources paths from executable.make

* Fix jay not being set to build

* Fix wrong slashes being used for embedded resource paths

* [csproj] Update project files
2018-06-29 08:01:31 +02:00
Egor Bogatov 51935465ae Delete unused files in BCL (#9288)
The following files in `mcs/class/*.cs` are not used anywhere (*.csproj/*.source).
2018-06-25 11:15:20 +02:00
Ludovic Henry 927ae95702 [build] Rename darwin platform to macos + Add unix host platform (#9022)
* [mcs] Rename darwin paltform to macos

Darwin is common to both macOS and iOS/tvOS/watchOS, while we use the darwin platform only for macOS.

* [mcs] Add Unix platform for other Unixes than Linux

* [mcs] Remove PLATFORMS from xammac_net_4_5 since it only make sense on macos

* [bcl] Bump corlib version

* [csproj] Update project files
2018-06-13 20:39:56 -04:00
monojenkins ab4d81e794 [csproj] Update project files 2018-05-31 23:34:33 +02:00
Katelyn Gadd 7eff6686fd Default platform to net_4_x if none is specified, to fix tools that build without setting a platform (#8223)
* Default platform to net_4_x if none is specified, to fix tools that build without setting a platform

* [csproj] Update project files
2018-04-16 09:54:53 -04:00
monojenkins 2f66873ab2 [msvc] Update csproj files (#7811)
* [msvc] Update csproj files

* [msvc] Delete old net_4_x.csproj and xbuild_12.csproj files
2018-03-28 19:29:28 +02:00
Marek Safar 4e3389667f [System.Xml] Update source file location from commit d4816ef1ab 2018-03-13 08:49:00 +01:00
monojenkins 3e8f4f7db8 [msvc] Update csproj files (#7497) 2018-03-08 17:14:32 +01:00
monojenkins 12cbe9a7bd [msvc] Update csproj files (#7238) 2018-02-23 17:00:46 +01:00
monojenkins 72e5ca60b8 [msvc] Update csproj files 2018-02-22 19:03:29 +01:00
Marek Safar d4816ef1ab [System.Xml] Remove reflection calls for value has to be set 2018-02-22 08:39:29 +01:00
monojenkins d2998f5089 [msvc] Update csproj files 2018-02-09 11:24:46 -05:00
Marek Safar 71ad99f720 [build] Narrow recursive dependencies 2018-02-08 23:49:44 -05:00
monojenkins e51565c7e5 [msvc] Update csproj files (#6100) 2017-11-25 23:34:52 +01:00
Alexander Köplinger 5ef930b5f8 [bcl] Build some assemblies with -warnaserror (#5295)
* [bcl] Build some assemblies with -warnaserror

This ensures that we keep the build warning free.

We'll only opt-in a few assemblies that already have zero warnings.
We also only apply this when using csc as mcs might raise different warnings.

For now just opt-in assemblies in the net_4_x profile.
2017-11-24 14:05:39 +01:00
Egor Bogatov b44333823d XmlReaderSettings.EnableLegacyXmlSettings should always be false on mono. Fixes bug-60621 (#6014) 2017-11-19 13:43:06 +01:00
Alexander Kyte ca8b8bd346 [runtime] Add Dedup Support to MkBundle (#5484)
* [runtime] Fix mkbundle compilation on OSX

* [runtime] Add aot arguments to mkbundle

* [runtime] Enable compiling aot with mkbundle

* [runtime] Add new dedup interface to mkbundle

* [runtime] Fix path resolving for mkbundle

* [runtime] Use mkbundle in BCL tests

* [runtime] Skip building System.Security, System.IdentityModel tests on testing_aot_full

* [runtime] Fix in-tree building for mkbundle

* [runtime] Move testing dll into profile

* [runtime] Add target to mkbundle all tests before CI

* [runtime] Build stripper and use with mkbundle

Preliminary linker support ran into dependency-finding bug
with the monolinker.exe binary. Fix postponed until later.

* [runtime] Skip not supported tests with mkbundle

* [runtime] Don't re-aot when running BCL tests

* [runtime] Provide config to mkbundle

* [runtime] Fix mkbundle internationalization test results, build all

* [runtime] Clean up temp mkbundle aot directory

* [runtime] Add mkbundle support for dedup

* [runtime] Fix tracking of dedup module in mkbundle

* [runtime] Document mkbundle AOT options in man pages

* [runtime] Fix CADMessage generic method argument marshalling
2017-11-15 09:56:26 -05:00
Marek Safar c5fa794e98 [bcl] Updates referencesource to 4.7.1 2017-11-06 11:31:56 -08:00