1089 Commits
Author SHA1 Message Date
Maxim Lipnin 9988ebc7f2 [System.Xml] Fix deserialization issue (#16965)
[This ](https://github.com/mono/mono/pull/11194/files#diff-ae54d9565e735005686191de0f19ed50R431-R435)change in `XmlTypeMapElementInfo.GetElement`  introduced the logic for handling the case of derived types deserialization. 
For some cases (like https://github.com/mono/mono/issues/16918) it breaks existing functionality because it returns wrong element for given element name after searching withing derived types collection.

![image](https://user-images.githubusercontent.com/3258267/65416085-bedc0500-ddff-11e9-941c-f24045c64121.png)

Unfortunately, what I can do here is just reverting the related changes.

Fixes https://github.com/mono/mono/issues/16918
2019-09-24 11:35:15 +02:00
Alexander Köplinger 9606a8f180 [bcl] Remove usages of mono-project.com/go-mono.com/google.com in tests (#14586)
Use example.com and example.org instead.

Fixes https://github.com/mono/mono/issues/14585

Note that not all of the things I replaced make an actual network request but I thought it'd be nice to be consistent.
2019-05-23 14:12:14 +02:00
Martin Baulig 1eb9161ca6 Removing some remoting and multi-appdomain APIs on wasm and the AOT test profiles.
Build / profile changes:
------------------------

* `build/profiles/testing_aot_common.make`: define `DISABLE_REMOTING = yes` and
  `NO_MULTIPLE_APPDOMAINS = yes`.

* `mcs/class/corlib/Makefile`: check `DISABLE_REMOTING` when setting
  `REFERENCE_SOURCES_FLAGS` (and don't define `FEATURE_REMOTING`, `MONO_COM`
   and `FEATURE_COMINTEROP`).

* added new `testing_aot_common_corlib.dll.exclude.sources`.  Several types in
  the `System.Runtime.Remoting.Messaging` namespace are used by the runtime in
  non-remoting scenarios, so those need to be preserved.
  For all other remoting namespaces, we only need a few stripped down stub versions
  of the some of the types; those have been added to a new `legacy` directory, so
  we can wildcard-exclude all the files here.

* added new `testing_aot_common_corlib.dll.sources`; this currently only contains
  `legacy/*.cs` to list above mentioned stub versions.

* added new `testing_aot_common_corlib_test.dll.exclude.sources` as a common test
  excludes file.

API Changes (conditional to `DISABLE_REMOTING`):
------------------------------------------------

* `mcs/class/corlib/legacy/`: add stub-versions for some of the remoting-related
  classes that are used by the runtime (so we can't completely remove those types):

  - `System.MarshalByRefObject`.
  - `System.Runtime.Remoting.IRemotingTypeInfo`.
  - `System.Runtime.Remoting.ObjectHandle`.
  - `System.Runtime.Remoting.RemotingServices`.
  - `System.Runtime.Remoting.Activation.ActivationServices`.
  - `System.Runtime.Remoting.Contexts.Context`.
  - `System.Runtime.Remoting.Messaging.ILogicalThreadAffinative`.
  - `System.Runtime.Remoting.Messaging.LogicalCallContext`.
  - `System.Runtime.Remoting.Proxies.TransparentProxy`.
  - `System.Runtime.Remoting.Proxies.RealProxy`.

  some of these have fields that need to be preserved; these are marked with
  appropriate `#region` pragmas.

All changes below are conditional to `DISABLE_REMOTING`.

* `System.Runtime.Remoting.Messaging.AsyncResult`: this class is used by some of
  the async code, so we can't completely remove it.  However, we can remove the
  `MonoMethodMessage call_message` field when `DISABLE_REMOTING`.

* `System.Runtime.Remoting.Messaging.MonoMethodMessage`: this class is also used
  by some runtime code and thus needs to be preserved. However, when `DISABLE_REMOTING`
  is defined, then we make some changes to it:
  - remove all iterfaces (`IMethodCallMessage`, `IMethodReturnMessage`, and `IInternalMessage`).
  - `Properties` throws `PlatformNotSupportedException`.

* `System.Runtime.InteropServices.Marshal`: disable some COM-related code.

* `System.Threading.Thread`: remove `CurrentContext` property.

* `System.Threading.ExecutionContext`: adjust conditional logic; don't define
  `FEATURE_REMOTING` if `DISABLE_REMOTING`.

* `System.Activator`: add `DISABLE_REMOTING` to the existing
   `#if FEATURE_REMOTING || MOBILE_LEGACY` conditional in this class.

* `System.AppDomain`: since we only have one domain, `DefaultDomain` will always
   return the root domain; comment out the call to `RemotingServices.GetDomainProxy`
   as well as some internal methods.

* `System.__ComObject`: stub out on `DISABLE_REMOTING` as well as `!FULL_AOT_RUNTIME`.

* `System.Runtime.Serialization.Formatters.Binary.BinaryFormatter`: adjust `IFormatter`
  versus `IRemotingFormatter` interface logic to use the former when `DISABLE_REMOTING`.

* `System.Runtime.Serialization.Formatters.Binary.BinaryObjectReader`: adjust existing
  `#if FEATURE_REMOTING || MOBILE_LEGACY` conditional to add `DISABLE_REMOTING` to it.

* `System.Diagnostics.CorrelationManager`: comment out some `CallContext.LogicalGetData()`
  and `CallContext.LogicalSetData`.

* `System.Diagnostics.TraceEventCache`: likewise.

Test changes:
-------------

* `mono/tests/Makefile.am`: conditionally disable some remoting tests.

* `corlib/Test/System.Runtime.Serialization/SerializationTest.cs`: conditionally
   disable all tests requiring remoting.

* `corlib/Test/System/ActivatorTest.cs`: same; trying to preserve as much as possible
  in this test.

* added some `DISABLE_REMOTING` and `DISABLE_SECURITY` conditionals to some of the tests.
2019-05-21 12:33:55 +02:00
Martin Baulig 0e5e464cff Add a few DISABLE_SECURITY conditionals. (#14300)
* Add a few `DISABLE_SECURITY` conditionals.

* [csproj] Update project files

* Fix tests.
2019-05-10 10:17:00 +02:00
Alexander Köplinger 77cf4cc4f8 [tests] Remove MONOMAC ifdef from BCL tests (#13694)
It was set by xamarin-macios when they were still taking the raw .cs source files
but since we switched to prebuilt binaries we need to replace it with
some define we're actually setting in Mono.

Most cases can be replaced by just XAMMAC_4_5 since MOBILE is defined on the xammac profile.
2019-03-27 20:21:48 +01:00
Alexander Köplinger 1bc213fac1 [System.Xml] Don't hardcode nunit-lite-console in GeneratedCodeAttribute
Instead determine it at runtime.
2019-03-27 11:39:22 +01:00
Vlad Brezae 53672c5f4c [interp] Enable System.Xml tests (#11791)
* [tests] Change timezone so it doesn't fail on UTC+2 systems

Change to remote UTC-1

* [interp] Enable System.XML tests
2018-11-28 07:19:08 -08:00
majellin24 92711632bf Modification to allow deserialization of derrived types (#11194)
* Modification to allow deserialization of derrived types

* white space correction

* second attempt

* third attempt

* fourth

* whitespace

* maybe fix null ref exception

* missed same condition in other method

* fixing condition

* hopefully correcting the test failure in AOT

* Modification to allow deserialization of derrived types

white space correction

second attempt

third attempt

fourth

whitespace

maybe fix null ref exception

missed same condition in other method

fixing condition

hopefully correcting the test failure in AOT

formatting

missed some formatting

* adding a test for PR #11194

* fixing a few exceptions

* adding ref
2018-10-31 10:43:46 +01:00
Alexander Köplinger 3d910b7477 [System.XML] Switch tests to use embedded test resources 2018-09-27 22:47:14 +02:00
Marek Safar 262c5f40cb [corlib] Default to fast Span<T> (#9204)
Part of #7249
2018-07-12 10:15:07 +02:00
Alexander Köplinger 5ef930b5f8 [bcl] Build some assemblies with -warnaserror (#5295)
* [bcl] Build some assemblies with -warnaserror

This ensures that we keep the build warning free.

We'll only opt-in a few assemblies that already have zero warnings.
We also only apply this when using csc as mcs might raise different warnings.

For now just opt-in assemblies in the net_4_x profile.
2017-11-24 14:05:39 +01:00
Egor Bogatov b44333823d XmlReaderSettings.EnableLegacyXmlSettings should always be false on mono. Fixes bug-60621 (#6014) 2017-11-19 13:43:06 +01:00
Alexander Kyte ca8b8bd346 [runtime] Add Dedup Support to MkBundle (#5484)
* [runtime] Fix mkbundle compilation on OSX

* [runtime] Add aot arguments to mkbundle

* [runtime] Enable compiling aot with mkbundle

* [runtime] Add new dedup interface to mkbundle

* [runtime] Fix path resolving for mkbundle

* [runtime] Use mkbundle in BCL tests

* [runtime] Skip building System.Security, System.IdentityModel tests on testing_aot_full

* [runtime] Fix in-tree building for mkbundle

* [runtime] Move testing dll into profile

* [runtime] Add target to mkbundle all tests before CI

* [runtime] Build stripper and use with mkbundle

Preliminary linker support ran into dependency-finding bug
with the monolinker.exe binary. Fix postponed until later.

* [runtime] Skip not supported tests with mkbundle

* [runtime] Don't re-aot when running BCL tests

* [runtime] Provide config to mkbundle

* [runtime] Fix mkbundle internationalization test results, build all

* [runtime] Clean up temp mkbundle aot directory

* [runtime] Add mkbundle support for dedup

* [runtime] Fix tracking of dedup module in mkbundle

* [runtime] Document mkbundle AOT options in man pages

* [runtime] Fix CADMessage generic method argument marshalling
2017-11-15 09:56:26 -05:00
Alexander Köplinger 2439f17bef Revert "Merge pull request #5330 from alexanderkyte/dedup_mkbundle"
This reverts commit 9a287c0412, reversing
changes made to 4a79280b3b.

It breaks tons of tests.
2017-08-31 00:41:53 +02:00
Alexander Kyte 3802e3de1b [runtime] Skip not supported tests with mkbundle 2017-08-30 12:54:49 -04:00
Alexander Köplinger f95b3f433c [bcl] Cleanup outdated csproj/sln files (#4806)
They were either replaced by the autogenerated csproj files
or just completely broken for years.
2017-05-09 00:07:45 +02:00
Alexander Köplinger d61e7aca9a [bcl] Update tests that failed when .cs file contained CRLF
Most of them used multiline C# string literals which
means they contained the line ending character of the file.
Updated to make the tests resilient to having CRLF instead of LF.

Some of the mcs tests used a checksum to compare files,
ensured those are checked out using LF.
2017-01-28 02:25:55 +01:00
Alexander Köplinger 6f2ce1ddf9 [bcl] Rename FEATURE_MONO_CAS to MONO_FEATURE_CAS
To be consistent with the other MONO_FEATURE_* defines.
2017-01-20 16:00:56 +01:00
Chris Hamons bb0564ff3c Mono BCL test fixes so XM can run them (#4210) 2017-01-10 16:59:08 -06:00
Marek Safar 27ab4a8175 [System.Xml] Disable more failing tests on old xslt implementation 2016-12-22 10:38:02 +01:00
Marek Safar 2659724dd3 [System.Xml] Disable failing tests on old xslt implementation 2016-12-22 10:31:22 +01:00
Marek Safar f3d036a124 [System.Xml] Add support for msxsl format functions. Fixes #50242 2016-12-20 14:46:17 +01:00
Marek Safar 93e845de16 [System.Xml] Enable more tests 2016-12-20 14:46:17 +01:00
Marek Safar ba51c60b57 [system.xml] Enable more tests 2016-11-10 18:43:14 +01:00
Alexander Köplinger 1a89bfde05 [System.Xml/System.ServiceModel/Dataflow] Use more specific type in assert
Apparently nunitlite is more strict here so we need to allow subclasses as well
and test for the more specific type.
2016-10-29 14:09:39 +02:00
Alexander Köplinger fbf1acd698 [System.Xml] Fix embedded assembly name in XmlCodeExporterTests
nunitlite doesn't run the test in a separate AppDomain so we get the name of the console host.
2016-10-29 14:09:38 +02:00
Marek Safar d19e5c42a5 [System.Xml] Update supported time formats for mobile version of XML deserializer. Fixes #42843 2016-10-14 09:10:17 +02:00
Marek Safar 398675d21a [System.Xml] Enable more tests 2016-10-14 09:10:17 +02:00
Niklas Therning bf8fc72e1b Fixes line ending issue in XmlReflectionImporterTests.Bug594490_SerializationOfXmlLangAttribute
This test is sensitive to the line ending mode used by git. When LF is used by
git (which is what Cygwin's git defaults to) this test fails on Windows since
CRLF will be used as line ending in the serialized XML. This patch changes the
test to use Environment.NewLine explicitly in the expected string.
2016-09-20 16:42:24 +02:00
Alexander Köplinger c4a5b6b5c3 [mcs] Remove NET_4_5 ifdef from the source files
It is always set in all profiles that we support so we can remove it.
2016-08-23 15:15:51 +02:00
Marek Safar b6a30059db [bcl] Update Reference Source to .NET Framework 4.6.2 2016-08-09 18:07:14 +02:00
Marek Safar ed989a8e9e [bcl] Make mono cas opt-in features instead of opt-out for mobile profiles 2016-06-16 14:37:55 +02:00
Alexander Köplinger b03e606287 Remove ChangeLog files from the repo
They weren't updated in the last 6 years and aren't helpful anymore (e.g. by causing unrelated matches during git grep searches).
2016-01-29 19:17:06 +01:00
Marcos Henrich e58fe58ef1 [System.Xml] Test sub class serialization on lists
Covers #36829
2016-01-11 18:03:43 +00:00
Marek Habersack 262b4ef73f Fix endless recursion in XmlCompiledTransform on mobile
One of the XmlCompiledTransform overloads called itself recursively,
leading to either a stack overflow or segfault

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=36436
2015-12-10 22:01:52 +01:00
Alexander Köplinger 3a71f84cca [build] Fix a few Makefiles to correctly use net_4_x instead of net_4_5 2015-07-25 17:47:29 +02:00
Marek Safar 584056a62b [system.xml] Check different results under disabled cas 2015-05-22 17:15:43 +02:00
Marek Safar aac0b374df [system.xml] One more mobile serialization incompatibility 2015-05-20 20:32:23 +02:00
Marek Safar 7215f95d58 [bcl] Mobile profiles fixes 2015-05-20 12:56:36 +02:00
Marek Safar 401a35cd69 [system.xml] Serialization from reference sources for desktop 2015-05-13 18:47:07 +02:00
Atsushi Eno ddca46d22b Revert "[system.xml] Serialization from reference sources for desktop"
This reverts commit 6ae517ea65.
2015-05-12 14:42:19 +08:00
Marek Safar 6ae517ea65 [system.xml] Serialization from reference sources for desktop 2015-05-11 15:37:01 +02:00
Marek Safar 1bda13b996 [bcl] Mobile profiles fixes 2015-05-06 17:11:33 +02:00
Marek Safar 9faaa72407 [system.xml] Update failing test 2015-04-16 00:08:01 +02:00
Dave Curylo bae8fad714 Fix XmlSerializationTest again. 2015-04-02 10:51:31 -04:00
Dave Curylo 389008df93 Corrects error in XmlSerializerTests. 2015-04-02 10:38:33 -04:00
Dave Curylo c58f019266 XmlSerializer should set *non* readonly {V}Specified fields
Addresses an oversight in PR 1257 that caused {V}Specified fields to not be set during XML deserialization in some circumstances.

Adds test for optional value serialization round trip
2015-04-01 21:56:49 -04:00
Marek Safar e58097e957 [corlib] String from reference sources, fixes mostly string.format issues 2015-03-25 15:08:06 +01:00
Atsushi Eno ee9fd48289 [xml] add test from bug #2917. 2015-03-17 18:55:34 +08:00
Alexander Köplinger ee307ef1e5 Fix the build broken in 40ba1978bc 2015-03-10 11:53:17 +01:00