* [bcl] Build some assemblies with -warnaserror
This ensures that we keep the build warning free.
We'll only opt-in a few assemblies that already have zero warnings.
We also only apply this when using csc as mcs might raise different warnings.
For now just opt-in assemblies in the net_4_x profile.
Most of them used multiline C# string literals which
means they contained the line ending character of the file.
Updated to make the tests resilient to having CRLF instead of LF.
Some of the mcs tests used a checksum to compare files,
ensured those are checked out using LF.
It is not simply replacement because we have to workaround dynamic codegen
for Xamarin.iOS.
Also there were several tests failing with MS implementation (e.g. for
W3C DOM conformance), so we had to disable them.
There is one regression that rather needs to be fixed in Reflection.Emit.
Also, some WCF tests fail with this implementation. They need to be
investigated, reviewed and appropriately fixed.
The thing is, XPathNodeIterator itself is stateful and does not behave
like IEnumerable, thus GetEnumerator() should not iterate nodes within
*itself*. Rather, it should have returned a clone of it.
After all we didn't have to damage performance to fix bug #3705, which is nice.
* XPathEditableDocument.cs : WriteAttributeString() is allowed on
an appended child on .NET, though IMHO incorrectly.
Fixed bug #554845.
* XPathEditableNavigatorTests.cs : added test for bug #554845.
svn path=/trunk/mcs/; revision=146350
* XPathNavigator.cs : name test did not handle String.Empty cases
for name and ns (i.e. no filter). Fixed bug #515136.
* XPathNavigatorTests.cs : added test for bug #515136.
svn path=/trunk/mcs/; revision=138384
* XPathNavigatorReader.cs : LookupNamespace() in XmlReader from
ReadSubtree() should work correctly on text nodes.
* XPathNavigatorCommonTests.cs : test that LookupNamespace() in
XmlReader from ReadSubtree() works correctly on text nodes.
svn path=/trunk/mcs/; revision=134196
* Expression.cs : gave up another optimization for bug #443090.
* SelectNodesTests.cs : added 2nd test for bug #443490.
svn path=/trunk/mcs/; revision=129574
* XmlDocumentNavigator.cs : in some corner cases an attribute
may have null OwnerElement. Fixed bug #458245.
* SelectNodesTests.cs : added test for bug #458245.
svn path=/trunk/mcs/; revision=123868
* Iterator.cs : DescendantIterator.Clone() was not cloning current
node in new code. Fixed bug #456103.
* XPathNavigatorTests.cs : added test fo bug #456103.
svn path=/trunk/mcs/; revision=121080
* XPathEditableDocument.cs : it should not expect ParentNode for
OwnerElement. Fixed bug #376210.
* XPathEditableNavigatorTests.cs : added test for bug #376210.
svn path=/trunk/mcs/; revision=99629
* XPathNavigator.cs : fixed InnerXml to not give up with root node.
Indent InnerXml. Fixed bug #376191.
* XPathNavigatorTests.cs : added test for bug #376191.
svn path=/trunk/mcs/; revision=99623
* XPathNavigator.cs : in some MoveTo*() methods, it should allow any
destination node when "type" is XPathNodeType.All. Based on the
patch by Sanghyeon Seo, fixed bug #365112.
* XPathNavigatorTests.cs : added test for bug #365112.
svn path=/trunk/mcs/; revision=96753
* DTMXPathDocumentBuilder2.cs : fixed incorrect namespace node links
which happened to following siblings of a node with namespaces.
* XPathNavigatorCommonTests.cs : added test for incorrect namespace
node links.
svn path=/trunk/mcs/; revision=70557
* Expression.cs : text() should match whitespace and significant
whitespace nodes.
* XPathNavigatorTests.cs : added test for text() and whitespace/
significantwhitespace node.
svn path=/trunk/mcs/; revision=70536
* XmlReader.cs : new 2.0 MoveToAttribute(int) failed to move to the
final attribute in an element.
* XPathNavigatorReaderTests.cs : added test for MoveToAttribute(int).
svn path=/trunk/mcs/; revision=69026
* XmlNode.cs : GetPrefixOfNamespace() was not correctly searching
ancestors' namespaces.
* XPathEditableDocument.cs : those writers should lookup prefix when
WriteStartElement/WriteStartAttribute are passed null prefix.
Removed nodeStack in XmlDocumentInsertionWriter, since nodes are
always added to current node immediately.
* XmlNodeTests.cs : added another test for GetPrefixOfNamespace().
* XPathNavigatorTests.cs : added test for XPath navigator editor's
LookupPrefix().
svn path=/trunk/mcs/; revision=69021
* XPathNavigator.cs :
- ReadSubtree() should reject everything but Element or Root.
- InnerXml and OuterXml should not use ReadSubtree() when it is
not positioned on an Element or the Root. Thus, implement them
in their own ways. Fixed bug #79875.
* XPathNavigatorTests.cs : added test for bug #79875, and some
"escaped" text tests for InnerXml.
* XPathNavigatorReaderTests.cs : make sure that most of XPath nodes
are rejected to read subtree.
svn path=/trunk/mcs/; revision=67659
* XPathNavigator.cs : InnerXml should allow Text-only content. Fixed
bug #79874, when tied to XPathNavigatorReader fix.
* XPathNavigatorReader.cs : removed node type restriction on
initialization. Fixed bug #79874, when tied to XPathNavigator fix.
* XPathNavigatorTests.cs : added test for bug #79874.
svn path=/trunk/mcs/; revision=67653
* XsltContext.cs : finally created a non-copyright-infringing test
for bug #46751 and fixed it.
* XPathNavigatorTests.cs : added (kind of) test for bug #46751.
svn path=/trunk/mcs/; revision=67045
* XPathEditableDocument.cs : (XmlDocumentEditableNavigator)
implement CanEdit to return true.
* XPathEditableNavigatorTests.cs : added test for CanEdit, based on
the patch by Konstantin Triger.
svn path=/trunk/mcs/; revision=66516
* XPathEditableDocument.cs : DocumentFragment should also be allowed
to have a child.
* XPathEditableNavigatorTests.cs : added test fro AppendChild() from
a document fragment.
svn path=/trunk/mcs/; revision=65219
* XPathNavigatorReader.cs : MoveToFirstAttribute() should return
true when current node is an attribute (including namespace node).
* XPathNavigatorReaderTests.cs : added test for MoveToFirstAttribute()
which is called from several current nodes.
svn path=/trunk/mcs/; revision=64720
* XPathNavigatorCommonTests.cs : added test for bug #78067.
* XPathNavigatorReaderTests.cs : ditto, for ReadSubtree() part.
* XPathNavigatorReader.cs : Read() did not compute Depth correctly.
It caused bug #78067.
* XPathNavigator.cs : get_OuterXml() returns indented output, without
XML declaration.
* XmlWriter.cs : WriteNode(XPathNavigator) : directly write element
and root nodes instead of dispatching to ReadSubtree().
svn path=/trunk/mcs/; revision=59286
* XmlSchema.cs : seems like there is XmlSchemaExternal.Schema property
that is filled after Compile(). Fixed bug #77687.
* XmlSchemaTests.cs : added test for bug #77687.
* 77687.xsd, 77687inc.xsd : test for bug #77687.
svn path=/trunk/mcs/; revision=57495
* XPathNavigator.cs : Added MonoTODO to CreateAttributes(). Removed
MonoTODO from ReadSubtree().
* XPathNavigatorReaderTests.cs : Actually AttributesAndNamespaces()
does not work under MS.NET.
svn path=/trunk/mcs/; revision=54366
* XPathNavigatorReader.cs : several fixes.
- Unless ReadState is Interactive, all name stuff should return "".
- Refactored Read() to work fine when input navigator is Root.
- Fixed all MoveTo*Attribute() methods match with other XmlReaders.
- Namespace nodes were not handled fine in MoveTo*Attribute().
* XPathNavigatorReaderTests.cs : new file for testing ReadSubtree()
and all dependent members.
* System.Xml_test.dll.sources: Added XPathNavigatorReaderTests.cs.
svn path=/trunk/mcs/; revision=54364
* XPathNavigator.cs : Reimplemented MoveToFollowing() to avoid
inefficient MoveToDescendant() and to match .NET 2.0 behavior.
* XPathEditableNavigatorTests.cs : added tests for MoveToFollowing().
svn path=/trunk/mcs/; revision=54296