154 Commits
Author SHA1 Message Date
Marius Ungureanu 394d8d1f21 Add RenamedEvent* to FSW sources from CoreFX (#16755)
* Add RenamedEvent* to FSW sources from CoreFX

Fixes #16486 - This was only partially fixed until now

* [csproj] Update project files

* Add test files which test these code paths on corefx

* Remove old RenamedEvent* files
2019-09-24 20:49:02 +02:00
Aleksey Kliger (λgeek) 3757a7296c [System] Make FileSystemWatcher backend non-static (#16922)
* [System] Make FileSystemWatcher backend non-static

The FileSystemWatcher `watcher` field is the backend IFileWatcher that's
supposed to be used for the actual operations.

Each backend has a `bool GetInstance (out watcher)` method that returns a
singleton object, so each new instance of FileSystemWatcher gets the same
IFileWatcher instance.  (They will get different `watcher_handle` instances
which are used by some backends to uniquely identify this FileSystemWatcher).

However when the first FileSystemWatcher instance is `Dispose`d, it will set
`watcher = null` which will prevent the remaining instances from calling

    watcher?.StopDispatching (watcher_handle);
    watcher?.Dispose (watcher_handle);

which means that the backend won't properly cleanup resources for any other FSW
instances that have other `watcher_handle` values.

Addresses https://github.com/mono/mono/issues/16709
2019-09-20 11:21:30 -04:00
Maxim Lipnin 12949cf2e6 [wasm] Switch to PNSE version of FileSystemWatcher and exclude xunit tests (#16892)
Fixes https://github.com/mono/mono/issues/16876
2019-09-19 08:13:02 -04:00
Marius Ungureanu 1d23ca14e1 Use the right FileSystemWatcher sources (#16539)
* Use the right FileSystemWatcher sources

The corefx code for FileSystemEventArgs has some changes to support
constructing one with a null filename.

Fixes #16486

* Remove the mono sources for the newly replaced files

* [csproj] Update project files
2019-08-28 19:45:25 -04:00
Alexis Christoforides 532605f533 [System] Keep events from firing from a disposed 'DefaultWatcher' FileSystemWatcher
Fixes https://github.com/mono/mono/issues/8747

Also try to stop other implementations from dispatching events past Dispose(), without guaranteeing it
2019-07-15 23:25:32 +03:00
Egor Bogatov e42bf95d14 NS2.1 Sync new changes, mobile profiles (#13198)
* Add RuntimeHelpers.GetSubArray. Add missing types to NS's TypeForwarders.cs

* more NS2.1 changes

* ios changes

* Update Decimal (it's now readonly struct)

* fix mcs

* add ROMC.cs

* Fix tests, finish monodroid profile

* Make SRE-not-supported NS2.1 compatible

* Make monotouch_tv and watch NS2.1 compatible

* make some SRE types more NS21 compatible (non-abstract now)

* bump corefx

* More NS21 fixes

* bump coreclr acceptance tests

* Bump API snapshot submodule

* [csproj] Update project files
2019-03-06 08:55:16 +01:00
Mike Krüger 085ddcccb5 Fixes VS4Mac Issue #6898 (#12432)
https://github.com/mono/monodevelop/issues/6898

Not sure if it's the root of the problem but it surely fixes the dead lock on my machine.
2019-01-28 16:30:40 -05:00
Alexis Christoforides 1b163d62d0 [System.IO] Enable CoreFX FilesystemWatcher on Android (#9766)
* [System.IO] Enable CoreFX FilesystemWatcher on Android
This was the last user of the 'InotifyWatcher' Mono implementation, so this is also removed.

* [csproj] Update project files
2018-09-07 23:33:03 -04:00
Alexis Christoforides bc4a1b31c5 [System.IO] Dispatch events asynchronously in FileSystemWatcher.DispatchEvents()
This used to happen in RaiseEvents(), but some CoreFX FSW tests require that a derived FSW be able to fire its event synchronously.
2018-05-30 09:54:02 -04:00
Alexis Christoforides 2fe6c6bfba [System.IO] Prevent the CoreFX bridge from even try-entering a monitor.
In the case of the FSEvent FileSystemWatcher, the CFRunLoop event loop thread has already an interrupt handler installed in the icall, and mono_monitor_try_enter  may try to install one as well which is not supported. So we create separate event tasks before we use the Operation() method.
2018-05-30 09:42:57 -04:00
Alexis Christoforides 183d994a91 [System.IO] Finish initializing all FileSystemWatchers, not just the first one
Fixes https://github.com/mono/mono/issues/8712
2018-05-29 16:25:21 -04:00
Daniel Becker 5e6e8682ad [System] Use Interrupt instead of Abort to shut down handler thread for kevent watcher (#2876)
The only place where the handler thread should block is in the
kqueue_notimeout() call; interrupting the thread should cause
that call to exit with EINTR, and allow the thread to exit.
2018-04-26 15:17:17 +02:00
Marek Safar a801621255 [System] Fixes desktop FSW wildcard pattern to match others implementations 2018-04-12 11:39:27 +02:00
Alexis Christoforides 1e1893d683 [System.IO] Don't throw exception when FileSystemWatcher is disposed while the backend is still trying to use it 2018-03-29 18:25:45 -04:00
Alexis Christoforides 3c8bf90a40 [System.IO] Use CoreFX FileSystemWatcher stub for mobile profile 2018-03-27 18:05:07 -04:00
Alexander Köplinger fa21013d7f Don't throw NotImplementedException in Dispose()
We had a few stubs that threw not implemented exceptions in Dispose()
which causes the finalizer thread to abort.

Since those classes throw in the constructor already there's no way
to create a valid object and we can remove the throw in Dispose().

Fixes https://github.com/mono/mono/issues/7338
2018-02-28 17:28:51 +01:00
Alexander Köplinger cb956b58a6 Revert "Revert "[System.IO] Integrate FileSystemWatchers from CoreFX The FSEvent CoreFX watcher becomes the new default for MacOS.""
This reverts commit 2174a521a3.
2018-02-28 13:42:15 +01:00
Marek Safar 2174a521a3 Revert "[System.IO] Integrate FileSystemWatchers from CoreFX The FSEvent CoreFX watcher becomes the new default for MacOS."
This reverts commit f5b10f34a9.
2018-02-28 12:46:53 +01:00
Alexis Christoforides f5b10f34a9 [System.IO] Integrate FileSystemWatchers from CoreFX
The FSEvent CoreFX watcher becomes the new default for MacOS.
2018-02-28 10:47:01 +01:00
Alexander Köplinger b3e3e4cc40 [System] Don't use DateTime.Now for measuring elapsed time
Use Stopwatch or DateTime.UtcNow instead which aren't affected
by things like daylight-saving time
2017-07-02 23:31:34 +02:00
Marek Safar 95b0698304 [System] Clean up some warnings 2016-10-25 14:28:35 +02:00
Alexander Köplinger 4d325a0674 [System] Add ISupportInitialize on mobile FileSystemWatcher
The interface was missing on the mobile stub.
2016-09-25 13:59:53 +02:00
Alexander Köplinger 112631f5c6 [bcl] Add missing APIs for netstandard parity and expose a few APIs on mobile
This ensures we're compliant with the upcoming netstandard2.0 API surface area.
2016-09-23 17:50:06 +02:00
Marek Safar 7ba748c8b8 [bcl] Base type update to match netstandard apis 2016-09-23 12:10:11 +02:00
Alexander Köplinger 3c3ef17376 [bcl] Update to match NETStandard 1.6 members 2016-08-11 20:53:38 +02:00
Marek Safar 10c5e72512 [bcl] netstandart 1.6 support 2016-07-13 11:02:10 +02:00
Alexis Christoforides ba3384aa88 Merge pull request #2417 from razzfazz/guard_substr
handle path stripping correctly for root of watched tree
2016-04-15 22:57:33 -04:00
Daniel Becker a06225626c use native realpath() function (#2877)
Instead of opening a file for the sole purpose of calling
F_GETPATH on the resulting descriptor, we can just use the
native realpath() function; as a side benefit, this also works
on *BSD where F_GETPATH isn't supported.
2016-04-13 22:53:34 -04:00
Alexander Köplinger b8893efbcc Merge pull request #2832 from razzfazz/handle_eintr
handle EINTR for kevent calls
2016-04-05 21:39:14 +02:00
Alexander Köplinger 1639e26a6b Merge pull request #2831 from razzfazz/fix_dllimport
clean up DllImport attributes
2016-04-05 15:04:31 +02:00
Daniel Becker ac49990f3d clean up DllImport attributes
Any native function that can modify errno should have the
SetLastError attribute set to true. Also, no need to specify
EntryPoint if it's the same as the function name.
2016-04-05 00:35:21 -07:00
Alexander Köplinger b03e606287 Remove ChangeLog files from the repo
They weren't updated in the last 6 years and aren't helpful anymore (e.g. by causing unrelated matches during git grep searches).
2016-01-29 19:17:06 +01:00
Daniel Becker 773729f807 handle path stripping correctly for root of watched tree 2016-01-09 12:28:33 -08:00
Daniel Becker 1b1f395bd4 handle EINTR for kevent calls
A kevent() syscall may "fail" with EINTR if the process receives
a signal before the timeout expires and before an event is placed
in the kqueue; in this case, rather than erroring out, the
syscall should simply be retried.
2016-01-09 12:17:52 -08:00
Daniel Becker a261f0806c fix struct timespec member name
The second member of struct timespec is actually called tv_nsec
(nanoseconds), not tv_usec (microseconds); this was likely
confused with struct timeval, where the second member is in fact
called tv_usec.
2016-01-09 12:17:20 -08:00
Alexis Christoforides 85c7bd08ef Merge pull request #2285 from knocte/filesystemwatcher
[FileSystemWatcher] Kill race condition (fixes BXC#10205)
2015-12-09 14:11:41 -05:00
Miguel de Icaza 2af882232c [System] Remove arbitrary debugging limit from FileSystemWatcher on OSX, fixes #28693 2015-12-05 15:09:06 -05:00
Andrés G. Aragoneses cfc5011ced [FileSystemWatcher] Kill race condition (fixes BXC#10205)
As seen in the stacktraces provided in [1],
a thread could modify the Files hashtable
while other thread is enumerating it, so this
can be prevented by using a lock{} in the parts
of the code that access and modify this field.

Patch licensed as MIT/X11.

[1] https://bugzilla.xamarin.com/show_bug.cgi?id=10205
2015-12-03 13:35:54 +08:00
Marek Safar 789808b507 [system] Simplify process redirection initialization 2015-08-19 14:13:03 +02:00
Zoltan Varga bf8f49aa7a [runtime] Move the kevent() calls from KeventWatcher to the runtime, add support for interrupts. 2015-08-11 14:37:59 -04:00
Zoltan Varga 00ef87ab6d Revert "[runtime] Move the kevent() calls from KeventWatcher to the runtime, add support for interrupts."
This reverts commit 7f44281658.

Revert this as icalls don't marshal kevent structures correctly.
2015-08-10 15:51:39 -04:00
Zoltan Varga 7f44281658 [runtime] Move the kevent() calls from KeventWatcher to the runtime, add support for interrupts. 2015-08-10 14:32:37 -04:00
Alexis Christoforides 9820f6e148 [System.IO.KeventWatcher] Fix handling some cases where an item is moved out of the watched path.
If a file or directory are moved out of the watcher's path they are removed from the index, but they might still have events in the kevent() changelist. This would sometimes cause an exception.
2015-06-02 19:10:48 -04:00
Alexis Christoforides a1828a2aa9 [System.IO.KeventWatcher] Disable the watcher when the root directory is deleted. Fixes #30043
This matches MS.NET behavior.
2015-06-01 23:07:07 -04:00
Aaron Hoffman 641f55922f Fix spelling of number in IOException message 2015-04-29 23:18:26 -05:00
Alexander Köplinger d4d7374efc [bcl] Remove ONLY_1_1 defines from class libs
This is not used anymore.
2015-01-21 17:18:30 +01:00
Zoltan Varga 1f32c791d4 Fix a deadlock introduced by 3f10c46468. 2015-01-13 21:52:31 -05:00
Zoltan Varga 3f10c46468 [bcl] Break waits in KeventWatcher by closing the command fd instead of polling. 2015-01-13 18:58:02 -05:00
Alexis Christoforides e79dc945a5 [FileSystemWatcher] Properly handle multicast delegates.
Reverted the async delegate firing which is how Caching et al. expect FSW events; and properly handle the multicast case.

Also fixing a typo/regression in @2f1a136583c90cae805441e63b94bc4f277bb953
2014-12-15 11:05:19 -05:00
Alexis Christoforides 0146e5c751 Fix merge typo 2014-12-11 16:00:40 -05:00