96 Commits
Author SHA1 Message Date
Martin Baulig 1553889bc5 Cleaning up SslStream, MobileAuthenticatedStream and TaskToApm. (#17393)
### Overview

After the removal of the Legacy TLS Provider, we can make some cleanups and improvements to the `SslStream` class.  Since both the remaining providers use the internal `MobileAuthenticatedStream` and support Task-async code, we can get rid of some of the Begin/End async logic and the the underlying
`Stream` class handle it instead.

This also fixes a nasty issue with some of those task objects leaking unobserved exceptions.  The problem was that `SslStream.Dispose()` needs to clear out all resources, but in doing so also nulls out the `Impl` handle to the `MobileAuthenticatedStream` - so a subsequent `End*()` call will not reach it's corresponding `TaskToApm.End()` method.

There are also some cleanups in the internal APIs that were only ever used internally and not intended for public consumption.

### Mono.Security.dll

* `Mono.Security.Interface`: removed internal `ICertificateValidator2` interface.

* `Mono.Security.Interface.IMonoSslStream`: this internal interface is only used by the web-tests, which only use it as a way to get the `SslStream` instance, so all those `Begin/End` async methods are now gone.

* `Mono.Security.Interface.IMonoSslStream2`: removed another internal interface.

* `Mono.Security.Interface.MonoTlsProvider`: removed some `internal abstract` methods; these have been moved into a new `Mono.Net.Security.MobileTlsProvider` inside `System.dll`.

### System.dll

* `Mono.Net.Security.MobileTlsProvider`:
  New abstract internal base class, which received the aforementioned abstract internal methods.  The naming is such to make it consistent with the already existing `MobileTlsContext` and `MobileAuthenticatedStream`.

Since both `AppleTlsProvider` and `BtlsProvider` now have an abstract internal base class inside `System.dll`, they can use the `ChainValidationHelper` class directly and we can also avoid some `Mono.Security` dances like for instance that `MonoSslPolicyErrors` enum.

This will also help make the code easier to read and maintainer.
  
* `Mono.AppleTls.AppleTlsProvider` and `Mono.Btls.MonoBtlsProvider`: change base class into `MobileTlsProvider` and reflect above mentioned overload changes.

* `Mono.AppleTls.AppleCertificateHelper`: use `ChainValidationHelper` as well.

* `Mono.Net.Security.ChainValidationHelper`: only implement `ICertificateValidator`.
  The `ICertificateValidator` interface is still required because it is in use by the web-tests, but the previous `ICertificateValidator2` was an internal dance.

* `Mono.Net.Security.MobileAuthenticatedStream`: largely cleaned up this class.
  - we now implement the current slimmer version of `IMonoSslStream`.
  - moved all those overloads into `SslStream` that only fill in default values for some of their arguments and then call another overloaded version of their own.
  - removed lots of `Begin/End` methods that are not used anymore.

* `Mono.Net.Security.MonoTlsProviderFactory`: use `MobileTlsStream` everywhere.

* `Mono.Net.Security.MonoTlsStream`: cleanup `SslStream` creation logic; instead of going throw `provider.CreateSslStream()`, we can now use an internal constructor directly, thus avoiding the `IMonoSslStream` interface while also making the code a lot easier to read and understand.

* `System.Net.Mail.SmtpClient`: same here.

* `System.Net.HttpWebRequest`: use `MobileTlsProvider`.

* `System.Net.Security.SslStream`: largely cleaned up this class.
  - we now use `MobileAuthenticatedStream` directly instead of the `IMonoSslStream` interface and therefore could also get rid of `IMonoSslStream2`.
  - cleanup constructor logic to allow the internal constructor being used with a `MobileTlsProvider` instead of going through `provider.CreateSslStream()`.
  - all those overloads that are only filling in default values for some of their arguments before calling another overloaded version of their own now live here instead of in the `MobileAuthenticatedStream` class.  The reason is to simply that `MobileAuthenticatedStream` is already quite a complex and difficult class, and removing some of that complexity out of it will make it easier to understand.
  - handle the `TaskToApm.Begin()` / `TaskToApm.End()` here to ensure that we are not leaking any task objects with unobserved exceptions.
  - removed `BeginRead()` and `BeginWrite()` overloads to let the underlying `Stream` class handle these.


* Bump API snapshot submodule

* [csproj] Update project files
2019-10-24 19:42:54 +02:00
Alexander Köplinger e0e93f396d [System] Rename method parameters to match .NET contract 2017-03-16 13:02:09 +01:00
Konstantin Safonov 0902d69876 Added missing DeliveryFormat property to MailClient
Doesn't actually change the behavior but at least allows to build sources referencing it on mono.
https://msdn.microsoft.com/en-us/library/system.net.mail.smtpclient.deliveryformat(v=vs.110).aspx
2016-08-03 17:50:53 +03:00
Marek Safar aa77a6ddcc [System] Remove PrebuiltSystem alias (it's not needed with any modern mcs) 2016-04-16 08:37:07 +02:00
Sebastien Pouliot 1a2b21803c [System] Make SmtpClient fallback to it's old behaviour if the hostname cannot be resolved. Fix #37246
Warning: System.Net.Mail is broken by design and sends incorrect emails.

This is not to fix SmtpClient itself but to ensure it remains compatible
(even if incorrect/broken) with older Mono releases.

The commit associated with bug# 33551 [1] can cause issues on computer
and devices that cannot resolve their hostname using the Dns API (which
have their own issues).

This commit catch the exception that occurs when resolution fails and
continue to send an email without a fully qualified domain name - just
like earlier Mono versions did in the past.

This solve bug #32746 [2] where some, but not all, AppleTV devices fails
to execute some of the System.dll unit tests.

Note: Whenever possible stay clear of SmtpClient (and friends) and use
something else like MimeKit/MailKit for your email needs

[1] https://bugzilla.xamarin.com/show_bug.cgi?id=33551
[2] https://bugzilla.xamarin.com/show_bug.cgi?id=37246
2016-01-26 13:11:46 -05:00
Alexander Köplinger 3bfea0a776 [System] Port System.Net.Mime namespace from referencesources
A few helper methods that existed in ContentType were moved into MailMessage.
I verified the test changes are required to match MS.NET behavior.
2015-12-24 13:27:12 +01:00
Miguel de Icaza ccdf8c3274 Merge pull request #1896 from meum/patch-1
Fix dot stuffing in SmtpClient
2015-12-22 10:20:19 -05:00
Martin Baulig b48cd9b3c1 [Mono.Security]: Minor 'Mono.Security.Interface' API improvements.
* MonoTlsSettings: Add static 'DefaultSettings' and CopyDefaultSettings().

* MonoTlsProvider: Add 'ID' and 'Name' properties.

(cherry picked from commit 51226c86f9)
2015-11-24 15:15:28 -05:00
Martin Baulig 35411c095d Remove a few more 'using System.Reflection's. 2015-10-23 16:05:19 -04:00
Martin Baulig dd3e9ab28c [System]: Use MonoTlsProvider API in FtpWebRequest and SmtpClient. 2015-10-21 14:36:06 -04:00
Miguel de Icaza fa081c5ecd Obsolete SmtpClient 2015-09-23 14:21:51 -04:00
Miguel de Icaza b711f7731b Merge pull request #2020 from tomjepp/master
Fix bug #33551 - Use a full FQDN for EHLO and HELO in SmtpClient.
2015-09-23 14:18:36 -04:00
Adam Burgess d89373d85e [System] Fix SmtpClient.SendMailAsync never completing 2015-09-22 04:43:12 +10:00
Thomas Jepp 2165b4616a Fix bug #33551 - Use a full FQDN for EHLO and HELO in SmtpClient. 2015-09-01 18:46:15 +01:00
meum 1d8284ed11 Fix dot stuffing in SmtpClient
As per RFC2821 section 4.5.2:
   -  Before sending a line of mail text, the SMTP client checks the
      first character of the line.  If it is a period, one additional
      period is inserted at the beginning of the line.
2015-06-23 17:03:59 +02:00
Zoltan Varga c1b4366932 [bcl] Remove NET_4_5 defines from class libs. 2015-01-13 16:34:23 -05:00
Zoltan Varga 032f313d5f [bcl] Remove NET_4_0 defines from class libs. 2015-01-13 16:06:31 -05:00
Alexander Köplinger 48e112d652 [Cleanup] Removed TARGET_JVM
It was once part of a special Java target profile, but this is no longer used today.
2014-08-08 03:28:34 +02:00
Marek Safar 7bf00fe94c [System] Fixes a warning 2014-06-27 13:37:50 +02:00
Jeffrey Stedfast 10fa44a5e6 Merge pull request #995 from yjoly/master
Fix the date time set in file by removing the ':'.
2014-06-24 11:07:35 -04:00
Marek Safar 1eac449e69 [system] Add SendMailAsync methods 2014-05-23 21:27:38 +02:00
Miguel de Icaza 705da187cf [System] Fix build warnings 2014-05-04 17:15:18 -04:00
Marek Habersack 34fb07d05f Include support for SSL/TLS right in System when building for the MONODROID profile
This patch builds upon commit 96a8500795 which placed parts of Mono.Security
responsible for dealing with SSL/TLS certificates for the purpose of certificate verification. The code enables
validation of the certifcates even if the user does not provide their own validation callback. The changes as related to
the original commit are few, basically consisting of enabling the same code used by MonoTouch in the MonoDroid context with
the only actual code change being the certificate validation bit mentioned above.

Since the change involves adding a subset of Mono.Security files to the monodroid version of System.dll, it is
also necessary to remove Mono.Android's dependence on Mono.Security.dll. The reason is that the code in AndroidPlatform
which looks up TLS support methods in Mono.Android.dll would use a type (X509CertificateCollection) that is now part of
System.dll but is *also* in Mono.Security.dll referenced by Mono.Android.dll and therefore the lookup would fail since
we'd have two distinct types from the reflection point of view.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=18962
2014-04-25 21:39:53 +02:00
yjoly a4a65eda9a Fix the date time set in file by removing the ':'.
This is the same code than the one under SendCore. The date time should
not have the : (time zone offset) to be able to use the file.
2014-04-15 15:41:40 -04:00
Sebastien Pouliot 96a8500795 Allow the MONOTOUCH targetr to build its SSL/TLS support right inside System.dll and remove code duplication and non-required code paths. 2013-07-01 16:21:04 -04:00
Marek Safar 510f20d376 Fix failing mobile tests 2013-02-26 10:37:01 +01:00
Shay Rojansky bf90b51599 Removed debugging prints that slipped through 2012-11-05 03:42:46 +02:00
Shay Rojansky c1e2462912 Fixed missing Content-Id email headers
When specifying a Content-Id header on Attachments and AlternateViews (but not LinkedResources) the header was not rendered.
This fixes bug #2279.
Also refactored header generation methods.
2012-10-29 02:29:15 +02:00
Miguel de Icaza f48ceb9860 [System] Removal of the NET_2_0 in the source code
Modulo the GUID in the assembly and the GUID embedded in some
field initializers that use the assembly GUID for their name, the
assemblies are idential before and after the patch.
2012-06-02 13:16:40 -04:00
Gonzalo Paniagua Javier c649da58f9 [SmtpClient] Don't send empty display name.
If there's no display name, don't send '""'.
	Fixes bug #670475.
2011-02-08 21:01:59 -05:00
Marek Habersack 0f51fe59c2 [system] SmtpClient implements IDisposable on 4.0 (a no-op for now) 2011-01-25 15:46:24 +01:00
Gonzalo Paniagua Javier b353b9cc84 Check that the default from is not empty
This should fix a bunch of tests failing since MailAddress parsing was
	fixed.
2010-10-31 17:29:21 -04:00
Gonzalo Paniagua Javier 97704e7322 Add support for EnableSsl in smtp config.
Ditto.
	Fixes bug #644816.
2010-10-08 00:40:18 -04:00
Raja R Harinath cc50d3ac37 Implement envelope sender semantics in SmtpClient
* System.Net.Mail/SmtpClient.cs (SendCore): Compute envelope sender
separately from the 'From: ' header.
* Test/System.Net.Mail/SmtpClientTest.cs (Deliver_Envelope): New.
2010-08-04 09:57:08 +05:30
Gonzalo Paniagua Javier 7a5370dcc4 2010-06-28 Gonzalo Paniagua Javier <[email protected]>
* SmtpClient.cs: support PLAIN authentication and throw if LOGIN and
	PLAIN are not supported. Fixes bug #607249.


svn path=/trunk/mcs/; revision=159619
2010-06-28 21:00:00 +00:00
Miguel de Icaza a90edd6979 2010-05-04 Miguel de Icaza <[email protected]>
* Apply patch from Ted Unangst to fix bug 574049

svn path=/trunk/mcs/; revision=156700
2010-05-05 03:10:07 +00:00
Miguel de Icaza f47e5fe6a6 2010-03-20 Miguel de Icaza <[email protected]>
* Eliminate warnings in a bunch of places.

svn path=/trunk/mcs/; revision=153952
2010-03-20 23:09:06 +00:00
Gonzalo Paniagua Javier 80db348b3c 2010-03-06 Gonzalo Paniagua Javier <[email protected]>
* SmtpClient.cs: typo in reply-to header. Thanks to Chris Tomlinson.
	Fixes bug #578271.


svn path=/trunk/mcs/; revision=153183
2010-03-06 16:40:23 +00:00
Gonzalo Paniagua Javier b411d31cf3 2010-02-15 Gonzalo Paniagua Javier <[email protected]>
* SmtpClient.cs: generate correct MIME when there are text and html
	linked resources. Fixes bug #579984. Patch by Ásgeir Halldórsson.


svn path=/trunk/mcs/; revision=151758
2010-02-16 01:22:22 +00:00
Gonzalo Paniagua Javier 91a420aa6b 2010-01-21 Gonzalo Paniagua Javier <[email protected]>
* SmtpClient.cs: rethrow inner exception so that
	AsyncCompletedEventArgs.Error gets the right value on error. Patch
	by Dimitar Dobrev.


svn path=/trunk/mcs/; revision=149983
2010-01-21 15:21:27 +00:00
Marek Safar 265206db2e Fixes build.
svn path=/trunk/mcs/; revision=148094
2009-12-11 08:43:54 +00:00
Miguel de Icaza 2be93c0df1 2009-12-11 Miguel de Icaza <[email protected]>
* SmtpClient.cs: Add half-implemented feature, TargetName for the
	SPN SMTP system.

svn path=/trunk/mcs/; revision=148093
2009-12-11 06:22:59 +00:00
Miguel de Icaza dd0bc8418a 2009-12-11 Miguel de Icaza <[email protected]>
* SmtpClient.cs, MailMessage.cs: Add 4.0 APIs.

svn path=/trunk/mcs/; revision=148092
2009-12-11 06:03:45 +00:00
Sebastien Pouliot c259a8cc51 2009-08-20 Sebastien Pouliot <[email protected]>
* SmtpClient.cs: Honor ServicePointManager.
	ServerCertificateValidationCallback when provided


svn path=/trunk/mcs/; revision=140347
2009-08-20 16:01:57 +00:00
Gonzalo Paniagua Javier f3af4e6e1d 2009-06-08 Gonzalo Paniagua Javier <[email protected]>
* SmtpClient.cs: handle dots. Patch by Ted Unangst that fixes bug
	#392875.


svn path=/trunk/mcs/; revision=135692
2009-06-08 20:40:18 +00:00
Gonzalo Paniagua Javier e36b6625b9 2008-11-17 Gonzalo Paniagua Javier <[email protected]>
* SmtpClient.cs: remove unused variable and obsolete comment.


svn path=/trunk/mcs/; revision=119084
2008-11-17 19:47:45 +00:00
Miguel de Icaza 0770265c72 2008-09-17 Miguel de Icaza <[email protected]>
* SmtpClient.cs: Actually set some of the headers like Priority,
	ReplyTo and Sender.

svn path=/trunk/mcs/; revision=113370
2008-09-18 00:33:11 +00:00
Atsushi Eno 6f83b3926e 2008-09-05 Atsushi Enomoto <[email protected]>
* SmtpClient.cs : attachment stream consumption was insufficient.
	  Fix bug #347553, by David Ion.


svn path=/trunk/mcs/; revision=112349
2008-09-05 02:23:27 +00:00
Marek Safar 225f1c9198 Warnings cleanup
svn path=/trunk/mcs/; revision=111790
2008-08-28 09:12:00 +00:00
Gert Driesen 13213bdd61 * SmtpClient.cs: Fixed paramname of Argument(Null)Exceptions to match
MS. Removed upper limit check for Port. Modified Send to no longer
allow a whitespace-only Host. Moved checks for SpecifiedPickupDirectory
delivery method to SendFile, and use Path.IsPathRooted to check for
absolute paths instead of using a unix-only check. In Send, wrap all
non-SMTP errors in an SmtpException.
* SmtpException.cs: Correctly chain up all .ctors. Removed extra
null check in deserialization .ctor.
* SmtpClientTest.cs: Added property tests. Added Send argument check
tests.
* SmtpExceptionTest.cs: Added .ctor and GetObjectData tests.
* System_test.dll.sources: Added SmtpExceptionTest.cs.

svn path=/trunk/mcs/; revision=110647
2008-08-16 12:34:38 +00:00