21 Commits
Author SHA1 Message Date
Martin Baulig 1256d6c8cf Use NetworkStream from CoreFX. (#16889)
* Use `NetworkStream` from CoreFX.

This brings the `NetworkStream` class and related tests from CoreFX.

* `SocketAsyncEventArgs`: partially replace the following properties
  with the CoreFX version: `Buffer`, `BufferList`, `Offset`, `SetBuffer ()`
  as well as the internal `CopyBufferFrom ()`.

* `SocketAsyncResult`: change `Buffer` from `byte[]` to `Memory<byte>`.

* Add internal `Socket` overloads:
   - `Receive (Memory<byte> buffer, int, int, SocketFlags, out SocketError)`
   - `ReceiveFrom (Memory<byte>, int, int, SocketFlags, ref EndPoint, out SocketError)`
   - `SendTo (Memory<byte>, int, int, SocketFlags, EndPoint)`

* Implement async task overloads from CoreFX (`Socket.Tasks.cs`) to `Socket`:
   - `int Read(Span<byte>)`
   - `Task<int> ReadAsync(byte[], int, int, CancellationToken)`
   - `ValueTask<int> ReadAsync(Memory<byte>, CancellationToken)`
   - `int ReadByte()`
   - `void Write(ReadOnlySpan<byte>)`
   - `Task WriteAsync(byte[], int, int, CancellationToken)`
   - `ValueTask WriteAsync(ReadOnlyMemory<byte>, CancellationToken)`
   - `void WriteByte(byte)`

* remove internal unused `PooledStream` and `ConnectionPool` APIs.

* bring new tests from CoreFX:
  - `System.Net.Sockets/tests/FunctionalTests/NetworkStreamTest.cs`
  - `System.Net.Sockets/tests/FunctionalTests/NetworkStreamTest.netcoreapp.cs`

* corlib: add `System.IO.FileSystem` and `System.Net.Sockets` resources and update SR.

* Update Socket.cs

* [csproj] Update project files

* Bump API snapshot submodule
2019-09-19 14:46:29 +02:00
Martin Baulig e92ecdc9ce Fix Socket.ConnectAsync(SocketAsyncEventArgs) behavior. (#15947)
We need to clearly distinguish between synchronous and asynchronous completions
and avoid any ambiguities and race conditions when it comes to error handling.

On synchronous completion, we must not invoke the async completion delegate.

In `System.Net.Sockets/Socket.cs`, the internal `BeginSConnect()` and `BeginMConnect()`
now return a `bool` indicating whether or not an async operation is pending.

If any error happens prior to starting the async operation, then we shall call
`SocketAsyncResult.Complete(..., true)` and return `false`.  And since this is
a synchronous completion, it's `AsyncCallback` will not be invoked.

In `referencesource/System/net/System/Net/Sockets/_MultipleConnectAsync.cs`,
I compared the entire file against the CoreFX version and then copied the
`AttemptConnection()` method from their implementation to adapt their behavior.

The difference is that on synchronous completion, the `InternalConnectCallback(null, args)`
should be invoked.
2019-08-01 12:31:25 +02:00
su21 463cf3b5c1 less allocation in Socket (#4516)
* less allocation in Socket

avoid allocate `System.Threading.QueueUserWorkItemCallback` in `SocketAsyncResult.Complete`
avoid allocate `Task` and anonymous function in `Socket.QueueIOSelectorJob`

* update: fix race and use replace static field with in line lambda

* cleanup code

* QueueIOSelectorJob keep async, and provie a fastpath

* SocketAsyncResult: simplify callback code

* add missing line `IOSelect.Add(handle, job)`  :(

* fix typo

* fix compile error
2017-03-17 15:35:41 -04:00
Ludovic Henry 5f7e9663af [socket] Fix race on SocketAsyncResult (#4389)
It might be possible that the callback modifies the current SocketAsyncResult via the Init method. We observe it with AcceptAsync with a ReceiveAsync in the callback.
2017-02-15 20:46:26 -05:00
Ludovic Henry 13c15c25fb [Socket] Use SemaphoreSlim instead of Queue (#3633)
This uses the same approach as corefx's FileStream. This simplifies the code, as well as make the intent of the queue clearer.
2016-09-25 19:54:07 +02:00
Ludovic Henry c5df7e9669 [referencesource] Import parts of System.Net.Sockets.Socket (#3618) 2016-09-24 20:10:01 +02:00
Ludovic Henry fd90b1e132 [socket] Make SocketAsyncResult use Socket.Handle
This is to avoid accessing a handle that has been disposed from the
SocketAsyncResult code.
2015-10-07 16:31:33 +01:00
Ludovic Henry e5e97eafef [socket] Refactor SocketAsyncEventArgs creation 2015-10-05 18:49:19 +01:00
Ludovic Henry 19f7162390 [socket] Remove SocketAsyncWorker
By having the callbacks directly in Socket, we can remove the SocketAsyncWorker class. This also greatly simplify this part of the code, as the callbacks are at the same place as the Begin/End invokes.
2015-10-05 18:49:19 +01:00
Ludovic Henry cdca8cde59 [socket] Remove SocketAsyncEventArgs.Init 2015-10-05 18:49:18 +01:00
Ludovic Henry 92a980a9af [socket] Factor SocketAsyncResult and ProcessAsyncResult common parts into IOAsyncResult + Abstract IO Threadpool jobs with IOSelectorJob
This simplifies greatly the native code, as we do not need to worry anymore about all IAsyncResult related work (call the callback, set completed, etc.), and we only need to care about the handle we are watching, and the callback to call when something happens on this handle.

This is quite a big commit, but unfortunatly, it's very hard to break it down in smaller commits as everything is very interwind.
2015-10-05 18:49:18 +01:00
Ludovic Henry 1f4d44800e [Socket] Duplicate logic of AsyncResult.ExecuteWorkItem to SocketAsyncResult
This consists in executing the callback synchronously and swallowing any exception in this callback.
2015-09-10 16:59:01 +01:00
Ludovic Henry fd02c73d71 Revert "[runtime] Move AsyncResult.Invoke to managed"
This reverts commit 29b07ab3ad.
2015-08-04 09:42:22 -04:00
Ludovic Henry 29b07ab3ad [runtime] Move AsyncResult.Invoke to managed 2015-08-03 15:57:37 -04:00
Ludovic Henry 0c9dcf73c2 [threadpool-io] Move Mono(Socket)RuntimeWorkItem ExecuteWorkItem code to (Socket)AsyncResult in managed 2015-04-20 16:15:07 +01:00
Ludovic Henry 52d761a1f6 [Socket] Use type specific read and write queue for SocketAsyncWorker 2015-04-09 15:46:18 +01:00
Ludovic Henry 333a93ab7b [Socket] Cleanup of SocketAsyncWorker, SocketAsyncResult and SocketAsyncEventArgs 2015-04-09 15:41:27 +01:00
Ludovic Henry c049a8b361 [Socket] Move Socket fields out of Socket_2_1.cs to Socket.cs 2015-04-08 19:13:18 +01:00
Ludovic Henry 0916f916f6 [Socket] Move SocketAsyncCall out of Socket_2_1.cs to SocketAsyncCallback.cs 2015-04-08 18:26:42 +01:00
Ludovic Henry 6c72a6e005 [Socket] Move Worker out of Socket_2_1.cs to SocketAsyncWorker.cs 2015-04-08 18:25:13 +01:00
Ludovic Henry 17df15ecb6 [Socket] Move SocketAsyncResult out of Socket_2_1.cs 2015-04-08 17:46:41 +01:00