19 Commits
Author SHA1 Message Date
Martin Baulig b61a3ffb02 [System]: Reenable native Apple Certificate support on WatchOS. (#11173)
During the code refactoring this summer, support for native apple certificates
has been dropped on watchOS.

* add `apple-certificates.sources` and move all certificate-related code from
  `appletls.sources`.

* move non-network related code from `MacProxy` into a new `AppleTypes`.

* add the `MONO_FEATURE_APPLE_X509` magic to `System/Makefile` where it was missing from.
2018-10-16 20:57:09 +02:00
Martin Baulig f9040e5fb3 Refactor the AppleTls Certificate code into a PAL-based approach. (#9524)
* Refactor the AppleTls Certificate code into a PAL-based approach.

* Added the internal `SafeHandle` based classes from CoreFX's PAL:
  `SafeSecCertificateHandle`, `SafeSecIdentityHandle`, `SafeKeychainItemHandle`
  and `SafeSecKeyRefHandle`.

* Added a new static internal class `MonoCertificatePal`:

  - `Mono.AppleTls/MonoCertificatePal.cs` is shared between OS X and Mobile.
  - `Mono.AppleTls/MonoCertificatePal.OSX.cs` contains the OS X specific parts.
  - `Mono.AppleTls/MonoCertificatePal.Mobile.cs` contains the Mobile specific parts.

  This split allows us to avoid all the `MONOTOUCH` conditionals in the code.

* In the `Mono.AppleTls` directory, all code from `Certificate.cs`, `Items.cs` and
  `ImportExport.cs` have all been merged into the new `MonoCertificatePal` class.

* The entire AppleTls code is now using these safe handles instead of the old
  Mono-specific types.  This allows us to swap out the implementation of the certificate
  code with CoreFX's PAL code.

* Cleaned up and removed some ancient dead code.

* `build/profiles/build.make`: Don't set `MONO_FEATURE_APPLETLS` here.

* Add `appletls.sources` and cleanup `MONO_FEATURE_APPLETLS` conditionals.

* [csproj] Update project files
2018-07-19 11:51:01 -04:00
iamphi 96a089ae5e Fix Automatic Proxy Configuration protocol for OSX 10.13 (#8227)
* Fix Automatic Proxy Configuration protocol for OSX 10.13

Reference comparison of kCFProxyTypeAutoConfigurationURL doesn't work in 10.13. Added fallback to do value/string comparison to get proxy type

* Change string comparison from C# string to CFString for possible memory safety and efficiency

* Code style changes
2018-04-17 22:34:00 -04:00
Rolf Bjarne Kvinge 3af24f31f3 [System] Use 'ObjCRuntimeInternal' as the namespace instead of 'ObjCRuntime'. (#4820)
Use 'ObjCRuntimeInternal' as the namespace instead of 'ObjCRuntime' to avoid
these compiler-warnings when building xamarin-macios assemblies (which defines
the same types in the ObjCRuntime namespace, and to whom System.dll has an
InternalsVisibleTo attribute):

> xamarin-macios/src/build/watch/watch/Foundation/NSExtensionRequestHandling.g.cs(28,49): warning CS0436: The type `ObjCRuntime.INativeObject' conflicts with the imported type of same name'. Ignoring the imported type definition
> xamarin-macios/src/ObjCRuntime/INativeObject.cs(6,19): (Location of the symbol related to previous warning)
> xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/lib/mono/Xamarin.WatchOS/repl/System.dll (Location of the symbol related to previous warning)
2017-05-10 16:52:01 +02:00
Martin Baulig d8ce8b81c3 [btls]: Cleanup certificate store initialization (#4683)
* [BTLS]: Cleanup certificate store initialization.

* Kill unused MonoBtlsX509Store.AddTrustedRoots().

* In server-mode, MonoBtlsProvider.SetupCertificateStore() now only adds
  certificates explicitly trused via MonoTlsSettings.TrustAnchors.

* MonoTlsProvider.ValidateCertificate() - which is called from
  X509Certificate2.Verify() via X509CertificateImplBtls.Verify() - now
  uses MonoTlsSettings.DefaultSettings and assumes client-mode.

* [appletls]: Actually use the new code that was added in PR #4671.

* [btls]: Add new MonoTlsSettings.CertificateValidationTime property.

This allows you to set a custom time for certificate expiration checks.

* [appletls]: Bind SecTrustSetVerifyDate() and check MonoTlsSettings.CertificateValidationTime.
2017-04-13 13:46:54 -04:00
Martin Baulig 1eb27c1df8 [appletls]: Use SecIdentityCreate() to avoid using the Mac keychain. (#4671)
* [appletls]: Use SecIdentityCreate() to avoid using the Mac keychain when we have a private key.

Reading Certificates from the Mac Keychain
==========================================

Reading the private key from the keychain is a new feature introduced with
AppleTls on XamMac and iOS. On Desktop Mono, this new feature has several
known issues and it also did not received any testing yet. We go back to the old
way of doing things, which is to explicitly provide an X509Certificate2 with a
private key.

Keychain Dialog Popups
======================

When using Xamarin.Mac or Xamarin.iOS, we try to search the keychain
for the certificate and private key.

On Xamarin.iOS, this is easy because each app has its own keychain.

On Xamarin.Mac, the .app package needs to be trusted via code-sign
to get permission to access the user's keychain. [FIXME: I still have to
research how to actually do that.] Without this, you will get a popup
message each time, asking you whether you want to allow the app to access
the keychain, but you can make these go away by selecting "Trust always".

On Desktop Mono, this is problematic because selecting "Trust always"
give the 'mono' binary (and thus everything you'll ever run with Mono)
permission to retrieve the private key from the keychain.

This code would also trigger constant keychain popup messages,
which could only be suppressed by granting full trust. It also makes it
impossible to run Mono in headless mode.

SecIdentityCreate
=================

To avoid these problems, we are currently using an undocumented API
called SecIdentityRef() to avoid using the Mac keychain whenever a
X509Certificate2 with a private key is used.

On iOS and XamMac, you can still provide the X509Certificate without
a private key - in this case, a keychain search will be performed (and you
may get a popup message on XamMac).
2017-04-11 17:43:51 -04:00
Martin Baulig 989aefce37 [appletls]: Make CFObject.dlsym() private and fix CFBoolean. (#4640)
This fixes a native crash when attempting to use appletls.
2017-04-04 14:28:17 -04:00
Chris Hamons 4d1e45d76a AppleTls Support (#4470) 2017-03-22 19:15:02 +01:00
Martin Baulig 8a38b0f7fa [System]: Change namespace for some internal classes.
(cherry picked from commit 997513da02)
2016-01-20 01:52:02 +01:00
Lluis Sanchez f5f69e540e [System.Net] Add support for .pac proxy config scripts on mac 2014-09-24 16:50:15 +02:00
Sebastien Pouliot 1355ca90df [System] Ensure pinvoke into OXS/iOS CFNetwork framework (for proxy support) are 64bits safe 2014-05-28 10:33:57 -04:00
Rolf Bjarne Kvinge 3c928782dd Don't call CFNetworkCopyProxiesForAutoConfigurationScript from more than one thread. Fixes #7923, comment 21. 2013-12-24 00:51:01 +01:00
Jeffrey Stedfast 450407d1c8 [MacProxy] Initialize err to IntPtr.Zero before calling CFNetworkCopyProxiesForAutoConfigurationScript 2013-09-26 12:27:12 -04:00
Rolf Bjarne Kvinge db195e8e90 [System.Net] Fix CFNetworkCopyProxiesForAutoConfigurationScript signature. Fixes #7923. 2013-09-20 10:33:49 +02:00
Jeffrey Stedfast 4e5ecefa68 Don't return a shared CFProxy instance 2012-12-03 13:59:11 -05:00
Jeffrey Stedfast ec3740aa80 Fixed MacOS proxy support for proxies requiring authentication 2012-12-03 12:23:55 -05:00
Jeffrey Stedfast 8187fda98f Added call to GC.SupressFinalize() in CFObject.Dispose() 2012-05-09 14:47:20 -04:00
Jeffrey Stedfast 544aae98c2 [MacProxy] Fixed refcounting and got rid of unneeded attribute flags 2012-05-09 10:45:09 -04:00
Jeffrey Stedfast 197498d047 [System.Net.WebRequest] Implemented new and improved proxy support on Mac/iOS 2012-05-08 18:31:05 -04:00