25 Commits
Author SHA1 Message Date
Marek Safar 02782f4a1a [system] System.Timer from reference sources 2015-01-15 10:05:50 +01:00
fengari b3251b6248 Do not dispose the underlying Timer every time the Enabled is set to false, keep it around for as long as this Timer exists. Throw ObjectDisposedException on Enabled setter. ArgumentException throwing according to docs. Removed 'disposed' field. DueTime for underlying timer changes only if enabled (as per docs). Check for already disposed in Dispose(). Not firing Elapsed if disposed. Unit tests. 2014-08-19 11:21:52 +03:00
Alex Rønne Petersen a571d29499 Improve my previous change a bit.
Checking the `disposing` argument is cleaner.
2013-11-09 02:52:20 +01:00
Alex Rønne Petersen 2d18195d17 Fix an NRE in System.Timers.Timer.Dispose ().
This would happen because _lock is nullified by the GC during
finalization. Dispose () calls Close () which sets the Enabled
property to false, which then attempts to lock on _lock.
2013-11-09 02:18:23 +01:00
Rodrigo Kumpera 5007c14d62 Kill the MOONLIGHT define in System. 2013-02-11 13:01:11 -05:00
Sebastien Pouliot 355a27b73d In System.Timers:
2010-03-19  Sebastien Pouliot  <[email protected]>

	* Timer.cs: Removed old NET_2_0 defines and added some new
	MOONLIGHT defines (needed for the client stack)

In System.Net:
2010-03-19  Sebastien Pouliot  <[email protected]>

	* AuthenticationManager.cs: Internal type for Moonlight.
	Add BasicClient, DigestClient, NtlmClient for NET_2_1 since
	this applies to both monotouch and moonlight (client stack).
	Removed unneeded NET_2_0 defines
	* CookieContainer.cs: For Moonlight it needs to be internal in 
	System.dll and public in System.Net.dll. Removed unneeded NET_2_0
	defines
	* HttpContinueDelegate.cs: Internal type for Moonlight.
	* HttpRequestCreator.cs: Remove a MOONLIGHT define
	* HttpStatusCode.cs: For Moonlight it needs to be internal in 
	System.dll and public in System.Net.dll
	* HttpWebRequest.cs: Internal type for Moonlight. Change S.Config
	to NET_2_1 defines (applies to both monotouch and moonlight).
	Removed unneeded NET_2_0 and NET_1_1 defines
	* HttpWebResponse.cs: Internal type for Moonlight. Removed 
	unneeded NET_2_0 defines
	* IAuthenticationModule.cs: Internal type for Moonlight.
	* ICertificatePolicy.cs: Internal type for Moonlight.
	* ICredentialPolicy.cs: Internal type for Moonlight. Removed 
	unneeded NET_2_0 defines
	* IWebRequestCreate.cs: For Moonlight it needs to be internal in 
	System.dll and public in System.Net.dll
	* ServicePoint.cs: Internal type for Moonlight. Change S.Config
	to NET_2_1 defines (applies to both monotouch and moonlight)
	* ServicePointManager.cs: Remove a MOONLIGHT define
	* WebException.cs: For Moonlight it needs to be internal in 
	System.dll and public in System.Net.dll. Removed unneeded NET_2_0
	defines
	* WebHeaderCollection.cs: Internal type for Moonlight. Removed 
	unneeded NET_2_0 defines
	* WebRequest.cs: Internal type for Moonlight. Change S.Config
	to NET_2_1 defines (applies to both monotouch and moonlight)
	* WebResponse.cs: Internal type for Moonlight. Removed unneeded
	NET_2_0 defines

In System.Net.Sockets:
2010-03-19  Sebastien Pouliot  <[email protected]>

	* Socket.cs: Remove some NET_2_0 defines (using) and add a few
	MOONLIGHT defines needed to reuse Socket in the client http stack
	* Socket_2_1.cs: Remove some MOONLIGHT defines
	* SocketAsyncEventArgs.cs: For Moonlight check policy if outside
	System.dll (the client stack use sockets with it's own web 
	xdomain policy)

In System:
2010-03-19  Sebastien Pouliot  <[email protected]>

	* Uri.cs: Remove some MOONLIGHT defines

In .:
2010-03-19  Sebastien Pouliot  <[email protected]>

	* moonlight_*_System.dll.sources: Bring extra types so we can
	build a full, managed, internal HTTP stack to be reused for SL3+
	* Makefile: Add a INSIDE_SYSTEM define when compiling System.dll
	to makes it possible to rebuild the same types in System.Net.dll


svn path=/trunk/mcs/; revision=153916
2010-03-19 19:01:31 +00:00
Sebastien Pouliot 57834310f0 2009-09-29 Sebastien Pouliot <[email protected]>
* Timer_2_1.cs: Removed. No longer needed by Moonlight


svn path=/trunk/mcs/; revision=142853
2009-09-29 12:11:55 +00:00
Sebastien Pouliot 4a5cb1bb74 2009-09-27 Sebastien Pouliot <[email protected]>
* Timer_2_1.cs: New. A smaller, internal subset of Timer for 
	Moonlight - needed for Socket.Close(int)


svn path=/trunk/mcs/; revision=142718
2009-09-27 14:37:43 +00:00
Gonzalo Paniagua Javier 200e529f19 2009-09-24 Gonzalo Paniagua Javier <[email protected]>
* Timer.cs: lock access to the 'timer' field. Attemp to fix bug
	#537921.


svn path=/trunk/mcs/; revision=142548
2009-09-24 05:10:22 +00:00
Paolo Molaro ed34912b86 Wed Sep 17 11:48:00 CEST 2008 Paolo Molaro <[email protected]>
* Timer.cs: rewritten to use Threading.Timer so it doesn't create a
	thread per timer and behaves better. Fixed also a few implementation
	bugs.


svn path=/trunk/mcs/; revision=113267
2008-09-17 09:49:24 +00:00
Jb Evain 7eb974a5cc 2008-07-17 Jb Evain <[email protected]>
* Timer.cs: Fix ArgumentException message.
	Patch by Paul Burton.


svn path=/trunk/mcs/; revision=108172
2008-07-17 19:34:47 +00:00
Robert Jordan 14904e434f In Test/System.Timers:
2007-10-30  Robert Jordan  <[email protected]>

	* TimerTest.cs: Enable test for bug #82701/#325368.

In System.Timers:
2007-10-30  Robert Jordan  <[email protected]>

	* Timer.cs (set_Enabled): Allow setting Enabled from within
	the Elapsed event handler. Fixes #325368.


svn path=/trunk/mcs/; revision=88437
2007-10-30 02:34:38 +00:00
Dick Porter d872700d75 2007-09-07 Dick Porter <[email protected]>
* Timer.cs: This calls Thread methods in the finalizer too, so use
	the same workaround as in r85425.



svn path=/trunk/mcs/; revision=85474
2007-09-07 13:27:23 +00:00
Gert Driesen ae5a5dd2e6 * Timer.cs: On 2.0 profile, only allow 32-bit interval in ctor.
svn path=/trunk/mcs/; revision=85357
2007-09-05 13:13:38 +00:00
Robert Jordan db6bf652fe 2006-12-19 Robert Jordan <[email protected]>
* Timer.cs: Apply the latest patch at attached to bug #77847.


svn path=/trunk/mcs/; revision=69727
2006-12-19 11:23:23 +00:00
Gonzalo Paniagua Javier fbe3212ca7 2006-12-19 Gonzalo Paniagua Javier <[email protected]>
* Timer.cs: Fixes race condition (bug #77847). Patch from Robert Jordan.


svn path=/trunk/mcs/; revision=69726
2006-12-19 10:40:55 +00:00
Robert Jordan 2d16546be9 2006-03-19 Robert Jordan <[email protected]>
* Timer.cs: Fix race condition of the wait handle object.
	Fixes bug #77847.


svn path=/trunk/mcs/; revision=69357
2006-12-11 20:11:41 +00:00
Sebastien Pouliot eeb2834d7b 2005-11-16 Sebastien Pouliot <[email protected]>
* TimersDescriptionAttribute.cs: Revert Description property fix 
	because it doesn't always returns null (exact conditions unknown).


svn path=/trunk/mcs/; revision=53123
2005-11-16 15:38:47 +00:00
Sebastien Pouliot 4b213fe79e 2005-11-16 Sebastien Pouliot <[email protected]>
* ElapsedEventHandler.cs: Remove [Serializable] from 2.0 profile.
	* Timer.cs: Add [Browsable(false)] to SynchronizingObject property for
	2.0 profile.
	* TimersDescriptionAttribute.cs: Description always returns null.


svn path=/trunk/mcs/; revision=53118
2005-11-16 14:26:14 +00:00
Kornél Pál 06fdd0f782 Fixed bug #75068
svn path=/trunk/mcs/; revision=45121
2005-05-27 18:30:19 +00:00
Duncan Mak 24f5ef2c44 Add MIT license to System.dll
svn path=/trunk/mcs/; revision=30054
2004-06-21 18:02:11 +00:00
Lluis Sanchez 1c38fe8835 * Timer.cs: The timer thread must be a background thread.
This fixes #58816.

svn path=/trunk/mcs/; revision=29594
2004-06-15 10:15:00 +00:00
Gonzalo Paniagua Javier ec3393747f 2004-05-11 Gonzalo Paniagua Javier <[email protected]>
* Timer.cs: if AutoReset, disable the timer before adding the callback
	to the ThreadPool. Patch by Tim Fries <[email protected]>. Fixes bug
	#57993.

svn path=/trunk/mcs/; revision=27114
2004-05-11 16:06:42 +00:00
Gonzalo Paniagua Javier 554d98db57 2003-03-17 Gonzalo Paniagua Javier <[email protected]>
* Timer.cs: Elapsed is an event. Added a few attributes.

svn path=/trunk/mcs/; revision=12620
2003-03-17 16:02:30 +00:00
Gonzalo Paniagua Javier 5d07543d21 2002-11-20 Gonzalo Paniagua Javier <[email protected]>
* ChangeLog:
	* ElapsedEventArgs.cs:
	* ElapsedEventHandler.cs:
	* Timer.cs:
	* TimersDescriptionAttribute.cs: New files.

	Don't use timers yet. If you do, your program will never end.

svn path=/trunk/mcs/; revision=9103
2002-11-20 02:14:56 +00:00