145 Commits
Author SHA1 Message Date
Alexander Köplinger 77cf4cc4f8 [tests] Remove MONOMAC ifdef from BCL tests (#13694)
It was set by xamarin-macios when they were still taking the raw .cs source files
but since we switched to prebuilt binaries we need to replace it with
some define we're actually setting in Mono.

Most cases can be replaced by just XAMMAC_4_5 since MOBILE is defined on the xammac profile.
2019-03-27 20:21:48 +01:00
Calvin Buckley a3be248d3f [corlib] Simplify RuntimeInformation by getting OS name from the runtime (#13164)
We can get the the OS name similar to the architecture from the value that is used by the runtime for DllMaps.

Cached the values into static fields so we only need to do the runtime icall once.

Added all the existing OS names recognized by DllMap to RuntimeInformation.
This also allows us to mark some corlib/System tests that hang the runtime on AIX as non-working.
2019-02-27 23:21:34 +01:00
Rolf Bjarne Kvinge 632bb59b21 [System] Implement a helper function to create unique temporary directories and use it in tests. (#11831)
While working on PR #11829 I stress-tested the tests by running multiple test
runs in parallel, and it turned out that many tests were not parallel-safe,
because they used the same temporary file names and ended up stomping on
eachother.

So I implemented a helper method that creates a guaranteed unique temporary
directory, and I've changed all tests to use this new helper method.
2018-12-04 16:43:23 +01:00
Jonathon Rossi 0cdb35fa47 Fix starting process with empty environment incorrectly inherits all variables (#11630)
This pull request fixes starting a process with an empty environment variable collection in `ProcessStartInfo`. As per the issue it fixes a regression that it used to work but currently an empty environment variable collection works like it was never touched.

I also made a minor fix to remove the `StringBuilder` because a simple `string.Concat` does the job without the `StringBuilder` allocation and overhead.

I've included unit tests. Please let me know if you'd like any changes.

Fixes #8766
2018-11-15 16:06:26 +01:00
Marek Safar e115d0c796 [corlib] Copying null references to value type array is not allowed 2018-05-14 14:38:30 +02:00
Zoltan Varga ada6edbad8 [bcl] Fix the compilation of System tests in the mobile profile. (#7882) 2018-03-28 19:57:41 +02:00
jaykrell 0f9b7f730f mono_perfcounter_counter_names returns incorrect names, and restructure slightly for clarity (#6355)
* Add some PerformanceCounter test code from reference source and MSDN,
combined and lightly edited per local conventions.

* Restructure PerformanceCounter code for type safety and fix incorrect typing.
2018-03-28 11:52:11 +02:00
Alexis Christoforides 401ed4d16c [System.Process] Consider open's exit code when using it to start a process. Fixes #19503 (#6010) 2017-11-15 13:53:00 -05:00
Alexander Köplinger b3e3e4cc40 [System] Don't use DateTime.Now for measuring elapsed time
Use Stopwatch or DateTime.UtcNow instead which aren't affected
by things like daylight-saving time
2017-07-02 23:31:34 +02:00
Ludovic Henry b0289fe19c [process] Disable tests that do not work on mobile (#4598) 2017-05-10 14:53:03 -04:00
Rodrigo Kumpera 3a49748b76 [System] Disable test that is too unreliable. 2017-04-05 14:18:26 -07:00
Rodrigo Kumpera 1fb2ab2244 [System] Disable a few tests that don't work on Android. 2017-04-05 14:18:26 -07:00
Rodrigo Kumpera ddcd1adb73 [System] Disable test that doesn't work on Android. 2017-04-05 14:18:26 -07:00
Marek Safar 4d5f823b0f [System] Fix Process tests on watch 2017-03-20 23:57:31 +01:00
Ludovic Henry f8f323d671 [Process] Fix NonChildProcessWaitForExit Exited callback (#4409) 2017-02-21 18:42:42 -05:00
Ludovic Henry f18e9a35e7 [ProcessTest] Ensure we enable raising Exited event (#4397) 2017-02-17 09:23:39 -05:00
Ludovic Henry b6f511dc16 [process] Allocate a handle even for non-child processes (#4393) 2017-02-16 13:10:33 -05:00
Ludovic Henry ecf2510108 [process] Improve error message for inaccessible process (#4354)
Fixes bug https://bugzilla.xamarin.com/show_bug.cgi?id=51561
2017-02-09 14:57:59 -05:00
Ludovic Henry 41fced547f [process] Fix Process.GetProcessesByName (#4351)
To get a process by name, we need to access the other process ProcessName, but it can fails on non-win32 platforms. This failure wouldn't be caught in the referencesource implementation trigerring this bug.

The exception we would observe would be:
 Unhandled Exception:
 System.InvalidOperationException: Process has exited, so the requested information is not available.
   at System.Diagnostics.Process.get_ProcessName () [0x0002d] in /Users/alexander/dev/mono/mcs/class/System/System.Diagnostics/Process.cs:336
   at (wrapper remoting-invoke-with-check) System.Diagnostics.Process:get_ProcessName ()
   at Program.Main (System.String[] args) [0x0003b] in <9c838a66cdc44c81b38c974edcc9c029>:0
 [ERROR] FATAL UNHANDLED EXCEPTION: System.InvalidOperationException: Process has exited, so the requested information is not available.
   at System.Diagnostics.Process.get_ProcessName () [0x0002d] in /Users/alexander/dev/mono/mcs/class/System/System.Diagnostics/Process.cs:336
   at (wrapper remoting-invoke-with-check) System.Diagnostics.Process:get_ProcessName ()
   at Program.Main (System.String[] args) [0x0003b] in <9c838a66cdc44c81b38c974edcc9c029>:0

Fixes bug https://bugzilla.xamarin.com/show_bug.cgi?id=52345
2017-02-08 22:29:03 -05:00
Alexander Köplinger d61e7aca9a [bcl] Update tests that failed when .cs file contained CRLF
Most of them used multiline C# string literals which
means they contained the line ending character of the file.
Updated to make the tests resilient to having CRLF instead of LF.

Some of the mcs tests used a checksum to compare files,
ensured those are checked out using LF.
2017-01-28 02:25:55 +01:00
Chris Hamons bb0564ff3c Mono BCL test fixes so XM can run them (#4210) 2017-01-10 16:59:08 -06:00
Alexander Köplinger 9f5b8c4cf2 Rename the mobile_static profile to aot_only
We decided it's a better name since we're using the profile to
test FullAOT scenarios on desktop (as opposed to the mobile profiles).

While doing the rename I saw that a lot of the #ifdefs were using
MOBILE_STATIC even though the code should actually be included/excluded
in all FullAOT scenarios, e.g. System.Reflection.Emit. I replaced those
cases with FULL_AOT_RUNTIME instead.

For cases where code is specific to this profile, I added a new
AOT_ONLY_DESKTOP define.
2016-11-24 17:40:54 +01:00
Marcos Henrich 863dc73d19 [bcl] Add NUnitHelper.cs with API not in nunit-lite
NUnitHelper.cs adds CollectionAssert, FileAssert, StringAssert.

Also adds AssertHelper class with methods that are not part of nunitlite
Assert class.
2016-10-29 14:09:33 +02:00
Alexander Köplinger df39947352 Merge pull request #3578 from henricm/fix-win-process-test
Fixes for ProcessTest on Windows
2016-09-20 11:12:01 +02:00
Alexander Köplinger 443b755fbc Add link to Bugzilla ticket for unifying the behavior between .NET and Mono 2016-09-20 11:11:46 +02:00
Henric Müller ce1993f362 Fixes for ProcessTest on Windows
* Checking more error codes on whitespace tests.
* Using findstr instead of type to enable stdin/out pipes.
2016-09-19 16:28:30 +02:00
Henric Müller 8fd49882a5 Ignoring case for MachineName in EventLogTest 2016-09-08 14:57:44 +02:00
Ludovic Henry 8afaa90625 [process] Fix Process.Exited event triggered too early
The Process.Exited event would be triggered too early, leading to crash in code using this event to access the process exit code. This is because in Process.ExitCode, we first check that the process has really exited.
2016-08-04 18:59:50 +02:00
Alexander Kyte 540e26a05b [mobile_static] Add MOBILE_STATIC to preprocessor guard 2016-07-02 21:33:06 -04:00
Ludovic Henry e19a2e2c40 [Process] Fix System.Diagnostics.ProcessTest.StandardInputWrite
The child process would simpky execute ls, then exiting right away. Writing to its stdin would then crash with "EPIPE: An attempt is made to write to a pipe that is not open for reading by any process." as the child process exited.
2016-04-24 16:04:46 -04:00
Ludovic Henry 00b5517dd3 [System] Import System.Diagnostics.Process 2016-02-16 20:11:58 +00:00
Ludovic Henry f74f703719 Revert "[System] Import System.Diagnostics.Process"
This reverts commit d30e99d172.
2016-02-12 18:14:02 +00:00
Ludovic Henry d30e99d172 [System] Import System.Diagnostics.Process 2016-02-12 13:56:38 +00:00
Bernhard Urban d022f26e2e [bcl] fix compilation of test on mobile
fix for the following problem:
> [13:33:37] src/System/Test/System.Diagnostics/ProcessTest.cs(1048,19): error CS0103: The name `GetCrossPlatformStartInfo' does not exist in the current context
2016-02-09 15:07:19 -08:00
Ludovic Henry 47d80e598b [Process] Fix possible double call to Begin(Output|Error)ReadLine
This is not allowed in .NET, as it could lead to unexpected results.
2016-02-04 14:30:25 +00:00
Alexander Köplinger b03e606287 Remove ChangeLog files from the repo
They weren't updated in the last 6 years and aren't helpful anymore (e.g. by causing unrelated matches during git grep searches).
2016-01-29 19:17:06 +01:00
Marek Safar f105ad2620 [System] Fixes Process::WaitForExit to honour EnableRaisingEvents setting 2016-01-04 18:45:31 +01:00
Rolf Bjarne Kvinge 828d7d782b [System] Remove Process.Start and related API from TvOS/WatchOS. 2015-11-25 12:55:58 +01:00
Marek Safar 70a295d1fe [system] Add a workaround for redirected StandardInput writes. Fixes #32905 2015-08-19 14:13:03 +02:00
Alexander Köplinger 2f36c4bdcc [System] Fix a race in two ProcessTest tests
The tests sometimes failed in CI, due to a race condition between
the Exited event and our assertion of whether it was called.
2015-08-01 01:33:04 +02:00
Marek Habersack 389c66409b [tests] Use correct path in process tests
/bin/ls doesn't exist on Android, it's /system/bin/ls
2015-07-15 20:45:20 +02:00
Zoltan Varga dd66efe5bd Fix the compilation of the System tests. 2015-06-25 16:04:24 -04:00
Marek Safar 4f4b324aa2 [system] Disable external process redirect test on mobile 2015-06-25 15:58:35 +02:00
Marcos Henrich dfa1ecaff7 [System] Made ProcessTest.Modules more verbose.
When Process.Modules fails it will now print the list of assemblies it
looked into.
2015-06-12 12:31:45 +01:00
Marcos Henrich 33a3716af6 [System] Test ProcessModule managed assemblies. 2015-06-08 14:04:10 +01:00
Marek Safar 3c47caca34 [system] Don't dispose exposed redirected streams. Fixes #30868 2015-06-08 13:29:19 +02:00
Zoltan Varga 202b55be9b [System] Disable a test on mobile. 2015-05-26 10:48:06 -04:00
Alexander Kyte cb47efb688 [runtime] Remove a test that leads to excessive heap thrashing and interferes with other tests. 2015-05-20 04:16:44 +00:00
Marcos Henrich e097a98f3b Merge pull request #1691 from esdrubal/exitevent
Improved Process.Exited
2015-04-20 15:04:32 +01:00
Marcos Henrich 287ba33275 [System] Test that Process.WaitForExit triggers the event Exited. 2015-04-08 14:42:03 +01:00