62 Commits
Author SHA1 Message Date
Calvin Buckley a3be248d3f [corlib] Simplify RuntimeInformation by getting OS name from the runtime (#13164)
We can get the the OS name similar to the architecture from the value that is used by the runtime for DllMaps.

Cached the values into static fields so we only need to do the runtime icall once.

Added all the existing OS names recognized by DllMap to RuntimeInformation.
This also allows us to mark some corlib/System tests that hang the runtime on AIX as non-working.
2019-02-27 23:21:34 +01:00
Jonathon Rossi 0cdb35fa47 Fix starting process with empty environment incorrectly inherits all variables (#11630)
This pull request fixes starting a process with an empty environment variable collection in `ProcessStartInfo`. As per the issue it fixes a regression that it used to work but currently an empty environment variable collection works like it was never touched.

I also made a minor fix to remove the `StringBuilder` because a simple `string.Concat` does the job without the `StringBuilder` allocation and overhead.

I've included unit tests. Please let me know if you'd like any changes.

Fixes #8766
2018-11-15 16:06:26 +01:00
Alexis Christoforides 401ed4d16c [System.Process] Consider open's exit code when using it to start a process. Fixes #19503 (#6010) 2017-11-15 13:53:00 -05:00
Alexander Köplinger b3e3e4cc40 [System] Don't use DateTime.Now for measuring elapsed time
Use Stopwatch or DateTime.UtcNow instead which aren't affected
by things like daylight-saving time
2017-07-02 23:31:34 +02:00
Ludovic Henry b0289fe19c [process] Disable tests that do not work on mobile (#4598) 2017-05-10 14:53:03 -04:00
Rodrigo Kumpera 3a49748b76 [System] Disable test that is too unreliable. 2017-04-05 14:18:26 -07:00
Rodrigo Kumpera 1fb2ab2244 [System] Disable a few tests that don't work on Android. 2017-04-05 14:18:26 -07:00
Rodrigo Kumpera ddcd1adb73 [System] Disable test that doesn't work on Android. 2017-04-05 14:18:26 -07:00
Marek Safar 4d5f823b0f [System] Fix Process tests on watch 2017-03-20 23:57:31 +01:00
Ludovic Henry f8f323d671 [Process] Fix NonChildProcessWaitForExit Exited callback (#4409) 2017-02-21 18:42:42 -05:00
Ludovic Henry f18e9a35e7 [ProcessTest] Ensure we enable raising Exited event (#4397) 2017-02-17 09:23:39 -05:00
Ludovic Henry b6f511dc16 [process] Allocate a handle even for non-child processes (#4393) 2017-02-16 13:10:33 -05:00
Ludovic Henry ecf2510108 [process] Improve error message for inaccessible process (#4354)
Fixes bug https://bugzilla.xamarin.com/show_bug.cgi?id=51561
2017-02-09 14:57:59 -05:00
Ludovic Henry 41fced547f [process] Fix Process.GetProcessesByName (#4351)
To get a process by name, we need to access the other process ProcessName, but it can fails on non-win32 platforms. This failure wouldn't be caught in the referencesource implementation trigerring this bug.

The exception we would observe would be:
 Unhandled Exception:
 System.InvalidOperationException: Process has exited, so the requested information is not available.
   at System.Diagnostics.Process.get_ProcessName () [0x0002d] in /Users/alexander/dev/mono/mcs/class/System/System.Diagnostics/Process.cs:336
   at (wrapper remoting-invoke-with-check) System.Diagnostics.Process:get_ProcessName ()
   at Program.Main (System.String[] args) [0x0003b] in <9c838a66cdc44c81b38c974edcc9c029>:0
 [ERROR] FATAL UNHANDLED EXCEPTION: System.InvalidOperationException: Process has exited, so the requested information is not available.
   at System.Diagnostics.Process.get_ProcessName () [0x0002d] in /Users/alexander/dev/mono/mcs/class/System/System.Diagnostics/Process.cs:336
   at (wrapper remoting-invoke-with-check) System.Diagnostics.Process:get_ProcessName ()
   at Program.Main (System.String[] args) [0x0003b] in <9c838a66cdc44c81b38c974edcc9c029>:0

Fixes bug https://bugzilla.xamarin.com/show_bug.cgi?id=52345
2017-02-08 22:29:03 -05:00
Alexander Köplinger 443b755fbc Add link to Bugzilla ticket for unifying the behavior between .NET and Mono 2016-09-20 11:11:46 +02:00
Henric Müller ce1993f362 Fixes for ProcessTest on Windows
* Checking more error codes on whitespace tests.
* Using findstr instead of type to enable stdin/out pipes.
2016-09-19 16:28:30 +02:00
Ludovic Henry 8afaa90625 [process] Fix Process.Exited event triggered too early
The Process.Exited event would be triggered too early, leading to crash in code using this event to access the process exit code. This is because in Process.ExitCode, we first check that the process has really exited.
2016-08-04 18:59:50 +02:00
Ludovic Henry e19a2e2c40 [Process] Fix System.Diagnostics.ProcessTest.StandardInputWrite
The child process would simpky execute ls, then exiting right away. Writing to its stdin would then crash with "EPIPE: An attempt is made to write to a pipe that is not open for reading by any process." as the child process exited.
2016-04-24 16:04:46 -04:00
Ludovic Henry 00b5517dd3 [System] Import System.Diagnostics.Process 2016-02-16 20:11:58 +00:00
Ludovic Henry f74f703719 Revert "[System] Import System.Diagnostics.Process"
This reverts commit d30e99d172.
2016-02-12 18:14:02 +00:00
Ludovic Henry d30e99d172 [System] Import System.Diagnostics.Process 2016-02-12 13:56:38 +00:00
Bernhard Urban d022f26e2e [bcl] fix compilation of test on mobile
fix for the following problem:
> [13:33:37] src/System/Test/System.Diagnostics/ProcessTest.cs(1048,19): error CS0103: The name `GetCrossPlatformStartInfo' does not exist in the current context
2016-02-09 15:07:19 -08:00
Ludovic Henry 47d80e598b [Process] Fix possible double call to Begin(Output|Error)ReadLine
This is not allowed in .NET, as it could lead to unexpected results.
2016-02-04 14:30:25 +00:00
Marek Safar f105ad2620 [System] Fixes Process::WaitForExit to honour EnableRaisingEvents setting 2016-01-04 18:45:31 +01:00
Rolf Bjarne Kvinge 828d7d782b [System] Remove Process.Start and related API from TvOS/WatchOS. 2015-11-25 12:55:58 +01:00
Marek Safar 70a295d1fe [system] Add a workaround for redirected StandardInput writes. Fixes #32905 2015-08-19 14:13:03 +02:00
Alexander Köplinger 2f36c4bdcc [System] Fix a race in two ProcessTest tests
The tests sometimes failed in CI, due to a race condition between
the Exited event and our assertion of whether it was called.
2015-08-01 01:33:04 +02:00
Marek Habersack 389c66409b [tests] Use correct path in process tests
/bin/ls doesn't exist on Android, it's /system/bin/ls
2015-07-15 20:45:20 +02:00
Zoltan Varga dd66efe5bd Fix the compilation of the System tests. 2015-06-25 16:04:24 -04:00
Marek Safar 4f4b324aa2 [system] Disable external process redirect test on mobile 2015-06-25 15:58:35 +02:00
Marcos Henrich dfa1ecaff7 [System] Made ProcessTest.Modules more verbose.
When Process.Modules fails it will now print the list of assemblies it
looked into.
2015-06-12 12:31:45 +01:00
Marcos Henrich 33a3716af6 [System] Test ProcessModule managed assemblies. 2015-06-08 14:04:10 +01:00
Marek Safar 3c47caca34 [system] Don't dispose exposed redirected streams. Fixes #30868 2015-06-08 13:29:19 +02:00
Zoltan Varga 202b55be9b [System] Disable a test on mobile. 2015-05-26 10:48:06 -04:00
Alexander Kyte cb47efb688 [runtime] Remove a test that leads to excessive heap thrashing and interferes with other tests. 2015-05-20 04:16:44 +00:00
Marcos Henrich e097a98f3b Merge pull request #1691 from esdrubal/exitevent
Improved Process.Exited
2015-04-20 15:04:32 +01:00
Marcos Henrich 287ba33275 [System] Test that Process.WaitForExit triggers the event Exited. 2015-04-08 14:42:03 +01:00
Marcos Henrich f9b1cff021 [System] Test Process.Exited. Covers #26362.
Process.Exited should not be called if Process.HasExited is false.
2015-04-08 14:35:01 +01:00
Marcos Henrich 5f8489c59a [System] Test StartTime of processes returned by GetProcesses.
Covers #26363.
2015-03-16 11:44:28 +00:00
Alexander Köplinger 746650d1b9 [bcl] Remove more NET_2_0 checks from class libs 2015-01-17 05:45:39 +01:00
Zoltan Varga b103884634 [runtime] Avoid Process.GetCurrentProcess ().HasExited asserting. Fixes #25720. 2015-01-08 04:47:55 -05:00
Miguel de Icaza c6ab899595 [System] Fix most warnings on the System test suite 2014-09-24 10:43:46 -04:00
Rodrigo Kumpera 1531d4f34d [System] Throw IOE in more cases when dealing with an invalid Process object. Fixes #19864 2014-05-16 16:30:56 -04:00
Alexander Köplinger b0032294da [Test] Cleaned up how a bunch of tests were ignored
Previously, many tests just had a return statement when the test shouldn't
be executed (e.g. Unix-only). This made it look like the test was successful
when in fact it wasn't executed at all.
Assert.Ignore() is now used instead to correctly exclude those tests.
2014-02-23 19:44:21 +01:00
Zoltan Varga c94730c32f Disable some System tests which are expected to fail in the mobile profile. 2013-04-11 16:37:02 +02:00
Marek Safar aff6d0592c Mobile tests update 2013-02-26 17:17:22 +01:00
Marek Safar f0ad346fb6 Mobile tests update 2013-02-22 21:41:19 +01:00
Zoltan Varga 1c65751376 Call BeginErrorReadLine()/BeginOutputReadLine() in a Process test so it runs on windows too. 2010-08-09 19:43:38 +02:00
Zoltan Varga 2072ecbf4f Avoid printing the output of /bin/ls in a Process test. 2010-08-09 18:29:01 +02:00
Andrés G. Aragoneses 5bb70a1030 * Test/System.Diagnostics/ProcessTest.cs: New tests for bug 477943.
* System.Diagnostics/Process.cs: Throw IOEs instead of normal
exceptions. Fixes bug 477943.

svn path=/trunk/mcs/; revision=127932
2009-02-25 02:28:14 +00:00