26 Commits
Author SHA1 Message Date
Alexander Köplinger d457346e06 [tests] Bump corefx to get Azure testhost change (#17275)
* Bump corefx to get Azure testhost change

See https://github.com/mono/corefx/pull/360

* Update ClientWebSocketTest as well
2019-10-11 09:34:28 +02:00
Rolf Bjarne Kvinge c93db5b047 [System] Refactor tests to use system-assigned ports whenever possible. (#11829)
Refactor tests to use system-assigned ports whenever possible, so that we
avoid the potential race condition in NetworkHelpers.FindFreePort.

This should make it much less probable to run into spurious "Address already
in use" exceptions.

In some cases I kept the call to NetworkHelpers.FindFreePort:

* When the test is not binding/listening on a port, but instead trying to
  connect to an inexistent port (for tests that verifies error handling /
  exceptions). In this case there is still a race condition (if a test tries
  to verify that a connection fails, it may unexpectedly succeed instead).

* Sometimes the test doesn't actually use the port (the test is verifying
  something very different, for instance a ArgumentNullExceptions, which are
  thrown before the port is used).

* Some API doesn't allow for requesting a system assigned port:

    * HttpListener: in this case I elected to re-try a few times in case of
      "Address already in use" exceptions.

    * The 'UdpClient (string, port)' constructor (other constructors work
      fine): these turned out a bit complicated to work around (or would
      modify the test more than would be reasonable), so for these we still
      have to hope for the best.

Hopefully fixes https://github.com/xamarin/maccore/issues/604.
2018-11-29 14:02:07 +01:00
Marek Safar dba0a9c566 [System] WebSockets from corefx 2017-03-30 13:24:56 +02:00
Marek Safar a5f5ca7e4b [System] Update flaky test 2017-02-23 11:08:14 +01:00
Alexander Köplinger ed685e8b76 [System] Fix failing ClientWebSocket test
The wrong part of the ifdef was deleted in a4df7d4923,
we need to InvalidOperationException instead of PNSE.
2017-02-16 02:58:43 +01:00
Marek Safar a4df7d4923 [System] Fixes failing tests on mobile 2017-02-16 00:04:19 +01:00
Marek Safar aad8adc02d [System] Fixes failing tests on watch 2017-02-13 12:50:12 +01:00
Marek Safar 27537cb676 [System] Update ClientWebSocket test to use Setup 2016-11-29 11:44:37 +01:00
Rolf Bjarne Kvinge e6536dd5e1 [System*] Throw a PlatformNotSupported exception when using the networking stack on watchOS. (#3606)
* [System] Fix line endings for a few files.

Best reviewed by not showing whitespace changes (should be empty diff in that case).

* [System] Fix potential crash in CookieParserTests.

Socket.EndAccept can throw an exception, which will crash the process if it
happens on a threadpool. So handle any exceptions when calling
Socket.EndAccept, and propagate those exceptions out of any threadpool code.

* [System.Net.Http] Throw a PlatformNotSupported exception when using HttpClientHandler on watchOS.

* [System.Net.Http] Tweak tests after watchOS API change.

Unfortunately the [ExpectedException] attribute can't be put on an entire
class, so remove the [Category ("RequiresBSDSockets")] attribute on the class
and instead decorate each test with an [ExpectedException] attribute.

* [System] Extract the HttpListenerResponseHelper class to a separate file.

Extract the HttpListenerResponseHelper class to a separate file so that it's
easier to replace the HttpListenerResponse implementation by using a different
file.

* [System] Throw a PlatformNotSupported exception when using the networking stack on watchOS.

* [System] Tweak tests after watchOS API changes.

Unfortunately the [ExpectedException] attribute can't be put on an entire
class, so remove the [Category ("RequiresBSDSockets")] attribute on the class
and instead decorate each test with an [ExpectedException] attribute.

* [System] Fix potential crash in SocketAcceptAsyncTest.

Fix potential crash in SocketAcceptAsyncTest by catching any exceptions in
code executed on the threadpool so that we never end up with unhandled
exceptions (which may terminate the process).

* [System] Avoid logic in SetUp attributes in tests.

Any type of exception in [SetUp] attributes causes all tests to fail with that
exception.

This even happens for tests that do not need the logic in the [SetUp]
attribute.

So rewrite tests a bit to not use [SetUp] when we can reasonably avoid it, and
instead instantiate class-level variables on first use. This ensures that any
exceptions that occur when initializing those variables are attributed to the
corresponding test, and not all of them.

* [System] Make exception handler (for test) catch more exceptions to avoid unhandled exceptions causing process termination.

* [System] Remove Obsolete attribute on API that throws PNSE.
2016-09-27 13:13:38 +02:00
Alexander Köplinger c4a5b6b5c3 [mcs] Remove NET_4_5 ifdef from the source files
It is always set in all profiles that we support so we can remove it.
2016-08-23 15:15:51 +02:00
Alexander Köplinger 0ba6902034 [System] Replace websocket echo test server with corefx one (#2902)
echo.websocket.org is down since yesterday. Let's use the one that corefx uses for now.
2016-04-16 21:33:24 -04:00
Marek Safar ac2c41ea09 [system] Keep excluded socket mobile tests in sync 2015-08-17 18:46:45 +02:00
Marek Habersack 405e9df234 [tests] Disable for Android
The tests work fine if only this fixture is ran, they fail when ran as part
of the entire test suite.
2015-07-15 20:45:25 +02:00
Marek Habersack 8948d49fec [tests] The test hangs on Android 2015-07-15 20:45:22 +02:00
Jo Shields 85c7025f9d Add port randomization to ClientWebSocketTest and HttpListenerTest
These two are consistently failing due to port re-use. Other hard-coded
ports exist, but let's target the *known* issues primarily, and can
handle the others ad-hoc if they demonstrate that they're problematic.
2015-03-23 14:42:16 +00:00
Rolf Bjarne Kvinge 1314cf9b87 Revert "[System] Ignore two tests which are failing due to external factors changing."
This reverts commit 597183658e.

According to the comments on the commit [1], this has already been fixed.

[1] https://github.com/mono/mono/commit/597183658e04260ba493495bcff2da28222b48b8
2014-11-25 09:38:06 +01:00
Rolf Bjarne Kvinge 597183658e [System] Ignore two tests which are failing due to external factors changing.
See https://bugzilla.xamarin.com/show_bug.cgi?id=24340
2014-11-14 00:31:16 +01:00
Alexander Köplinger 0442cdbc19 [System] Fixed formatting of new ClientWebSocket test and disabled it
We need to have an implementation for HttpListenerContext.AcceptWebSocketAsync () first before it works.
2014-11-07 20:16:51 +01:00
Alexander Köplinger 59d2397abc Merge branch 'patch-1' of https://github.com/ReubenBond/mono into ReubenBond-patch-1 2014-11-07 20:14:29 +01:00
Miguel de Icaza c6ab899595 [System] Fix most warnings on the System test suite 2014-09-24 10:43:46 -04:00
Reuben Bond eeac252404 Test ClientWebSocket.SendAsync EndOfMessage 2014-06-21 14:57:56 +10:00
Marek Safar f93fa0d582 Fix tests not to hang on failure 2014-05-23 11:15:37 +02:00
Sebastien Pouliot bc0900537c [System] Enable WebSockets on the mobile profile. Update related unit tests to run on mobile (and fix one to build with NUnitlite) 2014-02-21 13:41:57 -05:00
Sebastien Pouliot f9bbb7c58b Disable ClientWebSocketTest.cs (for mobile) until the type itself is added to the mobile profile (i.e. added to mobile_System.dll.sources). Fix building/running System.dll unit tests 2013-10-23 08:22:25 -04:00
Rodrigo Kumpera 3153dec190 Fix this test to work on 2.0. 2013-10-22 13:12:05 -04:00
Jérémie Laval 036ed3cc63 [System] Implement a first pass of ClientWebSocket. 2013-07-29 00:47:12 -04:00