Stephen Toub
00b0170bdc
Fix StyleCop rule SA1129 ("Do not use default value type constructor") ( #42531 )
...
Signed-off-by: dotnet-bot <[email protected] >
2019-11-15 13:29:04 +01:00
Stephen Toub
8b86349c2c
Disable another static analysis rule ( dotnet/corefx#42265 )
...
Signed-off-by: dotnet-bot <[email protected] >
2019-10-31 22:23:35 +01:00
Stephen Toub
a27aa7afd0
Update analyzer versions ( dotnet/corefx#42249 )
...
* Update analyzer packages to latest NuGet versions
* Fix new warnings
Signed-off-by: dotnet-bot <[email protected] >
2019-10-31 11:09:58 +01:00
Stephen Toub
036ab58b42
Fix several recently added StyleCop tuple rules ( dotnet/corefx#40794 )
...
Signed-off-by: dotnet-bot <[email protected] >
2019-09-04 11:15:23 +02:00
Dotnet-GitSync-Bot
dcb90fa1c0
Mirror changes from mono/coreclr,corefx ( #16654 )
...
* Refactor BinaryReader.ReadChars using Span (dotnet/coreclr#26325)
Avoids unsafe code and makes the code simpler
Signed-off-by: dotnet-bot <[email protected] >
* Remove unnecessary parens from `return (true);` and `return (false);` (#26488 )
Just a search and replace.
Signed-off-by: dotnet-bot <[email protected] >
* Avoid some unnecessary initialization in DateTimeParse (#26487 )
Signed-off-by: dotnet-bot <[email protected] >
* Update analyzer versions (dotnet/corefx#40778 )
In particular to pick up StyleCop fixes related to C# 8 and nullability.
Signed-off-by: dotnet-bot <[email protected] >
2019-09-04 00:20:35 -04:00
Stephen Toub
a86fb8c847
Fix StyleCop warning SA1001 (spaces around commas)
...
Signed-off-by: dotnet-bot <[email protected] >
2019-08-26 13:56:53 +02:00
madmir
4dd016004b
Re-enable xunit warning 1019 ( dotnet/corefx#40415 )
...
Make MemberData reference IEnumerable<object[]>
Signed-off-by: dotnet-bot <[email protected] >
2019-08-20 19:45:30 +02:00
Stephen Toub
0814b9de4d
Enable StyleCop rules 1205, 1411, 1026, and 1000 ( dotnet/corefx#40254 )
...
* Fix StyleCop warning SA1411 (attribute ctor shouldn't use unnecessary parens)
* Fix StyleCop warning SA1026 (new[] spacing)
* Fix StyleCop warning SA1000 (consistent spacing around if, for, switch, etc.)
* Fix StyleCop warning SA1205 (partial elements should declare an access modifier)
Signed-off-by: dotnet-bot <[email protected] >
2019-08-13 21:35:04 +02:00
Stephen Toub
b25395bde3
Re-enable StyleCop warning SA1400 (elements should specify access) ( #40240 )
...
One of the more common things we "nit" in PRs. Now the compiler will flag it for us.
Signed-off-by: dotnet-bot <[email protected] >
2019-08-12 19:46:54 +02:00
Stephen Toub
67a89b3a6f
Move CodeAnalysis.ruleset to shared ( dotnet/corefx#40153 )
...
So that the same settings can be applied to corelib.
Signed-off-by: dotnet-bot <[email protected] >
2019-08-09 12:30:05 +02:00