* NameObjectCollectionBase.cs: Add argument checking in CopyTo,
replace use of enumerator by for-loop. Check IsReadOnly in BaseSet()
only on the 2.0 profile.
2008-01-07 Gert Driesen <[email protected]>
* NameObjectCollectionBaseTest.cs: Add tests for argument checking in
GetObjectData, Add, Clear, Remove, RemoveAt, Set and CopyTo.
svn path=/trunk/mcs/; revision=92428
* StringDictionary.cs: Fixed line endings. Set eol-style to CRLF.
* StringEnumerator.cs: Set eol-style to CRLF.
* OrderDictionary.cs: Set eol-style to CRLF.
svn path=/trunk/mcs/; revision=66172
not be virtual.
* SortedList.cs: Count property, indexer and Clear method should not
be virtual. Removed unnecessary explicit interface implementation of
Add (TKey, TValue) and Remove (TKey, TValue).
* Queue.cs: Marked Enumerator as Serializable.
* Stack.cs: Marked Stack <T> and Enumerator as serializable.
svn path=/trunk/mcs/; revision=66168
* Uri.cs: Pragma disable warning 612 (Obsolete methods are being
used by us internally).
Ponder: should we instead move our methods to use new versions of
the Obsoleted ones?
2006-03-11 Miguel de Icaza <[email protected]>
* CodeNamespaceImportCollection.cs: It turns out that a lot of the
errors flagged with "!" were just missing explicit interface
implementations.
Implement.
2006-03-11 Miguel de Icaza <[email protected]>
* CodeDomConfigurationHandler.cs: Comment out unused methods.
* TempFileCollection.cs: Implement explicitly some interface
methods to get rid of the "!" errors on CorCompare.
2006-03-11 Miguel de Icaza <[email protected]>
* Queue.cs: Flag as serializable.
* LinkedList.cs (OnDeserialization): Fix signature.
* SortedList.cs: Implement explicitly a few methods that were
flagged by corcompare.
2006-03-11 Miguel de Icaza <[email protected]>
* IOrderedDictionary.cs: Flag GetEnumerator as a "new" method to
avoid warning.
2006-03-11 Miguel de Icaza <[email protected]>
* ConfigurationSettings.cs (ChangeConfigurationSettings): Make
internal to avoid warnings. This routine is called from
System.Web with MethodInfo.Invoke.
2006-03-11 Miguel de Icaza <[email protected]>
* DeflateStream.cs: Comment out DllImport that was not being
used.
2006-03-11 Miguel de Icaza <[email protected]>
* y
* SerialPort.cs: Remove unused variable (writeBuffer).
* SerialPortStream.cs (Dispose): override, not new.
2006-03-11 Miguel de Icaza <[email protected]>
* WebClient.cs: Only expose the right methods to avoid warnings.
* FtpDataStream.cs (Dispose): Fix signature.
* FtpWebResponse.cs: Comment out keepAlive field (unused, sounds
like we are missing features here).
* IPAddress.cs: Move m_HashCode property to the end, and set
pragmas to disable warnings.
2006-03-11 Miguel de Icaza <[email protected]>
* MailAddress.cs: Comment out unused field to remove warning.
2006-03-11 Miguel de Icaza <[email protected]>
* NetworkChange.cs: Use pragmas to eliminate warnings from events
that we do not trigger yet.
This is a candidate for using Aaron's NetworkManager code. But
would make us depend on d-bus.
* NetworkInformationException.cs: Use error_code for ErrorCode,
instead of NativeErrorCode. Fixes warning.
2006-03-11 Miguel de Icaza <[email protected]>
* AuthenticatedStream.cs: Fixed normative parameter names (yes, we
need to do this everywhere one day).
(Close): actually obey the "leaveInnerStreamOpen" setting from the
constructor.
2006-03-11 Miguel de Icaza <[email protected]>
* NetworkStream.cs (Dispose): Use the right signature depending on
the profile being built.
2006-03-11 Miguel de Icaza <[email protected]>
* X509Chain.cs: Flagged member as internal to avoid unused warning.
* X500DistinguishedName.cs: Comment out unused names and move
temporary unused variables inside the comments that were removed
svn path=/trunk/mcs/; revision=57836
* BitVector32.cs: Fixed 2.0 API changes and this[int] setter under 2.0
* HybridDictionary.cs: Fixed Contains different behaviour under 2.0.
* IOrderedDictionary.cs: Added missing GetEnumarator to the interface.
* NameObjectCollectionBase.cs: Fixed 2.0 API changes and
serialization.
* NameValueCollection.cs: Fixed 2.0 API changes.
* OrderedDictionary.cs: Fixed API changes, serialization and this[int]
setter.
* StringDictionary.cs: Added missing null checks.
svn path=/trunk/mcs/; revision=53678
Unify all list traversals into FindEntry.
(AreEqual): Remove.
(FindEntry): Split into two duplicate loops, one when comparer ==
null, the other when it isn't. Add new out parameter that points
to the entry preceding the result.
(Add, AddImpl, this []): Update.
(Remove): Use FindEntry for traversal.
(CopyTo): Add more tests.
(ListEntryEnumerator): Simplify.
(ListEntryCollection, ListEntryCollectionEnumerator): Likewise.
(I started out to delete AreEqual, but it ended up into an drive-by cleanup)
svn path=/trunk/mcs/; revision=47958
* HybridDictionary.cs: Rewrite to avoid a test on each operation.
(list, hashtable): Remove.
(inner): New IDictionary field that can hold either a list
dictionary or a hashtable.
(is_list): New. Notes whether 'inner' holds a list dictionary or not.
(Clear): Don't change a hashtable to a list dictionary.
svn path=/trunk/mcs/; revision=47950
* NameObjectCollectionBase.cs: Don't throw an exception in
OnDeserialization if infoCopy has not been set, which means that
the serialization constructor has not been called, because
a subclass may completely override that constructor.
This fixes bug #75607.
svn path=/trunk/mcs/; revision=47636
* NameObjectCollectionBase.cs: after 1.0, this uses DefaultInvariant for
the hash code provider and comparer, as Ben said.
svn path=/trunk/mcs/; revision=44225
* NameObjectCollectionBase.cs: Fix line endings. It's mostly in
DOS endings, so I left it at that.
(GetEnumerator): Made virtual.
* ConfigurationElement.cs (InitializeDefault): Made virtual.
* AppSettingsSection.cs:
* Configuration.cs:
* ConfigurationLocation.cs:
* ConfigurationLocationCollection.cs:
* ConfigurationSection.cs:
* ConfigurationSectionCollection.cs:
* ConfigurationSectionGroup.cs:
* ConfigurationSectionGroupCollection.cs:
* ConnectionStringsSection.cs: Added stubs and bits of implementation.
Other than ConfigurationElementCollection and
ConnectionStringsSectionCollection, we now have the basic skeleton for
implementing the configuration system in the System.Configuration
namespace.
svn path=/trunk/mcs/; revision=32398
* NameObjectCollectionBase.cs: Now use IComparer to compare keys. This
completes a TODO and fix Remove in NameValueCollection.
svn path=/trunk/mcs/; revision=29550
* HybridDictionary.cs: Fixed Contains for null argument.
* NameValueCollection.cs: Fixed Set to remove existing values. Fixed
Add(NVC) to throw same exception as MS implementation.
svn path=/trunk/mcs/; revision=28891
* System.dll.sources: added ProcessStringDictionary.
* System.Collections.Specialized/ProcessStringDictionary.cs: the same
as StringDictionary, but doesn't turn keys into lowercase.
* System.Diagnostics/Process.cs: added environment variables setting
support and also send useShellExecute to the runtime.
* System.Diagnostics/ProcessStartInfo.cs: support EnvironmentVariables.
MS uses StringDictionary, which turns keys into lowercase. We don't
do that.
svn path=/trunk/mcs/; revision=24068
* BitVector32.cs (CreateSection): Check that the new
calculated offset isn't more than 32 and not that the sum of the
new offset and the number of set bits is more than 32.
(this): Perform bitwise and with the complement of the mask
shifted version (~(section.Mask << section.Offset)) and not with
the shifted version of the mask's complement (~section.Mask <<
section.Offset).
(this): Currently doesn't return the correct value when the data
in the BitVector32 instance is negative.
* ListDictionary.cs (CopyTo): If the array is null, it should
throw ArgumentNullException. If the index is less than 0, it
should throw ArgumentOutOfRangeException.
(Remove): Throw ArgumentNullException when the parameter is null.
* BitVector32Test.cs (TestNegativeIndexer, TestSectionIndexer,
TestCreateSection): new tests from Alon Gazit <[email protected]>.
* ListDictionaryTest.cs (CopyTo1, CopyTo2, Remove): New file, with
tests from Alon Gazit <[email protected]>.
svn path=/trunk/mcs/; revision=17885
* StringCollection.cs: Rewrote. Now uses ArrayList. Fixes up quite
a few Rotor bugs.
* ArrayList.cs, Hashtable.cs, SortedList.cs: Enumerator fixes, error
checking
We are now passing 37% of the System.Collections.* tests that were failing!
svn path=/trunk/mcs/; revision=15207
* NameValueCollection.cs: Uncoment constructor, an old MCS bug
prevented this from working. Removed test for nullitude of col,
as it would have aborted anyways on the dereference in the base
constructor call.
svn path=/trunk/mcs/; revision=12163