Commit Graph
58 Commits
Author SHA1 Message Date
Jb Evain 232d3340e1 in System.Collections:
2007-11-06  Jb Evain  <[email protected]>

	* Hashtable.cs: Don't compare user keys against the special removed
	key. Fix #324761.

in Test/System.Collections:
2007-11-06  Jb Evain  <[email protected]>

	* HashtableTest.cs: Add test case for #324761.

svn path=/trunk/mcs/; revision=89004
2007-11-06 16:48:36 +00:00
Zoltan Varga 7154fb99ce 2007-10-25 Zoltan Varga <[email protected]>
* Hashtable.cs: Put the hash values into a separate array to help the GC. Fixes
	#336069.

svn path=/trunk/mcs/; revision=88233
2007-10-25 21:25:23 +00:00
Miguel de Icaza eebf4087dd Fix, SerializationInfo.GetValue might throw an error
svn path=/trunk/mcs/; revision=68055
2006-11-17 13:42:29 +00:00
Miguel de Icaza 1ded59163d Improved the MonoTODO messages, as these will be developer visible
2006-11-16  Miguel de Icaza  <[email protected]>

	* Hashtable.cs: Serialize EqualityComparer.


svn path=/trunk/mcs/; revision=67996
2006-11-16 13:33:32 +00:00
Miguel de Icaza 2da7bc41d2 2006-08-16 Miguel de Icaza <[email protected]>
* Hashtable.cs (PutImpl): Do not access the table twice, only
	once. 
	
	(TestPrime): optimize, take the sqrt out of the loop.

svn path=/trunk/mcs/; revision=64217
2006-08-22 23:51:19 +00:00
Sebastien Pouliot 28c6cae779 2006-01-04 Sebastien Pouliot <[email protected]>
* Hashtable.cs: Mark all inner classes as [Serializable] to match MS
	behaviour. Fix bug #76300.


svn path=/trunk/mcs/; revision=55081
2006-01-04 21:26:50 +00:00
Miguel de Icaza 5370ce3394 2005-09-29 Miguel de Icaza <[email protected]>
* Add ComVisible(true) to all the classes that needed it.

	* Removed documentation from DictionaryBase.cs and moved it to
	Monodoc. 

	* ArrayList.cs: Fixed signature for constructor, parameter names
	are normative.

	* CollectionBase.cs: Add a couple of missing methods. 



svn path=/trunk/mcs/; revision=51018
2005-09-30 02:15:04 +00:00
Zoltan Varga c09d655623 2005-09-05 Zoltan Varga <[email protected]>
* Hashtable.cs: Add new IEqualityComparer constructors for 2.0.

	* CaseInsensitiveHashCodeProvider.cs IHashCodeProvider.cs: Mark these
	as obsolete in 2.0.

svn path=/trunk/mcs/; revision=49484
2005-09-05 16:57:08 +00:00
Atsushi Eno 87d77899f2 2005-09-01 Atsushi Enomoto <[email protected]>
* Hashtable.cs : SyncHashtable.GetEnumerator() returned keys instead
	  of entries (DictionaryEntry). Fixed bug #75790.

	* HashtableTest.cs : testcase for #75790.


svn path=/trunk/mcs/; revision=49248
2005-09-01 06:24:42 +00:00
Martin Baulig 00d6ed169c Applied a patch from David Waite <[email protected]> containing some collection updates.
svn path=/trunk/mcs/; revision=46043
2005-06-15 14:10:38 +00:00
Zoltan Varga 3470ce092a 2005-06-06 Zoltan Varga <[email protected]>
* Hashtable.cs: Add some missing 2.0 attributes.

svn path=/trunk/mcs/; revision=45488
2005-06-06 14:13:37 +00:00
Sebastien Pouliot 80a0e22519 2005-05-22 Sebastien Pouliot <[email protected]>
* corlib.dll.sources: Renamed CER to Cer to match 2.0 beta2.


svn path=/trunk/mcs/; revision=44891
2005-05-22 15:20:04 +00:00
Zoltan Varga 2faa9773a9 2005-02-21 Zoltan Varga <[email protected]>
* Hashtable.cs: Add net 2.0 ReliabilityContractAttributes.

svn path=/trunk/mcs/; revision=41005
2005-02-21 16:11:57 +00:00
Ben Maurer 7284445dc3 * Hashtable.cs (get_Item): duplicate Find here, as we can
specialize a few things. This gives me 7% back.
	(Find) Use break rather than return -1. Saves a bit of code.
	

svn path=/trunk/mcs/; revision=38045
2004-12-21 19:10:43 +00:00
Ben Maurer 1e30148bfb 2004-12-21 Ben Maurer <[email protected]>
* Hashtable.cs (GetHash): Avoid a method call. Also, don't store
	the this.hcpRef in a variable. This will create another register
	which must be pushed on the stack. It is better to just reference
	the variable again. hcpRef.GetHashCode (key) is the slow path
	anyways, so an extra variable reference here doesn't hurt
	(KeyEquals): ditto.

	This gives me a few % back in a raw benchmark.


svn path=/trunk/mcs/; revision=38044
2004-12-21 18:54:07 +00:00
Ben Maurer b0f2cd6acb * Hashtable.cs (Find): Some minor optimizations here.
svn path=/trunk/mcs/; revision=38016
2004-12-21 03:07:59 +00:00
Ben Maurer d12836d6ae * Hashtable.cs: Remove GetImpl and inline it.
svn path=/trunk/mcs/; revision=38009
2004-12-21 00:22:57 +00:00
Ben Maurer 72d62fcf17 * Hashtable.cs (Find): Before calling KeyEquals, check to see if k
== key (ie, they are the same pointer). In many cases, this will
	avoid two virtual calls. This gives me 1% on mcs bootstrap (!!!!)
	

svn path=/trunk/mcs/; revision=38001
2004-12-20 23:01:29 +00:00
Ben Maurer 1fb732c551 2004-12-20 Ben Maurer <[email protected]>
* Hashtable.cs (Find): Make `i' a uint rather than an int. This
	avoids having a long compare.


svn path=/trunk/mcs/; revision=38000
2004-12-20 22:44:29 +00:00
Lluis Sanchez 51b4a2164f 2004-12-16 Lluis Sanchez Gual <[email protected]>
* Hashtable.cs: Check for null serialization info in OnDeserialization.
	A hashtable subclass can fully override the constructor, so
	serializationInfo would be null in this case. Fixes bug #70698.


svn path=/trunk/mcs/; revision=37988
2004-12-20 18:23:22 +00:00
Lluis Sanchez a0390e9fd6 2004-12-16 Lluis Sanchez Gual <[email protected]>
* Hashtable.cs: Add deserialized elements in OnDeserialization, since
	when the serialization constructor is called, some of the elements
	may not yet be fully deserialized. This fixes bug #70570.


svn path=/trunk/mcs/; revision=37830
2004-12-16 13:05:43 +00:00
Geoff Norton b287d431b5 Patch for bug #61802 (Approved by miguel)
svn path=/trunk/mcs/; revision=31389
2004-07-22 19:30:21 +00:00
Sebastien Pouliot 55b671bb85 2004-06-14 Sebastien Pouliot <[email protected]>
* Hashtable.cs: Compare index and length in CopyTo only when length > 0.

svn path=/trunk/mcs/; revision=29538
2004-06-14 19:53:00 +00:00
Duncan Mak 13d1764537 Add license and copyright to all source files in corlib
svn path=/trunk/mcs/; revision=29249
2004-06-11 02:09:36 +00:00
Sebastien Pouliot e2c9c8c0bf 2004-05-31 Sebastien Pouliot <[email protected]>
* Hashtable.cs: Added ArgumentNullException in GetObjectData.

svn path=/trunk/mcs/; revision=28601
2004-06-01 00:44:10 +00:00
Sebastien Pouliot 06257093b5 2004-05-27 Sebastien Pouliot <[email protected]>
* Hashtable.cs: Cloned synchronized Hashtables are now synchronized.

svn path=/trunk/mcs/; revision=28273
2004-05-27 14:46:50 +00:00
Lluis Sanchez 3a59ec0931 * Hashtable.cs: Renamed internal class to make serialization compatible
with MS.NET.

svn path=/trunk/mcs/; revision=27961
2004-05-24 11:20:08 +00:00
Gert Driesen 4dc6b21ef5 * Hashtable.cs: marked EnumeratorMode private
* SortedList.cs: marked EnumeratorMode private

svn path=/trunk/mcs/; revision=27020
2004-05-10 08:59:50 +00:00
Andreas N d2f65ad9d1 2004-05-01 Andreas Nahr <[email protected]>
* BitArray.cs: Fix parameter names
	* CaseInsensitiveHashCodeProvider.cs: Fix signature
	* DictionaryEntry.cs: Fix parameter names
	* Hashtable.cs: Fix signatures
	* SortedList.cs: Fix signatures

svn path=/trunk/mcs/; revision=26502
2004-05-01 10:23:55 +00:00
Ben Maurer a322a8c901 constify
svn path=/trunk/mcs/; revision=26353
2004-04-29 22:10:51 +00:00
David Sheldon 16fcacf230 2004-03-18 David Sheldon <[email protected]>
* Hashtable.cs: Serialise/Deserialise to two arrays of
   keys/values. This will match what MS.NET appears to be
   doing.

svn path=/trunk/mcs/; revision=24308
2004-03-18 23:25:35 +00:00
Lluis Sanchez 2351fc2ee8 * Hashtable.cs: Added serialization support to SynchedHashtable. This
fixes bug #52741.

svn path=/trunk/mcs/; revision=21991
2004-01-12 23:02:00 +00:00
Gonzalo Paniagua Javier 08fd92c968 2004-01-12 Gonzalo Paniagua Javier <[email protected]>
* Hashtable.cs: fix Clone. Closes bug #52740. Patch by Benjamin Jemlich
	([email protected]).

svn path=/trunk/mcs/; revision=21976
2004-01-12 10:31:20 +00:00
Gonzalo Paniagua Javier 153b8e21fb 2003-10-10 Gonzalo Paniagua Javier <[email protected]>
* System.Collections/Hashtable.cs:
	* Test/System.Collections/HashtableTest.cs: patch from Carlos A.
	Barcenilla ([email protected]) that includes some fixes for
	Hashtable + NUnit2 tests.

svn path=/trunk/mcs/; revision=18845
2003-10-10 03:24:41 +00:00
Zoltan Varga 81ec0b8f92 2003-09-26 Zoltan Varga <[email protected]>
* Hashtable.cs: Remove empty static constructor since it prevents this
	class from being beforefieldinit.

svn path=/trunk/mcs/; revision=18312
2003-09-26 16:47:05 +00:00
Duncan Mak c3bb789165 2003-08-20 Duncan Mak <[email protected]>
* Hashtable.cs (PutImpl): Fix my previous checkin, see details
	posted on bug #47692.

	I really hope I don't mess up this time, because, if I do again,
	it will be really embarrassing.

svn path=/trunk/mcs/; revision=17430
2003-08-20 04:57:06 +00:00
Duncan Mak 4acf8c6f82 (PutImpl): Patch from Luca Barbieri <[email protected]>.
Currently Hashtable.PutImpl has an incorrect test which causes the
key chain search to terminate as soon as a free slot is found,
causing key duplication.

svn path=/trunk/mcs/; revision=17376
2003-08-18 04:06:27 +00:00
Duncan Mak 6923e85550 2003-06-27 Duncan Mak <[email protected]>
* Hashtable.cs: Patch from [email protected], GetEnumerator should be
	returning DictionaryEntrys, instead of just the Key of the table.

svn path=/trunk/mcs/; revision=16251
2003-07-15 04:47:19 +00:00
Gonzalo Paniagua Javier f42c0d1e5d 2003-07-07 Gonzalo Paniagua Javier <[email protected]>
* Hashtable.cs: made SynchedHashtable serializable. Fixes bug #45918.
	Thanks to [email protected] (Joerg Rosenkranz).

svn path=/trunk/mcs/; revision=16021
2003-07-07 14:48:07 +00:00
Lluis Sanchez 1c7df13cd0 * Hashtable.cs: Fixed bug when serializing and deserializing
a hashtable from which one element has been deleted. The Object instance
	  used as a removed marker is not detected as a such, since the
	  serializer creates a different instace.

svn path=/trunk/mcs/; revision=15641
2003-06-25 22:52:04 +00:00
Duncan Mak d6e894bb6b Fixes to various System.Collections class, with test cases included.
svn path=/trunk/mcs/; revision=15361
2003-06-13 08:40:21 +00:00
Ben Maurer 9102ceb52e 2003-06-08 Ben Maurer <[email protected]>
* StringCollection.cs: Rewrote. Now uses ArrayList. Fixes up quite
	a few Rotor bugs.
	* ArrayList.cs, Hashtable.cs, SortedList.cs: Enumerator fixes, error
	checking
We are now passing 37% of the System.Collections.* tests that were failing!

svn path=/trunk/mcs/; revision=15207
2003-06-09 00:41:39 +00:00
Pedro Martínez Juliá 7378a8a117 Hashtable.cs: Finish the work on the serialization and. Add TestCase for
the serialization with Binary Formatter.

svn path=/trunk/mcs/; revision=11604
2003-02-15 12:04:43 +00:00
Gonzalo Paniagua Javier 0c06d75f25 2002-10-27 Gonzalo Paniagua Javier <[email protected]>
* Hashtable.cs: add the key when to the error mesagge when
	'key duplication'.

svn path=/trunk/mcs/; revision=8594
2002-10-27 13:24:31 +00:00
Nick Drochak 44e1a334c6 2002-04-29 Nick Drochak <[email protected]>
* Hashtable.cs (CopyTo): Throw exceptions where needed.

svn path=/trunk/mcs/; revision=4123
2002-04-28 19:42:42 +00:00
Piers Haken 4c6ef57917 minor fixups:
visibility changes
	remove obsolete (& unimplemented) methods

svn path=/trunk/mcs/; revision=3558
2002-04-02 19:24:40 +00:00
Piers Haken 610d7923ac added missing [Serializable] attribute
svn path=/trunk/mcs/; revision=3540
2002-04-01 20:22:40 +00:00
Sergey Chaban 4e71fda724 * Hashtable.cs: Fixed ToPrime (). Removed ALLOC_GRAIN. Removed unused code. Changed GetObjectData () to use modificationCount as Version.
svn path=/trunk/mcs/; revision=2999
2002-03-08 14:57:15 +00:00
Duncan Mak 01beb5e5b9 Serialization bits for System.Collection.Hashtable, System.Reflection.AssemblyName and System.Security.SecurityException
svn path=/trunk/mcs/; revision=2259
2002-02-07 17:33:39 +00:00
Paolo Molaro a88a62cce1 Sat Jan 5 15:56:54 CET 2002 Paolo Molaro <[email protected]>
* Hashtable.cs: the IDictionaryEnumerator returns DictionaryEntries.


Sat Jan 5 15:59:05 CET 2002 Paolo Molaro <[email protected]>

	* ILGenerator.cs: fix emission of two-bytes opcodes.
	Missing slot for locals array. Throw exceptions on unimplemented
	methods.
	* OpCode.cs: add a comment: the Value property is useless.
	* OpCodes.cs: fix name of tail opcode (Tail -> Tailcall).


Sat Jan 5 15:53:50 CET 2002 Paolo Molaro <[email protected]>

	* Enum.cs: dummy ToString impl.
	* String.cs: dummy format implementations to get compiler errors
	somewhat working.
	* Type.cs: implemented filter delegates. FindMembers runs the filter, now.

svn path=/trunk/mcs/; revision=1851
2002-01-05 11:12:22 +00:00