* Test/System.Xml/XmlDataDocumentTest2.cs : Test if DataSet schema with whitespace
characters are saved and loaded correctly, Test if null values are
correctly saved and loaded, Test if creating a row in Dataset is
reflected in the document.
* Test/System.Data/DataSetTest2.cs : Test if ConstraintName with whitespace is saved
correctly.
* System.Xml/XmlDataDocument.cs :
- Use encoded names for DataSet schema.
- StringToElement : Return 'null' if the value is empty string
or null.
- OnDataTableRowAdded : Add the row elements to the tablenode if
they are not already added.
* System.Data/XmlHelper.cs : A helper class for encoding/decoding schema names.
Caches the Schema names to minimize encoding/decoding operations and
duplicate strings created.
* System.Data/XmlSchemaWriter :
- Use XmlHelper for encoding/decoding schema names.
- Encode ConstraintNames when writing as xml.
* System.Data/DataSet.cs
* System.Data/XmlDataReader.cs
* System.Data/XmlDataInferenceLoader.cs
* System.Data/XmlSchemaDataImporter.cs
- Use XmlHelper for encoding/decoding schema names.
* System.Data/DataTableCollections : Minor code refactor.
* System.Data/DataRow.cs : Create XmlElement only if required.
svn path=/trunk/mcs/; revision=59624
* ConstraintCollection.cs: in 2.0, class is not serializable and
is sealed. make all the "virtuals" #if !NET_2_0 as well.
* Constraint.cs: not serializable in 2.0.
* DataColumnCollection.cs: in 2.0, class is not serializable and
is sealed. make all the "virtuals" #if !NET_2_0 as well.
* DataRelationCollection.cs: not serializable in 2.0.
* DataRelation.cs: not serializable in 2.0.
* DataRowBuilder.cs: class is sealed in 2.0.
* DataRowCollection.cs: in 2.0, class is not serialized and is
sealed. Also, Add isn't virtual in 2.0 (as the class is sealed).
* DataRow.cs: not serializable in 2.0.
* DataSet.cs: remove some DataSysDescriptions from the 2.0 build,
and s/GetDataReader/CreateDataReader.
* DataTableCollection.cs: in 2.0, class is not serializable and is
sealed. make all the "virtuals" #if !NET_2_0 as well.
* DataTableReader.cs: remove VisibleFieldCount property.
* DataViewSettingCollection.cs: not serializable in 2.0.
* DataViewSetting.cs: not serializable in 2.0.
* ForeignKeyConstraint.cs: serializable in 2.0.
* OperationAbortedException.cs: class is sealed and serializable.
* PropertyCollection.cs: serializable in 2.0.
* StatementCompletedEventArgs.cs: class is sealed.
* UniqueConstraint.cs: not serializable in 2.0.
svn path=/trunk/mcs/; revision=56982
* Test/System.Data.SqlTypes/SqlStringTest.cs : Removed NotWorking attribute for testcases fixed
* Test/System.Data/DataTableCollectionTest2.cs,EvaluateExceptionTest.cs,
DataColumnTest.cs,DataRowViewTest.cs,DataRowCollectionTest2.cs,
DataTableTest2.cs,DataTableTest.cs,DataColumnCollectionTest2.cs,
DataColumnCollectionTest.cs,DataViewTest.cs,DataColumnTest2.cs
- Removed 'NotWorking' attributes for the testcases fixed
- Added few new testcases
* System.Data.SqlTypes/SqlString.cs :
- GetUnicodeBytes()
- GetNonUnicodeBytes()
- Constructor
Use Encoding class to convert between byte[] and string
* Mono.Data.SqlExpressions/ColumnReference.cs :
- GetReferencedRow ()
- GetReferencedRows() : Verify the column before getting the values.
Validate the ColumnReference even when the table has no rows.
* Mono.Data.SqlExpressions/Function.cs : Modified Eval()
- A tmp fix to check for null. Expression.Eval needs to be modified all
around to return DBNull.Value.
* System.Data/DataTableCollection.cs :
- Remove () : Check for invalid TableName
- Add () : Verify the table doesn't belong to another dataset
* System.Data/DataView.cs :
- CompleteLastAdded () : Do not raise ItemAdded Event as it is
already raised in AddNew().
* System.Data/DataColumn.cs :
- Expression : Verify that the Column names in the expression are valid
- ResetCollectionInfo : Renamed to ResetColumnInfo
* System.Data/DataRow.cs :
- RejectChanges () : Reorganized the code to do the Right thing.
- Item : Dont check for detached and deleted rows as these are
done elsewhere.
* System.Data/DataRowCollection.cs :
- Add () : Check for null value
* System.Data/DataTable.cs :
- PrimaryKey : Set AllowDBNull=false for all the key columns
- ImportRow : Import the row only if it is not in Detached state. if in Deleted
state, perform the validation when AcceptChanges/RejectChanges is called.
* System.Data/DataColumnCollection.cs :
- Add : Validate the column expression before adding it to the collection.
- GetColumnDependency () : New. Get the dependencies on the column
- CanRemove : Move checks to GetColumnDependency
- Clear () : Simplified code. Remove unncessary checks.Also, dont check Expression col.
- IndexOf - Check argument.
Overall , appropriate error msg's are thrown if Remove/Clear fails. Removed a few
redundant checks performed and moved the common code to GetColumnDependency.
Fixes failing testcases in System.Data.
svn path=/trunk/mcs/; revision=56531
2005-07-22 Sureshkumar T <[email protected]>
* DataColumnMappingCollection.cs: updated attributes & attribute
descriptions to match with masterinfos.
In System.Data.SqlClient:
2005-07-22 Sureshkumar T <[email protected]>
* SqlCommandBuilder.cs, SqlParameterCollection.cs,
SqlConnection.cs, SqlParameter.cs:
- updated attributes & attribute descriptions to match with
masterinfos.
In System.Data:
* DataViewSettingCollection.cs, DataTableCollection.cs,
DataSet.cs, DataView.cs, DataColumn.cs, ForeignKeyConstraint.cs,
DataRelationCollection.cs, UniqueConstraint.cs, DataTable.cs,
DataColumnCollection.cs, DataRelation.cs, DataSet.cs:
- updated attributes & attribute descriptions to match with
masterinfos.
In System.Data.Odbc:
* OdbcParameter.cs: updated attributes & attribute descriptions to
match with masterinfos.
svn path=/trunk/mcs/; revision=47554
* DataTableCollection.cs : reset the table's DataSet to null when
removing a table from this collection.
* DataTable.cs : When Namespace is not specified explicitly, its
Namespace property reflects DataSet's Namespace if exist.
This fixes bug #60469.
svn path=/trunk/mcs/; revision=29975
* DataColumnCollection.cs : Fixed nunit test errors, removed TODOs
* DataTableCollection.cs : Tested and removed TODO
* TypedDataSetGeneratorException.cs : Fixed a couple of TODOs
svn path=/trunk/mcs/; revision=26407
(Add) : Find if the new column name is the same as the one found in IndexOf.
(IndexOf) : New method.
(Contains) : Use new IndexOf.
(IndexOf) : Use new IndexOf.
* DataRelationCollection.cs (DataRelationCollection.AddCore) : Add The Relation to the collection.
(DataSetRelationCollection.AddCore) : First add the UniqueConstraint.
* DataRow.cs (this[int columnIndex, DataRowVersion version]) : Change exceptions.
(Delete) : Detach row if the RowState was Added.
(GetChildRows) : Get the array form the ChildTable.
(GetParentRows) : Get the array from the ParenTable.
* DataRowCollection.cs (Remove) : Check if row state is Detached to avoid exception.
* DataSet.cs (IXmlSerializable.ReadXml) : Do not call MoveToContent and ReadEndElement - the XmlSerializationReader does it.
* DataTable.cs (PrimaryKey) : Fix bugs.
(Compute) : First call Select. Then create ExpressionAggregate to aggregate the Select result.
* DataTableCollection.cs (Add) : Fix a bug.
* ForeignKeyConstraint.cs (_validateColumns) : Throw correct exception.
* MergeManager.cs (AdjustSchema) : Fix a bug.
svn path=/trunk/mcs/; revision=20666
* DbDataAdapter.cs (Fill): Patch from Eran Domb, <[email protected]>.
Fixes a possible NullReferenceException, more details here:
* DataColumn.cs (Unique): Implemented.
* DataTable.cs:
* ConstraintCollection.cs:
* ForeignKeyConstraint.cs (_ensureUniqueConstraintExists): Fixes
an Exception thrown. Details:
http://lists.ximian.com/archives/public/mono-devel-list/2003-September/002130.html
* DataRowCollection.cs (Add): There is no checking that there is
no violation of the unique constrains.
* UniqueConstraint.cs (AssertConstraint): There is no checking on
all columns in the constraint.
svn path=/trunk/mcs/; revision=18298
* DataSystem.Data.DataTableCollection.cs:
Removed HashTable. There could be situations where DataTable
is added to collection before it hava TableName. So using
HashTable is impossible.
svn path=/trunk/mcs/; revision=9264
* System.Data/ConstraintCollection.cs:
* System.Data/DataColumnCollection.cs:
* System.Data/DataRowCollection.cs:
* System.Data/DataTableCollection.cs:
* System.Data/InternalDataCollectionBase.cs: made List internal to fix
the build with csc. It must be a mcs bug. I will try to get a test case.
svn path=/trunk/mcs/; revision=8050
* System.Data.Common/DbDataAdapter.cs:
- More implementation of Fill methods
- Get rid of isDirty flag, because we can just check
if the table exists
- Do *not* remove DataTables before Filling them
- Implicitly open the connection before doing a Fill
if it does not exist.
* System.Data.SqlClient/SqlDataAdapter.cs:
- Minor fixup
* System.Data/DataTableCollection.cs:
- Add DataSet to internal, undocumented constructor
- When a table is created, set its DataSet property
- Default table name for creation is "Table1" (see .NET)
- Inherit the ArrayList list from InternalDataCollecitonBase
and maintain a hashtable between table names and
DataTables
* System.Data/DataTable.cs:
- Add internal dataSet field. This is used by
DataTableCollection when the DataTable is constructed.
* System.Data/DataSet.cs:
- Pass a reference to the DataSet when constructing the
DataTableCollection.
svn path=/trunk/mcs/; revision=4722
* System.Data/DataTableCollection.cs:
Fix an issue when adding a DataTable and size == 0.
Now explicitly checks if size > 0 before doing Array.Copy ()
* System.Data.Common/DbDataAdapter.cs:
Move closer to a working implementation.
Make the IDbCommand fields protected so that they can
be inherited.
* System.Data.SqlClient/SqlDataAdapter.cs:
This should inherit the IDbCommands instead of having its
own. An explicit cast is used to force conversion between
IDbCommand and SqlCommand
svn path=/trunk/mcs/; revision=4588
* System.Data/DataRelation.cs
* System.Data/ForeignKeyConstraint.cs
* System.Data/UniqueConstraint.cs: added more stubs
* System.Data/DataTableRelationCollection.cs: added back to cvs
and modified for compile errors. DataRelationCollection is an
abstract class and there must be a class that implements for
DataTable/DataSet. DataTableRelationCollection was changed
to an internal class.
* System.Data.build: modified - new files added
also wanted to include files/classes in the build
so we can get a compilable forward read only result set.
It compiles now using csc/nant with warnings, but this
is a start for adding functionality for the result set.
Classes associated with/and DataSet are still excluded.
* TODO: modified - updated to do list for System.Data
* System.Data/Constraint.cs
* System.Data/ConstraintCollection.cs
* System.Data/DataRelationCollection.cs
* System.Data/DataRow.cs
* System.Data/DataRowChangeEventArgs.cs
* System.Data/DataRowCollection.cs
* System.Data/DataTable.cs
* System.Data/DataTableCollection.cs
* System.Data/InternalDataCollectionBase.cs
* System.Data/PropertyCollection.cs: modified -
changes to compile SqlDataReader/DataTable and
dependencies
* System.Data/IDbCommand.cs
* System.Data.SqlClient/SqlCommand.cs: modified -
un-commented overloaded methods ExecuteReader
which returns a SqlDataReader
svn path=/trunk/mcs/; revision=4098
* System.Data/DataTableCollection.cs: more implementation.
(Count): added 'override' keyword, as pointer out by Martin.
* System.Data.Common/DataColumnMappingCollection.cs (Add, AddRange):
only call Array.Copy when there is really stuff to be copied.
(CopyTo): don't create the temporary array, it's not needed.
* System.Data.build: excluded newly added file from build.
svn path=/trunk/mcs/; revision=4084
* System.Data/DataTableRelationCollection.cs: removed, it's not
on MS SDK documentation.
* System.Data/DataTableCollection.cs: new class.
svn path=/trunk/mcs/; revision=4082