* ImageMap.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in Render ().
* DropDownList.cs, ListBox.cs: validate the event in LoadPostData ().
* TextBox.cs: validate the event in LoadPostData ().
Register for event validation in AddAttributesToRender ().
* HiddenField.cs: validate the event in RaisePostDataChangedEvent.
Register for event validation in Render ().
* RadioButton.cs: validate the event in LoadPostData ().
Register for event validation in InternalAddAttributesToRender.
* CheckBox.cs, RadioButtonList.cs: validate the event in
RaisePostDataChangedEvent.
* Menu.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in GetClientEvent ().
* DetailsView.cs, GridView.cs: validate the event in
RaisePostBackEvent ().
Register for validation in GetCallbackScript () and in OnPreRender
* Button.cs, Table.cs, BulletedList.cs, Calendar.cs, LinkButton.cs,
ImageButton.cs, TreeView.cs: validate the event in RaisePostBackEvent ().
2008-10-17 Marek Habersack <[email protected]>
* Control.cs: added the ValidateEvent internal method, used by
classes descending from Control to automatically trigger event
validation.
* Page.cs: removed the CheckForValidationSupport method. It moved
to Control.cs
RaisePostBackEvent no longer validates the events, this
functionality has been moved to Control.ValidateEvent.
2008-10-17 Marek Habersack <[email protected]>
* HtmlInputHidden.cs: validate the event in LoadPostDataInternal.
* HtmlInputButton.cs: validate the event in
RaisePostBackEventInternal ().
Register for event validation in RenderAttributes ()
* HtmlTextArea.cs: validate the event in
RaisePostBackDataChangedEvent ().
* HtmlButton.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ()
* HtmlAnchor.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ().
* HtmlInputRadioButton.cs, HtmlSelect.cs: validate the event in
LoadPostData.
* HtmlInputText.cs, HtmlInputImage.cs, HtmlInputCheckBox.cs,
HtmlInputPassword.cs: validate the event in
RaisePostDataChangedEvent ().
2008-10-17 Marek Habersack <[email protected]>
* MenuAdapterTest.cs: work around event validation failure in the
test environment.
2008-10-17 Marek Habersack <[email protected]>
* PageTest.cs: use a custom version of HtmlInputHidden control to
work around the new event validation code which doesn't work in
this instance.
svn path=/trunk/mcs/; revision=116231
* HtmlInputHidden.cs:
* HtmlSelect.cs:
* HtmlInputText.cs:
* HtmlSelect.cs:
* HtmlInputText.cs:
* HtmlInputImage.cs:
* HtmlInputFile.cs:
* HtmlInputCheckBox.cs:
* HtmlInputRadioButton.cs:
* HtmlInputImage.cs: do not register the control for post back
processing or if it's disabled.
2007-04-11 Marek Habersack <[email protected]>
* ImageButton.cs: implement the Enable property and do not
register for post back if the control isn't enabled.
2007-04-11 Marek Habersack <[email protected]>
* Page.cs: check whether control passed to
RegisterRequiresPostBack implements the IPostBackDataHandler
interface.
svn path=/trunk/mcs/; revision=75594
* Button.cs:
* ButtonField.cs:
* CommandField.cs:
* DataControlButton.cs:
* DataControlField.cs:
* ImageButton.cs:
* PagerSettings.cs:
Internal classes are used in databound controls for buttons
are derived from right types. It allows to have access to them by casting
to public types. This trick is used in one of starter kits of MS.
2007-02-04 Igor Zelmanovich <[email protected]>
* Page.cs:
VerifyRenderingInServerForm does not fire exception when IsCallback
svn path=/trunk/mcs/; revision=72269
* Rationalize the user of MonoTODOs.
- Removed all the TODOs that were only overwritten methods
and had no further information.
- Methods that threw exceptions now have the message "Not
implemnted".
- Methods that return some constant are declared like
that.
- Removed a bunch of stale MonoTODOs that had not been
removed.
svn path=/trunk/mcs/; revision=68620
* DetailsView.cs:
* GridView.cs:
* PagedDataSource.cs:
* FormView.cs:
* ImageButton.cs:
* LinkButton.cs: implement GetPostBackOptions for the 2.0 controls that
support it. The GridView control will no longer throw an exception when
rendered in the paging mode. Patch by Marek Habersack. Fixes bug #78288.
svn path=/trunk/mcs/; revision=62863
* ImageButton.cs: use UniqueID in LoadPostData and also try just the
UniqueID without appending a ".x" or ".y". Fixes several issues in
mojoPortal. Thanks to Joe Audetter for his patience.
svn path=/trunk/mcs/; revision=51145
* ImageButton.cs: fix a bug reported on the list. We were triggering the
command event on every POST. And the 'name' attribute was not being
rendered, so the 'x,y' coordinates didn't have 'uniqueid.' prepended
and we couldn't find the values.
svn path=/trunk/mcs/; revision=51063
* AccessDataSource.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [ToolboxBitmap] on class.
* AdRotator.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Removed extra Page and ViewState properties.
* BulletedList.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* Button.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Added [SupportsEventValidation] on class (2.0).
* Calendar.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* CheckBox.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* CompositeControl.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added new protected RecreateChildControls method.
* DataControlCommands.cs: Added declarative security (LinkDemands) for
Minimal. Added private ctor.
* DataGrid.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Fixed properties for 2.0 (mostly removing
[Bindable]). Added override for TagKey property.
* DataGridColumn.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [UrlProperty] on HeaderImageUrl (2.0).
* DataGridItem.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added IDataItemContainer interface for 2.0.
* DataGridPagerStyle.cs: Added declarative security (LinkDemands) for
Minimal. Remove [Bindable] from 2.0 and add [Localizable].
* DataList.cs: Removed [Load|Save]ControlState methods.
* DropDownList.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* EditCommandColumn.cs: Added declarative security (Link and
Inheritance demands) for Minimal. Added missing attributes,
[DefaultValue] and [Localize] for 2.0.
* FontInfo.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Remove [Bindable] and added [RefreshProperties]
for 2.0.
* Login.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Fixed IsStyleEmpty. Removed extra [Themeable] attributes.
* ImageButton.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* LinkButton.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* ListBox.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Added [SupportsEventValidation] on class (2.0).
* Literal.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Removed [EditorBrowsable] on CreateControlCollection method.
* LoginStatus.cs: Added missing [Themeable] attributes on properties.
* MenuItemStyle.cs: Changed IsEmpty to public (required to compile -
but will be shown as extra).
* RadioButton.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* RadioButtonList.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* RangeValidator.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added missing [Themeable] attributes.
* RegularExpressionValidator.cs: Added declarative security (Link and
Inheritance demands) for Minimal. Remove [Bindable] from 2.0 and add
[Localizable].
* RoleGroupCollection.cs: Added declarative security (Link and
Inheritance demands) for Minimal. Fixed base class (changed in RC).
Re-implemented CopyTo. Removed some methods.
* Style.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Remove static IsStyleEmpty and ToString (from 2.0). IsEmpty
is now public in 2.0.
* Table.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Added [SupportsEventValidation] on class (2.0).
* TableCell.cs: Fixed PersistenceMode for 2.0.
* TextBox.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Added [SupportsEventValidation] on class (2.0).
* TreeNodeStyle.cs: Changed IsEmpty to public (required to compile -
but will be shown as extra).
* WebControl.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Removed [EditorBrowsable] on ControlStyleCreated
property.
svn path=/trunk/mcs/; revision=50329
* Various places: make sure that the DefaultValue matches the
type. Thanks to Michael for pointing this out.
In future audits, you might want to use the following awk command:
awk '/DefaultValue/ { v=$0; looking = 1; } /public/ && looking &&
!/string/ && !/ int / && !/ bool / { print FILENAME; print v;
print $0; looking = 0; } /public/ && looking { looking = 0; } '
*.cs
The above skips bools, strings and ints as those were fine as we
set them. The bug was on the other ones.
svn path=/trunk/mcs/; revision=49274
* CalendarTest.cs: Trackview states
2005-08-02 Jordi Mas i Hernandez <[email protected]>
* RadioButtonListTest.cs: test unit
2005-07-29 Jordi Mas i Hernandez <[email protected]>
* SelectedDatesCollectionTest.cs: new unit test
* CalendarDayTest.cs: new unit test
* CalendarTest.cs: more tests for calendar control
2005-07-12 Jordi Mas i Hernandez <[email protected]>
* ButtonTest.cs: add Default constructors tests
* ImageButtonTest.cs: Adds ImageButtonTest
2005-07-11 Jordi Mas i Hernandez <[email protected]>
* ButtonTest.cs: New unit test for Button
2005-08-04 Jordi Mas i Hernandez <[email protected]>
* Calendar.cs: fixes issues with OnDayRender event and others
2005-08-03 Jordi Mas i Hernandez <[email protected]>
* Calendar.cs: fixes Save/Load state
2005-08-03 Jordi Mas i Hernandez <[email protected]>
* Calendar.cs: bug fixes
2005-08-02 Jordi Mas i Hernandez <[email protected]>
* RadioButtonList.cs: bug fixes
2005-08-02 Jordi Mas i Hernandez <[email protected]>
* CheckBox.cs, RadioButton.cs: mecanism to avoid exposing
AddAttributesToRender
* RadioButtonList.cs: Implementation
2005-08-01 Jordi Mas i Hernandez <[email protected]>
* ImageButton.cs: fixes, complete missing parts
2005-07-29 Jordi Mas i Hernandez <[email protected]>
* Calendar.cs: fixes exceptions, bug fixes, new features
* SelectedDatesCollection.cs: Fixes bugs discovered by the tests
* CalendarDay.cs: fixes default value
2005-07-27 Jordi Mas i Hernandez <[email protected]>
* Calendar.cs: get the styles right, honors more properties, fixes, fix
var names style
2005-07-26 Jordi Mas i Hernandez <[email protected]>
* Calendar.cs: selection of dates, state load, save, track, support
for new properties, many fixes.
2005-07-23 Jordi Mas i Hernandez <[email protected]>
* Button.cs: fixes events, adds attributes
2005-07-22 Jordi Mas i Hernandez <[email protected]>
* Calendar.cs: Initial implementation
* CalendarSelectionMode.cs: fix enum order
2005-07-12 Jordi Mas i Hernandez <[email protected]>
* TitleFormat.cs: Add attribute
* TextBoxMode.cs: Add attribute
* CalendarDay.cs: Initial implementation
* ImageButton.cs: Initial implementation
* CalendarSelectionMode.cs:Initial implementation
2005-07-12 Jordi Mas i Hernandez <[email protected]>
* TextBoxMode.cs: simple enum
* TitleFormat.cs: simple enum
2005-07-10 Jordi Mas i Hernandez <[email protected]>
* Button.cs: Initial Button implementation
svn path=/trunk/mcs/; revision=48923
* Button.cs, ImageButton.cs: Interpret PostBackOptions.ClientSubmit
correctly.
* CommandField.cs: Mostly implemented.
* Menu.cs: Use callback methods moved to ClientScriptManager.
* DataControlButton.cs: Internal control used to implement buttons
for navigating in data bound controls.
* DataControlField.cs, PagerSettings.cs: Use the new DataControlButton
to render the column headers.
* CheckBox.cs, RadioButton.cs, BulletedList.cs, TextBox.cs
DropDownList.cs, Calendar.cs, ListBox.cs, LinkButton.cs, TreeView.cs:
Don't use Page.GetPostBackClientEvent
since it is deprecated in 2.0.
* GridView.cs: Implemented some several interfaces.
Implemented support client sorting and page navigation (using callbacks).
Implemented the autogenerated command column using the new CommandField
class.
* ButtonFieldBase.cs: Implemented.
* GridView.js: New helper script to support client side sorting and
paging in the grid view.
svn path=/trunk/mcs/; revision=41698
* HyperLinkColumn.cs, Label.cs: Added missing 2.0 properties.
* RadioButton.cs: Added missing 2.0 methods.
* ListItem.cs: Added Enabled property.
* MailMessageEventArgs.cs: Use the correct message class.
* ListControl.cs: Implemented missing properties and support for
control state. Implemented base RenderContents method.
* Image.cs: Implemented DescriptionUrl and GenerateEmptyAlternateText
properties.
* BaseCompareValidator.cs: Implemented methods that support conditional
use of the invariant culture.
* DataBoundControl.cs: Set RequiresDataBinding to true in OnLoad.
* SqlDataSourceCommandEventArgs.cs, SqlDataSourceStatusEventArgs.cs:
It takes a DbCommand instead of a IDbCommand.
* GridViewSortEventArgs.cs: Added SortDirection property.
* TextBox.cs, CheckBoxList.cs: Added protected version of
IPostBackDataHandler methods.
* RadioButtonList.cs: Added protected version of
IPostBackDataHandler and IRepeatInfoUser methods.
* Repeater.cs: Updated some method names.
* DropDownList.cs: Added protected version of
IPostBackDataHandler methods. Reuse RenderContents from base class.
* RepeaterItem.cs, Localize.cs, Literal.cs: Fix inheritance.
* GridViewUpdatedEventArgs.cs: Fix typo.
* ListBox.cs: Added protected version of IPostBackDataHandler methods.
Reuse RenderContents from base class.
* BaseDataBoundControl.cs: Several fixes.
* ImageButton.cs, LinkButton.cs: Implemented several 2.0 properties.
svn path=/trunk/mcs/; revision=40772
that the .x and .y values are not being posted, and only the x
value is being posted with the ctrl's id as the key.
svn path=/trunk/mcs/; revision=19725
* ImageButton.cs:
(AddAttributesToRender): fixer another stack overflow.
* WebControl.cs:
(TagName): modified to use TagKey instead of tagKey as the property
can be overriden.
svn path=/trunk/mcs/; revision=5258