When cloning a table we loop over all the columns and clone them, but if a column
contains an expression with a reference to a later column, we'll throw an exception
unless we delay the expression compilation until all the columns have been added
to the new table clone.
So I've split out the expression compilation logic from the Expression property setter,
and now the column Clone method only sets the field. The Clone caller is responsible
for calling CompileExpression on the cloned column after adding all the cloned columns to
the cloned table.
* Fixes to the SUBSTRING and TRIM function to allow
a wider range of functions to be passed as
parameters. This fixes xamarin #665
* Fix to the Parser.jay grammar to eliminate the
reduce/reduce conflicts.
* Dropping the string concatenation code and instead
use the existing arithmetic addition operator which
also fixes the concatenation operation in the presence
of null values
* Adds the null literal
With the associated test cases.
- It is recommended to set auto-increment fields to ReadOnly. When
calling Copy() the check for ReadOnly must be omitted, otherwise
you get an exception.
The RadOnly attribute is set for the parent "Id" field to test
proper handling of read-only fields.
- Source reindention and cleanups.
Signed-off-by: Carsten Schlote <[email protected]>
** Fixes#582732 - Patch by Jeffrey Alvarez <[email protected]>
* DataColumn.cs (Clone): Deep copy the ExtendedProperties
collection.
* XmlSchemaDataImporter.cs: Support import of extended
properties.
* XmlSchemaWriter.cs: Fix exception by writing the extended
properties before simpletype element.
** Fixes#561667
* SqlCommand.cs (Dispose): While Disposing, set connection's
datareader to null so the connection can be reused with another datareader.
This is a scripted conversion of mixed line-ending files to LF-only or CRLF-only
based on which patch is smaller. I used a threshold of upto a quarter of the
lines to determine whether to keep the patch or not.
This set of .gitattributes was automatically generated from the list of files
that GIT tried to normalize when I enabled automatic EOL conversion.
With this set of attributes, we prevent automated EOL conversion on files that
we know will cause trouble down the road.
** Fixes#565616 - Based on Patch by Hubert FONGARNAND
* DataContainer.cs (GetContainerData): If typecode is string,
call Convert.ToString() irrespective of whether value is
IConvertible or not.
** Fixes part of #427769 - Patch by John Lenz <[email protected]>
* DataSet.cs: XML serialization improvements to be compatible with MS impl.
svn path=/trunk/mcs/; revision=142668
** Fixes#536194 - Patch by Andrew Kurochk <[email protected]>
* MergeManager.cs (Merge*): Do nothing when source and target
datasets are same.
svn path=/trunk/mcs/; revision=142590
* SqlCommandTest.cs: Fixes for SQL Server 7.0 / TDS 7.
* SqlConnectionTest.cs: Fixes for SQL Server 7.0 / TDS 7.
* SqlDataAdapterTest.cs: Added tests for Update. Fixed Fill_Test_Data,
Fill_Test_PriKey and Fill_Test_FillErrorTest to pass on SQL Server 7.0.
Avoid catching and rethrowing AssertionException. Minor improvements.
* SqlParameterTest.cs: Fixes for SQL Server 7.0 / TDS 7. Updated
ZeroLengthString to pass on 1.0 profile.
* SqlTransactionTest.cs: Fixes for SQL Server 7.0 / TDS 7.
svn path=/trunk/mcs/; revision=139242
values of clientVersion.
* app-net_2.0.config: added engine config for SQL Server 7.0. Fixed
values of clientVersion.
svn path=/trunk/mcs/; revision=139238
conversion if type of value is different from "system type". Make
DbTypeMapping hashtable available on 1.0 profile, and add missing
mappings. Wrap FormatException adding information on conversion
that failed.
* SqlParameterTest.cs: Added test for bug #526794, and failed
conversion from (zero-length) string to int. Changed spaces to tabs.
svn path=/trunk/mcs/; revision=139116
* SqlParameterTest.cs: Marked SqlChars/SqlBytes tests for SqlValue
as NotWorking as these types are considered as SqlString/SqlBinary
respectively.
svn path=/trunk/mcs/; revision=139071
CloseConnection behavior.
* SqlCommand.cs: Ensure connection is closed if CloseConnection
behavior is set, and reader could not be created.
svn path=/trunk/mcs/; revision=138854
* SqlParameterTest.cs: Added/improved tests for SqlValue, and
SqlTypes. Improved tests for char and char [] type inferrence.
svn path=/trunk/mcs/; revision=138699
** Fixes#382734
* Tds80.cs: Consider queries with Parameters as RPCs and avoid formatting
param values as strings. Fixes issues with locale specific string
formatting/conversions.
* TdsRpcProcId.cs: New - enum of rpc Ids to use with RPC packet type.
svn path=/trunk/mcs/; revision=134765