Commit Graph
776 Commits
Author SHA1 Message Date
Miguel de Icaza 2852ed0b59 Update copyrights 2011-09-13 18:26:13 -04:00
Rolf Bjarne Kvinge 36469066f5 [System.Data] Delay column expression evaluation after all the columns have been cloned when cloning a table. Fixes #666.
When cloning a table we loop over all the columns and clone them, but if a column
contains an expression with a reference to a later column, we'll throw an exception
unless we delay the expression compilation until all the columns have been added
to the new table clone.

So I've split out the expression compilation logic from the Expression property setter,
and now the column Clone method only sets the field. The Clone caller is responsible
for calling CompileExpression on the cloned column after adding all the cloned columns to
the cloned table.
2011-09-13 14:07:27 +02:00
Rolf Bjarne Kvinge 6c7d6c034a [System.Data] Properly clone a column's extended properties when cloning a table. Fixes #668. 2011-09-13 13:01:16 +02:00
Miguel de Icaza 8cf313456e Various fixes to the Expression parser, the fixes include:
* Fixes to the SUBSTRING and TRIM function to allow
	  a wider range of functions to be passed as
	  parameters.   This fixes xamarin #665

	* Fix to the Parser.jay grammar to eliminate the
	  reduce/reduce conflicts.

	* Dropping the string concatenation code and instead
	  use the existing arithmetic addition operator which
	  also fixes the concatenation operation in the presence
	  of null values

	* Adds the null literal

With the associated test cases.
2011-09-09 22:02:56 -04:00
Atsushi Eno 1d5a375459 DiffLoader didn't handle encoded name and caused mismatch between .NET. 2011-08-31 17:49:36 -07:00
David Schmitt f4b240e9cf reformat to coding guidelines 2011-04-11 21:58:59 +02:00
David Schmitt 29cc973a08 Update to NUnit 2.5 syntax 2011-04-11 21:53:11 +02:00
Veerapuram Varadhan 094404cd57 [ado.net]fixes 672113 - Keep a copy of columns array in constraints than
a reference
2011-03-15 22:47:23 +05:30
Carsten Schlote 2392c6a50d Extended CloneCopy() test with ReadOnly field
- It is recommended to set auto-increment fields to ReadOnly. When
  calling Copy() the check for ReadOnly must be omitted, otherwise
  you get an exception.
  The RadOnly attribute is set for the parent "Id" field to test
  proper handling of read-only fields.
- Source reindention and cleanups.

Signed-off-by: Carsten Schlote <[email protected]>
2011-02-14 10:52:22 -05:00
Veerapuram Varadhan a7bfa16bd9 Added schema file to fix test break 2011-01-30 14:19:29 +05:30
Veerapuram Varadhan e2e8734262 Don't run the test. Fixes test break. 2011-01-30 14:19:29 +05:30
vvaradhan ce15f042af 2010-10-01 Veerapuram Varadhan <[email protected]>
** Fixes #582732 - Patch by Jeffrey Alvarez <[email protected]>
	* DataColumn.cs (Clone): Deep copy the ExtendedProperties
	collection.
	* XmlSchemaDataImporter.cs: Support import of extended
	properties.
	* XmlSchemaWriter.cs: Fix exception by writing the extended
	properties before simpletype element.
2010-10-04 16:44:44 +05:30
vvaradhan ceefad76f1 2010-10-01 Veerapuram Varadhan <[email protected]>
** Fixes #561667
	* SqlCommand.cs (Dispose): While Disposing, set connection's
	datareader to null so the connection can be reused with another datareader.
2010-10-04 15:27:52 +05:30
vvaradhan b2285ad835 2010-09-29 Veerapuram Varadhan <[email protected]>
** Fixes failed test for smallmoney
	* Tds70.cs (WriteParameterInfo): Round money values to 4
	decimals, for smallmoney too.
2010-10-01 19:17:48 +05:30
vvaradhan 2ff8ca98f1 2010-09-20 Veerapuram Varadhan <[email protected]>
* SqlDataReaderTest.cs: Add test for bug#613087
2010-09-29 14:39:01 +05:30
vvaradhan 57e6ec2bdb test fixes 2010-09-29 14:37:37 +05:30
vvaradhan f5d5778245 2010-09-16 Veerapuram Varadhan <[email protected]>
* SqlCommandTest.cs: Add test for bug#569543
2010-09-28 20:36:55 +05:30
vvaradhan 29db32e771 2010-09-16 Veerapuram Varadhan <[email protected]>
* SqlCommandTest.cs: Add test for bug#584833
2010-09-28 20:28:44 +05:30
Raja R Harinath cd51491631 Fix a few cases of mixed line-endings
This is a scripted conversion of mixed line-ending files to LF-only or CRLF-only
based on which patch is smaller.  I used a threshold of upto a quarter of the
lines to determine whether to keep the patch or not.
2010-07-26 02:20:13 +05:30
Raja R Harinath b293948fb7 EOL handling
This set of .gitattributes was automatically generated from the list of files
that GIT tried to normalize when I enabled automatic EOL conversion.

With this set of attributes, we prevent automated EOL conversion on files that
we know will cause trouble down the road.
2010-07-25 20:17:39 +05:30
vvaradhan 4613d5956f 2010-07-23 Veerapuram Varadhan <[email protected]>
** Fixes #623451
	* DataColumnCollection.cs (MoveColumn): Fix shifting of
	DataColumn according to the direction of movement.
2010-07-23 22:28:47 +05:30
Veerapuram Varadhan 2ec0a00139 2010-07-23 Veerapuram Varadhan <[email protected]>
** Fixes #565616 - Based on Patch by Hubert FONGARNAND
	* DataContainer.cs (GetContainerData): If typecode is string,
	call Convert.ToString() irrespective of whether value is
	IConvertible or not.
2010-07-23 18:55:50 +05:30
Veerapuram Varadhan b664161029 2010-04-21 Veerapuram Varadhan <[email protected]>
** Fixes #595918
	* Tds70.cs (WriteParameterInfo): Write updated decimal value
	according to specified scale value.

svn path=/trunk/mcs/; revision=155912
2010-04-21 20:21:41 +00:00
Jonathan Pobst 1c0e37a580 2010-01-21 Jonathan Pobst <[email protected]>
* DateComparisonTest.cs: Failing test TestDateComparisonLeft
	marked NotWorking.  Bug filed as 572725.

svn path=/trunk/mcs/; revision=149994
2010-01-21 17:07:48 +00:00
Jonathan Pobst dad1f1ee67 2010-01-21 Jonathan Pobst <[email protected]>
* DataTableTest2.cs: Mark PrimaryKey test as NotWorking.
	Bug filed as 572722.

svn path=/trunk/mcs/; revision=149993
2010-01-21 17:01:10 +00:00
Veerapuram Varadhan 34efb60a62 2009-10-13 Veerapuram Varadhan <[email protected]>
* DataSetTest2.cs (Bug537229_BinFormatSerializer_Test): Added new.

svn path=/trunk/mcs/; revision=143995
2009-10-13 01:13:09 +00:00
Veerapuram Varadhan 92e8a25de8 test break fix.
svn path=/trunk/mcs/; revision=142690
2009-09-26 21:15:11 +00:00
Veerapuram Varadhan 9ea53b0d21 2009-09-26 Veerapuram Varadhan <[email protected]>
** Fixes part of #427769 - Patch by John Lenz <[email protected]>
	* DataSet.cs: XML serialization improvements to be compatible with MS impl.

svn path=/trunk/mcs/; revision=142668
2009-09-26 08:08:22 +00:00
Veerapuram Varadhan 8db39691da 2009-09-15 Veerapuram Varadhan <[email protected]>
** Fixes #536194 - Patch by Andrew Kurochk <[email protected]>
	* MergeManager.cs (Merge*): Do nothing when source and target
	datasets are same.

svn path=/trunk/mcs/; revision=142590
2009-09-24 17:39:57 +00:00
Veerapuram Varadhan 1c5588c2d8 Broken test fix
svn path=/trunk/mcs/; revision=141648
2009-09-09 22:39:24 +00:00
Veerapuram Varadhan b1e0716ffa Fixes tests related to #510176
svn path=/trunk/mcs/; revision=141647
2009-09-09 22:39:03 +00:00
Gonzalo Paniagua Javier 84558bda8f fix
svn path=/trunk/mcs/; revision=140953
2009-08-31 10:10:11 +00:00
Gonzalo Paniagua Javier 91749a356c PAtch by Adam Wendt
svn path=/trunk/mcs/; revision=140952
2009-08-31 09:47:49 +00:00
Veerapuram Varadhan b3fd359ec4 2009-07-23 Adam Wendt <[email protected]>
* Comparison.cs (Compare): Parse string if other object is DateTime
       regardless of which side the DateTime is on.

svn path=/trunk/mcs/; revision=140113
2009-08-17 22:11:38 +00:00
Gert Driesen 812bfb22f4 * sqlserver7.sql: Added script for SQL Server 7.0, with unicode
encoding (as isql7 does not deal well with utf-8).

svn path=/trunk/mcs/; revision=139701
2009-08-11 11:47:32 +00:00
Gert Driesen 5def661365 * SqlDataReaderTest.cs: Fixes for SQL Server 7.0 / TDS 7. Avoid
catching and rethrowing AssertionException. Minor code formatting
changes.

svn path=/trunk/mcs/; revision=139244
2009-08-01 14:38:27 +00:00
Gert Driesen b5fa4ed568 * SqlCommandBuilderTest.cs: Fixes for SQL Server 7.0 / TDS 7.
* SqlCommandTest.cs: Fixes for SQL Server 7.0 / TDS 7.
* SqlConnectionTest.cs: Fixes for SQL Server 7.0 / TDS 7.
* SqlDataAdapterTest.cs: Added tests for Update. Fixed Fill_Test_Data,
Fill_Test_PriKey and Fill_Test_FillErrorTest to pass on SQL Server 7.0.
Avoid catching and rethrowing AssertionException. Minor improvements.
* SqlParameterTest.cs: Fixes for SQL Server 7.0 / TDS 7. Updated
ZeroLengthString to pass on 1.0 profile.
* SqlTransactionTest.cs: Fixes for SQL Server 7.0 / TDS 7.

svn path=/trunk/mcs/; revision=139242
2009-08-01 13:07:28 +00:00
Gert Driesen 3af3766d03 * app-net_1.1.config: added engine config for SQL Server 7.0. Fixed
values of clientVersion.
* app-net_2.0.config: added engine config for SQL Server 7.0. Fixed
values of clientVersion.

svn path=/trunk/mcs/; revision=139238
2009-08-01 12:01:37 +00:00
Gert Driesen 86f912a56e * SqlParameterTest.cs: Improved tests for bug #382589.
svn path=/trunk/mcs/; revision=139119
2009-07-30 19:56:59 +00:00
Gert Driesen 594407eb88 * SqlParameter.cs: Modified ConvertToFrameworkType to only perform
conversion if type of value is different from "system type". Make
DbTypeMapping hashtable available on 1.0 profile, and add missing
mappings. Wrap FormatException adding information on conversion
that failed.
* SqlParameterTest.cs: Added test for bug #526794, and failed
conversion from (zero-length) string to int. Changed spaces to tabs.

svn path=/trunk/mcs/; revision=139116
2009-07-30 19:42:59 +00:00
Veerapuram Varadhan 5c9d9ec104 2009-07-29 Veerapuram Varadhan <[email protected]>
* SqlParameterTest.cs: Marked SqlChars/SqlBytes tests for SqlValue
        as NotWorking as these types are considered as SqlString/SqlBinary
        respectively.

svn path=/trunk/mcs/; revision=139071
2009-07-30 12:37:57 +00:00
Veerapuram Varadhan ea3ee3d074 Test fix.
svn path=/trunk/mcs/; revision=139064
2009-07-30 12:36:07 +00:00
Veerapuram Varadhan 8d5211d815 conflict fix between trunk and local tree
svn path=/trunk/mcs/; revision=139063
2009-07-30 12:35:52 +00:00
Gert Driesen 1925fbede7 * SqlCommandTest.cs: Improved test for invalid statement to cover
CloseConnection behavior.
* SqlCommand.cs: Ensure connection is closed if CloseConnection
behavior is set, and reader could not be created.

svn path=/trunk/mcs/; revision=138854
2009-07-28 17:24:35 +00:00
Gert Driesen 5cc9f25881 * SqlParameter.cs: Improved support for SqlValue and SqlTypes.
* SqlParameterTest.cs: Added/improved tests for SqlValue, and
SqlTypes. Improved tests for char and char [] type inferrence.

svn path=/trunk/mcs/; revision=138699
2009-07-26 19:53:09 +00:00
Atsushi Eno f28350170e migration to newer nunit style.
svn path=/trunk/mcs/; revision=137768
2009-07-13 07:52:51 +00:00
Veerapuram Varadhan 7b01ff9a50 2009-05-26 Veerapuram Varadhan <[email protected]>
** Fixes #382734
	* Tds80.cs: Consider queries with Parameters as RPCs and avoid formatting
	param values as strings.  Fixes issues with locale specific string
	formatting/conversions.

	* TdsRpcProcId.cs: New - enum of rpc Ids to use with RPC packet type.

svn path=/trunk/mcs/; revision=134765
2009-05-26 16:00:45 +00:00
Veerapuram Varadhan 4dcf2b98a9 Nunit 2.4 changes and other sqlserver config fixes
svn path=/trunk/mcs/; revision=134258
2009-05-16 01:16:20 +00:00
Veerapuram Varadhan 29eccae63a Fix for bug #382589 and corresponding tests
svn path=/trunk/mcs/; revision=134257
2009-05-16 01:16:05 +00:00
Gert Driesen d401e17752 * app-net_1.1.config: Added ClientVersion to Engine section. Added
SQL Server 2000 config.
* app-net_2.0.config: Spaces to tabs.

svn path=/trunk/mcs/; revision=129380
2009-03-15 13:32:32 +00:00