When there is an ongoing operation we can't dispose the internal
worker because it might be used by the IO threadpool.
Fixes Novell bug #691076 and Xamarin bug #766.
* System.Net.Sockets/Socket_2_1.cs: Ensure RemoteEndPoint is always
available after ConnectAsync (connected or not, allowed or not).
Ensure the Connect event is fired even if denied by policy.
* System.Net.Sockets/Socket_2_1.cs: Fix some moved code (from
SocketAsyncEventArgs.cs) so should the references to RemoteEndPoint
still point to the SocketAsyncEventArgs instance. Fix some moon-unit
test failures
When trying multiple addresses, the second and sucessive calls to
BeginConnect(IPAddress) will cause an error which we would have to
ignore and then retry. Since this behavior is not documented, we just
close the socket and open a new one for retries is there is already a
pending connect attempt.
Windows/Linux flagged the socket as writable even when connect() has
not been called. On *BSD and OSX, this was not the case and we waited
forever.
Now, for blocking sockets, we make them blocking and call connect()
before adding the socket to the wait pool.
* System.Net/System.Net.Sockets/SocketException_2_1.cs:
* System.Net/System.Net/WebClient_2_1.cs:
* System.Net/System.Net/WebRequest_2_1.cs:
* System/System.Net.Sockets/Socket_2_1.cs:
* System/System.Net/Cookie.cs:
* System/System.Net/DnsEndPoint.cs:
* System/System.Net/EndPoint.cs:
* System/System.Net/IPAddress.cs:
* System/System.Net/IPEndPoint.cs:
* System/System.Net/SocketAddress.cs:
Remove all red ! from corcompare in System.Net.dll (Silverlight
4 profile) to make it easier to pinpoint other errors/warnings.
When disposing a socket that has more than one asynchronous read/write
pending, one of the callbacks could call DisposeAllOnClose() while
another one is waiting on the lock. Once the lock is acquired,
queue.Count will be 0 and Dequeue would fail.
This if fixed now.
Fixes bug #645675.
When possible, schedule the user callback from unmanaged code. We pass
it from the IO pool to the regular pool after our internal callback is
finished.
* System.Net.Sockets/Socket_2_1.cs: Fix, by explicitely throwing an NRE,
the checks in [Receive|Send]Async methods - otherwise an exception would
occur later, on another thread and close the socket (leading to other,
unexpected, exceptions)
* Test/System.Net.Sockets/SocketTest.cs: Add parameter validation test
cases for both ReceiveAsync and SendAsync
* System.Net.Sockets/SocketAsyncEventArgs.cs: Move policy restriction
and elevated trust check outside of loop since its value won't change
based on the ipaddress
* System.Net.Sockets/SocketAsyncEventArgs.cs: Set the Socket
RemoteEndPoint to our RemoteEndPoint on Connect operation.
* System.Net.Sockets/Socket_2_1.cs: Return the 'candidate' EndPoint
provided by SocketAsyncEventArgs in ConnectAsync (intead of null)
until the connection is completed.
The code involved in a delegate BeginInvoke is too heavy and of no use
for socket asynchronous operations. With these changes, we bypass all
that and send the work items directly to the asynchronous IO queue,
improving performance and lowering memory use.
-ConnectAsync() changed to make security checks for all endpoints before
trying to connect for the first time.
-Use the socket Connect() call instead of repeating the same stuff.
Connect should be splitted in 2 pieces (DNS + Connection attempts).
-Removed #if NET_2_0
-All the *Async() calls but ConnectAsync() are routed through the
asynch IO threadpool instead of creating a new short-lived thread for
every operation.
-When reusing a SocketAsyncEventArgs only 1 new object, a delegate, is
created.