Commit Graph
74 Commits
Author SHA1 Message Date
Zoltan Varga 032f313d5f [bcl] Remove NET_4_0 defines from class libs. 2015-01-13 16:06:31 -05:00
Marek Habersack 06dba14e80 [asp.net] Fix for bug #617746. GridRow must auto-bind only properties directly declared in item type
When GridView auto-generates columns it uses reflection to retrieve list of public properties present
in the item type. Only the properties that have bindable type and are declared directly in the item
type must be considered for column auto-generation.
2010-08-12 11:10:51 +02:00
Marek Habersack f9aca58e82 4.0/2.0 metadata updates + some test updates
svn path=/trunk/mcs/; revision=160378
2010-07-14 19:46:01 +00:00
Marek Safar d2cf197fe9 Clean up 2 warnings
svn path=/trunk/mcs/; revision=160247
2010-07-12 14:22:44 +00:00
Marek Habersack d8838a6414 This commit introduces a few 4.0 rendering changes which break some tests. The broken tests
fail to work on .NET 4.0 as well, for the most part. I will fix them next week.

    2010-07-02  Marek Habersack  <[email protected]>

    	* TemplateControlParser.cs: added support for ClientIDMode
    	property

    	* Control.cs: implemented 4.0 features - ClientIDMode and
    	RenderingCompatibility.

    	* ClientIDMode.cs, IDataKeysControl.cs: added

    2010-07-02  Marek Habersack  <[email protected]>

    	* Menu.cs: 4.0 API updates.

    	* GridView.cs: implemented 4.0 properties -
    	SortedAscendingCellStyle, SortedAscendingHeaderStyle,
    	SortedDescendingCellStyle, SortedDescendingHeaderStyle,
    	ClientIDRowSuffix, ClientIDRowSuffixDataKeys, ShowHeaderWhenEmpty
    	along with associated rendering changes.

    	* DetailsView.cs, FormView.cs, GridView.cs: 4.0 API changes -
    	renamed ShowPage to SetPageIndex and made it public.
    	Added 4.0 interfaces to inheritance list and implemented them.

    	* DataKeyArray.cs: added internal constructor which accepts IList
    	instead of ArrayList. Changed the 'keys' field type to IList.

    	* ContainedTable.cs: the 'id' attribute must be rendered last.

    	* CheckBox.cs, CheckBoxList.cs, SiteMapPath.cs, Table.cs,
    	TableStyle.cs, TextBox.cs, WebControl.cs: 4.0 rendering changes.

    	* Calendar.cs, CompositeControl.cs, DropDownList.cs, HyperLink.cs,
    	Image.cs, ImageButton.cs, Label.cs, LinkButton.cs, LoginName.cs,
    	Panel.cs, Table.cs, TableCell.cs, TableRow.cs:
    	added new 4.0 property, SupportsDisabledAttribute.

    2010-07-02  Marek Habersack  <[email protected]>

    	* VersionConverter.cs: added support for checking whether the
    	passed version is equal or more than a specified minimal version.

    	* PagesSection.cs: added two 4.0 properties - ClientIDMode and
    	ControlRenderingCompatibilityVersion

    2010-07-02  Marek Habersack  <[email protected]>

    	* TemplateControlCompiler.cs: added support for ClientIDMode 4.0
    	property

    	* PageCompiler.cs, UserControlCompiler.cs: AddStatementsToInitTop
    	must call the base implementation.

svn path=/trunk/mcs/; revision=159826
2010-07-02 19:12:31 +00:00
Marek Habersack 7e02dfbdc9 Fixes to a bunch of unit tests which would fail when running on .NET and few updates to
our system.web controls.

svn path=/trunk/mcs/; revision=159495
2010-06-24 12:55:00 +00:00
Marek Habersack 221a24b979 - 1.1 code removal
- coding style
- minor optimizations

svn path=/trunk/mcs/; revision=159333
2010-06-22 12:26:13 +00:00
Marek Habersack 2d668e9583 2010-06-21 Marek Habersack <[email protected]>
* BaseValidator.cs, BulletedList.cs, Calendar.cs, CheckBox.cs,
    	CheckBoxList.cs, DataGrid.cs, DropDownList.cs, GridView.cs,
    	HyperLink.cs, ImageButton.cs, LinkButton.cs, ListBox.cs,
    	ListControl.cs, Menu.cs, RadioButton.cs, RadioButtonList.cs,
    	RepeatInfo.cs, Repeater.cs, TextBox.cs, TreeView.cs,
    	ValidationSummary.cs, WebControl.cs: use WebControl.IsEnabled
    	instead of Enabled wherever necessary.

svn path=/trunk/mcs/; revision=159280
2010-06-21 18:41:51 +00:00
Marek Habersack 3f3fd1c424 2010-04-13 Marek Habersack <[email protected]>
* GridView.cs: make sure Header and Footer visibility are set when
	binding the data. Fixes bug #595567

svn path=/trunk/mcs/; revision=155331
2010-04-13 21:31:23 +00:00
Marek Habersack 98fff2b311 2010-03-29 Marek Habersack <[email protected]>
* GridView.cs: main table must be created and added to the
	controls collection before any OnRowCreated event is fired.

svn path=/trunk/mcs/; revision=154386
2010-03-29 16:59:22 +00:00
Marek Habersack 609922272f 2009-10-02 Marek Habersack <[email protected]>
* DynamicValidator.cs: initial implementation

	* DynamicDataManager.cs: implemented OnLoad.
	Better implementation of RegisterControl

	* DynamicDataExtensions.cs: implemented FindDataSourceControl.

2009-10-02  Marek Habersack  <[email protected]>

	* DynamicValidatorTest.cs: added.

2009-10-02  Marek Habersack  <[email protected]>

	* GridView.cs: added two 3.5 properties - SelectedPersistedDataKey
	and IPersistedSelector.DataKey.

	* BaseDataBoundControl.cs: slight optimizations to FindDataSource

svn path=/trunk/mcs/; revision=143278
2009-10-02 11:35:41 +00:00
Marek Habersack db1c3a970d 2009-04-28 Marek Habersack <[email protected]>
* GridView.cs: implemented ColumnsGenerator and enabled its use in
	CreateColumns.

	* DetailsView.cs: implemented the RowsGenerator property and
	enabled its use in CreateFieldSet.

svn path=/trunk/mcs/; revision=132833
2009-04-28 12:14:16 +00:00
Marek Habersack ef9c9e51ce Do not abuse the 'private' keyword
svn path=/trunk/mcs/; revision=116539
2008-10-20 17:37:54 +00:00
Marek Habersack 81c4068d12 2008-10-17 Marek Habersack <[email protected]>
* ImageMap.cs: added the SupportsEventValidation attribute to the
	class.
	Validate the event in RaisePostBackEvent ().
	Register for event validation in Render ().

	* DropDownList.cs, ListBox.cs: validate the event in LoadPostData ().

	* TextBox.cs: validate the event in LoadPostData ().
	Register for event validation in AddAttributesToRender ().

	* HiddenField.cs: validate the event in RaisePostDataChangedEvent.
	Register for event validation in Render ().

	* RadioButton.cs: validate the event in LoadPostData ().
	Register for event validation in InternalAddAttributesToRender.

	* CheckBox.cs, RadioButtonList.cs: validate the event in
	RaisePostDataChangedEvent.

	* Menu.cs: added the SupportsEventValidation attribute to the
	class.
	Validate the event in RaisePostBackEvent ().
	Register for event validation in GetClientEvent ().

	* DetailsView.cs, GridView.cs: validate the event in
	RaisePostBackEvent ().
	Register for validation in GetCallbackScript () and in OnPreRender

	* Button.cs, Table.cs, BulletedList.cs, Calendar.cs, LinkButton.cs,
	ImageButton.cs, TreeView.cs: validate the event in RaisePostBackEvent ().

2008-10-17  Marek Habersack  <[email protected]>

	* Control.cs: added the ValidateEvent internal method, used by
	classes descending from Control to automatically trigger event
	validation.

	* Page.cs: removed the CheckForValidationSupport method. It moved
	to Control.cs
	RaisePostBackEvent no longer validates the events, this
	functionality has been moved to Control.ValidateEvent.

2008-10-17  Marek Habersack  <[email protected]>

	* HtmlInputHidden.cs: validate the event in LoadPostDataInternal.

	* HtmlInputButton.cs: validate the event in
	RaisePostBackEventInternal ().
	Register for event validation in RenderAttributes ()

	* HtmlTextArea.cs: validate the event in
	RaisePostBackDataChangedEvent ().

	* HtmlButton.cs: validate the event in RaisePostBackEvent ().
	Register for event validation in RenderAttributes ()

	* HtmlAnchor.cs: validate the event in RaisePostBackEvent ().
	Register for event validation in RenderAttributes ().

	* HtmlInputRadioButton.cs, HtmlSelect.cs: validate the event in
	LoadPostData.

	* HtmlInputText.cs, HtmlInputImage.cs, HtmlInputCheckBox.cs,
	HtmlInputPassword.cs: validate the event in
	RaisePostDataChangedEvent ().

2008-10-17  Marek Habersack  <[email protected]>

	* MenuAdapterTest.cs: work around event validation failure in the
	test environment.

2008-10-17  Marek Habersack  <[email protected]>

	* PageTest.cs: use a custom version of HtmlInputHidden control to
	work around the new event validation code which doesn't work in
	this instance.

svn path=/trunk/mcs/; revision=116231
2008-10-17 14:56:19 +00:00
Roei Erez cd84894a4b When the RowDataBound event is invoked, the value of GridView1.DataKeys should contains all the keys up untill the current row, and not be empty
svn path=/trunk/mcs/; revision=107820
2008-07-13 11:55:35 +00:00
Marek Habersack a5ecccea52 2008-07-02 Marek Habersack <[email protected]>
* GridView.cs: minor optimizations (removed a foreach loop,
	replaced calls to Array.Length with a variable containing the
	length).

svn path=/trunk/mcs/; revision=107043
2008-07-02 08:06:42 +00:00
Igor Zelmanovich 9bf94370fe 2008-02-25 Igor Zelmanovich <[email protected]>
* GridView.cs:
at Update and Delete use not read only coppies of dictionaries
in event argumens, that allows user to change them before corresponding
DataSource's method is called.


svn path=/trunk/mcs/; revision=96556
2008-02-25 14:44:54 +00:00
Marek Habersack 3476c409c3 2007-12-13 Marek Habersack <[email protected]>
* ClientScriptManager.cs, MasterPageParser.cs, Control.cs,
	Page.cs: speed optimization - use String.Concat instead of
	String.Format in some cases.
2007-12-13  Marek Habersack  <[email protected]>

	* Menu.cs, TreeView.cs: optimize use of String.Format in
	OnPreRender.
	Speed optimization - use String.Concat instead of String.Format in
	some cases.

	* GridView.cs, DetailsView.cs: optimize use of String.Format in
	OnPreRender.

	* CheckBox.cs, AccessDataSource.cs, WebColorConverter.cs,
	WebControl.cs,TextBox.cs, DropDownList.cs, ValidationSummary.cs,
	ListBox.cs, Panel.cs, BaseValidator.cs, LinkButton.cs: speed
	optimization - use String.Concat instead of String.Format in some cases.
2007-12-13  Marek Habersack  <[email protected]>

	* HtmlForm.cs, HtmlButton.cs: speed optimization - use String.Concat
	instead of String.Format in some cases.
2007-12-13  Marek Habersack  <[email protected]>

	* AssemblyResourceLoader.cs: speed optimization - use String.Concat
	instead of String.Format in some cases.
2007-12-13  Marek Habersack  <[email protected]>

	* SessionId.cs: 
	speed optimization - use String.Concat
	instead of String.Format in some cases.
2007-12-13  Marek Habersack  <[email protected]>

	* SqlProfileProvider.cs, ProfileParser.cs: speed optimization -
	use String.Concat instead of String.Format in some cases.
2007-12-13  Marek Habersack  <[email protected]>

	* ApplicationManager.cs, ApplicationHost.cs,
	DefaultVirtualPathProvider.cs: speed optimization - use
	String.Concat instead of String.Format in some cases.

svn path=/trunk/mcs/; revision=91230
2007-12-13 13:50:10 +00:00
Marek Habersack 27037fb3ad 2007-09-19 Marek Habersack <[email protected]>
* GridView.cs: copy attributes from GridView to the child table,
            as this is where the rendering takes place. Fixes bug #326309.


svn path=/trunk/mcs/; revision=86000
2007-09-19 11:41:48 +00:00
Marek Habersack 8c71431f01 2007-08-31 Marek Habersack <[email protected]>
* GridView.cs: instead of not adding hidden fields to the rows,
            mark the cells they would contain as invisible. Fixes bug #82615.

svn path=/trunk/mcs/; revision=85094
2007-08-31 11:30:58 +00:00
Igor Zelmanovich 0afd07a577 2007-07-01 Igor Zelmanovich <[email protected]>
* GridView.cs:
	the Pager is created but unvisible for only one page. 
	the Patch submitted by Dumitru Ban [[email protected]]	

2007-07-01 Igor Zelmanovich <[email protected]>

	* GridViewTest.cs:
	Added new tests


svn path=/trunk/mcs/; revision=81139
2007-07-01 10:58:58 +00:00
Igor Zelmanovich 64055b640d 2007-07-01 Igor Zelmanovich <[email protected]>
* FormView.cs:
	* DetailView.cs:
	* GridView.cs:
	does not requires data binding if any ITemplate property is set.

2007-07-01 Igor Zelmanovich <[email protected]>

	* FormViewTest.cs:
	* DetailViewTest.cs:
	* GridViewTest.cs:
	Added new tests



svn path=/trunk/mcs/; revision=81138
2007-07-01 09:28:15 +00:00
Igor Zelmanovich 3b065bb117 2007-06-24 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed AllowPaging feature:
	When the AllowPaging is true the GridView control should automatically 
	hide the pager row when the data source contains fewer than 2 records.	
	patch Patch submitted by Dumitru Ban [[email protected]]	


svn path=/trunk/mcs/; revision=80611
2007-06-24 07:51:31 +00:00
Igor Zelmanovich 51ce33d915 2007-04-12 Igor Zelmanovich <[email protected]>
* GridView.cs:
	when databound with AutoGenerateColumns = true, 
	data source enumerator created only once.	


svn path=/trunk/mcs/; revision=75865
2007-04-18 10:26:36 +00:00
Marek Habersack 03e6d60374 2007-04-06 Marek Habersack <[email protected]>
* GridView.cs: don't render invisible fields. Fixes bug #80061.

	* DetailsView.cs: don't render invisible fields.


svn path=/trunk/mcs/; revision=75464
2007-04-05 22:13:37 +00:00
Igor Zelmanovich 627c448387 2007-04-05 Igor Zelmanovich <[email protected]>
* GridView.cs:
	* BaseDataBoundControl.cs:
	Break recursion when the property is set from within the OnSelect handler 
	in user's code. fixes bug #81175.	

svn path=/trunk/mcs/; revision=75422
2007-04-05 10:54:30 +00:00
Igor Zelmanovich fc6b1309c0 2007-03-20 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: PageIndex considers PageCount.	

svn path=/trunk/mcs/; revision=74689
2007-03-20 14:55:19 +00:00
Marek Habersack beabee8a4f 2007-03-20 Marek Habersack <[email protected]>
* BaseDataBoundControl.cs: fix as per MSDN - the property is set
	only if data binding doesn't occur.

	* DataBoundControl.cs: avoid endless recursion here. Fixes bug #81175


svn path=/trunk/mcs/; revision=74679
2007-03-20 12:16:16 +00:00
Igor Zelmanovich c3da319cdb 2006-02-18 Igor Zelmanovich <[email protected]>
* GridView.cs: IsBindableType for decimal returns true.

svn path=/trunk/mcs/; revision=73083
2007-02-18 16:13:53 +00:00
Eyal Alalouf 9396a91227 add Http callback support for J2EE portlets.
svn path=/trunk/mcs/; revision=73071
2007-02-18 12:28:38 +00:00
Igor Zelmanovich db6918a3f7 2007-01-31 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: 
	RowDataBound is fired for PagerRow.
	Styles are applied using MergeWith instead CopyFrom 
	to allow using custom styles for rows in code-behind.

svn path=/trunk/mcs/; revision=72022
2007-01-31 13:19:47 +00:00
Igor Zelmanovich acd03f1c5b 2007-01-31 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: RowCommand event is fired properly.


svn path=/trunk/mcs/; revision=72020
2007-01-31 12:23:11 +00:00
Igor Zelmanovich ae1fdb2c7e 2007-01-31 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: created rows are added in table after initialization.
	* BoundField.cs: 	

svn path=/trunk/mcs/; revision=72018
2007-01-31 11:31:46 +00:00
Konstantin Triger 645443b229 don't force creating rows collection when SelectedIndex changes; RequireBinding on select
svn path=/trunk/mcs/; revision=71189
2007-01-17 13:42:45 +00:00
Igor Zelmanovich af12bdb519 2007-01-10 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: header and footer does not appear in no items.
	* CompositeDataBoundControl.cs:


svn path=/trunk/mcs/; revision=70773
2007-01-10 15:02:50 +00:00
Igor Zelmanovich 3f540072ae 2007-01-09 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: SelectedDataKey.


svn path=/trunk/mcs/; revision=70755
2007-01-10 08:12:50 +00:00
Igor Zelmanovich 6c1f56b5fc 2007-01-08 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: show all rows when AllowPaging=false

svn path=/trunk/mcs/; revision=70660
2007-01-08 16:16:12 +00:00
Igor Zelmanovich 5d78df5438 2007-01-08 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed:
	ReadOnly property is false for AutoGeneratedColumn if field is DataKey.
	causesValidation parameter is considered properly in UpdateRow.
	OldValues contains readonly fields values

svn path=/trunk/mcs/; revision=70653
2007-01-08 14:28:13 +00:00
Igor Zelmanovich 75ac380f91 2006-12-31 Igor Zelmanovich <[email protected]>
* ContainedTable.cs:
	* DataControlButton.cs:
	* DetailsView.cs: fixed EnablePagingCallbacks
	* DetailsView.js:
	* GridView.cs:
	* GridView.js: fixed EnableSortingAndPagingCallbacks

svn path=/trunk/mcs/; revision=70284
2006-12-31 14:44:01 +00:00
Igor Zelmanovich 499d009db5 2006-12-28 Igor Zelmanovich <[email protected]>
* DetailsView.cs:
	* GridView.cs:
	* FormView.cs:
	control's behavior depends on using DataSource or DataSourceID 
	property for binding	


svn path=/trunk/mcs/; revision=70165
2006-12-28 13:28:38 +00:00
Igor Zelmanovich 92555407d3 2006-12-11 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: Update works not only for EditRow
	* TemplateField.cs:
	* CompositeDataBoundControl.cs:		


svn path=/trunk/mcs/; revision=69315
2006-12-11 12:37:59 +00:00
Igor Zelmanovich debc8019ba 2006-11-20 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: header, footer and empty rows are databound.


svn path=/trunk/mcs/; revision=68198
2006-11-20 15:10:35 +00:00
Igor Zelmanovich cc6e7588a9 2006-11-14 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: Rows property, DataBinding flow.
	* DataBoundControl.cs:
	* BaseDataBoundControl.cs:		
	

svn path=/trunk/mcs/; revision=67854
2006-11-14 17:18:01 +00:00
Igor Zelmanovich 4465add3ba 2006-11-09 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: DataKeys, PageCount, DataBinding flow.


svn path=/trunk/mcs/; revision=67542
2006-11-08 16:46:25 +00:00
Igor Zelmanovich b2cf26705d 2006-11-01 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: UpdateRow, DeleteRow, RowCreated.


svn path=/trunk/mcs/; revision=67218
2006-11-01 14:03:44 +00:00
Igor Zelmanovich b7b3ecd853 2006-10-23 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: IPostBackContainer.GetPostBackOptions method.
	* DataControlButton.cs:	
	* CommandField.cs: CausesValidation feature must be implemented other way


svn path=/trunk/mcs/; revision=66903
2006-10-23 15:14:28 +00:00
Igor Zelmanovich 901f16172b 2006-10-12 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: EnableSortingAndPagingCallbacks feature.
	when postback is invoked after callback control state is restored
	properly. 


svn path=/trunk/mcs/; revision=66613
2006-10-12 16:52:49 +00:00
Igor Zelmanovich 4df8f73c78 2006-10-12 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: Sorting feature.
	When sorting EditIndex and PageIndex are reseted


svn path=/trunk/mcs/; revision=66597
2006-10-12 12:22:09 +00:00
Igor Zelmanovich e2c1398ca0 2006-10-12 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: Sorting feature.
	CreateDataSourceSelectArguments considers SortExpression and SortDirection.
	(corresponding test does not work because bug in ObjectDataSourceView)


svn path=/trunk/mcs/; revision=66594
2006-10-12 10:33:06 +00:00
Igor Zelmanovich 64fa0dbf78 2006-10-11 Igor Zelmanovich <[email protected]>
* GridView.cs: fixed: 
	CreateDataSourceSelectArguments works according to MSDN.
	(corresponding test does not work because bug in ObjectDataSourceView)


svn path=/trunk/mcs/; revision=66553
2006-10-11 14:15:06 +00:00