* ClientScriptManager.cs, MasterPageParser.cs, Control.cs,
Page.cs: speed optimization - use String.Concat instead of
String.Format in some cases.
2007-12-13 Marek Habersack <[email protected]>
* Menu.cs, TreeView.cs: optimize use of String.Format in
OnPreRender.
Speed optimization - use String.Concat instead of String.Format in
some cases.
* GridView.cs, DetailsView.cs: optimize use of String.Format in
OnPreRender.
* CheckBox.cs, AccessDataSource.cs, WebColorConverter.cs,
WebControl.cs,TextBox.cs, DropDownList.cs, ValidationSummary.cs,
ListBox.cs, Panel.cs, BaseValidator.cs, LinkButton.cs: speed
optimization - use String.Concat instead of String.Format in some cases.
2007-12-13 Marek Habersack <[email protected]>
* HtmlForm.cs, HtmlButton.cs: speed optimization - use String.Concat
instead of String.Format in some cases.
2007-12-13 Marek Habersack <[email protected]>
* AssemblyResourceLoader.cs: speed optimization - use String.Concat
instead of String.Format in some cases.
2007-12-13 Marek Habersack <[email protected]>
* SessionId.cs:
speed optimization - use String.Concat
instead of String.Format in some cases.
2007-12-13 Marek Habersack <[email protected]>
* SqlProfileProvider.cs, ProfileParser.cs: speed optimization -
use String.Concat instead of String.Format in some cases.
2007-12-13 Marek Habersack <[email protected]>
* ApplicationManager.cs, ApplicationHost.cs,
DefaultVirtualPathProvider.cs: speed optimization - use
String.Concat instead of String.Format in some cases.
svn path=/trunk/mcs/; revision=91230
* WebControl.cs: added an internal method, BuildScriptAttribute,
which merges the specified JavaScript code in an attribute, with
the value of that attribute specified by the user.
* CheckBox.cs, DropDownList.cs: AutoPostBack handling makes sure to
preserve user-specified attribute value, if present.
* ListBox.cs, TextBox.cs: AddAttributesToRender calls the base
after doing its job. AutoPostBack handling makes sure to preserve
user-specified attribute value, if present. Fixes bug #327816.
svn path=/trunk/mcs/; revision=86294
* Rationalize the user of MonoTODOs.
- Removed all the TODOs that were only overwritten methods
and had no further information.
- Methods that threw exceptions now have the message "Not
implemnted".
- Methods that return some constant are declared like
that.
- Removed a bunch of stale MonoTODOs that had not been
removed.
svn path=/trunk/mcs/; revision=68620
make rendering of the onclick attribute to consider ValidationGroup property
Page.Validate() is called when CausesValidation=true
svn path=/trunk/mcs/; revision=65571
* TextBox.cs: render the name attribute even when ID is not set. Patch
by Alenxander Concha that fixes bug #79020.
svn path=/trunk/mcs/; revision=64268
* Button.cs: For 2.0 don't add the "name" attribute unless there's an
id.
* DataGrid.cs: Fix TagKey (table) for 2.0.
* DataList.cs: Revert 2.0 specific stuff that was changed in RC.
* DropDownList.cs: For 2.0 don't add the "name" attribute unless
there's an id.
* ListBox.cs: For 2.0 don't add the "name" attribute unless there's an
id.
* RoleGroupCollection.cs: Fix "extra" exception in Remove method.
* Style.cs: Fixed (2.0) RegisteredCssClass to returns String.Empty
(i.e. not null).
* TextBox.cs: For 2.0 don't add the "name" attribute unless there's an
id.
* TreeView.cs: Added declarative security (Link and Inheritance
demands) for Minimal.
* XmlDataSource.cs: Added declarative security (Link and Inheritance
demands) for Minimal.
svn path=/trunk/mcs/; revision=50583
* AccessDataSource.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [ToolboxBitmap] on class.
* AdRotator.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Removed extra Page and ViewState properties.
* BulletedList.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* Button.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Added [SupportsEventValidation] on class (2.0).
* Calendar.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* CheckBox.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* CompositeControl.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added new protected RecreateChildControls method.
* DataControlCommands.cs: Added declarative security (LinkDemands) for
Minimal. Added private ctor.
* DataGrid.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Fixed properties for 2.0 (mostly removing
[Bindable]). Added override for TagKey property.
* DataGridColumn.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [UrlProperty] on HeaderImageUrl (2.0).
* DataGridItem.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added IDataItemContainer interface for 2.0.
* DataGridPagerStyle.cs: Added declarative security (LinkDemands) for
Minimal. Remove [Bindable] from 2.0 and add [Localizable].
* DataList.cs: Removed [Load|Save]ControlState methods.
* DropDownList.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* EditCommandColumn.cs: Added declarative security (Link and
Inheritance demands) for Minimal. Added missing attributes,
[DefaultValue] and [Localize] for 2.0.
* FontInfo.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Remove [Bindable] and added [RefreshProperties]
for 2.0.
* Login.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Fixed IsStyleEmpty. Removed extra [Themeable] attributes.
* ImageButton.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* LinkButton.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* ListBox.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Added [SupportsEventValidation] on class (2.0).
* Literal.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Removed [EditorBrowsable] on CreateControlCollection method.
* LoginStatus.cs: Added missing [Themeable] attributes on properties.
* MenuItemStyle.cs: Changed IsEmpty to public (required to compile -
but will be shown as extra).
* RadioButton.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* RadioButtonList.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* RangeValidator.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added missing [Themeable] attributes.
* RegularExpressionValidator.cs: Added declarative security (Link and
Inheritance demands) for Minimal. Remove [Bindable] from 2.0 and add
[Localizable].
* RoleGroupCollection.cs: Added declarative security (Link and
Inheritance demands) for Minimal. Fixed base class (changed in RC).
Re-implemented CopyTo. Removed some methods.
* Style.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Remove static IsStyleEmpty and ToString (from 2.0). IsEmpty
is now public in 2.0.
* Table.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Added [SupportsEventValidation] on class (2.0).
* TableCell.cs: Fixed PersistenceMode for 2.0.
* TextBox.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Added [SupportsEventValidation] on class (2.0).
* TreeNodeStyle.cs: Changed IsEmpty to public (required to compile -
but will be shown as extra).
* WebControl.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Removed [EditorBrowsable] on ControlStyleCreated
property.
svn path=/trunk/mcs/; revision=50329
* CalendarTest.cs: Test based on an msdn example. Again, I (heart)
anonymous methods.
2005-08-03 Ben Maurer <[email protected]>
* RepeatInfoTest.cs: Test for copying from base control
* WebControlTest.cs: Issue I found while doing repeatinfo
* LabelTest.cs: New tests.
* PanelTest.cs: New tests
2005-07-30 Ben Maurer <[email protected]>
* RepeatInfoTest.auto.cs: Regen.
* RepeatInfoTest.gen.cs: Autogenerate tests for 0 items
2005-07-26 Ben Maurer <[email protected]>
* RepeatInfoTest.cs: Remove tests that are contained below
* RepeatInfoTest.auto.cs: Generated tests.
* RepeatInfoTest.gen.cs: A test generator for repeatinfo
2005-07-20 Ben Maurer <[email protected]>
* DropDownListTest.cs (InitialSelectionMade): Add a test for a
regression that seems to be caused by some change to
ListItemCollection. Add this file to sources as all tests other
than this pass using the old impl of ddl except for this, which is
a regression.
2005-07-19 Ben Maurer <[email protected]>
* UnitConverterTest.cs: New tests
2005-07-07 Ben Maurer <[email protected]>
* FontUnitTest.cs: Make it run on msft
2005-08-05 Ben Maurer <[email protected]>
* HtmlTextWriterTest.cs: Option is rendered as a block.
2005-07-18 Ben Maurer <[email protected]>
* HtmlTextWriterTest.cs: I fixed the nested indents
2005-07-18 Ben Maurer <[email protected]>
* HtmlTextWriterTest.cs: Enable some indentation tests, others
need to be disabled
2005-07-12 Ben Maurer <[email protected]>
* HtmlTextWriterTest.cs: Enable some tests
2005-07-11 Ben Maurer <[email protected]>
* HtmlTextWriterTest.cs: The style attr thing below seems to be a
2.0 ism. Add tests for indentation.
2005-07-11 Ben Maurer <[email protected]>
* HtmlTextWriterTest.cs: Add a test for popping end tags working
correctly.
* ToolboxDataAttributeTest.cs: Don't depend on the way that hash
values are generated. Also, use built strings rather than stuff
from ldstr to make the test a bit stronger.
* PropertyConverterTest.cs: Make this pass on MSFT 1.1
2005-07-08 Ben Maurer <[email protected]>
* HtmlTextWriterTest.cs: Update notworking
2005-07-07 Ben Maurer <[email protected]>
* HtmlTextWriterTest.cs: More tests.
2005-08-04 Ben Maurer <[email protected]>
* HttpContext.cs: Kill a NIE.
2005-07-30 Ben Maurer <[email protected]>
* HtmlForm.cs: Make sure we actually put the "?" in the url
2005-08-05 Ben Maurer <[email protected]>
* HtmlTextWriter.cs: Revert the patch below, see test case
2005-08-03 Ben Maurer <[email protected]>
* HtmlTextWriter.cs: Optmize this not to do insane amounts of
allocation for large pages, etc.
2005-07-29 Ben Maurer <[email protected]>
* StateBag.cs: Don't remove when tracking viewstate, as per msft
docs.
2005-07-29 Ben Maurer <[email protected]>
* StateBag.cs: Actually *remove* items that are null. Duh.
2005-07-18 Ben Maurer <[email protected]>
* HtmlTextWriter.cs: Fix nested indentation
2005-07-18 Ben Maurer <[email protected]>
* HtmlTextWriter.cs: Fix indentation (somewhat at least)
2005-07-17 Ben Maurer <[email protected]>
* AttributeCollection.cs: Use the invariant culture.
* StateBag.cs: "Duh" optimization: return null when there are no
dirty items in the view state
2005-07-14 Ben Maurer <[email protected]>
* StateBag.cs: A "short" version of my favorite method.
* HtmlTextWriter.cs: New method to get the tag name staticly.
2005-07-13 Ben Maurer <[email protected]>
* HtmlTextWriter.cs: Remove debugging spew. Style cleanup
2005-07-12 Ben Maurer <[email protected]>
* HtmlTextWriter.cs: Make styles work.
2005-07-11 Ben Maurer <[email protected]>
* HtmlTextWriter.cs: Missing a PopEndTag here.
* PropertyConverter.cs: Pass tests
2005-07-08 Ben Maurer <[email protected]>
* HtmlTextWriter.cs: Much better compliance with msft
2005-07-07 Ben Maurer <[email protected]>
* StateBag.cs: Noticed an issue where SetDirty was called when the
key did not exist.
2005-07-07 Ben Maurer <[email protected]>
* StateBag.cs: Add a method that gets a string or else a default
value.
2005-07-06 Ben Maurer <[email protected]>
* HtmlTextWriter.cs: Make sure to clear attributes when they are
written.
* StateBag.cs: New impl
2005-07-15 Ben Maurer <[email protected]>
* DataSourceHelper.cs: Obsolete
* DataSourceResolver.cs: Moved from DataSourceHelper.
2005-07-14 Ben Maurer <[email protected]>
* DataSourceHelper.cs: Helper method used for data binding.
2005-08-04 Ben Maurer <[email protected]>
* LinkButton.cs: Fix up the test suite here.
* Panel.cs: Fix up nowrap
2005-08-03 Ben Maurer <[email protected]>
* RepeatInfo.cs: Finally figured out how to use base control
2005-07-31 Ben Maurer <[email protected]>
* TextBox.cs: Html encode for multiline text boxes
* HyperLink.cs: Resolve images
2005-07-30 Ben Maurer <[email protected]>
* RepeatInfo.cs: Handle 0 items situations correctly
* HyperLink.cs: Resolve urls correctly
* CheckBox.cs: use the correct ID for the label element.
* Label.cs: Correct AddParsedSubObject impl. See FAQ
2005-07-29 Ben Maurer <[email protected]>
* Label.cs: ClientID should be used rather than UniqueID to get
the For attribute
2005-07-29 Ben Maurer <[email protected]>
* RadioButton.cs: The "remove from groupstate" isn't needed any
more, now that statebag is correct.
2005-07-28 Ben Maurer <[email protected]>
* CompositeControl.cs: Stub
2005-07-25 Ben Maurer <[email protected]>
* RepeatInfo.cs: WOOHOOO! all tests pass. Boy is this class
cracktastic.
2005-07-25 Ben Maurer <[email protected]>
* RepeatInfo.cs: If the repeater has one column, the separators
are rendered on a different line
2005-07-25 Ben Maurer <[email protected]>
* RepeatInfo.cs: Split the horiz and vertical cases, because this
class has rules that are beyond strange. Continue working to make
my tests work.
2005-07-25 Ben Maurer <[email protected]>
* RepeatInfo.cs: Misc fixes for my test suite.
2005-07-22 Ben Maurer <[email protected]>
* HyperLink.cs: Handle non-literal children.
2005-07-21 Ben Maurer <[email protected]>
* Label.cs: SP1 stuff
2005-07-21 Ben Maurer <[email protected]>
* TextBoxMode.cs: Wrong ordering of enum...
2005-07-21 Ben Maurer <[email protected]>
* RepeatInfo.cs: Fix most of the tests.
2005-07-20 Ben Maurer <[email protected]>
* SelectedDatesCollection.cs: Apprarently, I don't write code well
at 1 am.
* Repeater.cs: Uh, actually add stuff to the items collection
(thanks sp ;-)
2005-07-20 Ben Maurer <[email protected]>
* DataGridColumnCollection.cs: New impl
* TemplateColumn.cs: New impl
2005-07-19 Ben Maurer <[email protected]>
* FontUnit.cs: Corcompare fixes
* UnitConverter.cs: Fix api diffs
2005-07-18 Ben Maurer <[email protected]>
* ListControl.cs: Fix api differences
2005-07-18 Ben Maurer <[email protected]>
* TextBox.cs: Finish this up.
* AdRotator.cs: Fix issues in the test suite. Minor style
cleanups.
* Repeater.cs: Fix a bug where the datasource is null and we do
the binding
* WebColorConverter.cs: Optimize by not doing a concat on a
formatted string.
2005-07-17 Ben Maurer <[email protected]>
* ListItemCollection.cs: Multiple uses of equals rather than
string.compare as below. Remove unreachable code warning.
* WebColorConverter.cs (ConvertTo): Use the == operator on string
rather than an invariant non-case ignoring compare. They are
exactly the same thing. Use proper coding style in this method.
* WebControl.cs: Return null when saving the view state if there
is no state in any of the things we save. This creates a fairly
large savings, because we can avoid saving anything about many
levels of deaply nested controls.
2005-07-15 Ben Maurer <[email protected]>
* Repeater.cs (DoItem): Add the DataItem before we call user
methods, as it seems to be there with msft.
2005-07-15 Ben Maurer <[email protected]>
* Repeater.cs (DoItem): We need to .Add the control *before* we
data bind it so that the state gets tracked correctly. Fixes the
postback test case.
2005-07-14 Ben Maurer <[email protected]>
* WebControl.cs:
- Some optimizations
* Don't use enum formatting stuff, it is 1) expensive 2) does
allocations. Use a new method in HtmlControl to do the right
formatting.
* Don't use Enum.IsDefined but an explicit check.
* (x == "" || x.Length < 2) is not needed since "".Length == 0 < 2
- Use the correct coding style.
2005-07-14 Ben Maurer <[email protected]>
* Repeater.cs: Cleanup; use the DataSourceHelper thingy.
2005-07-14 Ben Maurer <[email protected]>
* Repeater.cs: Get it working
2005-07-14 Ben Maurer <[email protected]>
* Repeater.cs: The beginnings of this control
2005-07-13 Ben Maurer <[email protected]>
* RepeaterItem.cs: Compile fix
* RepeaterItemCollection.cs: New file
* RepeaterItem.cs: get OnBubbleEvent right.
2005-07-13 Ben Maurer <[email protected]>
* RepeaterItem.cs: Stub
2005-07-13 Ben Maurer <[email protected]>
* RepeatInfo.cs: Impl.
2005-07-12 Ben Maurer <[email protected]>
* ListItem.cs: New impl.
2005-07-12 Ben Maurer <[email protected]>
* TextBox.cs: Passwords seem 1) not to be rendered to the client
if set, 2) not kept in view state (for security reasons...)
* LinkButton.cs:
* Button.cs: Page.Validate () if needed. Gets the validator tests
working again.
* TextBox.cs: Properties to get the validator stuff to work.
2005-07-11 Ben Maurer <[email protected]>
* LinkButton.cs:
* Button.cs: Bubble the Command event.
2005-07-11 Ben Maurer <[email protected]>
* Button.cs:
- Clean up style (with my wonderful state bag hack!)
- Fix a view state typo.
- Use AddAttributesToRender
- Don't add an extra <span>
2005-07-09 Ben Maurer <[email protected]>
* TextBox.cs: More work on this
2005-07-09 Ben Maurer <[email protected]>
* TextBox.cs: Add the work I did on this today. It's not complete
yet, but its a start!
2005-07-08 Ben Maurer <[email protected]>
* LinkButton.cs: Command impl
2005-07-08 Ben Maurer <[email protected]>
* LinkButton.cs: Initial impl
2005-07-07 Ben Maurer <[email protected]>
* PlaceHolderControlBuilder.cs: new file
* LabelControlBuilder.cs: New file
* HyperLink.cs: use control builder; fix parsing stuff
* HyperLinkControlBuilder.cs: new file
* Panel.cs: misc fixes
2005-07-07 Ben Maurer <[email protected]>
* PlaceHolder.cs: New file. Seems to do nothing
* Label.cs: Use my new statebag trick to reduce typing
* HyperLink.cs: New file
2005-07-06 Ben Maurer <[email protected]>
* Unit.cs: cctor not needed; static fields are 0 init'd by default
* WebControl.cs: Kothari & Datye's book explains how these work.
* IRepeatInfoUser.cs: Reimpl.
svn path=/trunk/mcs/; revision=48921
* Button.cs, ImageButton.cs: Interpret PostBackOptions.ClientSubmit
correctly.
* CommandField.cs: Mostly implemented.
* Menu.cs: Use callback methods moved to ClientScriptManager.
* DataControlButton.cs: Internal control used to implement buttons
for navigating in data bound controls.
* DataControlField.cs, PagerSettings.cs: Use the new DataControlButton
to render the column headers.
* CheckBox.cs, RadioButton.cs, BulletedList.cs, TextBox.cs
DropDownList.cs, Calendar.cs, ListBox.cs, LinkButton.cs, TreeView.cs:
Don't use Page.GetPostBackClientEvent
since it is deprecated in 2.0.
* GridView.cs: Implemented some several interfaces.
Implemented support client sorting and page navigation (using callbacks).
Implemented the autogenerated command column using the new CommandField
class.
* ButtonFieldBase.cs: Implemented.
* GridView.js: New helper script to support client side sorting and
paging in the grid view.
svn path=/trunk/mcs/; revision=41698
* HyperLinkColumn.cs, Label.cs: Added missing 2.0 properties.
* RadioButton.cs: Added missing 2.0 methods.
* ListItem.cs: Added Enabled property.
* MailMessageEventArgs.cs: Use the correct message class.
* ListControl.cs: Implemented missing properties and support for
control state. Implemented base RenderContents method.
* Image.cs: Implemented DescriptionUrl and GenerateEmptyAlternateText
properties.
* BaseCompareValidator.cs: Implemented methods that support conditional
use of the invariant culture.
* DataBoundControl.cs: Set RequiresDataBinding to true in OnLoad.
* SqlDataSourceCommandEventArgs.cs, SqlDataSourceStatusEventArgs.cs:
It takes a DbCommand instead of a IDbCommand.
* GridViewSortEventArgs.cs: Added SortDirection property.
* TextBox.cs, CheckBoxList.cs: Added protected version of
IPostBackDataHandler methods.
* RadioButtonList.cs: Added protected version of
IPostBackDataHandler and IRepeatInfoUser methods.
* Repeater.cs: Updated some method names.
* DropDownList.cs: Added protected version of
IPostBackDataHandler methods. Reuse RenderContents from base class.
* RepeaterItem.cs, Localize.cs, Literal.cs: Fix inheritance.
* GridViewUpdatedEventArgs.cs: Fix typo.
* ListBox.cs: Added protected version of IPostBackDataHandler methods.
Reuse RenderContents from base class.
* BaseDataBoundControl.cs: Several fixes.
* ImageButton.cs, LinkButton.cs: Implemented several 2.0 properties.
svn path=/trunk/mcs/; revision=40772
* TextBox.cs: don't save the Text if in ViewState if it's a password.
Save it if the control is not visible or not enabled. Fixes bug #58497.
svn path=/trunk/mcs/; revision=27549
* System.Web.UI/AttributeCollection.cs:
(Add): handle 'style' through styleCollection.
* System.Web.UI/CssStyleCollection.cs:
(fillStyle): renamed to FillStyle and made it internal.
* System.Web.UI/Page.cs:
(GetViewStateString): fixed, broken after other recent changes.
(ProcessPostData): allow a second try for postback data after OnLoad.
(ProcessRequest): clear controls collection, removed call to
UnloadRecursive.
* System.Web.UI.HtmlControls/HtmlControl.cs: the attributes must use
ViewState as its StateBag, if not style values are lost between
postbacks.
* System.Web.UI.WebControls/TextBox.cs: default for Wrap is true.
(OnPreRender): don't save Text if there are no listeners on TextChanged.
svn path=/trunk/mcs/; revision=5954
* RadioButton.cs: mono-stylized and some little fixes.
* TextBox.cs: mono-stylized.
(MaxLength): fixed typo.
(AddAttributesToRender): don't render the text between the tags for
SingleLine, use value attribute for it. Don't render the text for
Password.
(OnPreRender): don't throw exception and call base.OnPreRender.
(Render): for MultiLine, render the text between the opening and
closing tags encoded as HTML.
svn path=/trunk/mcs/; revision=5263