Commit Graph
34 Commits
Author SHA1 Message Date
lateralusX 68d1fceba9 Fix race related to final event signaling in RegisteredWaitHandle.
We have seen sporadic failures in thread pool tests on CI related to
test case:

System.Threading.ThreadPools.Tests.ThreadPoolTests.QueueRegisterPositiveAndFlowTest [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   1
      Stack Trace:
          at System.Threading.ThreadPools.Tests.ThreadPoolTests.QueueRegisterPositiveAndFlowTest () [0x00143] in D:\j\workspace\z3\label\w64\external\corefx\src\System.Threading.ThreadPool\tests\ThreadPoolTests.cs:337
          at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
          at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in D:\j\workspace\z3\label\w64\mcs\class\corlib\System.Reflection\RuntimeMethodInfo.cs:395

Finally managed to track down the issue to a race when using the same final
event in sequential calls to RegisterWaitForSingleObject. The event could, depending on
timing, get signaled multiple times for the same RegisterWaitHandle instance
causing a thread waiting for completion on another RegisterWaitHandle using same event
to be signaled before that callback was completed. That will cause the race seen in the
failing test above.

Fix make sure we only signal the final event one time per RegisterWaitHandle
instance.
2019-06-26 07:12:16 -05:00
Marek Safar 088cbe3b04 [System.Private.CoreLib] Remove unused members and further cleanups 2019-05-29 09:44:58 +02:00
Marek Safar 00c43ce6e8 [System.Private.CoreLib] Resolve APIs mismatches 2019-05-27 17:32:26 +02:00
Marek Safar 6751700b20 [System.Private.Corelib] More nullable types tweaks 2019-05-22 12:47:11 +02:00
Egor Bogatov 64fe6a054c [netcore] Add Microsoft.Private.CoreFx.OOB package to corefx-restore.csproj (#14559)
* Add Microsoft.Private.CoreFx.OOB package

* Add GC.GetTotalAllocatedBytes stub

* Add missing icalls

* Add more tests to ignore

* Update GC.cs

* Add more tests to ignore

* Update Monitor.cs
2019-05-22 12:32:05 +02:00
Marek Safar dc683e5cd3 Fix the build 2019-04-29 22:47:13 +02:00
Zoltan Varga 569be02071 [netcore] Fix the tests. (#14108)
* [netcore] Fix the tests.

* Fix Monitor class too.
2019-04-18 08:23:01 +02:00
Zoltan Varga 9e10afd3d6 [netcore] Create netcore specific versions of refsource classes. (#14074) 2019-04-17 08:56:16 +02:00
Egor Bogatov 8cd9b562ea [netcore] Fix WaitHandle.SignalAndWait (#13809)
* fix failing tests

* Add build-corefx-test-for- rule

* Update WaitHandle.cs

* fix S.T.T.rsp file

* fix build

* bump corlib version

* handle new errors in old mono

* Update w32handle.c
2019-04-16 12:04:02 +02:00
Filip Navara 7ac572217d [netcore] Make System.Private.CoreLib and host APIs compilable on Windows (#13943)
* Fix Windows builds of CLR hosting API

* Make System.Private.CoreLib compilable on Windows

* Remove accidental change

* Fix Unix build

* Update GlobalizationMode.cs

* Update GlobalizationMode.Unix.cs
2019-04-14 18:58:40 +02:00
Filip Navara a1e65c0559 [netcore] Fix TrySetApartmentStateUnchecked return value 2019-04-01 23:04:41 +02:00
Filip Navara 9ccfd778e3 [System.Private.CoreLib/mscorlib] Implement Interlocked.MemoryBarrierProcessWide (#13712)
* Implement Interlocked.MemoryBarrierProcessWide

* Bump MONO_CORLIB_VERSION

* Bump API snapshot submodule
2019-03-31 12:08:51 +02:00
Filip Navara d261a9ace1 [netcore] Implement missing functions in RegisteredWaitHandle and EventWaitHandle 2019-03-28 08:30:20 +01:00
Filip Navara 7a74f15949 [netcore] Fix stack size for new threads 2019-03-27 15:23:59 +01:00
Zoltan Varga 4bb8637454 [netcore] Fix some thread failures. 2019-03-27 09:15:45 +01:00
Egor Bogatov b3287d7157 [netcore] Semaphore (#13627)
* Update Semaphore.cs

* netcore Semaphore

* Update Semaphore.cs
2019-03-25 08:51:52 +01:00
Egor Bogatov e72d6d9e1c [netcore] Implement missing bits in Mutex (#13591)
Needed for xunit console runner tool.
2019-03-22 18:54:20 +01:00
Egor Bogatov 36a62bbf8a [netcore] Implement missing bits in ThreadPool (#13566)
* implement missing bits in ThreadPool

* remove [SecurityCritical]
2019-03-21 11:29:43 +01:00
Zoltan Varga 0f798ae6cf [netcore] Ongoing work. (#13357)
* [netcore] Implement MethodBody using internal Runtime* classes. Use the mono version for ModuleHandle.

* [netcore] Reflection fixes.

* Address review comments.

* [netcore] Implement RuntimeHelpers:GetUninitializedObject ().

* [netcore] Implement the Type::GetMethod () overload which has a genericParameterCount parameter.

* [netcore] Implement Thread.OptimalMaxSpinWaitsPerSpinIteration.

* Revert a change to fix a test failure.

* [netcore] Implement Marshal:GetExceptionForHRInternal ().

* [netcore] Implement GC:GetSegmentSize ().

* [runtime] Allow pointer type members in typed references.
2019-03-09 05:26:40 -05:00
Marek Safar c96df417d1 Remove code moved to shared 2019-03-07 00:42:25 +01:00
Zoltan Varga f82ae71c90 [netcore] Fix threading. 2019-03-03 13:42:10 +01:00
Marek Safar 519139773f Fix the build 2019-03-03 12:01:00 +01:00
Zoltan Varga 4970e055b3 [netcore] Implements threads. (#13245)
* [netcore] Implements threads.

There is only one thread object, since there are no domains.

* Make the start callback internal.
2019-03-01 15:15:31 -05:00
Marek Safar a88ad66551 Build fixes 2019-02-28 23:05:24 +01:00
Marek Safar 4c4421f30d Fix the build 2019-02-28 22:41:40 +01:00
Dotnet-GitSync-Bot 2b4bff1956 Mirror changes from mono/coreclr (#13192)
This PR contains mirrored changes from mono/coreclr


**Please REBASE this PR when merging**

 cc @grant-d
2019-02-26 23:59:38 +01:00
Marek Safar ecef8d334a [System.Private.CoreLib] Implement more APIs 2019-02-25 13:51:30 +01:00
Marek Safar 34c3055a7c Move Interlocked 2019-02-15 09:25:26 +01:00
Marek Safar dc323ae290 Remove local SynchronizationContext 2019-02-05 10:20:12 +01:00
Marek Safar c40885324e Remove local Timer copy 2019-01-27 22:45:35 +01:00
Dotnet-GitSync-Bot f76994e0a1 Mirror changes from mono/coreclr,corert (#12612) 2019-01-25 14:01:09 +01:00
Marek Safar 9f16ba6567 Fix the build 2019-01-24 11:15:35 +01:00
Marek Safar 76fcb3343d Fix the build 2019-01-24 00:09:19 +01:00
Marek Safar 2c6ec113ff [System.Private.CoreLib] Initial build pass (#12450)
* [System.Private.CoreLib] Initial build pass

* Add temporary files not officialy converted to allow to build the library

* Formatting changes

* master rebase

* Fixes build

* Doc tests update

* Bump API snapshot submodule
2019-01-17 23:25:23 +01:00