* ControlBuilder.cs: on the 2.0 profile BindingContainerType
returns the associated control's base type when parent builder is
absent instead of typeof (Control). It returns typeof (Control) if
the parent builder type is determined to be a
NamingContainer. This makes the generated code match the MS.NET
output. Fixes bug #82119.
2007-07-18 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: on the 2.0 profile, GetContainerType
does not look up the Item/Items properties to determine the
container type, instead it just returns the type reported by the
builder passed to this method. This change makes the generated
code match MS.NET. Fixes bug #82119.
svn path=/trunk/mcs/; revision=82200
* TemplateControlCompiler.cs: don't use StartWith to see if a
variable's value is a bind expression, as it erroneously renames
all calls to methods starting with the string Bind. Use a regular
expression now instead. Fixes bug #81928.
svn path=/trunk/mcs/; revision=81172
* TemplateControlCompiler.cs: make sure control has a writable
TemplateControl property prior to assigning values to it.
svn path=/trunk/mcs/; revision=79348
* TemplateControlCompiler.cs: TemplateControl is assigned for
controls that are placed within ContentPlaceHolder and not for the
ContentPlaceHolder itself.
No longer add the overriden version of TemplateSourceDirectory to
the generated source, all the work is now done in
Control.TemplateSourceDirectory.
* BaseCompiler.cs: AppRelativeVirtualPath shouldn't end with a
slash, for compatibility with MS.NET
2007-06-09 Marek Habersack <[email protected]>
* TemplateControl.cs: make sure TemplateControl is set to the
current control.
* Control.cs: TemplateControl property goes up the parent chain if
the property isn't defined in the current control.
TemplateSourceDir finally implemented correctly.
2007-06-09 Marek Habersack <[email protected]>
* ControlTest.cs: enabled two tests that hadn't been working
before.
svn path=/trunk/mcs/; revision=79021
* TemplateControlCompiler.cs: TemplateSourceDirectory in the 2.0
profile uses the TemplateControl property instead of Parent. This
allows to return the correct path.
2007-06-05 Marek Habersack <[email protected]>
* Control.cs: TemplateSourceDirectory uses TemplateControl to
lookup the virtual source directory in the 2.0 instead of the
Parent.
ResolveClientUrl copes with empty TemplateSourceDirectory in the
correct way now - the check is made after the basePath checks.
The changes above make ResolveClientUrl work properly when called
from within a control residing in a TemplateControl.
svn path=/trunk/mcs/; revision=78624
* TemplateControlCompiler.cs: Changed a few incorrect
ObjectCreationExpression to the correct DelegateCreationExpression.
Fixes#81706.
svn path=/trunk/mcs/; revision=77950
* ResourceExpressionBuilder.cs: added a static method to generate
a GetLocalResourceObject call which properly handles types which
cannot be converted from strings.
* TemplateControlCompiler.cs: use code described above to generate
code for properties assigned from resources.
svn path=/trunk/mcs/; revision=77437
* TemplateControlCompiler.cs: BuildTemplateMethod is a delegate,
so use a delegate create expression - it may make difference for
languages other than C# (e.g. VisualBasic).
svn path=/trunk/mcs/; revision=76923
2007-05-04 Marek Habersack <[email protected]>
* HtmlAnchor.cs: use ResolveClientUrl when generating
attributes. Necessary if the control is in a master page which is
in a different directory than the current page.
2007-05-04 Marek Habersack <[email protected]>
* AdRotator.cs: use the new GetPhysicalFilePath method to look up
the physical path of the ad file.
2007-05-04 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: do not query the parent for
TemplateSourceDirectory if we are generating code for a Master
Page.
2007-05-04 Marek Habersack <[email protected]>
* Control.cs: added an internal method to resolve a physical path
to a file from its virtual path considering the possibility that a
control is placed in a master page, which in turn is referenced
from a directory another than that of master page itself.
svn path=/trunk/mcs/; revision=76665
* TemplateControlCompiler.cs: fix generation of code for
declarative attribute assignments of the form Font-Size="small"
(i.e. when a font size is assigned a symbolic, relative size
value). This fixes for example rendering of the 0th level of
TreeView controls.
svn path=/trunk/mcs/; revision=76472
Use GetExpressionFromString to generate a correct expression for
custom page/control attributes. Fixes bug #81132.
svn path=/trunk/mcs/; revision=74980
Process meta:resourcekey after all the field/attribute assignments
are done. Fixes bug #80809.
Clean the code up a bit.
svn path=/trunk/mcs/; revision=74973
* TemplateParser.cs: support the meta:resourcekey attribute in
Page and Control directives. Fixes bug #81204.
2007-03-26 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: refactor assining properties from
resources a bit to support pages and user controls. Fixes bug
#81204.
svn path=/trunk/mcs/; revision=74972
* TemplateControlCompiler.cs: added support for setting custom
attributes of a base class from the Page or Control directive
attributes.
2007-03-21 Marek Habersack <[email protected]>
* UnknownAttributeDescriptor.cs: an internal helper class for
custom directive attributes support.
* BaseParser.cs: ThrowParseException can now take variadic
parameters, for convenience.
* TemplateParser.cs: add support for custom attributes for the
Page and Control directives.
2007-03-21 Marek Habersack <[email protected]>
* System.Web.dll.sources: added UnknownAttributeDescriptor.cs
svn path=/trunk/mcs/; revision=74734
builders that have no control type. Fixes bug #81092
* TemplateControlCompiler.cs:
Make sure builders are in valid state before trying to use them.
svn path=/trunk/mcs/; revision=74171
* TemplateParser.cs: name generated classes the same way MS.NET
does - include the app-relative path to the control/page in the
class name.
* PageCompiler.cs: interfaces are to be implemented by the parent
partial class, not the generated one.
* TemplateControlCompiler.cs:
Put field declarations for controls in the partial class.
* BaseCompiler.cs:
Change the generated code model for pages/controls to comply with
the way MS.NET does (partial class contains only two properties
plus declarations of all the controls, the actual control/page
class inherits from the partial class). Fixes bug #81001.
svn path=/trunk/mcs/; revision=74167
* AppResourceFilesCollection.cs: added separate constructor for
local resources handling.
* TemplateControlCompiler.cs: request the local resource object
with proper virtual path.
* BaseCompiler.cs: added code to assing AppRelativeVirtualPath
property in the page/control constructor.
* AppResourcesCompiler.cs: does not require specifying manually
whether it's a global or local resource compiler anymore. New
constructors take care of that.
Changed to compile local resources on demand, when a control/page
is parsed.
2007-03-13 Marek Habersack <[email protected]>
* AppResourceFilesCollection.cs: added separate constructor for
local resources handling.
* TemplateControlCompiler.cs: request the local resource object
with proper virtual path.
* BaseCompiler.cs: added code to assing AppRelativeVirtualPath
property in the page/control constructor.
* AppResourcesCompiler.cs: does not require specifying manually
whether it's a global or local resource compiler anymore. New
constructors take care of that.
Changed to compile local resources on demand, when a control/page
is parsed.
2007-03-13 Marek Habersack <[email protected]>
* TemplateControl.cs: implement AppRelativeVirtualPath. Closes bug
#80634.
svn path=/trunk/mcs/; revision=74159
* HttpContext.cs (GetGlobalResourceObject): remove unused variable.
* StaticFileHandler.cs (ProcessRequest): remove unused variable.
* HttpApplication.cs (ProcessError): Remove unused variable.
2007-01-20 Miguel de Icaza <[email protected]>
* ClientBuildManager.cs: Remove unused variable (this could be a
real problem, we never use the appPhysicalTargetDir)
* AssemblyBuilder.cs: Remove unused field.
* AppResourceFilesCollection.cs: Remove unused field.
* TemplateControlCompiler.cs (GetExpressionFromString): Remove
unused variable.
* AppResourcesCompiler.cs: Remove unused variable.
* AppSettingsExpressionBuilder.cs (GetAppSetting): remove unused
parameter.
* PageCompiler.cs: Put InternalCreatePageProperty inside the
NET_2_0 block to eliminate warnings.
2007-01-20 Miguel de Icaza <[email protected]>
* HandlerFactoryConfiguration.cs (LoadType): remove unused
variable.
(ctor): do not assign parent, we do not use it, keep the code for
reference.
2007-01-20 Miguel de Icaza <[email protected]>
* ApplicationManager.cs: Remove unused variable.
(ShutdownAll) remove unused variables.
* ApplicationHost.cs: Protect create_dir lock
2007-01-20 Miguel de Icaza <[email protected]>
* SqlRoleProvider.cs: comment out unused code.
* SqlMembershipProvider.cs: Removed unused variables.
Remove unused variable.
* AnonymousIdentificationModule.cs (ClearAnonymousIdentifier):
remove unused variable. This might be a real bug.
2007-01-20 Miguel de Icaza <[email protected]>
* SessionStateModule.cs: Removed unused variables.
2007-01-20 Miguel de Icaza <[email protected]>
* SessionDictionary.cs: Removed unused variable (dirty).
2007-01-20 Miguel de Icaza <[email protected]>
* XhtmlTextWriter.cs: comment out unused code.
* ThemeProvider.cs: comment out unused code.
* DataSourceView.cs: Comment unused variable.
* ClientScriptManager.cs: Put the expandoAttributes inside the 2.0
code
* Control.cs: Put _templateControl inside the NET_2_0 ifdef
2007-01-20 Miguel de Icaza <[email protected]>
* HtmlHead.cs: comment out unused code, in particular metadata is
commented out because nothing could have triggered its creation.
* HtmlButton.cs: Move declaration of `csm' inside the 1.1 case.
2007-01-20 Miguel de Icaza <[email protected]>
* DataControlFieldCollection.cs (RemoveAt): remove unused
variable.
* RoleGroupCollection.cs (OnValidate): Flag as protected, as it
should not show up.
* RadioButton.cs (RaisePostDataChangedEvent): This method was not
used in 1.0, so put the whole method in 2.0
2007-01-20 Miguel de Icaza <[email protected]>
* WebPart.cs: Remove
* PersonalizableAttribute.cs: Remove extra API that was wrong as well.
2006-11-28 Miguel de Icaza <[email protected]>
* WebPart.cs:
2007-01-20 Miguel de Icaza <[email protected]>
* FileUtils.cs (CreateTemporaryFile): Remove unused variable.
svn path=/trunk/mcs/; revision=71399
* TemplateControlCompiler.cs: fixed:
When <%# Bind(...) %>-expression is used more then once for same control
The variable associated with this control is declared only once.
svn path=/trunk/mcs/; revision=68150
* TemplateControlCompiler.cs: fixed: Bind functions (Data-Binding Syntax).
At run time, the Bind method calls the Eval method, if there is DataItem
!= null to bind to.
If there is DataItem == null (like InsertItemTemplate in FormView) Bind
method don't raise exception and works properly to extract data from
bounded controls on postback.
svn path=/trunk/mcs/; revision=66192
* TemplateControlCompiler.cs: An attempt to fix the regression
introduced in r58505 (a bug fix for 77762). This was reported in
the mailing list with a batch of new 2.0 failures.
We really need a test suite in NUnit to check on ASP.NET aspx
svn path=/trunk/mcs/; revision=59249
* System.Web.UI/ControlBuilder.cs: when creating a default property
builder, handle strings specially.
* System.Web.UI/StringPropertyBuilder.cs: new builder used in
TextBox 2.0.
* System.Web.dll.sources: add StringPropertyBuilder.
* System.Web.Compilation/TemplateControlCompiler.cs: handle the new
StringPropertyBuilder.
Fixes bug #77762.
svn path=/trunk/mcs/; revision=58505
* TemplateControlCompiler.cs (InitMethod): when generating the
call to ApplyStyleSheetSkin, don't just blindly pass "this" as the
argument to it. Only do that if the class we're compiling is
actually a subclass of Page. If it's not, pass this.Page.
svn path=/trunk/mcs/; revision=57910
* AspGenerator.cs: refactor the parsing code so that we can
initiate parsing from outside this class.
* PageCompiler.cs (PrependStatementsToFrameworkInitialize): new
method, add our StyleSheetTheme assignment here.
(AppendStatementsToFrameworkInitialize): rename AddStatements* to
this.
* TemplateControlCompiler.cs (EnsureID): make protected.
(CreateAssignStatementsFromAttributes): same
(AddChildCall): same.
(CreateControlTree): same.
(CreateFrameworkInitializeMethod): change
"AddStatementsToFrameworkInitialize" to
"AppendStatementsToFrameworkInitialize", and add call to
"PrependStatementsToFrameworkInitialize" before the generation of
"base.FrameworkInitialize()."
* PageThemeCompiler.cs (CreateControlSkinMethod): remove spew.
svn path=/trunk/mcs/; revision=57674
2006-03-02 Chris Toshok <[email protected]>
* Control.cs (ApplyStyleSheetTheme): remove the exception, and add
a MonoTODO.
* Page.cs (Theme): implement setter/getter.
(StyleSheetTheme): same.
* PageParser.cs (ProcessMainAttributes): parse the Theme and
StyleSheetTheme attributes.
In System.Web.UI.WebControls:
2006-03-02 Chris Toshok <[email protected]>
* WebControl.cs (SkinID): implement setter/getter, and have them
just chain up to base.SkinID.
In System.Web.Compilation:
2006-03-02 Chris Toshok <[email protected]>
* TemplateControlCompiler.cs (InitMethod): emit an assignment for
SkinID just after the creation of our object, and right after that
call "_ctrl.ApplyStyleSheetSkin (page)".
(CreateAssignStatementsFromAttributes): split out the majority of
this code to CreateAssignStatementFromAttribute, and change this
method to simply a loop over the attribute keys. In the 2.0 case,
skip the SkinID property, since that's handled explicitly in
InitMethod.
* PageCompiler.cs (AddStatementsToInitMethod): emit assignments
for Theme and StyleSheetTheme.
svn path=/trunk/mcs/; revision=57516
* System.Web.UI/WebHandlerParser.cs:
* System.Web.UI/WebServiceParser.cs:
* System.Web.UI/UserControlParser.cs:
* System.Web.UI/PageParser.cs: added new ctor that uses a TextReader
as input.
* System.Web.UI/TemplateControlParser.cs: new Reader property.
* System.Web.UI/SimpleWebHandlerParser.cs: new Reader property and
ctor.
* System.Web.dll.sources: added new files.
* System.Web.Compilation/GlobalAsaxCompiler.cs:
* System.Web.Compilation/PageCompiler.cs:
* System.Web.Compilation/TemplateControlCompiler.cs: CreateMethods is
now internal.
* System.Web.Compilation/WebServiceBuildProvider.cs:
* System.Web.Compilation/PageBuildProvider.cs:
* System.Web.Compilation/UserControlBuildProvider.cs:
* System.Web.Compilation/WebHandlerBuildProvider.cs: new build
providers.
* System.Web.Compilation/BuildProvider.cs: add assemblies.
* System.Web.Compilation/BaseCompiler.cs: expose the provider and the
compile unit through properties.
svn path=/trunk/mcs/; revision=56878
* TemplateControlCompiler.cs (AddParsedSubObjectStmt): append the
calls to AddParsedSubObject to a special statement collection --
builder.flushOutputStatements -- not to builder.method.Statements.
(InitMethod): initially, set flushOutputStatements to
method.Statements. If we're dealing with a ContentPlaceHolder,
set flushOutputStatements to be the else block of a conditional we
create. This causes the compiled control to fall back to the
ContentPlaceHolder's child controls in case there's no
corresponding Content template.
(AddChildCall): use methodStatements instead of method.Statements.
(CreateControlTree): same.
* PageCompiler.cs (CreatePropertyAssign): factor out the
string,string implementation and add one that also takes a
CodeExpression; make the string,string implementation call the
three arg one with thisRef.
(AddStatementsToInitMethod): make use of the 3-arg form of
CreatePropertyAssign to reduce code. Also, add support for
setting the page's Title from the parser's Title.
svn path=/trunk/mcs/; revision=56639
* TemplateControlCompiler.cs (AddParsedSubObjectStmt): append the
calls to AddParsedSubObject to a special statement collection --
builder.flushOutputStatements -- not to builder.method.Statements.
(InitMethod): initially, set flushOutputStatements to
method.Statements. If we're dealing with a ContentPlaceHolder,
set flushOutputStatements to be the else block of a conditional we
create. This causes the compiled control to fall back to the
ContentPlaceHolder's child controls in case there's no
corresponding Content template.
* PageCompiler.cs (CreatePropertyAssign): factor out the
string,string implementation and add one that also takes a
CodeExpression; make the string,string implementation call the
three arg one with thisRef.
(AddStatementsToInitMethod): make use of the 3-arg form of
CreatePropertyAssign to reduce code. Also, add support for
setting the page's Title from the parser's Title.
svn path=/trunk/mcs/; revision=56635
* UserControlCompiler.cs (AddStatementsToInitMethod): emit code to
assign __ctrl.MasterPageFile to our master page, if we have one.
* PageCompiler.cs (CreateContructor): remove the MasterPageFile
assignment from here.
(AddStatementsToInitMethod): and move it here.
* TemplateControlCompiler.cs (InitMethod): in the case where
builder is a RootBuilder (we're building the __BuildControlTree
method), call a virtual method so that subclasses can add their
own statements to the method (used by both Page and MasterPage);
Also, in the RootBuilder case, the argument should be the
parser.ClassName type (the class we're building); lastly, expand
the ContentPlaceHolder logic to include all the
ContentTemplates/InstantiateIn magic.
(AddStatementsToInitMethod): empty virtual method.
(AddContentTemplateInvocation): ContentControlBuilder ->
ContentControlBuilderInternal.
(CreateControlTree): same.
(CallBaseFrameworkInitialize): new function, create call to
base.FrameworkInitialize.
(CreateFrameworkInitializeMethod): call CallBaseFrameworkIniitialize.
svn path=/trunk/mcs/; revision=56619