* PagedDataSource.cs: fix IsLastPage. All tests pass.
* DataGrid.cs: InitializePager always add a cell and it's brand new. No
need to keep the old one in a field. Now all tests pass here too.
svn path=/trunk/mcs/; revision=50983
* PagedDataSource.cs: don't use the properties when they just return a
field. Fixed Count when paging is enabled. In GetEnumerator, IList goes
before ICollection (otherwise, an IList will always fall under the
ICollection case). The enumerator for lists will be empty if 'start'
is beyond the list size. All existing tests pass, but one in
DataGridTest that fails because of some problem with the paging.
svn path=/trunk/mcs/; revision=50972
* System.Web_test.dll.sources: add new test.
* System.Web.UI/AttributeCollection.cs: avoid code duplication and
don't add "style" to the bag, or it will overwrite the settings made
by CssStyleCollection.
* System.Web.UI/CssStyleCollection.cs: make it throw where MS throws.
Minimize the number of times we create the "style" string and take
care of updating it for the AttributeCollection. FillStyle and
BagToString are now private. One should use the 2.0 (internal in <2.0)
Value property.
* System.Web.UI.WebControls/Style.cs: avoid unnecesary creation of a
CssStyleCollection and instead write the style attributes directly to
the HtmlTextWriter.
* System.Web.UI.WebControls/CheckBox.cs: adapted to new API.
* DataGrid.cs: handle null data sources. Fixed the contions that make
the table to be added to the Controls collection.
* System.Web.UI.WebControls/Calendar.cs: the table needed an ID and the
attributes from the parent. Also don't create the ControlStyleCollection
if it has not already been created.
svn path=/trunk/mcs/; revision=50931
* DataGrid.cs: fix another test. The ID of the table generated by the
datagrid is set to the one on the datagrid if no one set the ID for the
table.
svn path=/trunk/mcs/; revision=50831
* FontUnit.cs: use a table for FontSize names, as the X{1,2}.* ones are
converted to string as X{1,2}-.*. All FontUnitTests pass now.
* Unit.cs: throw a format exception when there's not number or minus
sign in the first non-whitespace character.
svn path=/trunk/mcs/; revision=50821
* ListControl.cs: SelectedIndex/SelectedValue can be set before
DataBinding () is called on the control, so we have to keep this values
around and use them after the data is read. If both properties are
used, they must refer to the same item.
svn path=/trunk/mcs/; revision=50814
* DataList.cs: fill in the data keys from BaseDataList so that the
events can see them. Only assign DataItem when using data binding and
nullify it after all events are raised. Thanks to Joe Audette for quick
updates on this.
svn path=/trunk/mcs/; revision=50695
* Button.cs: For 2.0 don't add the "name" attribute unless there's an
id.
* DataGrid.cs: Fix TagKey (table) for 2.0.
* DataList.cs: Revert 2.0 specific stuff that was changed in RC.
* DropDownList.cs: For 2.0 don't add the "name" attribute unless
there's an id.
* ListBox.cs: For 2.0 don't add the "name" attribute unless there's an
id.
* RoleGroupCollection.cs: Fix "extra" exception in Remove method.
* Style.cs: Fixed (2.0) RegisteredCssClass to returns String.Empty
(i.e. not null).
* TextBox.cs: For 2.0 don't add the "name" attribute unless there's an
id.
* TreeView.cs: Added declarative security (Link and Inheritance
demands) for Minimal.
* XmlDataSource.cs: Added declarative security (Link and Inheritance
demands) for Minimal.
svn path=/trunk/mcs/; revision=50583
* BaseDataList.cs: it's the DataKeysArray what is stored in "DataKeys",
not the DataKeys.
* DataGrid.cs: add the keys to BaseDataList.DataKeysArray. When using
a data source, first try reflection, then componentmodel. If we get
an enumerator, keep it around, as MS only calls GetEnumerator once.
Throw an exception if no columns can be created from the given data
source. Tested with DbDataRecord, DataTable, ArrayList and
ICustomTypeDescriptor.
svn path=/trunk/mcs/; revision=50335
* AccessDataSource.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [ToolboxBitmap] on class.
* AdRotator.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Removed extra Page and ViewState properties.
* BulletedList.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* Button.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Added [SupportsEventValidation] on class (2.0).
* Calendar.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* CheckBox.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* CompositeControl.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added new protected RecreateChildControls method.
* DataControlCommands.cs: Added declarative security (LinkDemands) for
Minimal. Added private ctor.
* DataGrid.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Fixed properties for 2.0 (mostly removing
[Bindable]). Added override for TagKey property.
* DataGridColumn.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [UrlProperty] on HeaderImageUrl (2.0).
* DataGridItem.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added IDataItemContainer interface for 2.0.
* DataGridPagerStyle.cs: Added declarative security (LinkDemands) for
Minimal. Remove [Bindable] from 2.0 and add [Localizable].
* DataList.cs: Removed [Load|Save]ControlState methods.
* DropDownList.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* EditCommandColumn.cs: Added declarative security (Link and
Inheritance demands) for Minimal. Added missing attributes,
[DefaultValue] and [Localize] for 2.0.
* FontInfo.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Remove [Bindable] and added [RefreshProperties]
for 2.0.
* Login.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Fixed IsStyleEmpty. Removed extra [Themeable] attributes.
* ImageButton.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* LinkButton.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* ListBox.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Added [SupportsEventValidation] on class (2.0).
* Literal.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Removed [EditorBrowsable] on CreateControlCollection method.
* LoginStatus.cs: Added missing [Themeable] attributes on properties.
* MenuItemStyle.cs: Changed IsEmpty to public (required to compile -
but will be shown as extra).
* RadioButton.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* RadioButtonList.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added [SupportsEventValidation] on class (2.0).
* RangeValidator.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Added missing [Themeable] attributes.
* RegularExpressionValidator.cs: Added declarative security (Link and
Inheritance demands) for Minimal. Remove [Bindable] from 2.0 and add
[Localizable].
* RoleGroupCollection.cs: Added declarative security (Link and
Inheritance demands) for Minimal. Fixed base class (changed in RC).
Re-implemented CopyTo. Removed some methods.
* Style.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Remove static IsStyleEmpty and ToString (from 2.0). IsEmpty
is now public in 2.0.
* Table.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Added [SupportsEventValidation] on class (2.0).
* TableCell.cs: Fixed PersistenceMode for 2.0.
* TextBox.cs: Added declarative security (Link and Inheritance demands)
for Minimal. Added [SupportsEventValidation] on class (2.0).
* TreeNodeStyle.cs: Changed IsEmpty to public (required to compile -
but will be shown as extra).
* WebControl.cs: Added declarative security (Link and Inheritance
demands) for Minimal. Removed [EditorBrowsable] on ControlStyleCreated
property.
svn path=/trunk/mcs/; revision=50329
* TableStyle.cs: fixed typo that prevented restoring GridLines from
a saved viewstate.
* DataGrid.cs: the table does not get an auto ID. When restoring from
viewstate, use all the saved columns, not just that data bound ones. Set
the owner of the BoundColumns created. Save/restore columns.
OnItemCreated happens after the item is initialized and the data item is
set before the event and nullified after OnItemDataBound.
Add the render_table to the Controls immediately, otherwise we might get
errors from child controls such as "must be rendered inside a form".
Keep the items created in the list waiting for them.
The table uses the attributes from the DataGrid and ControlStyle.
Raise OnItemCommand on all bubble events and don't propagate bubble
event up in the hierarchy
* TableCell.cs: it does not get an automatic ID.
* BoundColumn.cs: FormatDataValue returns an empty string on null input
(there was already a test for this).
Fixes bug #76117.
svn path=/trunk/mcs/; revision=50218
* DataGrid.cs: merge column styles too. Fixes bug #76106.
* DataGridColumn.cs: new internal method to retrieve the styles without
creating an instance for them.
svn path=/trunk/mcs/; revision=50109
* Style.cs: corcompare stuff.
* RequiredFieldValidator.cs: more corcompare stuff.
* CheckBoxList.cs: clean up some of the interface methods vs
protected virtual 2.0 calls.
* SubMenuStyle.cs: corcompare says this should implement
ICustomTypeDescriptor... sooo, make it.
svn path=/trunk/mcs/; revision=49984
* TableCell.cs: do the same as HyperLink and others in
AddParsedSubobject so that adding a literal control does not remove the
existing controls if any. Fixes bug #76078.
svn path=/trunk/mcs/; revision=49980
* ListItem.cs: throw in AddParsedSubObject if the object is not a
LiteralControl.
* RadioButtonList.cs: implemented LoadPostData and
RaisePostDataChangedEvent.
svn path=/trunk/mcs/; revision=49841
* FontInfo.cs (IsEmpty): new internal property, used by
Style.IsEmpty.
* Style.cs (IsEmpty): make sure the fontinfo is null or empty as
well.
svn path=/trunk/mcs/; revision=49824
* Calendar.cs (WriteDay): always add BackColor=Silver,
ForeColor=White to selected day cells, before copying over the
selectedDayStyle, if it exists.
(WriteDays): fix nunit test - if the first day of the month falls
on the first day of the week, go back one week (effectively adding
a row of dates from the previous month.)
(WriteTitle): don't copy the control style to the tableTitle,
since it might have height specifications, which would make the
title look rather off.
svn path=/trunk/mcs/; revision=49672
* ValidationSummary.cs (AddAttributesToRender): we only set
display=none if there are no errors.
* BaseValidator.cs (OnPreRender): fix a JS error - on submit we
call ValidatorOnSubmit, not ValidatorCommonOnSubmit.
svn path=/trunk/mcs/; revision=49658
* ListControl.cs (SelectedIndex): add comment about how you'd
think OnSelectedIndexChanged would be called.. and you'd be wrong.
(Text): implement in terms of SelectedValue.
(TagKey): do the HAVE_CONTROL_ADAPTERS two-step.
(LoadControlState): implement - this is where the selected index
ArrayList gets stuffed in 2.0.
(OnInit): call Page.RegisterRequiresControlState.
(OnTextChanged): implement.
(RenderContents): for now just chain up to base.RenderContents.
(SaveControlState): save our control state properly.
(GetSelectedIndices): split this out from SaveViewState to it can
be used by both that and SaveControlState.
(SaveViewState): mangle this function so it works in both 2.0 and
1.0.
(LoadViewState): same.
svn path=/trunk/mcs/; revision=49612
* ValidationSummary.cs (Render): only do the JS stuff when the
validators on the page are uplevel.
* BaseValidator.cs (Render): remove unnecessary comment.
svn path=/trunk/mcs/; revision=49557
* Various places: make sure that the DefaultValue matches the
type. Thanks to Michael for pointing this out.
In future audits, you might want to use the following awk command:
awk '/DefaultValue/ { v=$0; looking = 1; } /public/ && looking &&
!/string/ && !/ int / && !/ bool / { print FILENAME; print v;
print $0; looking = 0; } /public/ && looking { looking = 0; } '
*.cs
The above skips bools, strings and ints as those were fine as we
set them. The bug was on the other ones.
svn path=/trunk/mcs/; revision=49274