Commit Graph
16 Commits
Author SHA1 Message Date
Andres G. Aragoneses 7c6f4bf67b [Microsoft.Build.BuildEngine] More NET_2_0 removal 2012-09-15 18:48:28 +01:00
Alan McGovern 961e2cf4ad [Xbuild] Use OrdinalIgnoreCase not InvariantCultureIgnoreCase
It's chewing up a fair bit of CPU time and buys us nothing. We only care
about ordinal ignore case for these scenarios.
2012-06-30 18:55:38 -04:00
Ankit Jain bc9997b296 Fix warnings.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-10-13  Ankit Jain  <[email protected]>

	* DirectoryScanner.cs:
	* ExpressionCollection.cs:
	* GroupingCollection.cs:
	* Project.cs:
	* Target.cs: Fix warnings.

In class/Microsoft.Build.Framework/Mono.XBuild.Framework:
2009-10-13  Ankit Jain  <[email protected]>

	* AssemblyLoadInfo.cs: Fix warning.

In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
	* ResolveAssemblyReference.cs: Fix warnings.

2009-10-13  Ankit Jain  <[email protected]>

In class/Microsoft.Build.Utilities/Microsoft.Build.Utilities:
2009-10-13  Ankit Jain  <[email protected]>

	* TaskLoggingHelper.cs:
	* ToolTask.cs: Fix warnings.

svn path=/trunk/mcs/; revision=144002
2009-10-13 09:09:07 +00:00
Ankit Jain 2f3d65b5c3 In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
* Expression.cs (ExpressionOptions): New.

	Introduce a ExpressionOptions argument to all ConvertTo*
	methods. Implement the rule: in evaluation phase, expand
	all items completely, but dont expand item refs in properties.
	At other times, expand the item refs in the properties.
	See comments in Expression.cs, for a full explanation.
	* BuildItem.cs: Track api changes.
	* BuildItemGroup.cs: Likewise.
	* BuildProperty.cs: Track api changes. Handle self-references.
	* BuildTask.cs: Track api changes.
	* IReference.cs: Add ExpressionOptions param.
	* ItemReference.cs: Track api changes.
	* PropertyReference.cs: Likewise.
	* MetadataReference.cs: Likewise.
	* ExpressionCollection.cs: Track api changes. Add support for
	converting all primitive types and DateTime, instead of a fixed
	few.
	* Project.cs (GetMetadataBatched): Use the evaluated metadata.
	* TaskBatchingImpl.cs: Handle the case when batching is required,
	but no items are available.

	* TaskEngine.cs: Throw on unsupported types. Correctly handle
	properties in case of empty values.

In class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine:

	* BuildItemTest.cs (TestSetMetadata5a): New.
	* ProjectTest.cs: Add tests for different property types
	with required attribute. Also, check the values - null or
	empty array.
	* TestTasks.cs: Add new tasks for above.

In class/Microsoft.Build.Engine/Test/resources:

	* TestTasks.cs: Add new tasks for different property types
	with required attribute. Also, emit whether the value was
	null or a zero length array.

In class/Microsoft.Build.Engine/Test/various:

	* Items.cs: Add tests for property/item evaluation.

svn path=/trunk/mcs/; revision=140911
2009-08-28 21:55:29 +00:00
Ankit Jain 6cd0309d85 In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
Fix bug #512535.
	* ExpressionCollection.cs (ConvertToITaskItemArray): Whitespace around a
	itemref is allowed if the prev/next element is ";".

In class/Microsoft.Build.Engine/Test/various:

	* Items.cs (TestItemsInTarget3a): Add another case for valid whitespace
	around an item ref.

svn path=/trunk/mcs/; revision=136000
2009-06-12 14:04:06 +00:00
Ankit Jain 9d370c21e6 * ExpressionCollection.cs (ConvertToObject): Allow true/on/yes
as valid true values for bool, and corresponding for false.

svn path=/trunk/mcs/; revision=132720
2009-04-27 11:41:06 +00:00
Ankit Jain 0b9db4baca Improve expression parsing, esp for concat'ing expressions.
In class/Microsoft.Build.Engine:

	* Microsoft.Build.Engine.dll.sources: Add IReference.cs

In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:

	* IReference.cs: New. Interface for Item/Metadata/PropertyReference.
	* ChangeType (ToBuildItemGroup): Add 'split' param.
	Track api changes.
	* Expression.cs (Parse): Add a new overload with a 'split' param.
	* ExpressionCollection.cs (Add): Add new overload for IReference,
	remove the ones for Item/Metadata/PropertyReference.
	(ConvertToArray): Implement correctly.
	(ConvertToString): Track api changes.
	(ConvertToITaskItem): Implement with ConvertToITaskItemArray.
	(ConvertToITaskItemArray): Implement support for concat'ing expressions.
	(AddItemsToArray): New.
	(ConvertToITaskItemArrayFromString): Refactor a bit.
	(ThrowCantConcatError): New.
	* ItemReference.cs: Update.
	* MetadataReference.cs: Update.
	* PropertyReference.cs (ConvertToITaskItemArray): Implement.
	(GetValue): New.
	* BuildPropertyGroup.cs: Track api changes.
	* TaskEngine.cs (PublishOutput): Improve exception message.
	* Project.cs (DoLoad): Improve exception message. Add a null check.

In class/Microsoft.Build.Engine/Test/various:

	* Items.cs: Add tests for expression parsing, mainly for concat'ing
	expressions. Remove "NotWorking" for some tests that are working now.

svn path=/trunk/mcs/; revision=122310
2009-01-01 08:38:13 +00:00
Ankit Jain 363b18904a In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
* ExpressionCollection.cs (ConvertToITaskItemArray): Add support for
	MetadataReference.
	* MetadataReference.cs (ConvertToITaskItemArray): New.
	* Project.cs (GetAllItemGroups): New.

In class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine:

	* ProjectTest.cs (TestBatchedMetadataRef*): New tests for metadata
	references.

In class/Microsoft.Build.Engine/Test/resources:

	* TestTasks.cs (BatchingTestTask): New.

svn path=/trunk/mcs/; revision=119668
2008-11-21 20:27:57 +00:00
Ankit Jain 70e34156f1 Added support for batching.
svn path=/trunk/mcs/; revision=119570
2008-11-21 02:40:13 +00:00
Marek Sieradzki fb310b62f9 2007-03-06 Marek Sieradzki <[email protected]>
* ExpressionCollection.cs (ConvertToArray): Simplify.


svn path=/trunk/mcs/; revision=73834
2007-03-06 19:22:28 +00:00
Marek Sieradzki f92b1040d8 2007-02-18 Marek Sieradzki <[email protected]>
* ExpressionCollection.cs (ConvertToITaskItemArrayFromString):
		Simplified.

	* ConditionFunctionExpression.cs: Removed warnings.

	* BuildTask.cs (Execute): Write exceptions to std err (they should be
	       logged but it's better than swallowing).



svn path=/trunk/mcs/; revision=73072
2007-02-18 13:04:26 +00:00
Marek Sieradzki 52f8ef62f9 006-12-16 Marek Sieradzki <[email protected]>
* ItemPropertyGroupingBase.cs, TaskEngineAssemblyResolver.cs: Removed
        classes that were public in Beta 2 and aren't used.

        * Expression.cs: Added replacement for parsing expressions char by
        char. It uses regexes to find item/property/metadata references in
        given text.

        * ExpressionCollection.cs, BuildTask.cs, ConditionFactorExpression.cs,
        Target.cs, TaskEngine.cs, BuildItemGroup.cs, UsingTask.cs, Import.cs,
        BuildItem.cs, BatchingImpl.cs, BuildProperty.cs: Track API changes.

        * ConditionRelationalExpression.cs: Formatting.

        * OldExpression.cs: Commented everything.

        * MetadataReference.cs, ItemReference.cs, PropertyReference.cs: Moved
        parsing to Expression.

        * BuildItem.cs: Check if project is from XML in set_Condition and
        set_Exclude.

        * BuildPropertyGroup.cs, Project.cs: Add ImportedProject to 
        Project.ctor.

        * ConditionNotExpression.cs, ConditionAndExpression.cs: Check if we
        can evaluate expression in CanEvaluateToBool ().


svn path=/trunk/mcs/; revision=69557
2006-12-15 23:35:11 +00:00
Marek Sieradzki 5d3f072e91 2006-09-20 Marek Sieradzki <[email protected]>
* ConditionParser.cs: Copyright note.
        * ExpressionCollection.cs: Fixed arrays passing.


svn path=/trunk/mcs/; revision=65700
2006-09-20 10:47:33 +00:00
Marek Sieradzki c654ca4dc0 2006-08-15 Marek Sieradzki <[email protected]>
* BuildTask.cs, UsingTaskCollection.cs, ImportCollection.cs,
        Target.cs, TaskDatabase.cs, TaskEngine.cs, BuildItemGroup.cs,
        BuildChoose.cs, DirectoryScanner.cs, BuildPropertyGroup.cs,
        TargetCollection.cs, Engine.cs, Project.cs: Started to use generics.


svn path=/trunk/mcs/; revision=63750
2006-08-15 09:29:31 +00:00
Marek Sieradzki 3f72f57672 2006-05-05 Marek Sieradzki <[email protected]>
* ExpressionCollection.cs, BuildItemGroup.cs, BuildItem.cs,
        ItemReference.cs, PropertyReference.cs: Changed name of *Reference
        methods converting reference to string from ToString () to
        ConvertToString () to avoid mistakes like using ToString () provided
        by default.


svn path=/trunk/mcs/; revision=60322
2006-05-05 18:52:31 +00:00
Marek Sieradzki 6a406d6c72 2006-05-03 Marek Sieradzki <[email protected]>
* Target.cs, TaskEngine.cs, BuildItemGroup.cs, MetadataReference.cs,
        Import.cs, ItemReference.cs, BuildItem.cs, BatchingImpl.cs,
        PropertyReference.cs, BuildProperty.cs: Changed Expression to
        OldExpression and changed To* functions to one ConvertTo ().
        * TaskEngine.cs: Fixed PublishOutput ().
        * OldExpression.cs: Added. It will be temporarily used before
        LiteralExpression will be written using Tokenizer.
        * Tokenizer.cs, Token.cs, ExpressionCollection.cs,
        ExpressionParseException.cs, LiteralExpression.cs: Added.


svn path=/trunk/mcs/; revision=60212
2006-05-03 10:44:05 +00:00