* Test/System.Data/DataViewTest2.cs :
- Tests for ToTable overloads
- Test for Equals method
- Tests to check for the Sort, RowFilter values when
DataView is created and when Table is set.
* Test/System.Data/DataViewTest_IBindingList.cs :
- Ensure tests do not depend on the order of
execution.
* Test/System.Data/DataViewTest_IBindingListView.cs : New
- Tests for IBindingListView interface methods
* System.Data.Common/Index.cs :
- GetAllRows : Added. Returns all the rows in the current
index.
- GetDistinctRows :Added. Returns all the distinct rows (based
in Key Columns) in the index.
* System.Data.dll.sources:
- Added to build :
Test/System.Data/DataViewTest_IBindingListView.cs
* System.Data/DataView.cs :
- ToTable : Implemented all the overloads
- Equals : Implemented
- IBindingListView : Implemented the interface
svn path=/trunk/mcs/; revision=62669
* Test/System.Data/DataSetTest2.cs : Test the behavior of EnforceConstraints
* Test/System.Data/DataViewTest_IBindingList.cs : Test to ensure the correct index is
used for comparision
* Test/System.Data/DataRowTest2.cs : Test to ensure the RowErrors and ColumnErrors are
filled correctly.
* System.Data.Common/Key.cs :
-Equals : Check for Equality of Sort Order too.
* System.Data/DataSet.cs :
- InternalEnforceConstraints : Check if any null constraints
are violated. Throw ConstraintException only after all the errors
are filled.
* System.Data/DataTable.cs :
- EnforceConstraints : Move away the logic to check for
NullConstraintViolation.
- AssertNotNullConstraint : Checks for Null Constraint
Violation.
- EndLoadData : Do not throw any exceptions here. All the
errors have to be found and RowErrors set before throwing the
exception.
* System.Data/DataRow.cs :
- ImportRecrod : Check the values of the row for any null
values.
- SetColumnError : If the error for column is already set,
do not add a new error but edit the existing error.
- CheckValue : Set the NullConstraintViolation flag if either
table is being loaded or if EnforceConstraints is set to
false.
* System.Data/Constraint.cs : Do not throw exception when EnforceConstraints is
set to false or table is being loaded.
* System.Data/UniqueConstraint.cs : Correct the error message. Set ColumnErrors
along with the RowError.
svn path=/trunk/mcs/; revision=61744
* Test/ProviderTests/System.Data.SqlClient/SqlCommandBuilderTest.cs :
- Corrected the testcase to check for queries corresponding to
ms.net 2.0
- verify that columns that do not allow nulls are not included
in the null-checks.
- Added testcase to check for DBConcurrencyException for
Delete Command.
- Check the DataType of the null-check parameters
* System.Data.Common/DbDataAdapter.cs :
* Update () : If the Update/Delete Query has a null check,
then populate the parameter value correctly.
* System.Data.SqlClient/SqlCommandBuilder.cs :
* CreateDeleteCommand ()
* CreateUpdateCommand ()
* CreateInsertCommand ()
- Changed the signature. Do not need DataRow parameter
as the Query generated is parametric.
- Correct the null-check term in the WhereClause, set the
correct properties for null-check parameter
fixes#78027
- Modified the generated query to match the query as
generated by 2.0. We now ignore null-check in the
whereclause if the Column does not allow nulls.
* ctor () : Set QuotePrefix and QuoteSuffix for 2.0 profile
* GetUpdateCommand ()
* GetInsertCommand ()
* GetDeleteCommand ()
- Do not create new command everytime. Create only if
not already created.
* RefreshSchema : Reset the commands.
svn path=/trunk/mcs/; revision=59175
* Test/System.Data/DataRowCollectionTest2.cs :
* Test/System.Data/DataTableTest2.cs :
- Fixed NotWorking tests.
* System.Data.Common/Index.cs :
- Update () : Add the new record in the correct position
* System.Data/DataRow.cs :
- RejectChanges () : Add the row to index, if it was in deleted state and
Update the index if in Modified State.
- AcceptChanges () : Do not update the Indexes.
- EndEdit () : Update the indexes even if BeginLoadData has been called
on the table. Ideally, indexes should not be maintained during DataLoad,
but this needs to handled in multiple places correctly. For now, just maintain
the index to ensure correct operation.
svn path=/trunk/mcs/; revision=57725
* Test/System.Data/DataRowCollectionTest2.cs : Check if index is maintained for row on calling RejectChanges.
* Test/System.Data/DataTableTest2.cs : Check if data is loaded and merged (if key exists) correctly.
* Test/System.Data/ForeignKeyConstraintTest.cs : Check if a ParentColumn value can be modified
when the row is in 'Added' State. Also, check if child col values are
updated correctly.
* Test/ProviderTests/System.Data.SqlClient/SqlAdapterTest.cs : Added testcases for verifying FillError Behavior
* System.Data.Common/DbDataAdapter.cs :
- FillTable : Move BeginLoadData, EndLoadData outside the loop. Also,
move EndLoadData outsidet try,catch block. FillError is only for errors
occuring during loading the data into datatable.
* System.Data.Common/Key.cs :
- Set Default value of RowStateFilter to (CurrentRos | OriginalRows).
- ContainsVersion : If RowStateFilter is set to default value, return true
for Modified Rows as they can contain Default/Original versions.
* System.Data/DataRow.cs
- RejectChanges : Do not remove Row from Indexes when state is Deleted.
- CheckChildRows : When checking for the ChildRows, use the current value
and not the original value.
svn path=/trunk/mcs/; revision=57149
* DbProviderFactory.cs: remove two methods. and mark the
DbProviderSupportedClasses ctor as internal since it's not part of
the public api.
* DbTable.cs: remove this class from 2.0 build.. leave it for the
JVM build, I guess?
* RowUpdatingEventArgs.cs: this class isn't abstract in 2.0.
* RowUpdatedEventArgs.cs: this class isn't abstract in 2.0.
* SupportedJoinOperators.cs: new 2.0 enum.
* CatalogLocation.cs: fix enum values.
* GroupByBehavior.cs: same.
* IdentifierCase.cs: same.
* SchemaTableColumn.cs: class is static, not sealed. and add
missing elements.
* SchemaTableOptionalColumn.cs: same.
svn path=/trunk/mcs/; revision=57008
* DbDataReader.cs: oops, add back in VisibleFieldCount (i missed
it in the corcompare output), add EditorBrowsable attributes all
over the place, and fix some method signatures.
svn path=/trunk/mcs/; revision=57000
* Test/ProviderTests/System.Data.SqlClient/SqlAdapterTest.cs : Added testcases for #77480
* System.Data.Common/DbDataAdapter.cs :
- FillSchema :
- Add table to schema only if MissingSchemaAction is not Ignore
Add schema to table if MissingSchemaAction is set to either of
Add or AddWithKey
- BuildSchema :
- Set the Schema values only if MissingSchemaAction is set to
AddWithKey
svn path=/trunk/mcs/; revision=56830
* Mono.Data.Tds/Mono.Data.Tds.Protocol/Tds.cs :
- Modified GetSqlMoney () , to set the precision and Scale correctly.
- Modified ProcessColumnDetails , to set the schema values correctly.
* Mono.Data.Tds/Mono.Data.Tds.Protocol/TdsDataColumn.cs : Added some default values for the column schema
* System.Data/Test/ProviderTests/ProviderIndependant/DataReaderTest : Corrected a failing testcase.
* System.Data/Test/ProviderTests/System.Data.SqlClient/SqlCommandBuilderTest.cs : corrected a failing testcase
* System.Data/System.Data.SqlTypes/SqlDateTime : Corrected the MaxValue for SqlDateTime
* System.Data/System.Data.Common/DbDataAdapter.cs :
- Modified schema population to follow MissingSchemaAction and MissingMappingAction
- Add a column to the Primary Key only if its not a hidden key
- Added some argument checks
- Removed some redundant code
* System.Data/System.Data.Common/DataAdapter :
- Added argument checks
* System.Data/System.Data.Common/ExceptionHelper :
- Added InvalidEnumException , a helper function to print error msg
* System.Data/System.Data.SqlClient/SqlCommandBuilder.cs :
- Modified CreateUpdateCommand,CreateDeleteCommand , to not include
column name in the query if its a expression col.
Also, modified the queries to match the generated queries in ms.net
* System.Data/System.Data.SqlClient/SqlCommand.cs :
- Modifed Prepare, to check if Parameter is explicitly initialized
* System.Data/System.Data.SqlClient/SqlParameter.cs :
- Added CheckIfInitialized : Checks if datatype is explicitly set and
non-zero size is set for variable datatypes.
* System.Data/System.Data.SqlClient/SqlDataReader.cs :
- Added code for GetSqlBinary ()
- Fixed GetFieldCount ()
- Added more checks and exceptions.
Fixes most of the failing SqlClient Provider Tests .
svn path=/trunk/mcs/; revision=56167
* Test/ProviderTests/System.Data.SqlClient/SqlDataAdapterTest.cs :
- Added Testcase for bug #76433.
* In System.Data.Common/DbDataAdapter.cs :
- BuildSchema() : Set the value of DataColumn Property 'AllowDBNull'
as returned by database. Fixes bug#76433.
svn path=/trunk/mcs/; revision=51791
2005-08-05 Sureshkumar T <[email protected]>
* DbDataAdapter.cs:
- Update (): set parameter values only after getting the
appropriate command from command builder. Close reader only if it
is not closed before. Use parameter's SourceVersion. Whitespace
corrections to comply with standard.
In System.Data.SqlClient:
2005-08-05 Sureshkumar T <[email protected]>
* SqlCommandBuilder.cs: Set SourceVersion property to the created
parameters as it is used by the Adapter's Update method.
In System.Data.Odbc:
2005-08-05 Sureshkumar T <[email protected]>
* OdbcDataReader.cs: RecordsAffected: get value from command.
GetSchemaTable (): set IsExpression based on BaseTableName. set
AllowDBNull to false if the column is PK.
* OdbcCommand.cs: correct UpdatedRowSource is returned. whitespace
changes to conform to standard.
* OdbcCommandBuilder.cs: Implemented.
* OdbcParameter.cs: Direction is set to Input by default.
svn path=/trunk/mcs/; revision=48043
2005-07-22 Sureshkumar T <[email protected]>
* DataColumnMappingCollection.cs: updated attributes & attribute
descriptions to match with masterinfos.
In System.Data.SqlClient:
2005-07-22 Sureshkumar T <[email protected]>
* SqlCommandBuilder.cs, SqlParameterCollection.cs,
SqlConnection.cs, SqlParameter.cs:
- updated attributes & attribute descriptions to match with
masterinfos.
In System.Data:
* DataViewSettingCollection.cs, DataTableCollection.cs,
DataSet.cs, DataView.cs, DataColumn.cs, ForeignKeyConstraint.cs,
DataRelationCollection.cs, UniqueConstraint.cs, DataTable.cs,
DataColumnCollection.cs, DataRelation.cs, DataSet.cs:
- updated attributes & attribute descriptions to match with
masterinfos.
In System.Data.Odbc:
* OdbcParameter.cs: updated attributes & attribute descriptions to
match with masterinfos.
svn path=/trunk/mcs/; revision=47554
2005-07-15 Sureshkumar T <[email protected]>
* DataTableMappingCollection.cs: GetTableMappingBySchemaAction:
meaningful error message if mapping is missing.
* DbDataAdapter.cs: Update: meaningful message if table is missing.
In System.Data.SqlClient:
2005-07-15 Sureshkumar T <[email protected]>
* SqlCommandBuilder.cs:
- set_DataAdapter: unsubscribe event if DataAdapter is reset.
- CreateInsertCommand, CreateUpdateCommand, CreateDeleteCommand:
if column mapping is missing, use the source column name. use
proper version to get the data.
- RowUpdatingHandler: set status to continue to actually process
the query.
svn path=/trunk/mcs/; revision=47340
* System.Data.Common/DbConnectionStringBuilder.cs: Implemented method for parsing
connection string through "ConnectionString" property.
* System.Data.Common/DbConnectionStringBuilderHelper.cs: Helper class to provide
conversion between string=>.net type mapping for connection string
builders. The idea is to use between other providers (odbc) as well.
* System.Data.SqlClient/SqlConnectionStringBuilder.cs: Connection String Builder class
for SqlClient Data Provider.
* Test/System.Data.SqlClient/SqlConnectionStringBuilderTest.cs: Added some preliminary tests.
* System.Data.dll.sources: Added SqlConnectionStringBuilder.cs and DbConnectionStringBuilderHelper.cs
* System.Data_test.dll.sources: Added SqlConnectionStringBuilderTest.cs
svn path=/trunk/mcs/; revision=46289
* System.Data/DataTable.cs:
* System.Data.Common/RecordCache.cs: quick fix for 2.0 profile build failure (follow up for check in 2005-05-16).
svn path=/trunk/mcs/; revision=44552