extra explicit interface implementation.
* OleDbParameter.cs: Changed argument names to match MS.
* OleDbTransaction.cs: Do not include IDbConnection.Connection and
IDisposable.Dispose for 2.0 profile.
* OleDbParameterCollection.cs: Changed argument names to match MS.
Do not include explicit interface implementations on 2.0 profile.
* OleDbConnection.cs: Changed argument names to match MS. Code
formatting.
svn path=/trunk/mcs/; revision=101354
* System.Data.dll.sources: Add new OleDbMetaDataCollectionNames.cs
* System.Data_test.dll.sources: Add the new OdbcMetaDataColumnNamesTest,
OleDbMetaDataCollectionNamesTest and SqlClientMetaDataCollectionNamesTest.
In class/System.Data/System.Data.Odbc:
* OdbcMetaDataCollectionNames.cs: Set the field values.
In class/System.Data/System.Data.OleDb:
* OleDbMetaDataCollectionNames.cs: New.
In class/System.Data/System.Data.SqlClient:
* SqlClientMetaDataCollectionNames.cs: Set the field values.
In class/System.Data/Test/System.Data.Odbc:
* OdbcMetaDataCollectionNamesTest.cs: New.
In class/System.Data/Test/System.Data.OleDb:
* OleDbMetaDataCollectionNamesTest.cs: New.
In class/System.Data/Test/System.Data.SqlClient:
* SqlClientMetaDataCollectionNamesTest.cs: New.
svn path=/trunk/mcs/; revision=97175
exception message for invalid DateTimeMode value to match MS. Code
formatting.
* DbDataPermissionAttribute.cs: In KeyRestrictionBehavior, reuse
ExceptionHelper.CheckEnumValue.
* ExceptionHelper.cs: Use same exception message for both 1.0 and 2.0.
* Index.cs: Fixed compiler warnings. Code formatting.
* SqlCommand.cs: Use ExceptionHelper.CheckEnumValue for enum checks.
* OleDbCommand.cs: Use ExceptionHelper.CheckEnumValue for enum checks.
* DBDataPermissionAttributeTest.cs: Improved test for invalid
KeyRestrictionBehavior. Fixed line endings.
* DataColumnTest.cs: No longer derive from deprecated Assertion class.
Code formatting. Added test for DateTimeMode.
svn path=/trunk/mcs/; revision=87866
OdbcCommandTest.cs, OdbcConnectionTest.cs, OdbcDataAdapterTest.cs,
OleDbCommandTest.cs, OleDbConnectionTest.cs, OleDbDataAdapterTest.cs,
SqlDataAdapterTest.cs.
* DbDataAdapter.cs: Implemented UpdateBatchSize setter.
* DataAdapter.cs: In FillLoadOption setter, ensure value is valid.
Modified MissingMappingAction and MissingSchemaAction setters to use
ExceptionHelper.CheckEnumValue to validate value. Spaces to tabs and
code formatting.
* ExceptionHelper.cs: Added CheckEnumValue method and modified
InvalidEnumValueException method to return AORE on 2.0 profile. Added
ConnectionClosed method that returns an InvalidOperationException.
* OleDbDataAdapter.cs: In default ctor, set SelectCommand to null.
Only initialize SelectCommand in ctors. Use direct assignment in
IDbDataAdapter implementation.
* OleDbCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Added implementation for UpdatedRowSource.
* OleDbConnection.cs: Moved initialization of gda to Open ().
Avoid unnecessary initialization. Return zero-length string if
ConnectionString is null. If getters to Database, DataSource and
Provider return zero-length string if the connection is closed.
In ServerVersion, BeginTransaction and GetSchema, throw an
InvalidOperationException if connection is closed.
* OdbcCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Spaces to tabs and code formatting.
* OdbcError.cs: Fixed typo in exception message.
* OdbcConnection.cs: Return zero-length string if ConnectionString is
null. In getters for Database, DataSource and Driver return a
zero-length string if connection is closed. In BeginTransaction and
GetSchema throw InvalidOperationException if connection is closed.
Added override for GetSchema (string, string []). Use string.Empty
instead of "".
* OdbcDataAdapter.cs: Avoid unnecessary initializations. Use direct
assignment in IDbDataAdapter implementation. In default ctor, set
SelectCommand to null.
* SqlCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Use ExceptionHelper.InvalidEnumValueException
to avoid code duplication. Spaces to tabs and code formatting.
* SqlConnection.cs: Use different default package size on 2.0 profile.
Added constants for default values, instead of using magic numbers.
Avoid unnecessary initialization. In PacketSize, return default or
configured packet size when connection is not open. Use
ExceptionHelper.ConnectionClosed instead of local method. Removed
use of some hardcoded values in SetDefaultConnectionParameters, and
use Environment.MachineName as default WorkstationId instead of
DNS host name. Code formatting.
* SqlDataAdapter.cs: In default ctor, set SelectCommand to null.
Avoid unnecessary initializations. Use direct assignment in
IDbDataAdapter implementation. Fixed exception message for negative
UpdateBatchSize. In Dispose override, make sure to invoke base
method.
* DbDataAdapterTest.cs: Added test for UpdateBatchSize.
* DataAdapterTest.cs: Added tests for AcceptChangesDuringFile,
AcceptChangesDuringUpdate, ContinueUpdateOnError, FillLoadOption,
MissingMappingAction, MissingSchemaAction and
ReturnProviderSpecificTypes.
* OdbcDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand and Dispose.
* OdbcDataReaderTest.cs: fixed line endings.
* OdbcCommandTest.cs: Added tests for ctors and CommantText.
* OdbcConnectionTest.cs: Removed original test that relied on MySQL.
Added ctor tests. Added tests for BeginTransaction, GetSchema and
ServerVersion with connection that is closed.
* OleDbDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand and Dispose.
* OleDbCommandTest.cs: Added tests for ctors and CommandText.
* OleDbConnectionTest.cs: Added tests for ctors and ConnectionString.
Added tests for BeginTransaction, GetSchema and ServerVersion with connection that is closed.
* SqlCommandTest.cs: Added tests for ctors and CommantText.
* SqlConnectionTest.cs: Added tests for ctors, ConnectionString and
ServerVersion.
* SqlDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand, UpdateBatchSize and
Dispose.
svn path=/trunk/mcs/; revision=87859
In IsolationLevel, throw IOE if transaction is no longer open.
* SqlTransaction.cs: Clear connection in commit. In IsolationLevel,
throw IOE if transaction is no longer open.
* OleDbTransaction.cs: Clear connection in Commit and Rollback. In
IsolationLevel and Begin overloads, throw IOE if transaction is no
longer open.
svn path=/trunk/mcs/; revision=87836
Leaves it up to deriving classes to override Dispose (bool) and
perform a rollback if necessary. Fixes bug #325397. Code formatting.
* ExceptionHelper.cs: Added TransactionNotUsable method that constructs
an InvalidOperationException to be thrown by IDbTransaction
implementations when the transaction is no longer open.
* OdbcTransaction.cs: Keep state of the transaction, and update it
when performing commit or rollback. In Dispose (bool), only perform
a rollback if transaction was not committed or rollback before.
In Commit and Rollback, throw an InvalidOperationException if
transaction is no longer open.
* SqlTransaction.cs: Avoid unnecessary initialization. Remove
isRolledBack since its essentially the same as isOpen. Use
ExceptionHelper.TransactionNotUsable instead of duplicating code.
On 2.0 profile, ignore call to Rollback when transaction was already
disposed.
* OleDbTransaction.cs: Keep track of whether transaction is open and
whether it's disposed. In Commit an Rollback, throw an IOE if the
transaction is no longer open. In Dispose (bool), perform a rollback
if the transaction is still open.
svn path=/trunk/mcs/; revision=87835
stubbed out where necessary. Fixed attributes for ConnectionString on
2.0 profile. Marked several members as override on 2.0 profile.
Do not hide StateChange event. Code formatting.
* OleDbCommandBuilder.cs: On 2.0, derive from DbCommandBuilder. Do not
include QuotePrefix and QuoteSuffix on 2.0. Stubbed out 2.0 members.
* OleDbDataAdapter.cs: On 2.0, derive from DbDataAdapter. Stubbed out
2.0 members. Do not not override Dispose on 2.0. Code formatting.
* OleDbDataReader.cs: Derive from DbDataReader on 2.0 profile. Marked
several members as override. Stubbed VisibleFieldCount. Added
EditorBrowsable attribute on GetData. Added GetDbDataReader on 2.0.
On 2.0, override GetEnumerator instead of explicit interface
implementation.
* OleDbErrorCollection.cs: Added 2.0 CopyTo overload.
* OleDbInfoMessageEventHandler.cs: Do not mark class serializable on
2.0 profile. Fixed API mismatch.
* OleDbParameter.cs: On 2.0, derive from DbParameter. Added new 2.0
ctor. Override properties from base class and added
SourceColumnNullMapping property on 2.0. Implemented ResetDbType and
ResetOleDbType methods on 2.0.
* OleDbParameterCollection.cs: Derive from DbParameterCollection on
2.0 profile. Marked several members as override. Implemented AddRange,
CopyTo, IndexOf, Insert, Remove and RemoveAt methods introduced in
2.0 profile. Stubbed out GetParameter and SetParameter overloads.
* OleDbPermission.cs: Added missing BrowsableAttribute on Provider.
Code formatting.
* OleDbPermissionAttribute.cs: Added BrowsableAttribute on Provdider
(2.0 only).
* OleDbRowUpdatedEventHandler.cs: Do not mark class serializable on
2.0 profile.
* OleDbRowUpdatingEventArgs.cs: Removed unused command field. Added
BaseCommand property on 2.0
* OleDbRowUpdatingEventHandler.cs: Do not mark class serializable on
2.0 profile. Fixed API mismatch.
* OleDbTransaction.cs: On 2.0, derive from DbTransaction. Added
DbConnection property and override Dispose (both 2.0 only). On 2.0,
Override Commit and Rollback. Code formatting.
svn path=/trunk/mcs/; revision=81189
System.ComponentModel.Component already calls Dispose.
* SqlParameter.cs: Removed explicit interface implementation of
IDataParameter.ParameterName.
* OdbcErrorCollection.cs: Removed explicit interface implementation
of IEnumerable.GetEnumerator ().
* OdbcCommand.cs: Removed destructor as the destructor in
System.ComponentModel.Component already calls the Dispose method.
Removed explicit interface implemenation of members that are
implement by public members.
* OdbcDataReader.cs: Removed explicit interface implemenation of
IDataRecord.GetData.
* OleDbErrorCollection.cs: Removed explicit interface implementation
of IEnumerable.GetEnumerator ().
* OleDbParameterCollection.cs: Removed explicit interface
implementation members that are already implementation by public
members.
* DataTable.cs: Renamed initInProgress to fInitInProgress. BeginInit
and EndInit must only be virtual in 2.0 profile. Set eol-style to CRLF.
svn path=/trunk/mcs/; revision=61328
* OleDbDataReader.cs: Added a call to GC.SuppressFinalize in Dispose
method (and avoids calling the destructor if the object was disposed).
* OleDbTransaction.cs: Added a call to GC.SuppressFinalize in Dispose
method (even if we throw an NotImplementedException afterward). This
will remove warnings from gendarme.
svn path=/trunk/mcs/; revision=51228
* OleDbCommand.cs: Fixed custom attributes to match MS.NET.
* OleDbParameter.cs: Fixed custom attribute to match MS.NET.
* OleDbException.cs: Added ErrorTypeConverter, assigned to ErrorCode
property to match MS.NET.
* OleDbConnection.cs: Fixed custom attributes to match MS.NET.
svn path=/trunk/mcs/; revision=48142
* OleDbCommand.cs: Make it inherit from the correct base class in 2.0,
and added stubs for some interface methods.
svn path=/trunk/mcs/; revision=40771
* OleDbPermission.cs: Added internal constructor accepting an OleDb
PermissionAttribute parameter (using base class protected ctor).
Re-added the Provider property (removed by error).
* OleDbPermission.cs: Copy now use the new OleDbPermission
constructor. Re-added the Provider property (removed by error).
svn path=/trunk/mcs/; revision=33904