Commit Graph
36 Commits
Author SHA1 Message Date
Veerapuram Varadhan 8d5211d815 conflict fix between trunk and local tree
svn path=/trunk/mcs/; revision=139063
2009-07-30 12:35:52 +00:00
Gert Driesen 5cc9f25881 * SqlParameter.cs: Improved support for SqlValue and SqlTypes.
* SqlParameterTest.cs: Added/improved tests for SqlValue, and
SqlTypes. Improved tests for char and char [] type inferrence.

svn path=/trunk/mcs/; revision=138699
2009-07-26 19:53:09 +00:00
Gert Driesen 7c73fb19d6 * SqlParameterTest.cs: Added .ctor tests. Improved
ParameterType and ResetDbType tests. Added ParameterName,
SourceColumn and Value tests. Partially enable SqlValue
test.

svn path=/trunk/mcs/; revision=122378
2009-01-03 22:48:07 +00:00
Gert Driesen 13b9781926 * System.Data_test.dll.sources: Added SqlCommandBuilderTest.cs
and SqlParameterTest.cs.
* DbCommandBuilder.cs (QuoteIdentifier): Throw NotSupportedException.
* DbDataAdapter.cs (Update): Add row causing concurrency violation
to DBConcurrencyException.
* OdbcCommandBuilder.cs (QuoteIdentifier): Escape QuoteSuffix
character(s) in unquoted identifier.
* SqlCommandBuilder.cs: Added missing checks for QuotePrefix and
QuoteSuffix on 2.0 profile, and return a zero-length string if
not set (or set to null) on 1.0 profile. Do not allow the value
of CatalogSeparator and SchemaSeparator to be changed from '.'.
Modified generated SQL to match MS. Added implementation for
QuoteIdenfifier. Modified parameters to match MS.
* SqlParameter.cs (SqlValue): Keep Value in sync.
* DbCommandBuilderTest.cs: Added test for QuoteIdentifier.
* OdbcCommandBuilderTest.cs: Enabled test for QuoteIdentifier.
* SqlCommandBuilderTest.cs: Added tests for CatalogLocation,
CatalogSeparator, ConflictOption, QuoteIdentifier, QuotePrefix,
QuoteSuffix  and SchemaSeparator.
* SqlParameterTest.cs: Moved existing tests from ProviderTests
to increase their visibility. Added tests for type inference.

svn path=/trunk/mcs/; revision=122361
2009-01-03 14:24:15 +00:00
Gert Driesen cd1071406b * SqlConnection.cs (ClearPool): Added null check.
* SqlConnectionTest.cs: Added test for null check in ClearPool.

svn path=/trunk/mcs/; revision=118309
2008-11-09 14:01:56 +00:00
Gert Driesen 9fb7f7aad0 * SqlConnection.cs: Use constants for min/max values. When value is
zero-length string, then fallback to default value for boolean and
integer backed properties. Throw ArgumentException when min pool size
exceeds max pool size. Check whether value for 'MARS' is a bool.
The 'user instance' property is 2.0 only.
* SqlConnectionTest.cs: Enabled connection string related tests that
previously failed. Added/improved connection string tests.

svn path=/trunk/mcs/; revision=110471
2008-08-14 11:12:49 +00:00
Gert Driesen e5b3cc5096 * SqlCommand.cs: Fixed order of arguments for ArgumentException in
CommandTimeout. 
* SqlConnection.cs (ChangePassword): Do not allow empty connection
string. Updated exception messages.
* SqlConnectionTest.cs: Enabled tests for ChangePassword argument
checks.

svn path=/trunk/mcs/; revision=109060
2008-07-28 18:37:07 +00:00
Gert Driesen f5f8d8daba * SqlCommand.cs: Fixed param name in ArgumentException for negative
CommandTimeout to match MS. On 2.0 profile, throw NRE in Prepare
when connection is NULL. In Prepare, return immediately after
connection check (2.0 only) for stored procedures, or when no
parameters are added. Added check to see if transaction is
associated with same connection as the command and updated
exception messages.
* SqlCommandTest.cs: Enabled CommandTimeout test. Enabled test for
Prepare with NULL connection. Enabled test for bug #412586.
* SqlCommandTest.cs: Enabled and improved tests for pending transaction
and transaction that is not associated with connection. Added tests for
Prepare.

svn path=/trunk/mcs/; revision=109058
2008-07-28 18:15:17 +00:00
Gert Driesen ebf1361ab6 * SqlCommand.cs: Added bool argument to ValidateCommand to specify
whether an async method is being executed. Minor changes to exception
messages to match MS.
* SqlCommandTest.cs: Enabled and improved tests for Execute* with closed
connection.
* SqlCommandTest.cs: Enabled and improved tests for Execute* with only a
transaction set.

svn path=/trunk/mcs/; revision=109043
2008-07-28 16:17:55 +00:00
Gert Driesen 3dfa81f709 * SqlCommand.cs: Avoid NRE in CloseDataReader when connection is NULL.
Fixes bug #412584. Removed unused moreResults eargument from
CloseDataReader. Removed behavior argument from Execute, and have it
use the behavior field instead. In ValidateCommand, throw
InvalidOperationException instead of NRE when Connection is NULL.
* SqlDataReader.cs: Sync with SqlCommand's CloseDataReader signature
change.
* SqlCommandTest.cs: Enabled test for bug #412584.

svn path=/trunk/mcs/; revision=109033
2008-07-28 15:44:30 +00:00
Gert Driesen 9ed5c19c8d * SqlCommandTest.cs: Added tests for bug #412584, #412586, Moved tests
that do not require connection from ProviderTests.
* SqlConnectionTest.cs: Moved tests that do not require connection
from ProviderTests.

svn path=/trunk/mcs/; revision=108989
2008-07-28 12:03:19 +00:00
Gert Driesen cbf4442816 * SqlCommandTest.cs: Removed extra tabs. Update bug number.
svn path=/trunk/mcs/; revision=107170
2008-07-03 18:20:50 +00:00
Robert Jordan 18741a1e23 In Test/System.Data.SqlClient:
2008-04-19  Robert Jordan  <[email protected]>

	* SqlCommandTest.cs: Add test case for bug #381100.

In System.Data.SqlClient:
2008-04-19  Robert Jordan  <[email protected]>

	* SqlParameterCollection.cs (AddRange(SqlParameter[])):
	Fix endless recursion.


svn path=/trunk/mcs/; revision=101212
2008-04-19 15:14:40 +00:00
Ankit Jain 8a986b5f97 In class/System.Data:
* System.Data.dll.sources: Add new OleDbMetaDataCollectionNames.cs
	* System.Data_test.dll.sources: Add the new OdbcMetaDataColumnNamesTest,
	OleDbMetaDataCollectionNamesTest and SqlClientMetaDataCollectionNamesTest.

In class/System.Data/System.Data.Odbc:

	* OdbcMetaDataCollectionNames.cs: Set the field values.

In class/System.Data/System.Data.OleDb:

	* OleDbMetaDataCollectionNames.cs: New.

In class/System.Data/System.Data.SqlClient:

	* SqlClientMetaDataCollectionNames.cs: Set the field values.

In class/System.Data/Test/System.Data.Odbc:

	* OdbcMetaDataCollectionNamesTest.cs: New.

In class/System.Data/Test/System.Data.OleDb:

	* OleDbMetaDataCollectionNamesTest.cs: New.

In class/System.Data/Test/System.Data.SqlClient:

	* SqlClientMetaDataCollectionNamesTest.cs: New.

svn path=/trunk/mcs/; revision=97175
2008-03-03 08:04:56 +00:00
Gert Driesen 3930b4b9cf * System.Data_test.dll.sources: Added DbDataAdapterTest.cs,
OdbcCommandTest.cs, OdbcConnectionTest.cs, OdbcDataAdapterTest.cs, 
OleDbCommandTest.cs, OleDbConnectionTest.cs, OleDbDataAdapterTest.cs, 
SqlDataAdapterTest.cs.
* DbDataAdapter.cs: Implemented UpdateBatchSize setter.
* DataAdapter.cs: In FillLoadOption setter, ensure value is valid.
Modified MissingMappingAction and MissingSchemaAction setters to use
ExceptionHelper.CheckEnumValue to validate value. Spaces to tabs and
code formatting.
* ExceptionHelper.cs: Added CheckEnumValue method and modified
InvalidEnumValueException method to return AORE on 2.0 profile. Added
ConnectionClosed method that returns an InvalidOperationException.
* OleDbDataAdapter.cs: In default ctor, set SelectCommand to null.
Only initialize SelectCommand in ctors. Use direct assignment in
IDbDataAdapter implementation.
* OleDbCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Added implementation for UpdatedRowSource.
* OleDbConnection.cs: Moved initialization of gda to Open ().
Avoid unnecessary initialization. Return zero-length string if
ConnectionString is null. If getters to Database, DataSource and
Provider return zero-length string if the connection is closed.
In ServerVersion, BeginTransaction and GetSchema, throw an
InvalidOperationException if connection is closed.
* OdbcCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Spaces to tabs and code formatting.
* OdbcError.cs: Fixed typo in exception message.
* OdbcConnection.cs: Return zero-length string if ConnectionString is
null. In getters for Database, DataSource and Driver return a
zero-length string if connection is closed. In BeginTransaction and
GetSchema throw InvalidOperationException if connection is closed.
Added override for GetSchema (string, string []). Use string.Empty
instead of "".
* OdbcDataAdapter.cs: Avoid unnecessary initializations. Use direct
assignment in IDbDataAdapter implementation. In default ctor, set
SelectCommand to null.
* SqlCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Use ExceptionHelper.InvalidEnumValueException
to avoid code duplication. Spaces to tabs and code formatting.
* SqlConnection.cs: Use different default package size on 2.0 profile.
Added constants for default values, instead of using magic numbers.
Avoid unnecessary initialization. In PacketSize, return default or
configured packet size when connection is not open. Use 
ExceptionHelper.ConnectionClosed instead of local method. Removed   
use of some hardcoded values in SetDefaultConnectionParameters, and
use Environment.MachineName as default WorkstationId instead of 
DNS host name. Code formatting.
* SqlDataAdapter.cs: In default ctor, set SelectCommand to null.
Avoid unnecessary initializations. Use direct assignment in   
IDbDataAdapter implementation. Fixed exception message for negative
UpdateBatchSize. In Dispose override, make sure to invoke base
method.
* DbDataAdapterTest.cs: Added test for UpdateBatchSize.
* DataAdapterTest.cs: Added tests for AcceptChangesDuringFile,   
AcceptChangesDuringUpdate, ContinueUpdateOnError, FillLoadOption,
MissingMappingAction, MissingSchemaAction and                      
ReturnProviderSpecificTypes.
* OdbcDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand and Dispose.
* OdbcDataReaderTest.cs: fixed line endings.
* OdbcCommandTest.cs: Added tests for ctors and CommantText.
* OdbcConnectionTest.cs: Removed original test that relied on MySQL.
Added ctor tests. Added tests for BeginTransaction, GetSchema and 
ServerVersion with connection that is closed.
* OleDbDataAdapterTest.cs: Added tests for ctors, DeleteCommand, 
InsertCommand, SelectCommand, UpdateCommand and Dispose.
* OleDbCommandTest.cs: Added tests for ctors and CommandText.
* OleDbConnectionTest.cs: Added tests for ctors and ConnectionString. 
Added tests for BeginTransaction, GetSchema and ServerVersion with connection that is closed.
* SqlCommandTest.cs: Added tests for ctors and CommantText. 
* SqlConnectionTest.cs: Added tests for ctors, ConnectionString and 
ServerVersion.
* SqlDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand, UpdateBatchSize and 
Dispose.

svn path=/trunk/mcs/; revision=87859
2007-10-20 23:16:52 +00:00
Gert Driesen 4ddc52b0cd * SqlConnectionTest.cs: Added tests for BeginTransaction and GetSchema
when connection is closed.

svn path=/trunk/mcs/; revision=87753
2007-10-18 14:30:29 +00:00
Gert Driesen 45e8c741c0 * SqlCommandTest.cs: Added test for bug #81710.
* System.Data_test.dll.sources: Added SqlCommandTest.cs.

svn path=/trunk/mcs/; revision=78147
2007-05-29 18:01:40 +00:00
Sebastien Pouliot d79aa4a725 2005-09-22 Sebastien Pouliot <[email protected]>
* SqlClientPermissionAttributeTest.cs: Removed *Choice security 
	actions.


svn path=/trunk/mcs/; revision=50481
2005-09-22 13:37:37 +00:00
Sureshkumar T 560aaec141 2005-09-22 Sureshkumar T <[email protected]>
* SqlConnectionTest.cs (OtherConnectionStringKeywords): marked
	Persist security info keyword as not implmented.


svn path=/trunk/mcs/; revision=50458
2005-09-22 06:52:17 +00:00
Sureshkumar T cce8383f1e added a new framework for testing data providers using nunit and mono.data's provider
factory. Moved few stand-alone tests from Test/ to this framework.

In Test:
2005-09-01  Sureshkumar T  <[email protected]>

	* ProviderTests: Added a new framework for testing Data
	Providers. This framework is based on nunit category tests and
	also the provider factory provided by Mono.Data.

In Test/System.Data.SqlClient:
2005-09-01  Sureshkumar T  <[email protected]>

	* SqlDataReaderTest.cs: moved to ProviderTests and integrated with
	connected mode tests
	* SqlCommandTest.cs: -- do --
	* SqlConnectionTest.cs: -- do --
	* SqlTransactionTest.cs: -- do --
	* SqlDataAdapterTest.cs: -- do --

In Test/System.Data.Odbc:
2005-09-01  Sureshkumar T  <[email protected]>

	* OdbcDataAdapterTest.cs: moved to ProviderTests and integrated
	with connected more framework.
	* OdbcCommandTest.cs: -- do --.

	* OdbcParameterCollectionTest.cs: Removed ParameterLengthTrimTest
	to ProviderTests.

In Test/ProviderTests/sql:
2005-09-01  Sureshkumar T  <[email protected]>

	* SCHEMA: schema specification.

	* sqlserver.sql: sql script file to create test schema for mssql
	database. added.

	* mysql.sql: sql script file to create test schema for mysql
	database. added.

In Test/ProviderTests/System.Data.Odbc:
2005-09-01  Sureshkumar T  <[email protected]>

	* OdbcCommandBuilderTest.cs: Added tests for OdbcCommandBuilder.cs
	* OdbcCommandTest.cs: pulled from Test/System.Data.Odbc
	* OdbcDataAdapterTest.cs: pulled from Test/System.Data.Odbc
	* OdbcDataReaderTest.cs: pulled from Test/System.Data.Odbc
	* OdbcParameterCollectionTest.cs: pulled from Test/System.Data.Odbc

In Test/ProviderTests/ProviderIndependant:
2005-09-01  Sureshkumar T  <[email protected]>

	* IDbCommandTest.cs: Added. Provider independent Command tests.

	* DataReaderTest.cs: Added. Provider independent DataReader tests.

In Test/ProviderTests:
2005-09-01  Sureshkumar T  <[email protected]>

	* System.Data.Connected.Tests.dll.sources: source files.

	* app-default.config:
	* app-net_2_0.config:
	configuration files for profiles and lists the assembly
	informations for the Provider factory.

	* odbc.config:
	* sqlserver.config:
	connection string info for respective databases.

	* README: initial.

	pulled connected mode test-cases around Test/* directory into this
	new framework. This framework is based on nunit category based
	test-cases and uses Provider Factories provided in Mono.Data.dll
	to write provider independent code.

In Test/ProviderTests/Common:
2005-09-01  Sureshkumar T  <[email protected]>

	* DBHelper.cs: Added. Class to provide helper methods for other tests.

	* ConnectionManager.cs: Added. Class to manage connections

In Test/ProviderTests/System.Data.SqlClient:
2005-09-01  Sureshkumar T  <[email protected]>

	* SqlCommandBuilderTest.cs: added tests for SqlCommandBuilder
	* SqlCommandTest.cs: pulled from Test/System.Data.SqlClient
	* SqlConnectionStringBuilderTest.cs: pulled from Test/System.Data.SqlClient
	* SqlConnectionTest.cs: pulled from Test/System.Data.SqlClient
	* SqlDataAdapterTest.cs: pulled from Test/System.Data.SqlClient
	* SqlDataReaderTest.cs: pulled from Test/System.Data.SqlClient
	* SqlTransactionTest.cs: pulled from Test/System.Data.SqlClient

	Added attribute Category ("sqlserver") to all these test fixtures.



svn path=/trunk/mcs/; revision=49260
2005-09-01 11:50:04 +00:00
Sureshkumar T 3c8687039f 2005-06-23 Sureshkumar T <[email protected]>
* System.Data.SqlClient/SqlConnectionStringBuilder.cs: simplified multiple keyword
          mappings and allowed-key checking. fixed Item, Remove, ContainsKey, ShoudSerialize,
          TryGetValue implementations.
        * Test/System.Data.SqlClient/SqlConnectionStringBuilderTest.cs: Added few more tests.


svn path=/trunk/mcs/; revision=46422
2005-06-23 13:13:04 +00:00
Sureshkumar T 6809aa66f4 2005-06-21 Sureshkumar T <[email protected]>
* System.Data.Common/DbConnectionStringBuilder.cs: Implemented method for parsing
	  connection string through "ConnectionString" property.
	* System.Data.Common/DbConnectionStringBuilderHelper.cs: Helper class to provide
	  conversion between string=>.net type mapping for connection string
	  builders. The idea is to use between other providers (odbc) as well.
	* System.Data.SqlClient/SqlConnectionStringBuilder.cs: Connection String Builder class
	  for SqlClient Data Provider.
	* Test/System.Data.SqlClient/SqlConnectionStringBuilderTest.cs: Added some preliminary tests.
	* System.Data.dll.sources: Added SqlConnectionStringBuilder.cs and DbConnectionStringBuilderHelper.cs
	* System.Data_test.dll.sources: Added SqlConnectionStringBuilderTest.cs


svn path=/trunk/mcs/; revision=46289
2005-06-21 09:56:41 +00:00
Kornél Pál c6e989717a Fixed Bug #53169
svn path=/trunk/mcs/; revision=44841
2005-05-20 18:06:02 +00:00
Atsushi Eno acd4da0ec6 2005-01-14 Atsushi Enomoto <[email protected]>
* DbDataPermissionAttribute.cs, PermissionHelper.cs :
	  fixed some incompatible type of exception between 2.0 and 1.x.
	* DataContainer.cs :
	  Wrap exceptions thrown by SetValue() within ArgumentException.

	* SqlClientPermissionTest.cs, SqlClientPermissionAttributeTest.cs:
	  Fixed some incompatible type of exception between 2.0 and 1.1.

	* OleDbPermissionTest.cs, OleDbPermissionAttributeTest.cs:
	  Fixed some incompatible type of exception between 2.0 and 1.1.

	* OdbcPermissionTest.cs, OdbcPermissionAttributeTest.cs:
	  Fixed some incompatible type of exception between 2.0 and 1.1.

	* DBDataPermissionTest.cs, DBDataPermissionAttributeTest.cs:
	  Fixed some incompatible type of exception between 2.0 and 1.1.



svn path=/trunk/mcs/; revision=38945
2005-01-14 17:03:07 +00:00
Gert Driesen e0e06bb1e7 SqlCommandTest.cs: Added testcase for bug #66630.
svn path=/trunk/mcs/; revision=35527
2004-11-01 13:44:40 +00:00
Umadevi S 818cdf035d 2004-10-30 Umadevi S <[email protected]>
* SqlDataAdapterTest.cs - Added testcase for nullguid

svn path=/trunk/mcs/; revision=35435
2004-10-29 08:39:00 +00:00
Umadevi S 684d11260f 2004-10-15 Umadevi S <[email protected]>
* SqlDataReaderTest.cs: Added testcase for reading emptyntextfield

svn path=/trunk/mcs/; revision=35016
2004-10-15 04:38:39 +00:00
Umadevi S c353d10832 2004-10-14 Umadevi S <[email protected]>
* SqlCommandTest.cs - added Test for clone method

svn path=/trunk/mcs/; revision=34965
2004-10-14 04:41:32 +00:00
Umadevi S 84f14a848a 2004-09-24 Umadevi S <[email protected]>
* SqlTransactionTest.cs -new file .unit testing for SqlTransaction

svn path=/trunk/mcs/; revision=34340
2004-09-24 09:58:25 +00:00
Sebastien Pouliot d42d4b58ec 2004-09-15 Sebastien Pouliot <[email protected]>
* SqlClientPermissionTest.cs: New. Unit tests for SqlClientPermission.

svn path=/trunk/mcs/; revision=33930
2004-09-15 11:42:38 +00:00
Sebastien Pouliot b05732da97 2004-09-13 Sebastien Pouliot <[email protected]>
* SqlClientPermissionAttributeTest.cs: New. Unit tests for SqlClient
	PermissionAttribute.

svn path=/trunk/mcs/; revision=33827
2004-09-13 22:52:21 +00:00
Umadevi S db776e3271 2004-09-02 Umadevi S <[email protected]>
* SqlCommandTest.cs - added file. Testing ExecuteNonQuery

svn path=/trunk/mcs/; revision=33195
2004-09-02 08:26:02 +00:00
Umadevi S ac082bc1ef 2004-09-02 Umadevi S <[email protected]>
* Added file SqlDataReaderTest.cs

svn path=/trunk/mcs/; revision=33191
2004-09-02 05:18:45 +00:00
Umadevi S af5df4fb3a 2004-08-20 Umadevi S <[email protected]>
* Added testcase in SqlDataAdapter.cs for Fillschema

svn path=/trunk/mcs/; revision=32560
2004-08-20 05:41:15 +00:00
Gert Driesen 89dfcd9907 * SqlConnectionTest.cs: Added testcases for bug #63165.
svn path=/trunk/mcs/; revision=32517
2004-08-19 06:56:37 +00:00
Umadevi S 77ba8def18 2004-08-19 Umadevi S <[email protected]>
* Added file SqlDataAdapterTest.cs - to test update method on a datatable

svn path=/trunk/mcs/; revision=32514
2004-08-19 05:41:23 +00:00