This patch introduces an infrastructure to stage the builds for the core
assemblies that have cyclic dependencies. This deals directly with
the following cycle:
System.dll requires:
System.Configuration.dll
Mono.Security.dll
System.Xml.dll
They all require System.dll to be built
System.Xml requires:
System.dll
System.Configuration.dll
System.Security.dll requires:
System.dll
Mono.Security.dll
System.Xml.dll
Principle
=========
The patch works by directing the build infrastructure to place
intermediate build steps on their own directory. For example the
first System.dll build that only takes a dependency in mscorlib.dll is
placed not under the final directory but on a subdirectory called
"bare".
The second time that System.dll is built (after Mono.Security and
System.Xml have been built) is placed on the "secxml" directory.
The third time is the final build, and that one ends in the profile
directory.
The same principle is applied to System.Xml.
Better Dependency Tracking
==========================
To handle the multiple stages, the new Makefiles for the various
parties involved in this loop are now able to build their
dependencies. This means that typing "make" on System.Security or
System.Xml or System will build all of the intermediate steps as
required, without needing the toplevel Makefile to perform multiple
build shots to incrementally build the result.
Bug fixes
=========
We must have regressed at some point the build of System.Xml as we
were only doing one build of it, one without System.Configuration
support. This patch introduces back the changes to build System.Xml
in two steps.
This patch fixes the setup where we end up rebuilding System.dll and
overwriting it two times as the build progresses as a side effect
(this is what required LIBRARY_USE_INTERMEDIATE_FILE).
Details
=======
library.make:
Introduces a new "the_libdir_base" which is the raw directory
where the final output will go. This points to the same location
that libdir_base previously pointed to.
The existing libdir_base is modified to contain an optional
"intermediate" directory, where intermediate builds can be
placed.
Other cycles
============
The System.Design assembly was listed as having cycles, but while this
cycle exists in theory, in practice we have not implemented any of the
code that brings the cycle in System.Windows.Forms.Design's
ImageListImageEditor and chances are, we wont any time soon.
When user has their own global application class (global.asax is present) the assembly produced from it must
be passed as reference to the compiler.
BuildManager.GetType now supports fully-qualified type names for 'typeName' and searches for the type in the
top-level assemblies, the global.asax assembly and in the assemblies specified in as references in web.config.
All of this fixes certain MVC3+Razor applications.
The patch removes a small race condition where a boolean flag is set after acquiring a lock to
indicate to code executing in the finally {} block that it should release the lock. The boolean
variable is now removed and the lock is released unconditionally. It carries a potential to
throw an exception when the lock is not held, but it's better than to fail to release it and
lead the application to a deadlock.
ASP.NET 4.0 allows one to set base types for Pages, User Controls, Application and PageParserFilter
from the pre-application start method(s). This commit implements support for this mechanism.
* ApplicationFileParser.cs: added override of DefaultBaseType property which checks whether
PageParser.DefaultApplicationBaseType is set and, if yes, uses it to set application base type
if there's no custom Global.asax
* PageParser.cs: implemented the EnableLongStringsAsResources, DefaultPageBaseType, DefaultApplicationBaseType,
DefaultPageParserFilterType and DefaultUserControlBaseType properties.
* TemplateParser.cs: if PageParser.DefaultPageParserFilterType is set, use it as the default type to create instance
of the page parser filter
* Added tests for the new properties.
* Added support in standalone runner for setting custom application domain data on domain creation, just before
the test is ran.
* HttpApplicationFactory.cs: pre-application start methods must be
called even before App_Code is compiled.
2010-05-17 Marek Habersack <[email protected]>
* BuildProvider.cs: made the Extension property case-insensitive
2010-05-17 Marek Habersack <[email protected]>
* BuildProvider.cs: implemented a 4.0 method RegisterBuildProvider
* BuildManager.cs: separated dynamically registered assemblies
store from the referenced assemblies cache.
svn path=/trunk/mcs/; revision=157435
* BuildManager.cs: do not cache referenced assemblies until it's
safe.
2010-05-16 Marek Habersack <[email protected]>
* HttpApplicationFactory.cs: let BuildManager know when it's safe
to cache referenced assemblies.
svn path=/trunk/mcs/; revision=157391
* BuildManager.cs: do less work in the static constructor
2010-03-04 Marek Habersack <[email protected]>
* RuntimeHelpers.cs: added. Contains methods moved here from
HttpRuntime, so that initialization sequence of various objects is
independent of HttpRuntime.
2010-03-04 Marek Habersack <[email protected]>
* HttpRuntime.cs: do less work in the static constructor. Most of
the code was moved to System.Web.Util.RuntimeHelpers. Properties
which have been moved: MonoVersion, RunningOnWindows,
CaseInsensitive, IsDebuggingEnabled
Also:
- hushed some compiler warnings
- various classes now use RuntimeHelpers instead of HttpRuntime
svn path=/trunk/mcs/; revision=153038
* HttpRuntime.cs: added internal property DomainUnloading.
* HttpApplication.cs: when app domain is unloading, catch
ThreadAbortExceptions and reset the abort.
2010-02-27 Marek Habersack <[email protected]>
* BuildManager.cs: count only builds of updated files before
unloading the app domain. Fixes bug #581459
svn path=/trunk/mcs/; revision=152600
* PreservationFile.cs: updated the BuildResulTypeCode enum
* BuildManager.cs: LoadCompiled now adds all the assemblies built
from the App_Code directory to the BuildManager.CodeAssemblies
collection. Fixes bug #576810
svn path=/trunk/mcs/; revision=150802
* BuildManager.cs: in GenerateAssembly, if compilation fails for
the requested path and exception thrown is of type
CompilationException, do not wrap it in HttpException, just
rethrow.
* AppResourcesCompiler.cs: the culture files dictionary is
case-insensitive now. Otherwise culture files with culture name
cased differently will cause overlapped i/o on response files
while building satellite assemblies and, in effect, compilation
will fail.
svn path=/trunk/mcs/; revision=149077
* BuildManager.cs: make sure to construct correct physical path
for every precompiled key in FixVirtualPaths. Fixes bug #546053
svn path=/trunk/mcs/; revision=143950
* BuildManager.cs: added IsPrecompiled internal property.
* AppResourcesCompiler.cs: load precompiled site local and global
resource assemblies from static constructor. Fixes bugs #536138
and #536143
svn path=/trunk/mcs/; revision=141474
* BuildManager.cs: when HttpRequest.FilePath is '/' in
GetAbsoluteVirtualPath, don't try to use
VirtualPathUtility.GetDirectory on it. Fixes bug #532679
svn path=/trunk/mcs/; revision=140786
* PageParser.cs: 2.0 profile takes advantage of the inputFile
parameter to GetCompiledPageInstance. A check is made whether the
file pointed to by this parameter is inside the application's
virtual path and if not, the compilation request is assumed to
refer to a fake location. Part of fix for bug #463813
2009-08-24 Marek Habersack <[email protected]>
* PageBuildProvider.cs: MapPath now takes a VirtualPath
instance. Part of fix for bug #463813
* BuildManager.cs: public APIs which take virtual path strings as
their parameters got internal counterparts accepting a VirtualPath
instance in place of string. Part of fix for bug #463813
* GenericBuildProvider.cs:
MapPath now takes a VirtualPath instance. Part of fix for bug
#463813
2009-08-24 Marek Habersack <[email protected]>
* SoapDocumentationHandler.cs: get rid of the ugly fake virtual
path hack when creating the helper page. Part of fix for bug
#463813
2009-08-24 Marek Habersack <[email protected]>
* VirtualPath.cs: Added new constructor which takes virtual and
physical paths as well as a boolean marking the instance as
referring to a fake location. Part of fix for bug #463813
svn path=/trunk/mcs/; revision=140548
* BuildManager.cs: precompilation setup failed if the precompiled
virtual directory was / and it was deployed somewhere else.
svn path=/trunk/mcs/; revision=138576
* BuildManager.cs: GetReferencedAssemblies unconditionally
includes all assemblies from bin/ for precompiled sites. Fixes bug
#502016
svn path=/trunk/mcs/; revision=138246
* BuildManager.cs: allow deployment of precompiled applications under
any virtual path, not just the default one used when precompiling.
Fixes bug #483268.
svn path=/trunk/mcs/; revision=135231
* HttpException.cs: if custom errors are enabled and the error
code is 404 show the "standard" 404 error message instead of the
default custom error mode one. Fixes bug #508649
2009-06-01 Marek Habersack <[email protected]>
* BuildManager.cs: when throwing a 404 exception, pass the virtual
path to the exception constructor.
svn path=/trunk/mcs/; revision=135147
* BuildManager.cs: RemoveFailedAssemblies wraps the compilation
exception to be rethrown in a HttpException instance.
* AspGenerator.cs: create a Location and pass it to the parser
before calling AddDirective from GetInheritedType, so that we get
meaningful exception messages with source, line information etc.
svn path=/trunk/mcs/; revision=133568
* BuildManager.cs: when BuildInner catches a compilation
exception, wrap it in HttpException before re-throwing.
2009-04-30 Marek Habersack <[email protected]>
* TemplateParser.cs: removed the PageParserFilterTypeName
property, the filter type name is looked up on demand now.
* ApplicationFileParser.cs, MasterPageParser.cs,
UserControlParser.cs: load config defaults explicitly after
initializing the instance.
svn path=/trunk/mcs/; revision=133169
* TemplateParser.cs: use generic lists for import, namespace and
interface caches. If a namespace is added (e.g. by parsing the
Import directive), find the assembly in which namespace is
defined.
2009-04-15 Marek Habersack <[email protected]>
* BuildManager.cs: do not add all assemblies in bin/ when serving
a precompiled site. Fixes bug #493873
When serving a precompiled site, check if the bin/ directory
contains certain well-known assemblies and load them if present.
svn path=/trunk/mcs/; revision=131768
* CompilationException.cs: skip warnings in ErrorMessage and
ErrorLines
* BuildManager.cs: when an error occurs while compiling the
requested virtual path, throw the exception, do not attempt to
build again.
* TemplateControlCompiler.cs: implemented missing converter for
the ExpandDepth property. Fixes bug #490860
2009-04-02 Marek Habersack <[email protected]>
* HttpException.cs: if there are more lines with errors, display
them all.
svn path=/trunk/mcs/; revision=130876
* All of the below are part of the fix for bug #489687
* ThemeDirectoryCompiler.cs: pass VirtualPath instances to parser
constructors.
* BuildProvider.cs: associated virtual path is stored internally
as an instance of VirtualPath, accessible via new
VirtualPathInternal property.
* BuildManagerDirectoryBuilder.cs: VirtualPath.IsFake is used to
detect fake virtual paths.
GetBuildProvider now takes a VirtualPath instead of string for the
virtualPath parameter. The passed VirtualPath instance is passed
unchanged to BuildProvider.
* BuildManager.cs: AssertVirtualPathExists now uses
VirtualPath.IsFake to check for fake virtual paths.
* ApplicationFileBuildProvider.cs, GenericBuildProvider.cs,
MasterPageBuildProvider.cs, PageBuildProvider.cs,
ThemeBuildProvider.cs, UserControlBuildProvider.cs,
WebHandlerBuildProvider.cs, WebServiceBuildProvider.cs:
CreateParser overloads now take a VirtualPath instead of a string
for the virtualPath parameter.
* ThemeBuildProvider.cs: use new parser constructors which take
VirtualPath instances instead of strings.
2009-03-31 Marek Habersack <[email protected]>
* VirtualPath.cs: added code to detect whether the VirtualPath
instance represents a fake virtual path (IsFake property).
Added new property DirectoryNoNormalize which returns
non-normalized directory for the VirtualPath instance.
Made ToString () a bit more friendly and well-behaved.
2009-03-31 Marek Habersack <[email protected]>
* ApplicationFileParser.cs, MasterPageParser.cs, PageParser.cs,
PageThemeFileParser.cs, PageThemeParser.cs, UserControlParser.cs,
WebHandlerParser.cs, WebServiceParser.cs: 2.0 constructors take a
VirtualPath instance for the virtualPath parameter, instead of a
string.
svn path=/trunk/mcs/; revision=130665
* BuildManager.cs, BuildManagerDirectoryBuilder.cs,
BuildProvider.cs, TemplateBuildProvider.cs: dependencies are
returned as an IDictionary <string, bool>. Dependencies must be
compared case-insensitively.
svn path=/trunk/mcs/; revision=129142
* System.Web/HttpWriter.cs: new Response property and WriteUTF8Ptr
method.
* System.Web/HttpResponseStream.cs: added support for writing from an
IntPtr. copied the memcpy method from String.cs.
* System.Web.Compilation/BuildManager.cs: updated comment.
* System.Web.UI/ResourceBasedLiteralControl.cs: new Control. It's just
like a LiteralControl but will render itself from the bytes pointed to
by an IntPtr and not create any string from the underlying data unless
needed.
* System.Web.UI/TemplateControl.cs: implemented a bunch of methods
that are used from the precompiled assemblies for a web project. The
most notable change needed is to be able to read a win32 resource from
the dll of the control. The resource is a concatenation of literals
with plain text for the control and a specialized LiteralControl is
generated from different chunks of the resource.
* System.Web.UI/HtmlTextWriter.cs: new method that returns the
HttpWriter in use.
* System.Web.dll.sources: added new file.
* System.Web.Util/ICalls.cs: new internal call to get a pointer to the
win32 resource associated with the control's assembly.
svn path=/trunk/mcs/; revision=127579
* System.Web/HttpApplicationFactory.cs: check of global.asax was precompiled.
* System.Web.UI/MasterPage.cs: the items in ContentPlaceHolders are lowercase.
* System.Web.Compilation/TemplateControlCompiler.cs: lowercase place holder names
* System.Web.Compilation/BuildManager.cs: initial support for
precompilation. No 'updatable', please.
svn path=/trunk/mcs/; revision=127352