The section mapping system wasn't being initialized and used properly since some ifdefs had
been left in the source code. This caused a null reference exception while trying to perform
some HTTP requests and, as the result, broke Xamarin Studio activation.
As suggested by Marek Habersack, instead of catching
SynchronizationLockException in the case that the lock wasn't
acquired, we now have a boolean that indicates if it was
acquired or not, so we can act on it on the finally{} block.
System.Web.ConfigurationManager had a cache which didn't have any max limit,
therefore when using Restful URIs in ASP.NET (like having some variable
parameter in the virtual path, i.e. /user/{userId}/tracks, where {userId}
is a variable Integer) this was very likely to cause a leak which would
end up causing troubles, like an InvalidCastException thrown by
HttpApplication::PreStart()
(Read operations in the cache now cause a write operation on the cache
object, so all sectionCache lock-read usages are converted to lock-write.)
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=5598
System.Web.ConfigurationManager had a cache which didn't have any max limit,
therefore when using Restful URIs in ASP.NET (like having some variable
parameter in the virtual path, i.e. /user/{userId}/tracks, where {userId}
is a variable Integer) this was very likely to cause a leak which would
end up causing troubles, like an InvalidCastException thrown by
HttpApplication::PreStart()
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=5598
Following is a step by step guide to create a testing project:
(1) Create an ASP.NET project in MonoDevelop
(2) Create a folder "base"
(3) Create two subfolders called "sub1" and "sub2" inside of "base"
(4) Create a web.config file in both sub folders "sub1" and "sub2" and enter the following code:
<configuration>
<appSettings>
<add key="myText" value="src=sub1"/>
</appSettings>
</configuration>
Set the "value=" element to the appropriate value of the corresponding sub folder.
(5) Enter the following code in Default.aspx.cs
public void Page_Load(object sender, EventArgs args)
{
//c2.ConfigPath contains wrong path
Configuration c1 = WebConfigurationManager.OpenWebConfiguration("~/base/sub1");
Configuration c2 = WebConfigurationManager.OpenWebConfiguration("~/base/sub2");
//myText_sub2 refers to the wrong AppSettings entry
KeyValueConfigurationElement myText_sub1 = (KeyValueConfigurationElement)c1.AppSettings.Settings["myText"];
KeyValueConfigurationElement myText_sub2 = (KeyValueConfigurationElement)c2.AppSettings.Settings["myText"];
}
It is possible that the user running the ASP.NET application does not
have permission to write to the registry. In this case, the auto
generated keys will be created on every application start.
* HttpRuntime.cs: disable filesystem watchers on appdomain shutdown and refuse to process
requests while the current AppDomain is unloading
* HttpApplicationFactory.cs: if the current AppDomain is unloading, ignore FileSystemWatcher
notifications
* WebConfigurationManager.cs: work around a deadlock issue when entering a ReaderWriterLockSlim
upgradeable read lock very early during ASP.NET runtime/AppDomain initialization. Every few runs
the attempt would lock up and since adding a section to cache is not a critical operation we can
afford timing the lock out in this case. The lockup is probably due to the fact that RWLS is using
thread local storage to store the current thread's lock status and it may happen that the TLS is
not cleared during thread object finalization (see metadata/threads.c, the start_wrapper function)
* Makefile: Compile tests with TEST defined (to include System.Web.Util.
MachineKeySectionUtils unit tests)
* System.Web.dll.sources: Move MachineKeySectionUtils.cs from System.
Web.Configuration_2.0 to System.Web.Util
* System.Web_test.dll.sources: Move MachineKeySectionUtilsTest.cs from
System.Web.Configuration_2.0 to System.Web.Util
* System.Web.Configuration_2.0/MachineKeySection.cs: Adjust using
clauses. Uncomment some code. Fix TripleDES versus 3DES for Validation
under NET_4_0. Remove 'private' on fields/methods.
* System.Web.Handlers/AssemblyResourceLoader.cs: Adjust using clauses
* System.Web.Security/MembershipHelper.cs: Adjust using clauses
* System.Web.Security/RolePrincipal.cs: Adjust using clauses
* System.Web.SessionState_2.0/SessionId.cs: Adjust using clauses
* System.Web.UI/LosFormatter.cs: Adjust using clauses.
* System.Web.Util/MachineKeySectionUtils.cs: Moved from System.Web.
Configuration_2.0. Rename namespace and remove 'internal' on type
declaration
* Test/System.Web.Util/MachineKeySectionUtilsTest.cs: Moved from Test/
System.Web.Configuration/MachineKeySectionTest.cs. Add test case for
TripleDES versus 3DES
* System.Web.Configuration_2.0/MachineKeyRegistryStorage.cs:
Remove key length check and generic key generation.
* System.Web.Configuration_2.0/MachineKeySection.cs: Add support for 4.0
ValidationAlgorithm and the use of custom algorithms (validation and
decryption). Allow the use of any, valid, key length (based on the
algorithm). Let each algorithm creates its own key (e.g. special needs,
default length...)
* System.Web.Configuration_2.0/MachineKeySectionUtils.cs: Remove key
generation (from random) code and 192bits key length hack (won't work
with custom algorithms). Add support for new (4.0) algorithms, including
custom ones. Provide uniform/shared code to Encrypt/Decrypt, Sign/Verify
and EncryptSign/VerifyDecrypt using MachineKeySection data.
* System.Web.Configuration_2.0/MachineKeyValidation.cs: Add new (4.0)
values.
* System.Web.Configuration_2.0/MachineKeyValidationConverter.cs: Add
support for new (4.0) algorithms.
* System.Web.Handlers/AssemblyResourceLoader.cs: Use the new common
cryptographic code and base64 the encrypted data.
* System.Web.Security/FormsAuthentication.cs: Use the new common
cryptographic code and base64 the signed and/or encrypted data.
* System.Web.Security/MembershipHelper.cs: Use the new common
cryptographic code - this should be 100% compatible with existing data.
* System.Web.Security/RolePrincipal.cs: Use the new common cryptographic
code.
* System.Web.Security/SqliteMembershipProvider.cs: Adapt code for
internal API change.
* System.Web.UI/LosFormatter.cs: Adapt code for internal API change.
Fix some small behaviro changes wrt NET_4_0
* System.Web.UI/ObjectStateFormatter.cs: Use the new common cryptographic
code.
* System.Web.UI/Page.cs: Remove code that is now unneeded (with the new
common cryptogrraphic code).
* System.Web.Configuration_2.0/MachineKeyCompatibilityMode.cs: New.
* Test/System.Web.Configuration/MachineKeyValidationConverterTest.cs:
Add more, mostly 4.0, test cases.
* Test/System.Web.Security/FormsAuthenticationTest.cs: Add test case to
ensure HashPasswordForStoringInConfigFile is not case sensitive.
* Test/System.Web.UI/LosFormatterTest.cs: Add some rountrip test cases
with the different ctors
* AuthorizationRule.cs: if the configuration save is not Full, SerializeElement checks whether the rule being
serialized is modified. If it isn't, validation and serialization are not performed.
* AuthorizationRuleCollection.cs: there is no element name for the collection.
The patch removes a small race condition where a boolean flag is set after acquiring a lock to
indicate to code executing in the finally {} block that it should release the lock. The boolean
variable is now removed and the lock is released unconditionally. It carries a potential to
throw an exception when the lock is not held, but it's better than to fail to release it and
lead the application to a deadlock.
WebConfigurationHost now supports one more parameter passed to it in InitForConfiguration -
a boolean telling whether the configuration being initialized belongs to another app. If it is
true then the virtual path passed to InitForConfiguration is used as the application virtual
path. This has the effect that IsDefinitionAllowed doesn't throw an exception when a configuration
element with the MachineToApplication level is parsed.
WebConfigurationManager.FindWebConfig checks whether the path passed to it belongs to this application
which allows the mechanism described in the first paragraph to work.
Make implementors of IInternalConfigurationHost.OpenStreamForRead return null instead of throwing an exception when there's no usable configuration file and deal with null at the call site.
* BuildProvider.cs: factored out build provider type retrieval code to a separate method
* BuildProviderCollection.cs: factored out build provider type retrieval code to a separate method
* BuildManagerDirectoryBuilder.cs: system.web/compilation section is not an application section - it can
be defined in web.config on any level.
fail to work on .NET 4.0 as well, for the most part. I will fix them next week.
2010-07-02 Marek Habersack <[email protected]>
* TemplateControlParser.cs: added support for ClientIDMode
property
* Control.cs: implemented 4.0 features - ClientIDMode and
RenderingCompatibility.
* ClientIDMode.cs, IDataKeysControl.cs: added
2010-07-02 Marek Habersack <[email protected]>
* Menu.cs: 4.0 API updates.
* GridView.cs: implemented 4.0 properties -
SortedAscendingCellStyle, SortedAscendingHeaderStyle,
SortedDescendingCellStyle, SortedDescendingHeaderStyle,
ClientIDRowSuffix, ClientIDRowSuffixDataKeys, ShowHeaderWhenEmpty
along with associated rendering changes.
* DetailsView.cs, FormView.cs, GridView.cs: 4.0 API changes -
renamed ShowPage to SetPageIndex and made it public.
Added 4.0 interfaces to inheritance list and implemented them.
* DataKeyArray.cs: added internal constructor which accepts IList
instead of ArrayList. Changed the 'keys' field type to IList.
* ContainedTable.cs: the 'id' attribute must be rendered last.
* CheckBox.cs, CheckBoxList.cs, SiteMapPath.cs, Table.cs,
TableStyle.cs, TextBox.cs, WebControl.cs: 4.0 rendering changes.
* Calendar.cs, CompositeControl.cs, DropDownList.cs, HyperLink.cs,
Image.cs, ImageButton.cs, Label.cs, LinkButton.cs, LoginName.cs,
Panel.cs, Table.cs, TableCell.cs, TableRow.cs:
added new 4.0 property, SupportsDisabledAttribute.
2010-07-02 Marek Habersack <[email protected]>
* VersionConverter.cs: added support for checking whether the
passed version is equal or more than a specified minimal version.
* PagesSection.cs: added two 4.0 properties - ClientIDMode and
ControlRenderingCompatibilityVersion
2010-07-02 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: added support for ClientIDMode 4.0
property
* PageCompiler.cs, UserControlCompiler.cs: AddStatementsToInitTop
must call the base implementation.
svn path=/trunk/mcs/; revision=159826
* HttpUtility.cs: moved chunks of code to the new
System.Web.Util.HttpEncoder class.
* HttpResponseHeader.cs: encode header names and values using
HttpEncoder.
* HttpRequest.cs: added internal method Validate, to validate the
request in 4.0 profile.
* HttpHeaderCollection.cs: added. A helper class to encode header
names/values on add.
* HttpApplication.cs: Pipeline () validates request by calling
HttpRequest.Validate in the 4.0 profile.
2010-06-01 Marek Habersack <[email protected]>
* HttpEncoder.cs: added. A 4.0 type but also used in 2.0 profile,
internally.
2010-06-01 Marek Habersack <[email protected]>
* HttpRuntimeSection.cs: added 4.0 properties
MaxQueryLengthString, MaxUrlLength, EncoderType and
RelaxedUrlToFileSystemMapping.
svn path=/trunk/mcs/; revision=158300
* HttpApplicationFactory.cs: pre-application start methods must be
called even before App_Code is compiled.
2010-05-17 Marek Habersack <[email protected]>
* BuildProvider.cs: made the Extension property case-insensitive
2010-05-17 Marek Habersack <[email protected]>
* BuildProvider.cs: implemented a 4.0 method RegisterBuildProvider
* BuildManager.cs: separated dynamically registered assemblies
store from the referenced assemblies cache.
svn path=/trunk/mcs/; revision=157435
Author: Marek Habersack <[email protected]>
Date: Sat Mar 6 03:37:53 2010 +0100
2010-03-06 Marek Habersack <[email protected]>
* CompilerCollection.cs: in the 4.0 profile, the latest C#
standard is the compiler's default.
2010-03-06 Marek Habersack <[email protected]>
* CSharpCodeCompiler.cs: in the 4.0 profile, the latest C#
standard is the default one.
2010-03-06 Marek Habersack <[email protected]>
* RequestValidatorTestGenerated.cs: added
* RequestValidator.cs: added
2010-03-06 Marek Habersack <[email protected]>
* TestWorkerRequest.cs: added overloads of GetRawUrl and
GetUriPath which make sure that the returned paths do not contain
more than one leading / character.
* TestRunItem.cs: added new TestRunData property - to contain
per-appdomain test run data.
* TestCallback.cs: added a TestRunItem parameter.
* StandaloneTest.cs: runner object is created for each test item
now.
Added test progress feedback.
* ITestRunner.cs: added two properties, TestRunData - to return
collected test result data, if any, and Domain which returns the
current AppDomain.
2010-03-06 Marek Habersack <[email protected]>
* RequestValidatorTest.cs: added
2010-03-06 Marek Habersack <[email protected]>
* HttpRequest.cs: cache RawUrl value.
Added new internal property, PathNoValidation, which returns
request path without validating it.
Implemented 4.0 extensible validation.
* HttpApplication.cs: Pipeline () validates the request path, if
new validation mode is enabled, before doing anything else.
Added a generic LoadType overload which checks whether the loaded
type, if any, derives from the type specified in the method's
specialization.
2010-03-06 Marek Habersack <[email protected]>
* RequestValidator.cs: added
* RequestValidationSource.cs: added
2010-03-06 Marek Habersack <[email protected]>
* WebConfigurationManager.cs: do not use Request.Path - it may
fail because of invalid web.config file, use
Request.PathNoValidation instead.
* VersionConverter.cs: added
* PropertyHelper.cs: added a Version converter helper.
* HttpRuntimeSection.cs: added 4.0 properties -
RequestPathInvalidCharacters, RequestValidationType and
RequestValidationMode.
svn path=/trunk/mcs/; revision=153172
* BuildManager.cs: do less work in the static constructor
2010-03-04 Marek Habersack <[email protected]>
* RuntimeHelpers.cs: added. Contains methods moved here from
HttpRuntime, so that initialization sequence of various objects is
independent of HttpRuntime.
2010-03-04 Marek Habersack <[email protected]>
* HttpRuntime.cs: do less work in the static constructor. Most of
the code was moved to System.Web.Util.RuntimeHelpers. Properties
which have been moved: MonoVersion, RunningOnWindows,
CaseInsensitive, IsDebuggingEnabled
Also:
- hushed some compiler warnings
- various classes now use RuntimeHelpers instead of HttpRuntime
svn path=/trunk/mcs/; revision=153038