* GridView.cs: minor optimizations (removed a foreach loop,
replaced calls to Array.Length with a variable containing the
length).
svn path=/trunk/mcs/; revision=107043
* BaseDataBoundControl.cs, ChangePassword.cs, CustomValidator.cs,
DataControlFieldCollection.cs, DataControlField.cs,
PasswordRecovery.cs, PagerSettings.cs: do not use synthetized
event accessors (to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* AnonymousIdentificationModule.cs, FormsAuthenticationModule.cs,
DefaultAuthenticationModule.cs, MembershipProvider.cs,
WindowsAuthenticationModule.cs, PassportAuthenticationModule.cs,
RoleManagerModule.cs: do not use synthetized event accessors (to
avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* HttpApplication.cs, HttpCachePolicy.cs, SiteMapProvider.cs,
TraceContext.cs: do not use synthetized event accessors (to avoid
locks).
2008-05-30 Marek Habersack <[email protected]>
* SessionStateModule.cs: do not use synthetized event accessors
(to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* ProfileModule.cs: do not use synthetized event accessors (to
avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* SessionStateModule.cs: do not use synthetized event accessors
(to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* DataBindingCollection.cs, ExpressionBindingCollection.cs: do not
use synthetized event accessors (to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* ClientBuildManager.cs: do not use synthetized event accessors
(to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* CacheDependency.cs: do not use synthetized event accessors (to
avoid locks).
svn path=/trunk/mcs/; revision=104569
* HierarchicalDataBoundControl.cs: Modified GetData method to check if
DataSource implements IHierarchicalEnumerable and if so constructs and
returns a new instance of ReadOnlyDataSourceView. This provides functional
compatibility with the Microsoft.NET framework. Fixes bug
#395209. Patch contributed by James Fitzsimons
<[email protected]>, thanks!
2008-05-18 Marek Habersack <[email protected]>
* HierarchicalDataBoundControlTest.cs: Added
TestIHierarchicalEnumerableDataSource to test change made to
GetData method to make functionally compatibile with Microsoft.NET
framework. Patch contributed by James Fitzsimons
<[email protected]>, thanks!
2008-05-28 Marek Habersack <[email protected]>
* ReadOnlyDataSourceView.cs: added. Patch contributed by James
Fitzsimons <[email protected]>, thanks!
svn path=/trunk/mcs/; revision=104329
* Calendar.cs: do not create dateInfo in the constructor - culture
might be not set yet at this point. Fixes bug #323566
Added a private property, DateInfo, which creates the dateInfo
when requested.
2008-05-06 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: compatibility - added the
__stringResource static field to the generated class and a call to
SetStringResourcePointer to the FrameworkInitialize method.
* PageCompiler.cs: __fileDependencies should also be defined in
the 1.x profile.
Page properties assigned in the page directive should be set
inside BuildControlTree in the 2.0 profile.
svn path=/trunk/mcs/; revision=102573
* BulletedList.cs: Avoid calling ToString on a string.
* ButtonField.cs: Throw, not just create, the exceptions.
* HyperLinkField.cs: Throw, not just create, the exceptions.
* ImageField.cs: Throw, not just create, the exception. Avoid calling
ToString on a string.
* ListControl.cs: Avoid calling ToString on a string.
[All issues were found using Gendarme]
svn path=/trunk/mcs/; revision=102571
* SiteMapNode.cs: the implicitResourceKey parameter to one of the
constructors sets the value of the ResourceKey property.
GetImplicitResourceString uses the provider's ResourceKey as the
global resource object key and the node's ResourceKey to construct
the resource name. Fixes bug #323994
ResourceKey setter throws an InvalidOperationException now, when
the node is read-only.
2008-04-30 Marek Habersack <[email protected]>
* SiteMapDataSource.cs: when no starting node is found, return
null instead of Provider.RootNode. Fixes bug #323994
svn path=/trunk/mcs/; revision=102197
* ObjectDataSourceView.cs: ExecuteSelect should return an empty
aray when no data has been retrieved from the specified source
type. Fixes bug #380106
svn path=/trunk/mcs/; revision=100819
* AssemblyResourceLoader.cs: dispose of streams the way it should
be done.
2008-04-15 Marek Habersack <[email protected]>
* MailDefinition.cs: dispose of streams the way it should
be done.
2008-04-15 Marek Habersack <[email protected]>
* HttpRequest.cs: dispose of streams the way it should
be done.
2008-04-15 Marek Habersack <[email protected]>
* CachingCompiler.cs: dispose of streams the way it should
be done.
svn path=/trunk/mcs/; revision=100690
* Control.cs: refactoring - IdSeparator property is internally
present also in 1.1.
2008-04-10 Marek Habersack <[email protected]>
* RadioButton.cs: adjust 'name' and 'value' attribute values to
match MS.NET. Fixes bug #378024
svn path=/trunk/mcs/; revision=100302
* CheckBoxList.cs: set the Selected property to the value in POST
data only if the item in question was enabled before postback
occurred. Fixes bug #377703
svn path=/trunk/mcs/; revision=100299
* ListControl.cs: make sure the owned items' Enabled property is
set to the same value what ListControl's. Fixes bug #377703
* ListItemCollection.cs: fixed SetDirty to store the index of the
last dirtied item properly. Fixes bug #377703
For the 2.0 profile, set the ListItem instances Enabled property
to the value of the owning ListControl (internal ItemsEnabled
property was added to make it possible). Fixes bug #377703
svn path=/trunk/mcs/; revision=100296
* NunitWebResources/adapters.browser,
NunitWebResources/TestCapability.browser: modified to work and
support tests of browser defs in
etc/mono/2.0/Browsers/Compat.browser.
++ class/System.Web/Test/System.Web/ChangeLog (working copy)
* AppBrowsersTest.cs: added tests to ensure browscap.ini
etc/mono/2.0/Browsers/Compat.browser are being used when there
are App_Browser/*.browser files.
++ class/System.Web/Test/System.Web.UI/ChangeLog (working copy)
* PageTest.cs: added tests to ensure that using a
ControlAdapter that is not of the type corresponding to the
control doesn't cause a cast error.
++ class/System.Web/Test/System.Web.UI.WebControls/ChangeLog (working copy)
* DataBoundControlTest.cs, HierarchicalDataBoundControlTest.cs,
WebControlTest.cs: added tests to ensure that using a
ControlAdapter that is not of the type corresponding to the
control doesn't cause a cast error.
++ class/System.Web/System.Web/ChangeLog (working copy)
* HttpApplicationFactory.cs (CapabilitiesProcessor): changed to
use etc/mono/2.0/Browser/*.browser files in addition to
~/App_Browsers/*.browser files.
++ class/System.Web/System.Web.UI/ChangeLog (working copy)
* Page.cs (PageAdapter): fixed cast error when a ControlAdapter that
wasn't a PageAdapter was used.
++ class/System.Web/System.Web.Configuration_2.0/ChangeLog (working copy)
* CapabilitiesBuild.cs (Process), ICapabilitiesProcess.cs (Process),
nBrowser/Build.cs (Process): Added initialCapabilities argument to
facilitate using browscap.ini capabilities.
* CapabilitiesResult.cs (ctor), nBrowserResult.cs (ctor): Change
items arg to IDictionary to facilitate using browscap.ini capabilities.
* nBrowser/Node.cs (Reset): Removed code which checked prohibited
non-alphanumerics in id attributes because .NET is not that strict.
* nBrowser/Node.cs (MergeFrom): Fixed NullReferenceExceptions that
occurred when the source or destination node did not have any
capabilities or adapters.
* nBrowser/Result.cs (AddAdapter): Fixed to allow types in other
assemblies.
++ class/System.Web/System.Web.UI.WebControls/ChangeLog (working copy)
* DataBoundControl.cs (InternalPerformDataBinding),
HierarchicalDataBoundControl.cs (InternalPerformDataBinding),
WebControl.cs (Render): fixed cast errors when a ControlAdapter
that wasn't of the type corresponding to the control was used.
++ class/System.Web/System.Web.Configuration/ChangeLog (working copy)
* HttpCapabilitiesBase.cs (GetConfigCapabilities): changed to use
browscap.ini for default capabilities when *.browser files are
present, so we don't need to maintain browser capabilities in two
places.
svn path=/trunk/mcs/; revision=100150
* DataListTest.cs: added test for bug #376519
(SelectedValue_SelectedIndex
2008-04-03 Marek Habersack <[email protected]>
* DataList.cs: use the value of SelectedIndex, not selectedIndex,
to return the key value in the SelectedValue property. Fixes bug
#376519. Patch from Sergey Kuleshov <[email protected]>, thanks
2008-04-03 Marek Habersack <[email protected]>
* HtmlFormTest.cs: indirect test for bug #376352 is 2.0+ only.
svn path=/trunk/mcs/; revision=99704
* add new resources:
PageWithAdapter.aspx for PageTest and PageAdapterTest.
TestCapability.browser for AppBrowsersTest.
* NunitWebResources/adapters.browser,
NunitWebResources/AppBrowsersTest.browser: modified to support
testing reference nodes with captures, and adapters.
* NunitWeb/NunitWeb/WebTest.cs: ensure that, during AppDomain
unload, no new requests are sent to the app host and any
pending requests are completed before the the unload occurs.
Also added WebTest.AppUnloaded event that tests can use to wait
for the app to unload (e.g. after touching Global.asax), and
WebTest.CleanApp() which can be called to restart the app with
the a skeleton directory structure. Tests which add files that
could effect other tests (e.g. App_Browsers/*.browser files) should
call WebTest.CleanApp() during TearDown to return the app to a
pristine environment.
++ Test/mainsoft/MainsoftWebTest/ChangeLog (working copy)
* HtmlAgilityPack/AssemblyInfo.cs: made assembly delay signed so that
tests can access System.Web internals now that System.Web is
InternalsVisibleTo this assembly.
++ Test/System.Web/ChangeLog (working copy)
* AppBrowsersTest.cs: added. Includes tests for Control.Adapter,
Control.ResolveAdapter, Control.TagWriter, and
Control.CreateHtmlTextWriter, when using App_Browsers/*.browser files.
AppBrowsersTest is currently tagged [Ignore], pending a fix for
bug #351878.
* HttpRuntimeTest.cs: added. Includes test for
HttpRuntime.UnloadAppDomain(). Marked [Ignore], pending a fix for
bug #351878.
++ Test/System.Web.UI.Adapters/ChangeLog (revision 0)
* PageAdapterTest.cs: added tests for PageAdapter.
* ControlAdapterTest.cs (ConfigCapabilitiesNotCalled): added test to
ensure that HttpCapabilitiesBase.ConfigCapabilities() is not called
during normal page processing if no files are in App_Browsers.
* ControlAdapterTest.cs: added tests for ControlAdapter.
++ Test/System.Web.UI/ChangeLog (working copy)
* PageTest.cs: add tests for using a PageAdapter.
* ControlTest.cs: moved commented out ResolveAdapter_1 test to
../System.Web/AppBrowsersTest.cs. Fixed typo in test name.
Added Customcontroladapter.Adapter property for use by AppBrowsersTest.
++ Test/System.Web.UI.WebControls.Adapters/ChangeLog (revision 0)
* MenuAdapterTest.cs: added
* WebControlAdapterTest.cs, HierarchicalDataBoundControlAdapterTest.cs,
DataBoundControlAdapterTest.cs, HideDisabledControlAdapterTest.cs: added
++ Test/System.Web.UI.WebControls/ChangeLog (working copy)
* MenuTest.cs (Menu_RenderStaticItems): added tests to check that
result was the same when using the base MenuAdapter as when using
no adapter.
* MenuTest.cs (Menu_RenderStaticItemsWithAdapter): added test
to ensure that MenuAdapter.RenderItem() is called.
* HierarchicalDataBoundControlTest.cs, WebControlTest.cs,
DataBoundControlTest.cs: added test for use of ControlAdapters
when present.
* WebControl.cs: added test for IsEnabled.
++ System.Web/ChangeLog (working copy)
* HttpApplicationFactory.cs: Added support for detecting
App_Browsers/*.browser files and using them to determine capabilities.
Also restart the app if the App_Browsers, App_Code, or App_GlobalResources
directories are created.
* BrowserCapabilities.cs (TagWriter): get value via internal virtual
GetTagWriter() method, which is overridden in nBrowser.Result.
* HttpRequest.cs (BrowserMightHaveSpecialWriter, BrowserMightHaveAdapters):
internal properties added to allow Page and Control methods to avoid
accessing Request.Browser to get browser-specific HtmlTextWriters or
ControlAdapters. Those things only exist when there are App_Browsers
files.
++ System.Web.UI.Adapters/ChangeLog (working copy)
* ControlAdapter.cs: made control field internal so
derived internal classes can access it without using base.Control
which can involved several typecasts.
* PageAdapter.cs: implemented all members.
* ControlAdapter.cs: implemented all members.
* PageAdapter.cs, ControlAdapter.cs: add MonoTODO's.
++ System.Web.UI/ChangeLog (working copy)
* Page.cs (SavePageControlState, LoadPageControlState): save/load
adapter state in 2.0 profile.
* Page.cs (CreateHtmlTextWriter): call Browser.CreateHtmlTextWriter()
in 2.0 profile.
* Page.cs (RenderPage): call CreateHtmlTextWriter() to get the writer
in 2.0 profile.
* Page.cs (DeterminePostBackMode, InitOutputCache,
RenderClientScriptFormDeclaration, InternalProcessRequest,
PageStatePersister): added support for PageAdapters.
* Control.cs (Adapter, ResolveAdapter): implemented. Adapter calls
ResolveAdapter and remembers result. ResolveAdapter checks for adapters
of the Type hierarchy until it finds one.
* Control.cs (SaveViewStateRecursive, LoadViewStateRecursive): save/load
adapter state in 2.0 profile.
* HtmlTextWriter.cs (BeginRender, EndRender): added empty virtual methods
required by 2.0 profile. These are called by corresponding methods of
System.Web.UI.Adapters.ControlAdapter.
* Page.cs, Control.cs: don't access Request.Browser if it couldn't have
any adapters/writers because there are no files in App_Browsers/.
++ Assembly/ChangeLog (working copy)
* AssemblyInfo.cs: made InternalsVisibleTo System.Web.test_net_2_0.dll
to support ControlAdapterTest.ConfigCapabilitiesNotCalled().
++ ChangeLog (working copy)
* System.Web_test.dll.sources: added
System.Web.UI.WebControls.Adapters/MenuAdapterTest.cs
System.Web.UI.WebControls.Adapters/WebControlAdapterTest.cs
System.Web.UI.WebControls.Adapters/HierarchicalDataBoundControlAdapterTest.cs
System.Web.UI.WebControls.Adapters/DataBoundControlAdapterTest.cs
System.Web.UI.WebControls.Adapters/HideDisabledControlAdapterTest.cs
System.Web.UI.Adapters/PageAdapterTest.cs
System.Web.UI.Adapters/ControlAdapterTest.cs
* Makefile (RESOURCE_FILES_2): added
System.Web.Configuration_2.0/RandomRoboBotKeywords.txt
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWebResources/PageWithAdapter.aspx
* System.Web.dll.sources: added
System.Web.Configuration_2.0/CapabilitiesBuild.cs
System.Web.Configuration_2.0/CapabilitiesChecksum.cs
System.Web.Configuration_2.0/CapabilitiesResult.cs
System.Web.Configuration_2.0/ICapabilitiesProcess.cs
System.Web.Configuration_2.0/nBrowser/Result.cs
System.Web.Configuration_2.0/nBrowser/NodeTypes.cs
System.Web.Configuration_2.0/nBrowser/Identification.cs
System.Web.Configuration_2.0/nBrowser/File.cs
System.Web.Configuration_2.0/nBrowser/Build.cs
System.Web.Configuration_2.0/nBrowser/Node.cs
System.Web.Configuration_2.0/nBrowser/Exception.cs
++ System.Web.UI.WebControls.Adapters/ChangeLog (working copy)
* WebControlAdapter.cs, HierarchicalDataBoundControlAdapter.cs,
DataBoundControlAdapter.cs: changed to use ControlAdapter.control
instead of using base.Control or using a new control field.
* MenuAdapter.cs: added internal constructor that takes a Menu
parameter. The constructor is used when writing unit tests.
* MenuAdapter.cs (OnInit, OnPreRender, RenderBeginTag,
RenderContents, RenderEndTag): delegate to base instead of
Control.
* MenuAdapter.cs (LoadAdapterControlState, SaveAdapterControlState,
RaisePostBackEvent, RenderItem): implemented.
* WebControlAdapter.cs (RenderContents): changed to call
control.RenderContents() instead of control.Render().
* WebControlAdapter.cs, HierarchicalDataBoundControlAdapter.cs,
DataBoundControlAdapter.cs, HideDisabledControlAdapter.cs: added
internal constructor that takes a parameter of the corresponding
Control type. The construct is used when writing unit tests.
++ System.Web.Configuration_2.0/ChangeLog (working copy)
* nBrowser/Result.cs, nBrowser/NodeTypes.cs, nBrowser/Identification.cs,
nBrowser/File.cs, nBrowser/Build.cs, nBrowser/Node.cs,
nBrowser/Exception.cs: added. The code under nBrowser handles *.browser
files. It is based on Owen "Ocean" Brady's code, with the following
changes and improvements. Replaced Result.Adapter
property with AdapterTypeMap property which maps control Type to adapter
Type. Added Result.MarkupTextWriter property. Added overrides for
Result.GetAdapters and Result.GetTagWriter to return MarkupTextWriter
and AdapterTypeMap, resp. Changed tree building algorithm to not
depend on nodes with id="Default" and to inject defaultBrowser nodes
as parents of regular nodes with the same ids. Changed Node.cs to use
Item instead of Add when adding a capability or sample header, so that
values get replaced instead of appended. Added support for reference
nodes (ie. nodes with refID="someID").
* CapabilitiesResult.cs: load RandomRoboBotKeywords.txt resource
using the correct name.
* RandomRoboBotKeywords.txt: added
* HttpCapabilitiesBase.cs (CreateHtmlWriter, Adapters): Added
support for *.browsers. Adapters property calls internal virtual
GetAdapters() method which is overrided in nBrowser.Result
returned by nBrowser code. CreateHtmlWriter uses type specified
by TagWriter property.
++ System.Web.UI.WebControls/ChangeLog (working copy)
* DetailsView.cs, ListControl.cs, DataBoundControl.cs,
FormView.cs, HierarchicalDataBoundControl.cs, WebControl.cs:
added support for using ControlAdapters when present.
* WebControl.cs: fixed implementation of IsEnabled to match
documentation.
* Menu.cs (RenderMenuBody): call Adapter.RenderItem() instead of
RenderMenuItem() if an adapter is present. MenuAdapter.RenderItem()
calls back to new Menu.RenderItem() internal method which calls
RenderMenuItem() with the appropriate parameters.
++ System.Web.Configuration/ChangeLog (working copy)
* HttpCapabilitiesBase.cs: changed to use nBrowser for *.browser
support. Also added internal GetConfigCapabilities_called
flag used by ControlAdapterTest.ConfigCapabilitiesNotCalled() to
test that GetConfigCapabilities() is not called during normal page
processing when there are no files in App_Browsers/.
svn path=/trunk/mcs/; revision=97824
* GridView.cs:
at Update and Delete use not read only coppies of dictionaries
in event argumens, that allows user to change them before corresponding
DataSource's method is called.
svn path=/trunk/mcs/; revision=96556
* FileUpload.cs: make sure FileContent always returns the input
stream positioned at the beginning. Fixes bug #356846
svn path=/trunk/mcs/; revision=94924
* ValidationSummary.cs:
refactoring: If page contents instance of IScriptManager, it calls
it's API instead Page.ClientScript.
svn path=/trunk/mcs/; revision=93660
* ListItem.cs: fixed Load/SaveViewState, added selected state storing
* ListItemCollection.cs: fixed Load/SaveViewState, added flag to not rebuild the collection if wasnt changed
svn path=/trunk/mcs/; revision=91518
* ClientScriptManager.cs, MasterPageParser.cs, Control.cs,
Page.cs: speed optimization - use String.Concat instead of
String.Format in some cases.
2007-12-13 Marek Habersack <[email protected]>
* Menu.cs, TreeView.cs: optimize use of String.Format in
OnPreRender.
Speed optimization - use String.Concat instead of String.Format in
some cases.
* GridView.cs, DetailsView.cs: optimize use of String.Format in
OnPreRender.
* CheckBox.cs, AccessDataSource.cs, WebColorConverter.cs,
WebControl.cs,TextBox.cs, DropDownList.cs, ValidationSummary.cs,
ListBox.cs, Panel.cs, BaseValidator.cs, LinkButton.cs: speed
optimization - use String.Concat instead of String.Format in some cases.
2007-12-13 Marek Habersack <[email protected]>
* HtmlForm.cs, HtmlButton.cs: speed optimization - use String.Concat
instead of String.Format in some cases.
2007-12-13 Marek Habersack <[email protected]>
* AssemblyResourceLoader.cs: speed optimization - use String.Concat
instead of String.Format in some cases.
2007-12-13 Marek Habersack <[email protected]>
* SessionId.cs:
speed optimization - use String.Concat
instead of String.Format in some cases.
2007-12-13 Marek Habersack <[email protected]>
* SqlProfileProvider.cs, ProfileParser.cs: speed optimization -
use String.Concat instead of String.Format in some cases.
2007-12-13 Marek Habersack <[email protected]>
* ApplicationManager.cs, ApplicationHost.cs,
DefaultVirtualPathProvider.cs: speed optimization - use
String.Concat instead of String.Format in some cases.
svn path=/trunk/mcs/; revision=91230