Commit Graph
1458 Commits
Author SHA1 Message Date
Marek Habersack 9bd54de080 2010-07-08 Marek Habersack <[email protected]>
* ImageMap.cs: implemented missing Enabled property (2.0+)
	RaisePostBackEvent must be protected and virtual (2.0+)
	NavigateUrl is ignored if the control is disabled (4.0)

svn path=/trunk/mcs/; revision=160053
2010-07-08 13:10:06 +00:00
Marek Habersack 6d0b03285c 2010-07-07 Marek Habersack <[email protected]>
* TreeView.cs:
	When using registered CSS classes, the node style must use them in
	reverse order.

More 4.0 test updates (disabled some Menu tests until its rendering is updated)

svn path=/trunk/mcs/; revision=160003
2010-07-07 13:04:50 +00:00
Marek Habersack fd8812fabf This code must be enabled for 2.0 as well
svn path=/trunk/mcs/; revision=159997
2010-07-07 11:29:34 +00:00
Marek Habersack a670985119 2010-07-07 Marek Habersack <[email protected]>
* TreeView.cs: 4.0 rendering changes.

Another batch of 4.0 test updates

svn path=/trunk/mcs/; revision=159996
2010-07-07 11:29:23 +00:00
Marek Habersack 0967be60db 2010-07-06 Marek Habersack <[email protected]>
* HyperLink.cs: the associated image is not rendered using the
	Image control.

4.0 updates for several tests (HTML rendering changes)

svn path=/trunk/mcs/; revision=159995
2010-07-07 11:29:09 +00:00
Marek Habersack d8838a6414 This commit introduces a few 4.0 rendering changes which break some tests. The broken tests
fail to work on .NET 4.0 as well, for the most part. I will fix them next week.

    2010-07-02  Marek Habersack  <[email protected]>

    	* TemplateControlParser.cs: added support for ClientIDMode
    	property

    	* Control.cs: implemented 4.0 features - ClientIDMode and
    	RenderingCompatibility.

    	* ClientIDMode.cs, IDataKeysControl.cs: added

    2010-07-02  Marek Habersack  <[email protected]>

    	* Menu.cs: 4.0 API updates.

    	* GridView.cs: implemented 4.0 properties -
    	SortedAscendingCellStyle, SortedAscendingHeaderStyle,
    	SortedDescendingCellStyle, SortedDescendingHeaderStyle,
    	ClientIDRowSuffix, ClientIDRowSuffixDataKeys, ShowHeaderWhenEmpty
    	along with associated rendering changes.

    	* DetailsView.cs, FormView.cs, GridView.cs: 4.0 API changes -
    	renamed ShowPage to SetPageIndex and made it public.
    	Added 4.0 interfaces to inheritance list and implemented them.

    	* DataKeyArray.cs: added internal constructor which accepts IList
    	instead of ArrayList. Changed the 'keys' field type to IList.

    	* ContainedTable.cs: the 'id' attribute must be rendered last.

    	* CheckBox.cs, CheckBoxList.cs, SiteMapPath.cs, Table.cs,
    	TableStyle.cs, TextBox.cs, WebControl.cs: 4.0 rendering changes.

    	* Calendar.cs, CompositeControl.cs, DropDownList.cs, HyperLink.cs,
    	Image.cs, ImageButton.cs, Label.cs, LinkButton.cs, LoginName.cs,
    	Panel.cs, Table.cs, TableCell.cs, TableRow.cs:
    	added new 4.0 property, SupportsDisabledAttribute.

    2010-07-02  Marek Habersack  <[email protected]>

    	* VersionConverter.cs: added support for checking whether the
    	passed version is equal or more than a specified minimal version.

    	* PagesSection.cs: added two 4.0 properties - ClientIDMode and
    	ControlRenderingCompatibilityVersion

    2010-07-02  Marek Habersack  <[email protected]>

    	* TemplateControlCompiler.cs: added support for ClientIDMode 4.0
    	property

    	* PageCompiler.cs, UserControlCompiler.cs: AddStatementsToInitTop
    	must call the base implementation.

svn path=/trunk/mcs/; revision=159826
2010-07-02 19:12:31 +00:00
Marek Habersack 7e02dfbdc9 Fixes to a bunch of unit tests which would fail when running on .NET and few updates to
our system.web controls.

svn path=/trunk/mcs/; revision=159495
2010-06-24 12:55:00 +00:00
Marek Habersack 221a24b979 - 1.1 code removal
- coding style
- minor optimizations

svn path=/trunk/mcs/; revision=159333
2010-06-22 12:26:13 +00:00
Marek Habersack afeab3ef73 - 1.1 code removal
- coding style
- minor optimizations

svn path=/trunk/mcs/; revision=159296
2010-06-21 21:01:26 +00:00
Marek Habersack 2d668e9583 2010-06-21 Marek Habersack <[email protected]>
* BaseValidator.cs, BulletedList.cs, Calendar.cs, CheckBox.cs,
    	CheckBoxList.cs, DataGrid.cs, DropDownList.cs, GridView.cs,
    	HyperLink.cs, ImageButton.cs, LinkButton.cs, ListBox.cs,
    	ListControl.cs, Menu.cs, RadioButton.cs, RadioButtonList.cs,
    	RepeatInfo.cs, Repeater.cs, TextBox.cs, TreeView.cs,
    	ValidationSummary.cs, WebControl.cs: use WebControl.IsEnabled
    	instead of Enabled wherever necessary.

svn path=/trunk/mcs/; revision=159280
2010-06-21 18:41:51 +00:00
Marek Habersack 23c3114ca3 2010-06-16 Marek Habersack <[email protected]>
* FormView.cs: row values must be retrieved with inclusion of
    	keys. Fixes bug #607722

svn path=/trunk/mcs/; revision=159037
2010-06-16 21:49:55 +00:00
Marek Habersack c8e70f1fc5 2010-06-03 Marek Habersack <[email protected]>
* Parameter.cs, ControlParameter.cs, SessionParameter.cs,
	CookieParameter.cs, FormParameter.cs, ProfileParameter.cs,
	QueryStringParameter.cs: Evaluate is 'protected internal virtual'
	in 4.0.

	* RouteParameter.cs: implemented.

svn path=/trunk/mcs/; revision=158371
2010-06-02 23:12:20 +00:00
Marek Habersack 6193eeb004 2010-05-19 Marek Habersack <[email protected]>
* DataSourceCacheDurationConverter.cs: implemented. Fixes bug
	#603083

svn path=/trunk/mcs/; revision=157547
2010-05-19 12:54:23 +00:00
Marek Habersack 9d5a298da2 2010-04-28 Marek Habersack <[email protected]>
* CheckBoxListTest.cs: added test for bug #600415

2010-04-28  Marek Habersack  <[email protected]>

	* CheckBoxList.cs: do not modify list item status in LoadPostData
	when the list control is disabled.
	If an item is selected and it was unchecked by the user, deselect
	it. Fixes bug #600415

svn path=/trunk/mcs/; revision=156312
2010-04-28 13:08:39 +00:00
Marek Habersack 3f3fd1c424 2010-04-13 Marek Habersack <[email protected]>
* GridView.cs: make sure Header and Footer visibility are set when
	binding the data. Fixes bug #595567

svn path=/trunk/mcs/; revision=155331
2010-04-13 21:31:23 +00:00
Marek Habersack 934829dadd 2010-04-13 Marek Habersack <[email protected]>
* ImageField.cs, CheckBoxField.cs: OnDataBindField must expect
    	sender to be something else than DataControlFieldCell. Fixes bug
    	#595568

    2010-04-13  Marek Habersack  <[email protected]>

    	* CheckBoxFieldTest.cs: added test for bug #595568

svn path=/trunk/mcs/; revision=155270
2010-04-12 22:40:55 +00:00
Marek Habersack 25177910f5 2010-04-07 Marek Habersack <[email protected]>
* FormParameter.cs, CookieParameter.cs, ProfileParameter.cs,
	QueryStringParameter.cs, SessionParameter.cs: implemented
	constructor overloads which take DbType as one of the arguments.

svn path=/trunk/mcs/; revision=154894
2010-04-06 23:53:13 +00:00
Marek Habersack 05c45cf998 2010-04-01 Marek Habersack <[email protected]>
* FormView.cs: do not show the pager if PagerSettings.Visible is
	false. Fixes bug #578863

2010-04-01  Marek Habersack  <[email protected]>

	* FormViewTest.cs: added test for bug #578863

svn path=/trunk/mcs/; revision=154631
2010-04-01 11:20:09 +00:00
Marek Habersack 98fff2b311 2010-03-29 Marek Habersack <[email protected]>
* GridView.cs: main table must be created and added to the
	controls collection before any OnRowCreated event is fired.

svn path=/trunk/mcs/; revision=154386
2010-03-29 16:59:22 +00:00
Gonzalo Paniagua Javier 447907f4a3 2010-03-19 Gonzalo Paniagua Javier <[email protected]>
* TreeView.cs: use enums instead of strings for attributes.


svn path=/trunk/mcs/; revision=153917
2010-03-19 20:11:21 +00:00
Marek Habersack f74cf1f825 2010-03-06 Marek Habersack <[email protected]>
* XmlDataSource.cs: reload document when one of Data, DataFile,
	Transform or TransformFile properties is set. Fixes bug
	#585968. Fix based on patch from Jeffrey Alvarez
	<[email protected]>, thanks.

svn path=/trunk/mcs/; revision=153167
2010-03-06 01:52:15 +00:00
Marek Habersack e105f08673 2010-03-04 Marek Habersack <[email protected]>
* BuildManager.cs: do less work in the static constructor

2010-03-04  Marek Habersack  <[email protected]>

	* RuntimeHelpers.cs: added. Contains methods moved here from
	HttpRuntime, so that initialization sequence of various objects is
	independent of HttpRuntime.

2010-03-04  Marek Habersack  <[email protected]>

	* HttpRuntime.cs: do less work in the static constructor. Most of
	the code was moved to System.Web.Util.RuntimeHelpers. Properties
	which have been moved: MonoVersion, RunningOnWindows,
	CaseInsensitive, IsDebuggingEnabled

Also:
	- hushed some compiler warnings
	- various classes now use RuntimeHelpers instead of HttpRuntime

svn path=/trunk/mcs/; revision=153038
2010-03-04 19:04:13 +00:00
Marek Habersack e4848932af 2010-02-19 Marek Habersack <[email protected]>
* SqlDataSourceTest.cs: added test for bug #572781

2010-02-19  Marek Habersack  <[email protected]>

	* SqlDataSource.cs: call base.OnInit in OnInit. Fixes bug #572781

svn path=/trunk/mcs/; revision=152060
2010-02-19 11:17:06 +00:00
Marek Habersack d63508e6c0 2010-02-18 Marek Habersack <[email protected]>
* Makefile (TEST_RESOURCE_FILES): added
	Test/mainsoft/NunitWebResources/CheckBoxList_Bug377703_1.aspx,
	Test/mainsoft/NunitWebResources/CheckBoxList_Bug377703_2.aspx and
	Test/mainsoft/NunitWebResources/CheckBoxList_Bug578770.aspx

2010-02-18  Marek Habersack  <[email protected]>

	* CheckBoxListTest.cs: added tests for bugs #377703 and #578770

	* TreeViewTest.cs: added test for bug #580692

svn path=/trunk/mcs/; revision=152025
2010-02-18 21:48:35 +00:00
Marek Habersack 140576e9f4 2010-02-18 Marek Habersack <[email protected]>
* TreeViewTest.cs: added test for bug #580692

2010-02-18  Marek Habersack  <[email protected]>

	* TreeView.cs: RegisterStyle must copy CssClass in addition to
	other style properties. Fixes bug #580692

svn path=/trunk/mcs/; revision=151964
2010-02-18 10:50:31 +00:00
Marek Habersack 287b184544 2010-01-18 Marek Habersack <[email protected]>
* Parameter.cs: added missing 3.5 APIs - constructors taking
	DbType as one of the parameters, ConvertDbTypeToTypeCode,
	ConvertTypeCodeToDbType and GetDatabaseType. Fixes bug #567850

2010-01-18  Marek Habersack  <[email protected]>

	* ParameterTest.cs: added tests for ConvertDbTypeToTypeCode,
	ConvertTypeCodeToDbType and constructors taking DbType as one of
	the parameters.

svn path=/trunk/mcs/; revision=149778
2010-01-18 22:34:03 +00:00
Marek Habersack 079990272c 2010-01-15 Marek Habersack <[email protected]>
* ChangePassword.cs: BaseChangePasswordContainer forwards
	EnsureChildControls call to its owner, so that finding controls in
	the container works correctly.

2010-01-15  Marek Habersack  <[email protected]>

	* Makefile (TEST_RESOURCE_FILES): added
	Test/mainsoft/NunitWebResources/ChangePasswordContainer_FindControl.aspx

2010-01-15  Marek Habersack  <[email protected]>

	* ChangePasswordTest.cs: added test for looking for controls in
	ChangePassword template containers.

svn path=/trunk/mcs/; revision=149631
2010-01-15 13:23:54 +00:00
Marek Habersack 49a2098186 2009-11-30 Marek Habersack <[email protected]>
* WebControl.cs: HasAttributes made available as internal for 1.1
	Avoid calling the Attributes getter many times in
	CopyBaseAttributes.
	If TrackViewState is called and attributes state bag already
	exists, mark all items in the latter as dirty.

	* CheckBox.cs, Button.cs, ImageButton.cs, LinkButton.cs: do not
	create the Attributes collection if not necessary.

svn path=/trunk/mcs/; revision=147094
2009-11-30 12:35:20 +00:00
Marek Habersack b58f5b27ba 2009-11-16 Marek Habersack <[email protected]>
* TreeNodeTest.cs: added test for a situation when a
	node already contains children when the PopulateOnDemand property
	is set.

2009-11-16  Marek Habersack  <[email protected]>

	* TreeNodeCollection.cs: whenever a node is added, let the owner
	know about it.

	* TreeNode.cs: added internal property HadChildrenBeforePopulating
	which is used to let TreeView know about an error condition where
	a populate-on-demand node contains children added outside the
	OnTreeNodePopulate event

	* TreeView.cs: if a node has any child nodes and PopulatOnDemand
	is set, throw an exception from RenderNode. This is the behavior
	of .NET

svn path=/trunk/mcs/; revision=146275
2009-11-16 17:09:06 +00:00
Marek Habersack ac27c6d1c1 Added null check to Remove
svn path=/trunk/mcs/; revision=146131
2009-11-13 13:22:23 +00:00
Marek Habersack e384ddcd0d 2009-11-13 Marek Habersack <[email protected]>
* TableRowCollection.cs: added .NET compatibility NREX throws to
	several methods.
	Whenever a row is added/removed, its Container property is
	set. Fixes bug #551666

	* TableRow.cs: introduced an internal property, Container, which
	is set by TableRowCollection whenever this row is added/removed
	to/from the collection. This allows the row to notify the
	collectio and, in consequence, collection owner that TableSection
	has been set and thead/tbody/tfoot elements need to be
	generated. Fixes bug #551666

2009-11-13  Marek Habersack  <[email protected]>

	* GridViewTest.cs: added test for bug #551666

2009-11-13  Marek Habersack  <[email protected]>

	* Makefile (TEST_RESOURCE_FILES): added
	Test/mainsoft/NunitWebResources/TableSections_Bug551666.aspx
	Test/mainsoft/NunitWebResources/TableSections_Bug551666.aspx.cs

svn path=/trunk/mcs/; revision=146126
2009-11-13 12:56:34 +00:00
Marek Habersack a95e30047c 2009-11-10 Marek Habersack <[email protected]>
* PasswordRecovery.cs:
	{Question,Success,UserName}TemplateContainer must all be populated
	the first time the property is accessed, so that calling
	FindControl on the container returns valid and expected
	results. If the associated template is not defined, though,
	populating is postponed till CreateChildControls is called -
	that's where default, empty, template will be created. This is
	required to fix YetAnotherForum's password recovery control.
	Mail template used in SendPasswordByMail must match the one used
	in .NET (it has to end with a newline) as YAF parses the message
	to retrieve user name and password and breaks if the last line
	doesn't end with a newline character.

svn path=/trunk/mcs/; revision=145824
2009-11-10 10:41:41 +00:00
Marek Habersack 2201611f9e 2009-10-30 Marek Habersack <[email protected]>
* PasswordRecovery.cs: mail message replacements should include <%
	Password %> and <% UserName %> and matching should be
	case-insensitive. Fixes bug #545370

svn path=/trunk/mcs/; revision=145109
2009-10-30 15:58:33 +00:00
Marek Habersack 37db37e5bf 2009-10-28 Marek Habersack <[email protected]>
* ListControl.cs: OnDataBinding must call base implementation
	before performing the binding, so that DataSource can be assigned
	from within the handler.

svn path=/trunk/mcs/; revision=144947
2009-10-28 14:01:21 +00:00
Marek Safar 9ec885d03b 2009-10-13 Marek Safar <[email protected]>
* WebColorConverter.cs: Delegate ConvertFrom to
	ColorTranslator.FromHtml, it is correctly implemented and knows
	many more tricks.


svn path=/trunk/mcs/; revision=144016
2009-10-13 15:33:54 +00:00
Marek Habersack 8483da2ba2 2009-10-13 Marek Habersack <[email protected]>
* WebColorConverter.cs: don't use a dictionary to check for valid
	color names, use Color.IsKnownColor instead. Update for bug
	#546173 fix.
	Added more CSS2 color name mappings.

svn path=/trunk/mcs/; revision=143990
2009-10-12 22:51:21 +00:00
Marek Habersack 2d54bac1ed Fix the build
svn path=/trunk/mcs/; revision=143979
2009-10-12 21:10:38 +00:00
Marek Habersack 2db2f1cf20 2009-10-12 Marek Habersack <[email protected]>
* WebColorConverter.cs: when converting from color name, check if
	the returned color's name is a member of the
	System.Drawing.KnownColor enumeration to test for error condition,
	as some colors might be #000000. Preserve the old error check as a
	fallback only.
	Map "captiontext" and "background" color names to
	"ActiveCaptionText" and "Desktop", respectively, before passing
	them to Color.FromName (). Fixes bug #546173

svn path=/trunk/mcs/; revision=143972
2009-10-12 14:42:55 +00:00
Marek Habersack 5c59801fff Performance improvements:
- made sure invariant culture is used with String.ToLower, String.ToUpper and String.Compare
- replaced all calls to CultureInfo.InvariantCulture with a reference to a static field System.Web.Util.Helpers.InvariantCulture

svn path=/trunk/mcs/; revision=143587
2009-10-07 00:10:03 +00:00
Marek Habersack 609922272f 2009-10-02 Marek Habersack <[email protected]>
* DynamicValidator.cs: initial implementation

	* DynamicDataManager.cs: implemented OnLoad.
	Better implementation of RegisterControl

	* DynamicDataExtensions.cs: implemented FindDataSourceControl.

2009-10-02  Marek Habersack  <[email protected]>

	* DynamicValidatorTest.cs: added.

2009-10-02  Marek Habersack  <[email protected]>

	* GridView.cs: added two 3.5 properties - SelectedPersistedDataKey
	and IPersistedSelector.DataKey.

	* BaseDataBoundControl.cs: slight optimizations to FindDataSource

svn path=/trunk/mcs/; revision=143278
2009-10-02 11:35:41 +00:00
Marek Habersack fef40778a9 2009-09-28 Marek Habersack <[email protected]>
* DataBoundControl.cs: Initialize sets RequiresDataBinding
	properly, only when we're not data-bound already, when we aren't
	in postback or when we are in postback, but with viewstate
	enabled. Fixes bug #542076

svn path=/trunk/mcs/; revision=142798
2009-09-28 21:41:52 +00:00
Marek Habersack 33b856ff2b 2009-09-01 Marek Habersack <[email protected]>
* ListView.cs: LoadControlState must call OnTotalRowCountAvailable
	after restoring the state, so that all parties subscribed to that
	event are given chance to react accordingly.
	SetPageProperties should use values stored in
	PagePropertiesChangingEventArgs arguments after handler returns.

2009-09-01  Marek Habersack  <[email protected]>

	* ObjectDataSourceView.cs: ExecuteSelect must call
	QueryTotalRowCount after executing the select method (that's what
	.NET does)

svn path=/trunk/mcs/; revision=141062
2009-09-01 19:24:40 +00:00
Marek Habersack d83880bd08 2009-08-25 Marek Habersack <[email protected]>
* WebColorConverter.cs: inform the user that the might need to
	check if libgdiplus is installed when parsing a color name
	fails. Fixes bug #533749

svn path=/trunk/mcs/; revision=140593
2009-08-25 08:51:58 +00:00
Marek Habersack a22edf372b 2009-08-21 Marek Habersack <[email protected]>
* Menu.cs: separator image is rendered next to the item in
	horizontal layout and is preceeded by 3px spacer (unless
	itemSpacing is set) to make output match .NET. Fixes bug #474716

svn path=/trunk/mcs/; revision=140438
2009-08-21 20:55:44 +00:00
Marek Habersack f61b24b177 2009-08-21 Marek Habersack <[email protected]>
* TreeNodeCollection.cs: {Save,Load}ViewState now store/load the
	type of the node, if node is a of a custom type. Fixes bug #475997

svn path=/trunk/mcs/; revision=140394
2009-08-21 00:41:34 +00:00
Gonzalo Paniagua Javier c2aad5b0ae 2009-06-29 Gonzalo Paniagua Javier <[email protected]>
* Parameter.cs: add new DbType property.


svn path=/trunk/mcs/; revision=137117
2009-06-29 22:10:45 +00:00
Marek Habersack 9743d97ec8 2009-06-16 Marek Habersack <[email protected]>
* RouteValueDictionaryExtensions.cs: do not compile if
	SYSTEMCORE_DEP is not defined

	* PatternParser.cs: if SYSTEMCORE_DEP is not defined, do not
	compile parts which require RouteValueDictionaryExtensions.

2009-06-16  Marek Habersack  <[email protected]>

	* Makefile (LIB_MCS_FLAGS): define SYSTEMCORE_DEP

2009-06-16  Marek Habersack  <[email protected]>

	* DynamicDataManager.cs, DynamicDataExtensions.cs: use new
	DataBoundControl.DataSourceObject instead of
	InternalGetDataSource

2009-06-16  Marek Habersack  <[email protected]>

	* Makefile: warn if the 4.0 assembly is compiled without
	System.Core

svn path=/trunk/mcs/; revision=136222
2009-06-16 13:48:30 +00:00
Marek Habersack 2ad931f695 2009-06-16 Marek Habersack <[email protected]>
* HtmlHeadBuilder.cs: use faster String.Compare overloads.

	* HtmlHead.cs: implemented 4.0 properties Description and
	Keywords.

2009-06-16  Marek Habersack  <[email protected]>

	* IPersistedSelector.cs: removed AspNetHostingPermission
	attributes from the 4.0 profile.

	* IDataBoundControl.cs, IDataBoundItemControl.cs,
	IDataBoundListControl.cs, IFieldControl.cs: added

	* DetailsView.cs: control implements 4.0 IDataBoundItemControl
	interface.

	* DataBoundControl.cs: implemented 4.0 property DataSourceObject
	and made the InternalPerformDataBinding method internal for the
	4.0 profile.

2009-06-16  Marek Habersack  <[email protected]>

	* net_4_0_System.Web.dll.sources:
	Added
	System.Web.UI.WebControls/IDataBoundControl.cs,
	System.Web.UI.WebControls/IDataBoundItemControl.cs,
	System.Web.UI.WebControls/IDataBoundListControl.cs,,
	System.Web.UI.WebControls/IFieldControl.cs

svn path=/trunk/mcs/; revision=136192
2009-06-16 01:46:33 +00:00
Gonzalo Paniagua Javier c95c37c8ca 2009-06-11 Gonzalo Paniagua Javier <[email protected]>
* ContentControlBuilderInternal.cs: detect missing
	ContentPlaceHolderID attribute when parsing instead of throwing a
	nullref later on.


svn path=/trunk/mcs/; revision=135960
2009-06-11 22:17:24 +00:00
Marek Habersack 540708a71f 2009-05-29 Marek Habersack <[email protected]>
* ListItem.cs: when tracking view state is turned on after
	attributes have been set, make sure that the associated state bag
	begins tracking state and that all of its existing items are
	marked as dirty. Do the same after loading view state. Fixes bug
	#507836

2009-05-29  Marek Habersack  <[email protected]>

	* StateBag.cs: made SetDirty (bool) available on 1.1 as
	internal. Fixes bug #507836

svn path=/trunk/mcs/; revision=135057
2009-05-29 10:25:35 +00:00