This reverts commit ed11296c51.
When a ThreadAbortException is thrown during request processing in AsyncRun () the _done.Set () call is not executed.
This then results in a deadlock because _done.WaitOne () doesn't get signaled and waits forever.
One solution would be enclosing the _done.Set () in a finally clause, but even then we'd need to relaunch the AsyncRun () loop to be in a usable state.
A simpler solution is to revert the commit that introduced the AsyncRun () in the first place, as it doesn't seem necessary now (the tests pass just fine without it).
The test that was disabled in 429cdf17cf is reenabled too, as it wasn't the culprit of the problem.
WebTest is now a partial class and every code outside System.Web that uses it can copy its own
resources in addition to the common ones by implementing the CopyResourcesLocal partial method.
When running the tests on the 4.0 profile, the configuration must no longer include
the System.Web.Extensions section declarations as they are merged with machine.config right now.
This set of .gitattributes was automatically generated from the list of files
that GIT tried to normalize when I enabled automatic EOL conversion.
With this set of attributes, we prevent automated EOL conversion on files that
we know will cause trouble down the road.
* Menu.cs: fixed skip link rendering (no child controls are added
in the process, writing directly to HtmlTextWriter). Fixes tests
for 4.0
If StaticSubMenuIndent equals Unit.Empty on 4.0, default to using
16px as the value of the margin-left CSS attribute.
Fixed all failing tests (both 2.0 and 4.0)
svn path=/trunk/mcs/; revision=160369
* AssemblyInfo.cs: this assembly should be signed with winfx.pub
2010-05-15 Marek Habersack <[email protected]>
* HttpResponse.cs: added internal Context property
* HttpRequest.cs: added a setter to the internal Context property
* HttpContext.cs: set request and response Context properties to
'this' in the constructor.
2010-05-15 Marek Habersack <[email protected]>
* Control.cs: implemented 4.0 GetRouteUrl overloads and
GetUniqueIDRelativeTo
2010-05-15 Marek Habersack <[email protected]>
* RouteValueExpressionBuilder.cs: added
* RouteUrlExpressionBuilder.cs: implemented
svn path=/trunk/mcs/; revision=157378
* CheckBoxListTest.cs: added test for bug #600415
2010-04-28 Marek Habersack <[email protected]>
* CheckBoxList.cs: do not modify list item status in LoadPostData
when the list control is disabled.
If an item is selected and it was unchecked by the user, deselect
it. Fixes bug #600415
svn path=/trunk/mcs/; revision=156312
* ImageField.cs, CheckBoxField.cs: OnDataBindField must expect
sender to be something else than DataControlFieldCell. Fixes bug
#595568
2010-04-13 Marek Habersack <[email protected]>
* CheckBoxFieldTest.cs: added test for bug #595568
svn path=/trunk/mcs/; revision=155270
* Control.cs: control cache must be filled using the local
_controls collection instead of the virtual Controls
property. Fixes bug #594238
Check if _controls isn't null before using it.
2010-04-07 Marek Habersack <[email protected]>
* ControlTest.cs: added test for bug #594238
2010-04-07 Marek Habersack <[email protected]>
* Makefile: moved App_* test resources to separate variables -
whatever is contained in those variables is preprocessed before
embedding as resource to include appropriate resource name prefix
(App_Code/, App_GlobalResources/ for now). This is used in WebTest
to automatically populate the relevant directories when running
the test suite.
2010-04-07 Marek Habersack <[email protected]>
* WebTest.cs: introduced concept of prefixed resources and added
an API which handles them - CopyPrefixedResources. All the
manifest resource names are checked for match with the given
prefix, and all the matching ones are copied to the specified
subdirectory of the test directory.
svn path=/trunk/mcs/; revision=154948
* FormView.cs: do not show the pager if PagerSettings.Visible is
false. Fixes bug #578863
2010-04-01 Marek Habersack <[email protected]>
* FormViewTest.cs: added test for bug #578863
svn path=/trunk/mcs/; revision=154631
* TemplateControlCompiler.cs: GetConverterForMember now completely
relies on TypeDescriptor and description providers to retrieve
converter for a property. Fixes bug #578586
If UrlPropertyAttribute is found for a member,
GetExpressionFromString uses the preconverted value, if any, as
parameter to HandleUrlProperty.
svn path=/trunk/mcs/; revision=152040
* AppResourcesCompiler.cs: explicitly dispose all the streams and
readers+writers in CompileResource.
2010-02-11 Marek Habersack <[email protected]>
* Web.config, Web.mono.config: added test role manager
definition.
2010-02-11 Marek Habersack <[email protected]>
* RolesTest.cs: added a test for IsUserInRole. Patch from Tiaan
Geldenhuys <[email protected]>, thanks!
2010-02-11 Marek Habersack <[email protected]>
* Roles.cs: IsUserInRole checks if username is null or empty
before attempting to use it. Patch from Tiaan Geldenhuys
<[email protected]>. thanks!
2010-02-11 Marek Habersack <[email protected]>
* System.Web_test.dll.sources: added
mainsoft/NunitWeb/NunitWeb/TestRoleProvider.cs
2010-02-11 Marek Habersack <[email protected]>
* WebTest.cs: test environment setup enhancements. Contributed by
Tiaan Geldenhuys <[email protected]>, thanks!
* TestRoleProvider.cs: added. Contributed by Tiaan Geldenhuys
<[email protected]>, thanks!
svn path=/trunk/mcs/; revision=151519
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWebResources/App_GlobalResources/Resource1.resx
and
Test/mainsoft/NunitWebResources/TagWithExpressionWithinAttribute.aspx
2010-01-19 Marek Habersack <[email protected]>
* TemplateControlCompilerTest.cs: added test for bug #568631
2010-01-19 Marek Habersack <[email protected]>
* AspGenerator.cs: modified the runatServer regex to correctly
match embedded server tags which end in a sequence like: "%>"/>
Fixes bug #568631
svn path=/trunk/mcs/; revision=149855
* ChangePassword.cs: BaseChangePasswordContainer forwards
EnsureChildControls call to its owner, so that finding controls in
the container works correctly.
2010-01-15 Marek Habersack <[email protected]>
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWebResources/ChangePasswordContainer_FindControl.aspx
2010-01-15 Marek Habersack <[email protected]>
* ChangePasswordTest.cs: added test for looking for controls in
ChangePassword template containers.
svn path=/trunk/mcs/; revision=149631
* Helpers.cs, ITestCase.cs, ITestRunner.cs, StandaloneTest.cs,
TestCallback.cs, TestCaseAttribute.cs,
TestCaseFailureException.cs, TestRunItem.cs, TestRunner.cs,
TestWorkerRequest.cs: added
2010-01-14 Marek Habersack <[email protected]>
* System.Web_standalone_test.dll.sources,
standalone-runner-support.dll.sources: added
* Makefile: Added targets to build and run standalone tests.
Added standalone tests and test tools to EXTRA_DISTFILES
2010-01-14 Marek Habersack <[email protected]>
* Consts.cs.in, Locations.cs: added
2010-01-14 Marek Habersack <[email protected]>
* standalone-runner.cs: added
* Makefile: added build targets for standalone-runner.exe
2010-01-14 Marek Habersack <[email protected]>
* NunitWebTest.cs: added new overload of GetControlFromPageHtml
which takes begin and end markers as parameters.
2010-01-14 Marek Habersack <[email protected]>
* ApplicationManager.cs: implemented a missing CreateObject
overload
2010-01-14 Marek Habersack <[email protected]>
* executable.make, library.make, rules.make: quote file name
wherever referenced in dist* targets, so that files with spaces in
name work fine.
svn path=/trunk/mcs/; revision=149522
* AspParser.cs: PlainText should calculate the boundaries of
text using character offset, not line offset. Fixes bug #562286
InternalLineOffset and Internal properties need not exist.
* AspGenerator.cs: AspParser inner parser constructor takes 5
parameters now - accepts character offset of the current outer
parser's position.
2009-12-14 Marek Habersack <[email protected]>
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWebResources/NestedParserFileText.aspx
svn path=/trunk/mcs/; revision=148378
* TableRowCollection.cs: added .NET compatibility NREX throws to
several methods.
Whenever a row is added/removed, its Container property is
set. Fixes bug #551666
* TableRow.cs: introduced an internal property, Container, which
is set by TableRowCollection whenever this row is added/removed
to/from the collection. This allows the row to notify the
collectio and, in consequence, collection owner that TableSection
has been set and thead/tbody/tfoot elements need to be
generated. Fixes bug #551666
2009-11-13 Marek Habersack <[email protected]>
* GridViewTest.cs: added test for bug #551666
2009-11-13 Marek Habersack <[email protected]>
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWebResources/TableSections_Bug551666.aspx
Test/mainsoft/NunitWebResources/TableSections_Bug551666.aspx.cs
svn path=/trunk/mcs/; revision=146126
* Assembly.cs: GetSatelliteAssembly must catch
AppDomain.LoadSatellite FileNotFoundException and attempt to load
satellites from subdirectories of current assembly's
directory. Fixes bug #548768
2009-11-03 Marek Habersack <[email protected]>
* AppResourcesCompiler.cs: put default culture resources in a
separate collection, exposed by the DefaultCultureFiles property.
* AppResourcesAssemblyBuilder.cs: compile the default assembly
before the satellite ones. Use the default assembly as template
for generation of the satellite ones.
svn path=/trunk/mcs/; revision=145280
- All resources are named the same on .NET and Mono for test assemblies
- Prepared SystemWebTestShim to work on .NET (to the extent it is possible)
- System.Web.Util made public when compiling tests in VS2008
svn path=/trunk/mcs/; revision=143511
* HostingEnvironment.cs: MapPath checks if HttpContext.Request
actually exists before using it.
2009-09-07 Marek Habersack <[email protected]>
* XmlSiteMapProviderTest.cs: added
* StaticSiteMapProviderTest.cs: added test for FindSiteMapNode
2009-09-07 Marek Habersack <[email protected]>
* XmlSiteMapProvider.cs: do not allow the provider to be
intialized more than once.
Initialize throws if it finds unknown attributes in the
'attributes' collection.
AddNode checks its arguments and throws if they are null or aren't
from the same provider.
FindStartingNode throws exceptions in several erroneous situations
now.
Added private method GetConfigDocument which performs several
checks on the source .sitemap file and throws exceptions if it
finds any errors.
BuildSiteMap clears provider state before building the map.
BuildSiteMapRecursive correctly deals with custom providers. Fixes
bug #465696
FindSiteMapNode maps url before searching. Fixes bug #465696
* VirtualPathUtility.cs: Combine a bit more efficient
* StaticSiteMapProvider.cs: FindSiteMap node checks if rawUrl is
relative to application root and if yes, makes it absolute.
MapUrl converts both rooted and not rooted urls to absolute.
* SiteMapProvider.cs: check if HttpContext.Request exists before
using it in FindSiteMapnode
* SiteMap.cs: Providers collection must be read-only.
2009-09-07 Marek Habersack <[email protected]>
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWeb/NunitWeb/Resources/sub_map_01.sitemap
Test/mainsoft/NunitWeb/NunitWeb/Resources/test_map_01.sitemap
Test/mainsoft/NunitWeb/NunitWeb/Resources/test_map_02.sitemap
Test/mainsoft/NunitWeb/NunitWeb/Resources/test_map_03.sitemap
Test/mainsoft/NunitWeb/NunitWeb/Resources/test_map_04.sitemap
Test/mainsoft/NunitWeb/NunitWeb/Resources/test_map_05.sitemap
Test/mainsoft/NunitWeb/NunitWeb/Resources/test_map_06.sitemap
Test/mainsoft/NunitWeb/NunitWeb/Resources/test_map_07.sitemap
Test/mainsoft/NunitWeb/NunitWeb/Resources/test_map_08.sitemap
Test/mainsoft/NunitWeb/NunitWeb/Resources/test_map_09.sitemap
2009-09-07 Marek Habersack <[email protected]>
* Tests/TestSiteMapProvider.cs: added
svn path=/trunk/mcs/; revision=141420
* AspTokenizer.cs: when there's put back record and we're in
verbatim mode, get_token must be careful with what it returns - it
can't return Token.* values, instead it should look at Value and
retrieve the next token from it. Fixes bug #400807
2009-08-26 Marek Habersack <[email protected]>
* TemplateControlCompilerTest.cs: added test for bug #400807
2009-08-26 Marek Habersack <[email protected]>
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWebResources/OneLetterIdentifierInCodeRender.aspx
svn path=/trunk/mcs/; revision=140703
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWebResources/DuplicateControlsInClientComment.aspx
2009-08-18 Marek Habersack <[email protected]>
* ControlBuilder.cs: Location property makes a copy of assigned
ILocation now.
2009-08-18 Marek Habersack <[email protected]>
* AspParser.cs: added a constructor which creates an internal
parser, nested within the outer one, and adjusts its ILocation
members to report correct locations in the outer parser for better
error reporting. Inner parser also returns the outer's FileText,
if available.
* AspGenerator.cs: restored part of r138474 reverted in r138657,
r138658 and r138659 to fix bug #525104
BuilderLocation creates a copy of Location for its own use (since
the ILocation passed is actually AspParser, the line numbers
change between creating a BuilderLocation and using its Location
member).
The end of tag, expression and client comment regular expressions
now use lazy quantifiers. This fixes bugs #525104 and #517656
Client side comment blocks aren't ignored anymore, they are parsed
just as the other parts of the document. Fixes bug #524358
2009-08-18 Marek Habersack <[email protected]>
* JavaScriptSerializer.cs: read converters from the config only if
explicitly requested.
2009-08-18 Marek Habersack <[email protected]>
* TemplateControlCompilerTest.cs: added test for bug #525104 and
improved test for bug #517656
svn path=/trunk/mcs/; revision=140161