The LOCAL_MCS_FLAGS are passed to the compiler before the standard
directory for the profile. This is important both for correctness,
and also assists the solution generator, since we can now precisely
determine which intermediate project must be referenced.
Added local targets (csproj-local) to all the assemblies that have
staged builds to dump their build information for the underlying
dependencies.
This information is needed to create the new Visual Studio csproj
files.
This commit also updates the collected build metadata from running:
make update-csproj
make package-inputs
As described in msvc/scripts/README
Since we are invoking make recursively to satisfy the dependencies
for any of the cyclic components, we need to inform make to not try
to parallelize any work on any of the cyclic dependencies, otherwise
multiple builds will execute building the same binary, and the result
will be truncated outputs.
For example, System's Makefile would launch all the parallel builds for
the dependencies:
$(secxml_libdir)/System.dll \
$(the_libdir_base)System.Xml.dll \
$(the_libdir_base)Mono.Security.dll \
$(bare_libdir)/System.dll
They could be launched in parallel, and in turn the makefiles on those
directories might try simultaneously to invoke recursively a component
that has not been built yet.
So we use .NOTPARALLEL to flag all the cyclic dependencies on a given
directory to instruct make to not run those in parallel.
This patch introduces an infrastructure to stage the builds for the core
assemblies that have cyclic dependencies. This deals directly with
the following cycle:
System.dll requires:
System.Configuration.dll
Mono.Security.dll
System.Xml.dll
They all require System.dll to be built
System.Xml requires:
System.dll
System.Configuration.dll
System.Security.dll requires:
System.dll
Mono.Security.dll
System.Xml.dll
Principle
=========
The patch works by directing the build infrastructure to place
intermediate build steps on their own directory. For example the
first System.dll build that only takes a dependency in mscorlib.dll is
placed not under the final directory but on a subdirectory called
"bare".
The second time that System.dll is built (after Mono.Security and
System.Xml have been built) is placed on the "secxml" directory.
The third time is the final build, and that one ends in the profile
directory.
The same principle is applied to System.Xml.
Better Dependency Tracking
==========================
To handle the multiple stages, the new Makefiles for the various
parties involved in this loop are now able to build their
dependencies. This means that typing "make" on System.Security or
System.Xml or System will build all of the intermediate steps as
required, without needing the toplevel Makefile to perform multiple
build shots to incrementally build the result.
Bug fixes
=========
We must have regressed at some point the build of System.Xml as we
were only doing one build of it, one without System.Configuration
support. This patch introduces back the changes to build System.Xml
in two steps.
This patch fixes the setup where we end up rebuilding System.dll and
overwriting it two times as the build progresses as a side effect
(this is what required LIBRARY_USE_INTERMEDIATE_FILE).
Details
=======
library.make:
Introduces a new "the_libdir_base" which is the raw directory
where the final output will go. This points to the same location
that libdir_base previously pointed to.
The existing libdir_base is modified to contain an optional
"intermediate" directory, where intermediate builds can be
placed.
Other cycles
============
The System.Design assembly was listed as having cycles, but while this
cycle exists in theory, in practice we have not implemented any of the
code that brings the cycle in System.Windows.Forms.Design's
ImageListImageEditor and chances are, we wont any time soon.
The thing is, XPathNodeIterator itself is stateful and does not behave
like IEnumerable, thus GetEnumerator() should not iterate nodes within
*itself*. Rather, it should have returned a clone of it.
After all we didn't have to damage performance to fix bug #3705, which is nice.
* XslCompiledTransform.cs : in XmlWriterSettings, use
ConformanceLevel.Fragment to allow fragment output.
In Transform(string,string), use TextWriter output instead of
XmlWriter to control xml declaration output.
Fixed bug #391424.
* XslTransformTests.cs : added test for bug #391424.
* 391424.xml, 391424.xsl : new test files.
* Makefile : more simplification (and I forgot the syntax again :/)
svn path=/trunk/mcs/; revision=103783
* XsdParticleValidationState.cs : a choice with only empty particle
children is emptiable. Fixed bug #376395.
* XsdValidatingReaderTests.cs : added test for bug #376395.
* 376395.xml, 376395.xsd : new test files.
* Makefile : extra distfiles (376395.xml, 376395.xsd).
svn path=/trunk/mcs/; revision=99679
* net_2_1_bootstrap_System.Xml.dll.sources,
* net_2_1_raw_System.Xml.dll.sources,
* Makefile:
Files for the SL2 version of System.Xml.
svn path=/branches/jb/ml2/mcs/; revision=99037
* XmlSchema.cs : Do recursively process xs:include inside included
schemas. Fixed bug #361818.
* XmlSchemaTests.cs: added test for bug #361818.
* 361818.xsd, 361818-2.xsd, 361818-3.xsd : new test files.
* Makefile : extra distfiles (361818*.xsd).
svn path=/trunk/mcs/; revision=96159
* XmlSchemaValidator.cs : added couple of null argument check.
Do not depend on XmlSchemaInfo to retrieve attribute value (it
could be null).
Do not practically validate attribute when it is not in validating
state (i.e. inside xs:any). Fixed bug #358408.
* XmlSchemaValidatorTests.cs : new. Test for bug #358408.
* 358408.xsd : new test file.
* System.Xml_test.dll.sources : added XmlSchemaValidatorTests.cs.
* Makefile : extra distfiles (358408.xsd).
svn path=/trunk/mcs/; revision=94729
* XsdValidatingReader.cs : r68046 didn't really fix the issue.
Enabled the actual fix. and fixed bug #336625.
* XsdValidatingReaderTests.cs : added test for #336625.
* 336625.xsd : new test file.
* Makefile : extra distfiles (336625.xsd).
svn path=/trunk/mcs/; revision=88537
* MapCodeGenerator.cs : avoid possible duplicates in generated field
names. Fixed bug #82078.
* XmlCodeExporterTests.cs : test for bug #82078.
* 82078.xsd : new test file.
* Makefile : extra distfiles (82078.xsd).
svn path=/trunk/mcs/; revision=84531
* XmlSchemaComplexType.cs,
XmlSchemaComplexContentRestriction.cs :
in Validate(), every descendant item in complexType must be first
validated before getting GetOptimizedParticle(), or it could result
in wrong content particle. Fixed bug #82010.
* XsdValidatingReaderTests.cs : test for bug #82010.
* 82010.xsd, 82010.xml : new test files.
* Makefile : extra distfiles (82010.xml/.xsd).
svn path=/trunk/mcs/; revision=83272
* XmlSchema.cs XmlSchemaGroup.cs XmlSchemaAny.cs XmlSchemaElement.cs
XmlSchemaNotation.cs XmlSchemaComplexType.cs
XmlSchemaAttributeGroup.cs XmlSchemaSimpleType.cs
XmlSchemaIdentityConstraint.cs XmlSchemaAnyAttribute.cs
XmlSchemaRedefine.cs XmlSchemaAttribute.cs :
avoid incorrect compilation of included schemas, fixed bug #81360.
more fix for wrong targetNamespace propagation within current
processing model. Replaced ParentIsSchema field with a property.
* XsdValidatingReaderTests.cs : added test for bug #81360.
* 81360.xsd, 81360inc1.xsd, 81360inc2.xsd : new test files.
* Makefile : added distfiles.
svn path=/trunk/mcs/; revision=76184
* Makefile : Now it supports (and expects) cyclic build. You need
another System.XML iteration in mcs/class/Makefile.
* System.Xml.dll.sources : moved extension classes, added config and
XmlSchemaEnumerator.cs and removed IXmlSerializerImplementation.cs.
svn path=/branches/atsushi/mcs/; revision=67234
* XsdValidatingReader.cs : Fixed bug #79650. Enumeration facet was
not validated for attributes. Also, simple type restriction should
require namespace manager to resolve QNames.
* XmlSchemaSimpleTypeRestriction.cs : for facet validation, it should
use namespacemanager. Though the change is not perfect, thus I
disable this change for now.
* XmlValidatingReaderTests.cs : added bug #79650 case.
* 79650.xsd : added test for bug #79650.
* Makefile : added 79650.xsd to dist file.
svn path=/trunk/mcs/; revision=67031