* XmlElementTest.cs: SetAttribute(name,value) should identify value
change for existing node, from new node insertion.
Fixed bug #464394.
* XmlElementTests.cs : added test for bug #464394.
svn path=/trunk/mcs/; revision=126323
* XmlElement.cs : (WriteTo) use IsEmpty to determine which to use:
WriteEndElement() and WriteFullEndElement(). Fixed sys.security
regression.
svn path=/trunk/mcs/; revision=57395
* IHasXmlChildNode.cs :
New internal interface to hold LastLinkedChild.
* XmlNodeListChildren.cs XmlEntity.cs XmlElement.cs XmlAttribute.cs
XmlLinkedNode.cs XmlEntityReference.cs XmlNode.cs
XmlDocumentFragment.cs XmlDocument.cs : use it. It minimizes memory
consumption in XmlText, XmlWhitespace, XmlComment etc.
* System.Xml.dll.sources : added IHasXmlChildNode.cs.
svn path=/trunk/mcs/; revision=56945
* XmlDocument.cs, XmlAttribute.cs, XmlElement.cs : Avoid unnecessary
name checks in CreateElement() and CreateAttribute().
get_DocumentType() could be stopped when the iterated child node
is the document element.
* XmlNode.cs : removed commented lines.
* XmlNameEntry.cs : hash code for a name entry is mostly identical by
its local name, so avoid extraneous GetHashCode() especially on
namespaces.
svn path=/trunk/mcs/; revision=56270
* XmlNode.cs,
XmlDocument.cs,
XmlAttribute.cs,
XmlElement.cs :
Added internal AppendChild() override that omites node type
checking, and used it in many places.
svn path=/trunk/mcs/; revision=56151
if value is null or zero-length string. Modified WriteNmToken to throw
ArgumentException if name is null or zero-length string. Cosmetic
change to WriteStringInternal.
* XmlElement.cs: In 2.0 profile, do not throw ArgumentNullException
if new value for Prefix is null.
* XmlElementTests.cs: Improved tests for setting prefix to null
or zero-length string. On 2.0 profile, setting prefix to null should
not result in ArgumentNullException.
* XmlTextWriterTests.cs: Enabled WriteNmToken tests and
WriteWhitespace tests for null or zero-length value.
svn path=/trunk/mcs/; revision=55115
* XmlElement.cs : patch for Prefix property by Vorobiev Maksim.
- null should cause ArgumentNullException.
- "" should not raise an error.
- throws ArgumentException when it is readonly.
* XmlElementTests.cs : Patch by Vorobiev Maksim.
- setting null to Prefix should raise ArgumentNullException.
- setting String.Empty to Prefix should be allowed.
svn path=/trunk/mcs/; revision=54849
* XmlElement.cs, XmlCDataSection.cs, XmlText.cs, XmlWhitespace.cs,
XmlSignificantWhitespace.cs : added ParentNode overrides (actually
they don't make sense since it just calls base.)
* XmlNode.cs, XmlDocument.cs : changed .NET 2.0 CreateNavigator() impl
to match signature and skip OwnerDocument check in XmlNode (since
it is overriden). Maybe MS does not have ownerDocument as a field and
costs too much on OwnerDocument property.
Added missing bits in XmlDocument.
svn path=/trunk/mcs/; revision=52647
* XmlAttribute.cs : added new overrides in 2.0 RTM (this scarcely
makes sense without real optimization though).
* XmlDocument.cs, XmlElement.cs, XmlNode.cs : avoid ChildNodes and
save extra XmlNodeList creation cost.
svn path=/trunk/mcs/; revision=52646
* XmlComment.cs, XmlNode.cs, XmlText.cs, XmlProcessingInstruction.cs,
XmlEntityReference.cs, XmlSignificantWhitespace.cs, XmlAttribute.cs,
XmlElement.cs, XmlEntity.cs, XmlCDataSection.cs :
For those nodes that are created by Clone(), IsReadOnly is false.
Patch by Konstantin Triger.
* XmlNodeTests.cs : added Clone() of readonly node returns a node
that is not readonly.
svn path=/trunk/mcs/; revision=41185
* XmlNode.cs (XmlNode.SchemaInfo): Mark this as not CLS-compliant
to avoid a CS3025.
* XmlReaderSettings.cs (XmlReaderSettings.XmlResolver): Mark this
as not CLS-compliant to avoid a CS3025.
svn path=/trunk/mcs/; revision=39449
* XmlNode.cs,
XmlAttribute.cs,
XmlAttributeCollection.cs :
Now reuse parentNode field for XmlAttribute.OwnerElement and
reduce class allocation size.
* XmlNameEntry.cs :
New class that represents a name triplet.
XmlNameEntryCache.cs :
New type to cache name entries.
* XmlAttribute.cs,
XmlElement.cs :
Replace name strings with name entry and save class allocation size.
XmlDocument.cs :
Add name entry cache field to document and reuse name entries that
are already allocated.
svn path=/trunk/mcs/; revision=39086
* XmlAttribute.cs, XmlElement.cs : get_Name should consider name table.
* XmlDocument.cs : use NameTable in Load() and LoadXml().
* XmlReader.cs : In Create(), use NameTable in XmlReaderSettings.
svn path=/trunk/mcs/; revision=35808
* XmlElement.cs : XmlAttributeCollection doesn't have to be created
every time until the actual use. This sometimes optimizes
attribute-less XML performance siginificantly.
svn path=/trunk/mcs/; revision=33008
* DTDObjectModel.cs,
DTDReader.cs,
XmlDocument.cs,
XmlInputStream.cs,
XmlParserInput.cs,
XmlTextReader.cs,
XmlUrlResolver.cs : removed reference to Mono.Xml.
Made Mono.Xml.* classes internal.
* XmlDocument.cs : output xml declaration for TextWriter output in Save()
* XmlElement.cs : Name character check should be done in .ctor().
* XmlNamespaceManager.cs : Removed dangerous internal .ctor()
svn path=/trunk/mcs/; revision=27149
W3C DOM compliant read-only check support (buggy part in MS.NET).
* XmlAttribute.cs,
XmlCDataSection.cs,
XmlCharacterData.cs,
XmlDocument.cs,
XmlElement.cs,
XmlNode.cs,
XmlSignificantWhitespace.cs,
XmlText.cs
: CloneNode() - set read-only when copied node is read-only.
Check IsReadOnly on attempt to modify value.
* XmlEntity.cs,
XmlEntityReference.cs : Set descendant nodes read-only.
* XmlAttributeCollection.cs,
XmlNode.cs
: Fixed incompatible exception type.
* XmlEntityReference.cs : CloneNode() should not pass an empty string
as its name.
* XmlEntityReference.cs,
XmlProcessingInstruction.cs : Check XML name validity.
* XmlText.cs : CloneNode() does not have to check children.
svn path=/trunk/mcs/; revision=25938
* XmlAttribute.cs : get_Value should return all children's value.
* XmlCharacterData.cs : DOM's substring does not raise an error when
startIndex + count exceeds the length of Data.
* XmlNamedNodeMap.cs : SetNamedItem() returns the new child when it
does not replace another named item.
* XmlElement.cs : with related to the XmlNamedNodeMap change,
SetAttributeNode() is required to fix as to return null when it does
not replace existing attribute.
svn path=/trunk/mcs/; revision=25018
* XmlAttributeCollection.cs : set owner element as parent on removal
events (though they are not "parent" in infoset or dom context)
* XmlElement.cs : Don't remove attributes twice (raises extraneous
removal events).
* XmlNamespaceManager.cs, XmlNodeChangedEventArgs :
Added NET_1_2 members.
svn path=/trunk/mcs/; revision=22933
* DTDValidatingReader.cs : Fixed MoveToElement() that causes incorrect
IsDefault and Depth.
* XmlAttribute.cs : Fixed .ctor(). Omit more namespace check when
checkNamespace = false.
* XmlNamedNodeMap.cs : Fixed SetNamedItem() to raise events.
* XmlAttributeCollection.cs : Reimplemented InsertAfter to use
InsertBefore() (similar to XmlNode).
* XmlDocument.cs : Added internal .ctor(). Reimplemented ReadNode()
as recursive, to make event order compatible.
* XmlDocumentType.cs : Use SetNamedItem() (to raise events).
* XmlElement.cs : Some refactory. Fixed SetAttributeNode() with
string name to block prefixed name.
* XmlEntity.cs : Don't raise events on setting contents.
* XmlNode.cs : Some refactory. Added raiseEvent argument to internal
InsertBefore().
* XmlEntityReference.cs : related fix for XmlNode change.
* XmlTextReader.cs : When the reader is on "attributes" of xmldecl or
doctype, Depth 1 lower than usual attribute. Split large function.
svn path=/trunk/mcs/; revision=22799
* DTDObjectModel.cs : Never expand entity on ScanEntityValue().
* DTDValidatingReader.cs : XmlDeclaration node requires attributes
to be movable.
* XmlAttribute.cs,
XmlDocument.cs,
XmlDocumentFragment.cs,
XmlElement.cs,
XmlEntity.cs,
XmlLinkedNode.cs,
XmlNode.cs,
XmlNotation.cs :
Added namespace checking flag (required for such xml readers
that holds Namespaces=false). Now only XmlNode holds LastLinkedNode.
* XmlDocumentType.cs,
XmlEntity.cs,
XmlEntityReference.cs : The children of Entity and EntityReference
became correct. They now holds parsed nodes, but it is only when
they are appended to the document.
* XmlNode.cs : Modified insertBeforeIntern() to InsertBefore() with
boolean checkNodeType argument. This method also tries to create
Entity's and EntityReference's child nodes. Also added internal
RemoveChild() with boolean checkNodeType argument.
* XmlNodeReader.cs : Quick hack for ResolveEntity() that became
broken with these changes. use InnerXml as input to entityReader.
* XmlTextReader.cs : XmlDeclaration's value LocalName should be the
same as Name. The names of DTD's pseudo attributes should be empty.
Fixed DTD node's Depth (was regarded as attribute value's depth).
svn path=/trunk/mcs/; revision=22767
* DTDObjectModel.cs :
- DTDNode's BaseURI should not always refer to that of DTD's.
- Use absolute URI's .ToString() instead of AbsolutePath.
* DTDReader.cs : Throw XmlException for illegal character references.
* DTDValidatingReader.cs :
- Share XmlResolver when the actual reader is XmlTextReader.
(MS's XmlValidatingReader and XmlTextReader do this.)
- Added its own EntityHandling property.
* XmlValidatingReader.cs : Share XmlResolver with XmlTextReader.
* XmlReader.cs,
XmlTextReader.cs : Added new NET_1_2 members.
* XmlElement.cs : Removed extra lines (caused by XmlTextWriter bugs).
* XmlEntityReference.cs : Forgot to add, the real fix by Boris.
svn path=/trunk/mcs/; revision=22509
* XmlNode.cs : When adding a node to child list, it should reject its
ancestors. Patch by Boris Kirzner.
* XmlNodeReader.cs : Related fix to the fix above. It should not move
to children of XmlEntityReference nodes.
* XmlTextWriter.cs : FixedWriteStartElement() not to write default
namespace when ns is null (while ns is "", it writes default ns).
* XmlElement.cs : Fixed WriteTo() to call WriteStartElement(localName)
when NamespaceURI is an empty string.
svn path=/trunk/mcs/; revision=22286
* XmlAttribute.cs, XmlDocument.cs, XmlElement.cs :
set_Prefix should atomize to name table.
Avoided extraneous atomization attempt a bit.
svn path=/trunk/mcs/; revision=21803
* XmlAttributeCollection.cs,
XmlElement.cs : Fixed bug #51415.
When adding attribute to an element using Attributes, it failed.
svn path=/trunk/mcs/; revision=21059
* XmlDocumentFragment.cs,
XmlElement.cs,
XmlEntityReference.cs : Removed extraneous MonoTODO.
* XmlNode.cs : Implemented Normalize().
* XmlNodeReader.cs :
- AttributeCount and HasAttributes should return its owner element's
value, to be consistent with XmlTextReader.
- Fixed Depth to reflect correct attribute/attribute-value iteration.
- simplified ownerElement and HasValue.
- Prefix won't return null.
- MoveToElement() should also work against attribute value nodes.
* XmlTextReader.cs : MoveToElement() should return false if it is
positioned at element itself.
svn path=/trunk/mcs/; revision=18589
* XmlInputStream.cs :
Fixed Initialize() that might result in incorrect buffer.
CanRead and Position should consider buffer (especially when the
stream was EOF).
CanSeek should use stream's CanSeek.
* XmlChar.cs : added GetPredefinedEntity().
* DTDObjectModel.cs :
- Modified ComputeDefaultValue() to use it.
- Fixed NormalizedDefaultValue not to expect parsed value as string.
- ResolveExternalEntity now detects invalid standalone specification.
- DTDParameterEntityDeclaration.Value is now changed to property and
keep its resolved value of literal value of external value using
new Resolve (XmlResolver) method (called only by XmlTextReader).
* DTDValidatingReader.cs :
- It now handles entity-expanded Whitespace and SignificantWhitespace
correctly. Does not raise unexpected text not allowed error.
- Fixed MoveToAttribute()s to move internal reader correctly, and
should be able to move in other cases than on element node.
- On Read()ing document type and ResolveEntity(), it now sets
XmlResolver on text reader.
- On ID constraints check and type verification, it now uses
normalized attribute or its tokenized value(s).
- Fixed ValidateAttributes() to add default values when
ValidationType is Auto.
* XmlParserContext.cs : added internal Dtd setter.
* XmlParserInput.cs :
InsertParameterEntityBuffer() should add surrounding whitespaces.
Removed unused code block.
* XmlTextReader.cs :
- Modified ReadReference(), ReadAttribute() and Dereference() to use
XmlChar.GetPredefinedEntity().
- When returning entity reference, it checks extity declaration
existence in certain conditions.
- ReadAttribute() now skips general entity replacement on reading
entity value.
- ReadText() now handles whitespace texts as XmlNodeType.Whitespace.
- ReadXmlDeclaration() holds isStandalone, which might be used in
entity reference's well-formedness check.
- internal 'DTD' now uses XmlParserContext.Dtd.
- isInternalSubset was meaningless. Now uses input stack's Count.
- Added some required SkipWhitespace().
- Several parameter entity handling changes. Added GetPEValue(name).
TryExpandPERef() now uses ImportAsPERef(). ReadParameterEntityDecl()
now uses its Resolve() when it was external PE. Now it uses value
buffer instead of currentTag, to efficiently read (included) PE.
CompileDeclaration() now uses ImportAsPERef instead of ExpandPERef().
ImportAsPERef() simply inserts the value to currentInput.
ReadEntityDecl() also uses value buffer. Removed non-used methods.
- Default attributes are now stored in normalized form.
- Dereference() now considers non-expanding predefined entities.
* XmlValidatingReader.cs : now holds Schemas, and ValidationType.Auto
is more correctly supported.
* XmlAttributeCollection.cs :
When removing default attribute, it immediately inserts the attribute.
RemoveAll() should consider default (not-removable) attributes.
* XmlDocument.cs :
Should have its default XmlResolver. Added Internal Resolver.
Some Load() should use its XmlResolver.
ImportNode() should copy its children in node level, not value level.
It also have to consider not to copy default attribute on importing
XmlElement.
* XmlDocumentType.cs : Now uses document's XmlResolver to read DTD.
* XmlAttribute.cs,
XmlDocumentFragment.cs.
XmlElement.cs : use XmlResolver on InnerXml. Removed some MonoTODO.
* XmlNodeReader.cs : GetInternalParserConext() should provide its DTD.
ResolveEntity() uses XmlResolver on entityReader.
svn path=/trunk/mcs/; revision=17202
* XmlParserContext.cs,
XmlAttribute.cs,
XmlElement.cs : Added internal Dtd and new internal XmlParserContext
.ctor() that takes DTDObjectModel. And then rewrote classes which
uses DTD information. Changed DocTypeName, InternalSubset, PublicId
and SystemId to use DTDObjectModel.
* DTDObjectModel.cs :
Added DTDObjectModel.InternalSubsetHasPEReference.
Added DTDEntityDeclaration.IsInternalSubset.
* XmlTextReader.cs :
Added internal GetInternalParserContext (to build entity reader).
Added private isIntSubset to check if the DTD subset is internal or
external, which might affect well-formedness constraints.
Changed GenerateDTDObjectModel to return the resulting DTD model.
* XmlEntityReference.cs : implemented BaseURI.
* XmlNodeReader.cs :
- Implemented ResolveEntity() and CanResolveEntity(). In fact
it leads too many changes on almost all methods and properties,
since they now must be aware of entityReader.
- fixed ownerElement that might be used to return from attribute
value to the element through parent attribtues.
- Now changed indexer to call GetAttribute() and moved actual logic
to the matching GetAttribute() methods.
svn path=/trunk/mcs/; revision=16946
* DTDValidatingReader.cs : (Read,ValidateAttributes,ReadAttributeValue)
attribute declaration should be got independently of elementdecl.
* XmlAttribute.cs :
Added internal SetDefault() to mark as default.
Removed InnerText implementation that is just the same as XmlNode.
* XmlDocument.cs : id shouldn't be removed from table at 'trying' to
get matching elements. ReadAttributeNode() now sets default mark.
* XmlElement.cs : WriteTo() should ignore default attributes.
* XmlTextWriter.cs : shuold allow valid name char such as digits.
svn path=/trunk/mcs/; revision=16783
* XmlDocumentType.cs :
modified private DTD to dtd and added internal DTD (the same thing).
* XmlElement.cs :
Fixed SetAttributeNode() to check if specified attribute is already
set to the other element. In fact it is W3C DOM's specification but
MS.NET 1.0 failed to catch it.
* XmlTextReader.cs :
ReadAttributeValue() should check if the value of the attribute is
already read when the whole value is entity reference.
Also, Name of text nodes should be "", not "#text"
svn path=/trunk/mcs/; revision=16716
* XmlAttribute.cs,
XmlElement.cs : Fixed CloneNode() for bug #46129.
* XmlDocument.cs : Fixed MakeReaderErrorMessage that specified invalid
String.Format arguments, and basically XmlException.ctor(
IXmlLineInfo, message) seems good idea to use.
* XmlTextReader.cs :
- Fixed .ctor(Stream, XmlNodeType, XmlParserContext) which had
required non-null context which don't have to exist.
- Added state check. Introduced 'currentState' and 'maybeTextDecl'
(for external entity) and removed hasEnteredDocument. Added
state-check logic to ReadStartTag(), ReadEndTag(), ReadText(),
ReadCData(), ReadDoctypeDecl() and ReadWhitespace().
- Replaced throw ReaderError() with throw new XmlException() and
fixed that some error hadn't thrown, only created.
- ResetState() should re-initialize existing private members other
than some specified fields.
- Private AddAttribute() should check if the same-named attribute
already exists.
* DTDObjectModel.cs : Additive declaration for ATTLIST is availabe now.
svn path=/trunk/mcs/; revision=16131
* XmlElement.cs : Removed extraneous xmlns output support (it should
be done by XmlTextWriter).
* XmlNode.cs : InsertBefore() now checks validity of the newChild (and
most of the changes are in fact indentation changes).
* XmlWriter.cs : WriteAttributes() now can write entity references.
WriteNode() now writes xmldecl attributes correctly.
Removed namespaceManager and xmlns check logic, since it should be
done by individual XmlTextWriter.
* XmlTextWriter.cs : Patch by Jerome. AddMissingElementXmlns () has
written multiple xmlns declarations.
Moved namespaceManager from abstract XmlWriter.
Write{Start|End}Attribute() and WriteString() now checks xmlns
attribute value. (MS.NET holds value only with this write method).
svn path=/trunk/mcs/; revision=15982