This fixes the behavior of process spawning when UseShellExecute is
set to true.
The right behavior is to return no process only when we used the system
launcher. So, spawning /bin/cat should behave in the same way independent
of how UseShellExecute is set.
Followup to:
http://forums.xamarin.com/discussion/comment/11823/#Comment_11823
These are Switches with a labotomy: the MOBILE profile does not
support System.Configuration.dll, so there is no support for
.exe.config files or
System.Diagnostics.DiagnosticsConfigurationHandler.
Consequently these Switches are largely a compatibility/portability
aid: they DO NOT have the full functionality that the desktop
profile affords. Specifically, there is no way to provide an XML
config file that contains the Switch values to use. If you need to set
the Switch values, this MUST be done manually, e.g. through a Switch
constructor's `defaultSwitchValue` parameter or through a property,
e.g. for SourceSwitch:
http://msdn.microsoft.com/en-us/library/w65awck1.aspxhttp://msdn.microsoft.com/en-us/library/system.diagnostics.sourceswitch.level.aspx
Modulo the GUID in the assembly and the GUID embedded in some
field initializers that use the assembly GUID for their name, the
assemblies are idential before and after the patch.
mcs/class/System/System.Diagnostics/Process.cs (Start_noshell):
If the process execution fails, then add the error message for
the native error code in the Win32Exception thrown.
Fixes#605033.
'cause stack overflow is back, mkay?
at System.Diagnostics.TraceImpl.InitOnce () <0x0005b>
at System.Diagnostics.TraceImpl.get_IndentLevel () <0x0000b>
at System.Diagnostics.TraceListenerCollection.InitializeListener (System.Diagnostics.TraceListener) <0x0000f>
at System.Diagnostics.TraceListenerCollection.Add (System.Diagnostics.TraceListener) <0x00017>
at System.Diagnostics.TraceListenerCollection..ctor (bool) <0x0007f>
at System.Diagnostics.TraceListenerCollection..ctor () <0x00013>
at System.Diagnostics.DiagnosticsConfigurationHandler.GetSharedListeners (System.Collections.IDictionary) <0x00083>
at System.Diagnostics.DiagnosticsConfigurationHandler.Create (object,object,System.Xml.XmlNode) <0x003cf>
at System.Configuration.ConfigurationSection.GetRuntimeObject () <0x0033d>
at System.Configuration.ClientConfigurationSystem.System.Configuration.Internal.IInternalConfigSystem.GetSection (string) <0x00041>
at System.Configuration.ConfigurationManager.GetSection (string) <0x00030>
at System.Configuration.ConfigurationSettings.GetConfig (string) <0x0000f>
at System.Diagnostics.DiagnosticsConfiguration.get_Settings () <0x00043>
at System.Diagnostics.TraceImpl.InitOnce () <0x0005b>
Thus, when we're getting the <sharedListeners/> element, we shouldn't call
the TraceListenerCollection default constructor, as that will attempt to add
the DefaultTraceListener (which isn't needed anyway, as the
DefaultTraceListener is explicitly added by TraceImplSettings).
This error was found by Gonzalo when he was looking at another problem
when thread IDs overflowed ints.
Currently we use gpointers in the io-layer for the threadid, but we were
only exposing the value as an int32. The good news is that the code is
not really used right now, but could cause problems in the future as we
extend Process.
This set of .gitattributes was automatically generated from the list of files
that GIT tried to normalize when I enabled automatic EOL conversion.
With this set of attributes, we prevent automated EOL conversion on files that
we know will cause trouble down the road.