- Ref: https://bugzilla.xamarin.com/show_bug.cgi?id=20048
- Mono currently doesn't support 2-args Socket ctor added in .NET 4.5
- Absence of this ctor prevents KestrelHttpServer (web server for
ASP.NET vNext: https://github.com/aspnet/KestrelHttpServer ) test
code from working
- I hesitated to put IPv4 only implementation, but full dual stack
(IPv4/v6) support would need bunch of works to be done. So, I pinned
supported protocol of new ctor to IPv4. Also, I filed v4/v6 support
issue as a MonoTODO entry inside the source code.
Socket.ConnectAsync uses BeginConnect, and ends here in
ConnectCallback. It needs to call EndConnect so any error can be
propagated up.
See Xamarin bug: https://bugzilla.xamarin.com/show_bug.cgi?id=21017
In the same way the overload Receive (buf, flags) already does, mention
"time out" in the exception message when the socketError is WOULDBLOCK and
the socket is not non-blocking (otherwise it would throw with the reason
"Operation on non-blocking socket would block", which doesn't make sense
for a socket that is not non-blocking).
- socket configuration attempts to determine if system supports ipv6
- checks app configuration, but configuration throws exception if called from embedded context
- solution is to put a try/catch guard and fall to an alternative test for ipv6
* Socket_2_1.cs: When closing a socket we need to abort any
pending syscalls to that socket. For most syscalls the kernel
does it for us. But accept/connect on linux requires extra
love.
We previously used Thread.Abort to implement that, but this
is a pretty radical solution with very complicated ramifications.
So instead now we use a new icall cancel_blocking_socket_operation
that makes sure we only abort the syscall and do nothing else.
This reduces the trouble surface a lot given how tricky
Thread.Abort is.
Modulo the GUID in the assembly and the GUID embedded in some
field initializers that use the assembly GUID for their name, the
assemblies are idential before and after the patch.
There are two types of checks that were being done before:
(1) offset < 0? size < 0? offset + size > buffer.Length? This is trivial to get around. If I make both offset and size positive but have the sum overflow, it will pass all three checks.
(2) offset in range? size in range? If the buffer is very large this might run into overflow issues with its checking, though fine most of the time...
Is the offset in range? And is the size in range against buffer.Length - offset (which we know to be >= 0 from the earlier offset check)? This method of bounds checking is not in any danger from two's complement overflows.
When there is an ongoing operation we can't dispose the internal
worker because it might be used by the IO threadpool.
Fixes Novell bug #691076 and Xamarin bug #766.
* System.Net.Sockets/Socket_2_1.cs: Ensure RemoteEndPoint is always
available after ConnectAsync (connected or not, allowed or not).
Ensure the Connect event is fired even if denied by policy.
* System.Net.Sockets/Socket_2_1.cs: Fix some moved code (from
SocketAsyncEventArgs.cs) so should the references to RemoteEndPoint
still point to the SocketAsyncEventArgs instance. Fix some moon-unit
test failures